From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only capital letters are allowed to be used for #define
declarations
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
From: Pierre Gondois
This patch fixes the following Ecc reported error:
All include file contents should be guarded by
a #ifndef statement.
This patch replaces a "#if !defined [...]" statement
by a "#ifndef [...]" statement, preventing Ecc to
throw an error.
Edk2 coding standard stating that:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
All include file contents should be guarded by
a #ifndef statement.
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
From: Pierre Gondois
This patch fixes the following Ecc reported error:
No used module files found
The source files
[ArmPkg/Library/SemihostLib/SemihostPrivate.h]
is existing in module
ArmPkg/Library/SemihostLib/SemihostLib.inf
but is not described in the INF file.
Signed-off-by: Pierre
From: Pierre Gondois
This patch fixes the following Ecc reported error:
8005:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
8007:
There should be
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Complex types should be typedef-ed
The error is due to the a nested structure declaration.
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Variable name does not follow the rules:
1. First character should be upper case
2. Must contain lower case characters
3. No white space characters
4. Global variable name must start with a 'g'
Signed-off-by: Pierre Gondois
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only capital letters are allowed to be used
for #define declarations
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
From: Pierre Gondois
The Ecc tools available in the BaseTools package checks for
good practice coding standards. Some errors reported while
running Ecc on the ArmPkg require modifications.
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
v2:
For
From: Pierre Gondois
This patch fixes the following Ecc reported error:
No used module files found
The source files
[ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h]
[ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h]
[ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h]
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only Doxygen commands '@bug', '@todo', '@example', '@file',
'@attention', '@param', '@post', '@pre', '@retval', '@return',
'@sa', '@since', '@test', '@note', '@par', '@endcode', '@code',
'@{', '@}' are allowed to mark the
From: Pierre Gondois
This patch fixes the following Ecc reported error:
No used module files found
The source files
[ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h]
is existing in module
ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf
but is not described in the INF file.
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Only capital letters are allowed to be used
for #define declarations
Edk2 coding standard stating that:
"Names starting with one or two underscores, such as
_MACRO_GUARD_FILE_NAME_H_, must not be used."
the include guard of
From: Pierre Gondois
This patch fixes the following Ecc reported error:
No used module files found
The source files
[ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h]
is existing in module
ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
but is not described in the INF file.
From: Pierre Gondois
Commit: 142fa386eb907df55c239311cd5fa2d40f5007dd
removes the ArmGicSecLib. The file ArmGic/ArmGicSecLib.c
was exclusively used by this library. Thus, this file should
also be removed.
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Function name should be left justified,
followed by the beginning of the parameter list,
with the closing parenthesis on its own line,
indented two spaces
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
From: Pierre Gondois
This patch fixes the following Ecc reported error:
There should be no unnecessary inclusion of library
classes in the INF file
This comes with the additional information:
The Library Class [BootLogoLib]
is not used in any platform
The Library Class [DxeServicesLib]
is not
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Module file has FILE_GUID collision with other
module file
The two .inf files with clashing GUID are:
ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf
As
From: Pierre Gondois
Edk2 coding standard states that:
"Names starting with one or two underscores, such as
_MACRO_GUARD_FILE_NAME_H_, must not be used."
Ref:
https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/
5_source_files/53_include_files#
From: Pierre Gondois
This patch fixes the following Ecc reported error:
Complex types should be typedef-ed
The error is due to the a nested structure declaration.
Signed-off-by: Pierre Gondois
---
The changes can be seen at:
https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v2
Update maintainer for Arm Ltd. Platforms in
edk2-platforms (
F: Platform/ARM/
F: Silicon/ARM/
)
based on discussions on the mailing list at:
https://edk2.groups.io/g/devel/message/71354
Cc: Ard Biesheuvel
Cc: Thomas Abraham
Cc: Leif Lindholm
Signed-off-by: Sami Mujawar
---
Have you the full build log? Seemly, AFeatureEnablerDxe driver is not
generated correctly.
Thanks
Liming
发件人: bounce+27952+71433+4905953+8761...@groups.io
代表 宋涛
发送时间: 2021年2月7日 20:54
收件人: devel@edk2.groups.io
主题: [edk2-devel] UEFI BUG
Hi,I face a problem, and it suggested that I can
On Monday, February 8, 2021 3:41 PM, Sami Mujawar wrote:
> Update maintainer for Arm Ltd. Platforms in
> edk2-platforms (
> F: Platform/ARM/
> F: Silicon/ARM/
> )
> based on discussions on the mailing list at:
> https://edk2.groups.io/g/devel/message/71354
>
> Cc: Ard Biesheuvel
> Cc:
(Adding Ard, just in case -- the topic is set by the first quoted
question below)
On 02/08/21 04:24, Ying Fang wrote:
> Hi, Does anybody know whether the EDK2 ArmVirtPkg has support for a
> virtio-mmio-device ?
virtio-mmio is a virtio transport type, not a particular device.
(1) ArmVirtPkg +
On 12/2/20 1:37 AM, Heinrich Schuchardt wrote:
On 12/1/20 6:11 PM, Daniel Schaefer wrote:
On 12/2/20 12:59 AM, Heinrich Schuchardt wrote:
On 12/1/20 5:17 PM, Daniel Schaefer wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
With this patch series we can build the UEFI SCT for
Reviewed-by: Andrei Warkentin
From: Pete Batard
Sent: Monday, February 8, 2021 11:08 AM
To: Jeremy Linton ; devel@edk2.groups.io
Cc: Andrei Warkentin ; samer.el-haj-mahm...@arm.com
; l...@nuviainc.com ;
ardb+tianoc...@kernel.org
Subject: Re: [PATCH v2 1/4]
Hi Hao,
These 2 modules seems to be the only ones need to be updated when we scrubbed
and validated our code base.
I will prepare for the tcg2 and variable module patches.
Thanks,
Kun
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Siva,
Just as Michael mentioned - the log you have provided suggests that you
are recurse-booting iPXE.
Next server: 10.0.84.155
Filename: ipxe.efi
tftp://10.0.84.155/ipxe.efi... ok
May I ask why?
Thanks,
Maciej
On 05-Feb-21 11:10, Michael Brown wrote:
On 05/02/2021 08:28, Sivaraman Nainar
Suggest changing the strings to reflect that the coming PCIe functionality
relies on the SMC conduit...
Reviewed-by: Andrei Warkentin
From: devel@edk2.groups.io on behalf of Jeremy Linton
via groups.io
Sent: Tuesday, January 12, 2021 4:27 PM
To:
On 02/04/21 20:49, Jordan Justen wrote:
> Cc: Andrew Fish
> Cc: Ray Ni
> Signed-off-by: Jordan Justen
> Reviewed-by: Andrew Fish
> ---
> Maintainers.txt | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 2cd356551e..96e792ab66 100644
> ---
On 2021.02.01 22:53, Jeremy Linton wrote:
In order for the wifi to work, and the SD to run at full
speed we need to bind the sd slot to the eMMC2 controller.
For consistency, you might want to capitalize SD here, since it's
capitalized before and after.
Since we now have a driver for the
On 2021.02.01 22:53, Jeremy Linton wrote:
DMA translation on the eMMC2 vary based on SOC, and
this is made worse by the poor _DMA support in linux.
For now the "safe" option is to simply run the eMMC2
controller in PIO mode. More advanced users or !linux
operating systems may choose to enable
Reviewed-by: Andrei Warkentin
From: Pete Batard
Sent: Monday, February 8, 2021 11:08 AM
To: Jeremy Linton ; devel@edk2.groups.io
Cc: Andrei Warkentin ; samer.el-haj-mahm...@arm.com
; l...@nuviainc.com ;
ardb+tianoc...@kernel.org
Subject: Re: [PATCH v2 3/4]
[with all of Pete's comments]
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Monday, February 1, 2021 4:53 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; Andrei Warkentin ;
samer.el-haj-mahm...@arm.com ; l...@nuviainc.com
; ardb+tianoc...@kernel.org
Reviewed-by: Andrei Warkentin
From: Jeremy Linton
Sent: Monday, February 1, 2021 4:53 PM
To: devel@edk2.groups.io
Cc: p...@akeo.ie ; Andrei Warkentin ;
samer.el-haj-mahm...@arm.com ; l...@nuviainc.com
; ardb+tianoc...@kernel.org ;
Jeremy Linton
Subject:
I'd rather we not set the PcdRamMoreThan3GB on a device with 1 or 2GB. I
recognise you're using this to choose behavior for an old Linux version, but
it's still non-sensical to the end user and it becomes a maintenance burden
since the logic is no longer clear, so you might as well add a boot
On 2021.02.01 22:53, Jeremy Linton wrote:
The primarly problem with the rpi Arasan controller working
Small typo: primarly -> primary
with a default SDHCI driver is the lack of a meaningful
capabilities register. As such if we add a _DSD entry
to provide that information, we can then bind it
Looks good to me.
On 2021.02.01 22:53, Jeremy Linton wrote:
Turns out its helpful to have a !PcdToken flag
that enables a DSDT/SSDT. That simplifies
both the emmc2 SSDT (it only installs when
!SdIsArasan) and later for the XHCI/PCIe switch
where we want to install one of two tables
depending on
Hi Leif,
thanks very much for the review!
I've cleaned up the patchset and addressed the issues. I'll send out another
set soon.
See comments below.
Thanks,
Daniel
On 12/2/20 8:04 PM, Leif Lindholm wrote:
On Wed, Dec 02, 2020 at 00:17:52 +0800, Daniel Schaefer wrote:
On 08.02.21 16:09, Daniel Schaefer wrote:
> Hi Leif,
>
> thanks very much for the review!
> I've cleaned up the patchset and addressed the issues. I'll send out
> another set soon.
> See comments below.
>
> Thanks,
> Daniel
>
> On 12/2/20 8:04 PM, Leif Lindholm wrote:
>> On Wed, Dec 02, 2020 at
On 2/3/21 8:18 AM, Leif Lindholm wrote:
> On Sun, Jan 31, 2021 at 16:25:03 -0700, Rebecca Cran wrote:
+// At each level of cache, we can have a single type (unified, instruction
or data),
+// or two types - separate data and instruction caches. If we have separate
+// instruction
On 12/2/20 7:44 PM, Leif Lindholm wrote:
On Wed, Dec 02, 2020 at 00:17:51 +0800, Daniel Schaefer wrote:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
TODO: Need to check whether we can avoid copying Aarch64 sources.
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
Cc:
On 08.02.21 15:30, Daniel Schaefer wrote:
> On 12/2/20 1:37 AM, Heinrich Schuchardt wrote:
>> On 12/1/20 6:11 PM, Daniel Schaefer wrote:
>>> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote:
On 12/1/20 5:17 PM, Daniel Schaefer wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
On 2/8/21 11:36 AM, Andrei Warkentin wrote:
I'd rather we not set the PcdRamMoreThan3GB on a device with 1 or 2GB. I
recognise you're using this to choose behavior for an old Linux version, but
it's still non-sensical to the end user and it becomes a maintenance burden
since the logic is no
On Sun, Feb 07, 2021 at 17:52:33 -0700, Rebecca Cran wrote:
> Much of the data for the SMBIOS tables is generic, and need not be
> duplicated for each platform. This patch series introduces
> ArmPkg/Universal/Smbios, which is largely copied from
> edk2-platforms/Silicon/HiSilicon/Drivers/Smbios
On 2/8/21 11:55 AM, Leif Lindholm wrote:
These are all trailing newlines at EOF, which git am complains about
when importing the patches, and an additional fix to aforementioned
macro.
Are you OK with me doing this?
Yes, please do.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
On Mon, Feb 08, 2021 at 12:02:08 -0700, Rebecca Cran wrote:
> On 2/8/21 11:55 AM, Leif Lindholm wrote:
>
> > These are all trailing newlines at EOF, which git am complains about
> > when importing the patches, and an additional fix to aforementioned
> > macro.
> >
> > Are you OK with me doing
Also, PeiFspSiPolicyInitLib.c is only including three header files. Please
double check and remove this file if these header files are already included by
the callers.
-Original Message-
From: Chaganty, Rangasai V
Sent: Monday, February 08, 2021 4:43 PM
To: Luo, Heng ;
Reviewed-by: Yuwei Chen
> -Original Message-
> From: matthewfcarl...@gmail.com
> Sent: Tuesday, February 9, 2021 8:51 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Chen, Christine ;
> Matthew Carlson
> Subject: [PATCH v5 1/1] BaseTools: Use pip module if available, CI
In BasePlatformHookLib.c, the code below It8628SioSerialPortInit () can be
removed.
Thanks,
Sai
-Original Message-
From: Luo, Heng
Sent: Saturday, February 06, 2021 9:38 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [PATCH 3/8]
(Adding Ard, just in case -- the topic is set by the first quoted
question below)
On 02/08/21 04:24, Ying Fang wrote:
>
> Hi, Does anybody know whether the EDK2 ArmVirtPkg has support for a
> virtio-mmio-device ?
> virtio-mmio is a virtio transport type, not a particular device.
Sorry, the
Maciej:
I am checking with the customer on the real use case.
I understand the customer is trying to run reboot test for 1000 times with
Network Enabled and I am waiting to know why the network chain loading is
enabled.
-Siva
-Original Message-
From: Rabeda, Maciej
From: Matthew Carlson
Hello all,
This patch adds the capability to leverage the pip based BaseTools.
The BaseTools master is current with EDK2 master (as of 3pm Nov 2, 2020).
While I could rehash a lot of what has gone out on the mailing list, I think
it might be better just to link the
From: Matthew Carlson
Use the new edk2-basetools pip module.
Includes a helpful message in setup to let users know which has been
selected.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Reviewed-by: Bob Feng
Signed-off-by: Matthew Carlson
---
.pytool/CISettings.py
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Loo Tung Lun
> Sent: Monday, February 8, 2021 1:04 PM
> To: devel@edk2.groups.io
> Cc: Loo, Tung Lun ; Ma, Maurice
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH v4] IntelFsp2Pkg: Add YAML file
The just added OemMiscLibNull fails to build due to DebugLib.h not
being included, missing the ASSERT definition. Add the include and the
library dependency.
Cc: Rebecca Cran
Cc: Ard Biesheuvel
Signed-off-by: Leif Lindholm
---
ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLibNull.inf | 2 +-
On 2/8/21 4:48 PM, Leif Lindholm wrote:
The just added OemMiscLibNull fails to build due to DebugLib.h not
being included, missing the ASSERT definition. Add the include and the
library dependency.
Cc: Rebecca Cran
Cc: Ard Biesheuvel
Signed-off-by: Leif Lindholm
---
Sorry for the delay.
Thanks for clarifying and further checking this, Dong.
I think some platforms in https://github.com/tianocore/edk2-platforms would do
this before EndOfDxe.
Yeah, I agree with Dong. If UefiPayloadPkg doesn't support trusted console and
may not support it in the future, I
Matt,
I helped to convert the endling character for those PosixLike scripts and
created a PR https://github.com/tianocore/edk2/pull/1415
Liming,
I verified the your pervious comments on this patch.
Thanks,
Bob
-Original Message-
From: Chen, Christine
Sent: Tuesday, February 9, 2021
66 matches
Mail list logo
