REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following library instances:
* TigerlakeURvp/Library/BoardAcpiLib
* TigerlakeURvp/Library/BoardInitLib
* TigerlakeURvp/Library/PeiPlatformHookLib
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following modules:
* BiosInfo
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.c | 200
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the DSC and build files necessary to build the
TigerlakeURvp board instance.
Key files:
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The TigerlakeURvp board description file.
*
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
This change adds the configuration to enable build for TigerlakeURvp.
Also it updates Tigerlake U Rvp details to the Readme.md.
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Platform/Intel/Readme.md | 11 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following files:
* TigerlakeURvp/Include/Fdf/FlashMapInclude.fdf
* TigerlakeURvp/Include/PeiPlatformHookLib.h
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Create the TigerlakeOpenBoardPkg to provide board support code. The
package may support Tigerlake boards. The package serves as a board
support package in the EDK II Minimum Platform design. Silicon support
for this package is provided in
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following library instances:
* FspWrapper/Library/PeiFspPolicyInitLib
* FspWrapper/Library/PeiSiDefaultPolicyInitLib
* FspWrapper/Library/PeiSiPreMemDefaultPolicyInitLib
* Library/BasePlatformHookLib
*
Patch pushed: 273261126e30c46737736bff3ece64c4bd77bedd
> -Original Message-
> From: Loo Tung Lun
> Sent: Monday, February 8, 2021 1:04 PM
> To: devel@edk2.groups.io
> Cc: Loo, Tung Lun ; Ma, Maurice
> ; Desimone, Nathaniel L
> ; Zeng, Star ; Chiu,
> Chasel
> Subject: [PATCH v4]
Thank Sai, I have sent Patch V2:
1. remove file PeiFspSiPolicyInitLib.c.
2. remove "PeiFspSiPolicyInitLib.c" from
FspWrapper\Library\PeiFspPolicyInitLib\PeiFspPolicyInitLib.inf
3. remove the code below It8628SioSerialPortInit
Thanks,
Heng
> -Original Message-
> From: Chaganty, Rangasai
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
This change adds owners to the the Maintainers.txt for TigerlakeOpenBoardPkg
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt
Adds a macro that rounds a given integer up to the nearest DWORD.
The config block data structure needs to be DWORD aligned. Since config blocks
are run-length encoded, the size of all config blocks therefore needs to be in
DWORD increments. This macro aids in storing arbitary data in a config
On 02/09/21 16:28, Ard Biesheuvel wrote:
> On Tue, 9 Feb 2021 at 14:41, Laszlo Ersek wrote:
>>
>> On 02/09/21 03:54, Ying Fang wrote:
>>
>>> I now realize that we emulate the virtio-blk-device over mmio, and we
>>> only emulate virtio-1.0 spec.
>>> As mentioned in (1c) , EDK2 only supports
On Mon, Feb 08, 2021 at 10:11:05 +, Sami Mujawar wrote:
> Update maintainer for Arm Ltd. Platforms in
> edk2-platforms (
> F: Platform/ARM/
> F: Silicon/ARM/
> )
> based on discussions on the mailing list at:
> https://edk2.groups.io/g/devel/message/71354
>
> Cc: Ard Biesheuvel
> Cc:
On Mon, Feb 08, 2021 at 18:04:45 +0100, Heinrich Schuchardt wrote:
> >>> diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> >>> b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> >>> new file mode 100644
> >>> index ..8bc2c624
> >>> --- /dev/null
> >>> +++
On 2/9/21 10:58 PM, Leif Lindholm wrote:
On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote:
I have no idea why the alignment would be 3 on other platforms, so I
don't know how to fix it.
If anyone knows more, please let me know. I'll just change the comment
to say Riscv64.
On 02/09/21 03:54, Ying Fang wrote:
> I now realize that we emulate the virtio-blk-device over mmio, and we
> only emulate virtio-1.0 spec.
> As mentioned in (1c) , EDK2 only supports virtio-0.95 spec for now, so
> this maybe a big problem.
> Since it may not handshake ok if we only emulate
On 09.02.21 13:42, Leif Lindholm wrote:
> On Mon, Feb 08, 2021 at 18:04:45 +0100, Heinrich Schuchardt wrote:
> diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S
> new file mode 100644
> index ..8bc2c624
>
When AP firstly wakes up, MpFuncs.nasm contains below logic to assign
an unique ApIndex to each AP according to who comes first:
---ASM---
TestLock:
xchg [edi], eax
cmpeax, NotVacantFlag
jz TestLock
movecx, esi
addecx, ApIndexLocation
Patch #1 follows Mike's suggestion to use XADD to avoid lock acquire/release.
Patch #2 follows Laszlo's suggestion to add global NASM macros for NASM struc
usage.
Patch #3 simply remves all hardcode offset in NASM without changing any logic.
Patch #4 removes the dead code.
The final code is the
In Windows environment, "dumpbin /disasm" is used to verify the
disassembly before and after using NASM struc doesn't change.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf | 5 +-
Signed-off-by: Ray Ni
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
---
MdePkg/Include/Ia32/Nasm.inc | 38
MdePkg/Include/X64/Nasm.inc | 38
2 files changed, 76 insertions(+)
diff --git
Hi Mike
Could you help review this patch and push it?
Liming may take leave now.
Thanks,
Bob
-Original Message-
From: Leif Lindholm
Sent: Tuesday, February 9, 2021 11:01 PM
To: Feng, Bob C
Cc: devel@edk2.groups.io; Liming Gao ; Chen,
Christine ; Matthew Carlson ;
Kinney, Michael D
On Tue, 9 Feb 2021 at 00:48, Leif Lindholm wrote:
>
> The just added OemMiscLibNull fails to build due to DebugLib.h not
> being included, missing the ASSERT definition. Add the include and the
> library dependency.
>
> Cc: Rebecca Cran
> Cc: Ard Biesheuvel
> Signed-off-by: Leif Lindholm
Signed-off-by: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Cc: Matthew Carlson
Cc: Michael D Kinney
Cc: Leif Lindholm
---
BaseTools/BuildEnv | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv
index
On Tue, Feb 09, 2021 at 14:47:46 +0100, Heinrich Schuchardt wrote:
> >>> I have no idea why the alignment would be 3 on other platforms, so I
> >>> don't know how to fix it.
> >>> If anyone knows more, please let me know. I'll just change the comment
> >>> to say Riscv64.
> >>>
> > +.align 3
>
On Tue, Feb 09, 2021 at 22:58:08 +0800, Bob Feng wrote:
> Signed-off-by: Bob Feng
> Cc: Liming Gao
> Cc: Yuwei Chen
> Cc: Matthew Carlson
> Cc: Michael D Kinney
> Cc: Leif Lindholm
SMTP strips the intersting aspect, but as long as the end result is a
BuildEnv that has no characters:
Hi Bob,
Something has gone wrong with the line endings on BaseTools/BuildEnv,
breaking the build on posix systems:
/work/git/edk2$ . edksetup.sh
-bash: /work/git/orion/edk2/BaseTools/BuildEnv: line 214: syntax error
near unexpected token `}'
-bash: /work/git/orion/edk2/BaseTools/BuildEnv: line
The Lock is no longer needed since "LOCK XADD" was used in
MpFuncs.nasm for ApIndex atomic increment.
Signed-off-by: Ray Ni
Cc: Eric Dong
Cc: Laszlo Ersek
Cc: Rahul Kumar
---
UefiCpuPkg/Library/MpInitLib/Ia32/MpFuncs.nasm | 4
UefiCpuPkg/Library/MpInitLib/MpEqu.inc | 4
On Tue, 9 Feb 2021 at 14:41, Laszlo Ersek wrote:
>
> On 02/09/21 03:54, Ying Fang wrote:
>
> > I now realize that we emulate the virtio-blk-device over mmio, and we
> > only emulate virtio-1.0 spec.
> > As mentioned in (1c) , EDK2 only supports virtio-0.95 spec for now, so
> > this maybe a big
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
Signed-off-by: Daniel Schaefer
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
Signed-off-by: Daniel Schaefer
---
Hi everyone,
here's my second patch series for porting the SCT to RISCV64.
Nothing substantial has changed. The first one was really just an RFC
like Leif mentioned. Now I have cleaned it up and it could be merged.
I've got 5 patches:
1. Copy the architectures specific sources from Aarch64
2.
The sources were copied from Aarch64. Follow-up commit will adapt them
for Riscv64.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
Signed-off-by: Daniel Schaefer
---
uefi-sct/SctPkg/UEFI/IHV_SCT.dsc | 15
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042
Cc: G Edhaya Chandran
Cc: Barton Gao
Cc: Samer El-Haj-Mahmoud
Cc: Eric Jin
Cc: Arvin Chen
Cc: Leif Lindholm
Cc: Heinrich Schuchardt
Cc: Abner Chang
Signed-off-by: Daniel Schaefer
---
After I sent this patch, Mike K helpfully pointed out that we already have
ALIGN_VALUE() In Base.h. Therefore, please consider this patch abandoned.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Tuesday, February 9, 2021 11:27 AM
> To:
Hi Michael,
Please see my response inline marked [SAMI].
Other than the minor space change needed to match the coding style, this patch
looks good to me.
With that changed:
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: mikub...@linux.microsoft.com
Sent:
I would like to perform passive mode tests but I've been unsuccessfully trying
to build the EMS tool(ver 2.6 and 2.7) following
https://github.com/tianocore/edk2-test/blob/master/uefi-sct/HowToBuild/HowToBuildEms.txt.
Since I'm snowballing into poorly updated libs and old compiler versions Is
Hi Michael,
Thank you for this patch.
There must be something missing with the GCC5 settings for AARCH64 as this
problem does not get flagged.
However, this change looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
-Original Message-
From: devel@edk2.groups.io On
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 2/8] TigerlakeOpenBoardPkg/TigerlakeURvp: Add fdf and header
file
REF:
Please remove commented code in SiliconEnableAcpi() and associated comments.
Thanks,
Sai
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 4/8]
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 6/8] TigerlakeOpenBoardPkg/TigerlakeURvp: Add DSC and build
files
REF:
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 7/8] Enable build for TigerlakeOpenBoardPkg
REF:
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 1/8] TigerlakeOpenBoardPkg: Add package and headers
REF:
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 5/8] TigerlakeOpenBoardPkg: Add modules
REF:
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios.
o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support
for SMBIOS 3.4.0, as is required by SBBR.
o Add an implementation of OemMiscLib that provides the system
information. The serial numbers, asset tags etc. are
Hi Sami,
I'm happy to change the spacing. The code base is very inconsistent with
this (a somewhat similar scenario would be space before opening
parenthesis) and it often trends toward a space after the cast. The
space before opening parenthesis is clearly required. However, I've
never
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 5/8] TigerlakeOpenBoardPkg: Add modules
REF:
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 8/8] Update Maintainers.txt for TigerlakeOpenBoardPkg
REF:
The interface proposed in this patch series intends to provide an
abstraction layer for DXE drivers to request certain memory regions to be
accessible from inside MM environment that applies total memory blockage.
The usage in VariableSmmRuntimeDxe to support runtime variable cache is
included in
This changes added usage of DxeMmUnblockMemoryLib to explicitly request
runtime cache regions(and its indicators) to be accessible from MM
environment when PcdEnableVariableRuntimeCache is enabled. It will bring
in compatibility with architectures that supports full memory blockage
inside MM.
Cc:
This change replaced gSmst with gMmst to support broader compatibility
under MM environment for Tcg2Smm driver.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Signed-off-by: Kun Qin
---
Notes:
v2:
- Newly added in v2.
SecurityPkg/Tcg/Tcg2Smm/Tcg2Smm.c | 4 ++--
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3168
This interface definition provides an abstraction layer for DXE drivers
to request certain memory blocks to be mapped/unblocked for accessibility
inside MM environment.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Eric Dong
Cc: Ray Ni
Cc: Jiewen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3169
This change separated the original Tcg2Smm module into 2 drivers: the
SMM driver that registers callback for physical presence and memory
clear; the Tcg2Acpi driver that patches and publishes ACPI table for
runtime use.
Tcg2Smm introduced
https://bugzilla.tianocore.org/show_bug.cgi?id=3169
This change added Standalone MM instance of Tcg2. The notify function for
Standalone MM instance is left empty.
A designated dependency library was created for DXE drivers to link as an
anonymous library.
Lastly, the support of CI build for
This changes added usage of DxeMmUnblockMemoryLib to explicitly request
allocated NVS region to be accessible from MM environment. It will bring
in compatibility with architectures that supports full memory blockage
inside MM.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Qi Zhang
Cc: Rahul Kumar
Pushed
PR: https://github.com/tianocore/edk2/pull/1419
Commit:
https://github.com/tianocore/edk2/pull/1419/commits/c10b513830e63fa4fc28f1edc43352de8d97b61f
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, February 9, 2021 5:21 PM
> To: Feng, Bob C ; Leif Lindholm
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 12:46 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V2 3/8] TigerlakeOpenBoardPkg: Add library instances
REF:
Hi Bob,
Reviewed-by: Michael D Kinney
It is difficult to see the changes. I did verify that the file before the
patch had mixed line
endings and the one after the patch is LF only line endings.
Minor issues with Author name with a ','. I fixed that when I added the rb to
the commit
I will send Patch V3 to remove commented code in SiliconEnableAcpi() and
associated comments.
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Wednesday, February 10, 2021 8:39 AM
> To: Luo, Heng ; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L
> Subject: RE: [Patch V2 4/8]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following files:
* TigerlakeURvp/Include/Fdf/FlashMapInclude.fdf
* TigerlakeURvp/Include/PeiPlatformHookLib.h
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Create the TigerlakeOpenBoardPkg to provide board support code. The
package may support Tigerlake boards. The package serves as a board
support package in the EDK II Minimum Platform design. Silicon support
for this package is provided in
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 8:00 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V3 4/8] TigerlakeOpenBoardPkg/TigerlakeURvp: Add library
instances
REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following library instances:
* FspWrapper/Library/PeiFspPolicyInitLib
* FspWrapper/Library/PeiSiDefaultPolicyInitLib
* FspWrapper/Library/PeiSiPreMemDefaultPolicyInitLib
* Library/BasePlatformHookLib
*
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following library instances:
* TigerlakeURvp/Library/BoardAcpiLib
* TigerlakeURvp/Library/BoardInitLib
* TigerlakeURvp/Library/PeiPlatformHookLib
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the following modules:
* BiosInfo
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Platform/Intel/TigerlakeOpenBoardPkg/BiosInfo/BiosInfo.c | 200
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
This change adds the configuration to enable build for TigerlakeURvp.
Also it updates Tigerlake U Rvp details to the Readme.md.
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Platform/Intel/Readme.md | 11 +++
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
Adds the DSC and build files necessary to build the
TigerlakeURvp board instance.
Key files:
* build_config.cfg - Board-specific build configuration file.
* OpenBoardPkg.dsc - The TigerlakeURvp board description file.
*
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175
This change adds owners to the the Maintainers.txt for TigerlakeOpenBoardPkg
Cc: Sai Chaganty
Cc: Nate DeSimone
Signed-off-by: Heng Luo
---
Maintainers.txt | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Maintainers.txt
On Wed, Jan 27, 2021 at 12:21 PM Vikas Singh
wrote:
>
> On Tue, Jan 26, 2021 at 4:49 PM Leif Lindholm wrote:
> >
> > Hi Vikas,
> >
> > On Tue, Jan 19, 2021 at 10:11:43 +0530, Vikas Singh wrote:
> > > > > > > +/** A helper macro for returning configuration manager objects
> > > > > > > +*/
> > >
Thanks Heng!
For the series..
Reviewed-by: Sai Chaganty
-Original Message-
From: Luo, Heng
Sent: Tuesday, February 09, 2021 8:00 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L
Subject: [Patch V3 8/8] Update Maintainers.txt for TigerlakeOpenBoardPkg
71 matches
Mail list logo
