Re: [edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

Hi Sughosh, Pushed as a2b5ea38a6fb..68e5ecc4d208 Regards, Sami Mujawar From: Sughosh Ganu Sent: 22 February 2021 03:19 PM To: Ard Biesheuvel ; Sami Mujawar Cc: devel@edk2.groups.io; Ilias Apalodimas ; Laszlo Ersek ; Leif Lindholm ; michael.d.kin...@intel.com; Jiewen Yao ; Achin Gupta

Re: [edk2-devel] [PATCH v1 0/2] Enable EKDII core CI support for Kvmtool

Hi All, Is it possible to integrate this patch in the edk2-stable202102 tag? This series is also acked at https://edk2.groups.io/g/devel/message/70710?p=,,,20,0,0,0::Created,,ArmVirtPkg,20,2,0,80094118 I have also created a Bugzilla ticket at ' *Bug 3216* (

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 02/23/21 08:45, Paolo Bonzini wrote: > On 22/02/21 15:53, Laszlo Ersek wrote: >>> + >>> +  if (mCpuHotEjectData != NULL) { >>> +    CPU_HOT_EJECT_HANDLER Handler; >>> + >>> +    Handler = mCpuHotEjectData->Handler; >> This patch looks otherwise OK to me, but: >> >> In patch v8 08/10, we have a

Re: [edk2-devel] MP Services Protocol : Support Hyper threading or not

On 02/23/21 02:17, fanjianf...@byosoft.com.cn wrote: > " Will EFI_MP_SERVICES_PROTOCOL.StartupAllAPs() make all 8 logical cores do > some tasks simultaneously?" > > All APs logical processors excute AP task, not including BSP. Acutally the > answer is 7. Good point :) Thanks Laszlo > > Jeff

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Hi Hao, Thanks for the suggestion. I can move the library to MdePkg similar to SmmMemLib and add the change for OVMF. Liming/Zhiguang, I am happy to prepare patches to cover the dependency change in ed2-platform in a separate patch series. But please let me know if you would like to proceed

[edk2-devel] [PATCH v3 1/1] BaseTools: Update the NASM CI dependency

Update the external dependency (consumed by Edk2Tools) version for NASM, as agreed in recent community meetings: https://edk2.groups.io/g/devel/message/71289 https://edk2.groups.io/g/devel/message/71070 This is primarily used by CI builds, but may also be used by platforms. Signed-off-by: Bret

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/UfsPassThruDxe: Improve Device initialization polling Loop

Bandaru, can you tell us please why you (apparently) refuse to subscribe to this list -- in spite of the two invites that I have sent you from the groups.io moderation WebUI? You are creating unnecessary work for the moderators. They need to approve your messages one by one, until you actually

Re: [edk2-devel] [PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use XADD to avoid lock acquire/release

Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Tuesday, February 9, 2021 6:17 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Laszlo Ersek ; > Kumar, Rahul1 > Subject: [edk2-devel] [PATCH v3 1/4] UefiCpuPkg/MpInitLib: Use

Re: [edk2-devel] [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables

On Tue, Feb 23, 2021 at 10:43:38 -0700, Rebecca Cran wrote: > o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. > o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support > for SMBIOS 3.4.0, as is required by SBBR. > o Add an implementation of OemMiscLib that provides the

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 02/23/21 08:37, Ankur Arora wrote: > On 2021-02-22 6:53 a.m., Laszlo Ersek wrote: >> Adding Paolo, one comment below: >> >> On 02/22/21 08:19, Ankur Arora wrote: >>> Call the CPU hot-eject handler if one is installed. The condition for >>> installation is (PcdCpuMaxLogicalProcessorNumber > 1),

[edk2-devel] [edk2-platforms PATCH v5 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables

o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are

[edk2-devel] [edk2-platforms PATCH v5 2/4] SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib

Use FdtHelperCountCpus from FdtHelperLib. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 55 ++-- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + 2 files changed, 6 insertions(+), 50 deletions(-)

[edk2-devel] [edk2-platforms PATCH v5 1/4] SbsaQemu: Add FdtHelperLib

The CountCpusFromFdt function is now used in two places. Create FdtHelperLib for this and similar functions. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 + Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h

[edk2-devel] [edk2-platforms PATCH v5 3/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables

o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are

[edk2-devel] [edk2-platforms PATCH v5 4/4] Silicon/Qemu: Don't re-use NumCores as loop index in AddMadtTable

Avoid re-using the NumCores variable as a loop index, in AddMadtTable: add a new CoreIndex variable for that purpose. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

Hi Michael, On 02/22/21 23:11, Michael Kubacki wrote: > Is there a particular reason two copies of > StandaloneMmDriverEntryPoint.h exist in the edk2 repo? > > 1. MdePkg > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Library/StandaloneMmDriverEntryPoint.h > > > 2.

Re: [edk2-devel] [edk2-platforms PATCH v4 1/4] SbsaQemu: Add FdtHelperLib

On 2/23/21 9:32 AM, Leif Lindholm wrote: On Tue, Feb 23, 2021 at 07:26:32 -0700, Rebecca Cran wrote: The CountCpusFromFdt function is now used in two places. Create FdtHelperLib for this and similar functions. Signed-off-by: Rebecca Cran Reviewed-by: Leif Lindholm ---

Re: [edk2-devel] [edk2-platforms PATCH v4 1/4] SbsaQemu: Add FdtHelperLib

On Tue, Feb 23, 2021 at 07:26:32 -0700, Rebecca Cran wrote: > The CountCpusFromFdt function is now used in two places. Create > FdtHelperLib for this and similar functions. > > Signed-off-by: Rebecca Cran > Reviewed-by: Leif Lindholm > --- > Platform/Qemu/SbsaQemu/SbsaQemu.dsc

Re: [edk2-devel] [PATCH v8 02/10] OvmfPkg/CpuHotplugSmm: collect hot-unplug events

On 02/22/21 23:03, Ankur Arora wrote: > On 2021-02-22 4:27 a.m., Laszlo Ersek wrote: >> On 02/22/21 08:19, Ankur Arora wrote: >>> diff --git a/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> b/OvmfPkg/CpuHotplugSmm/QemuCpuhp.c >>> index 8d4a6693c8d6..36372a5e6193 100644 >>> ---

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 23/02/21 18:06, Laszlo Ersek wrote: On 02/23/21 08:45, Paolo Bonzini wrote: On 22/02/21 15:53, Laszlo Ersek wrote: + +  if (mCpuHotEjectData != NULL) { +    CPU_HOT_EJECT_HANDLER Handler; + +    Handler = mCpuHotEjectData->Handler; This patch looks otherwise OK to me, but: In patch v8

Re: [edk2-devel] [PATCH] * ShellPkg: add the support to show Contained Element Count, Contained Element Record Length and Contained Elements

Hi Gao, I've resend the patch with your suggestion. the title is ShellPkg: add more items for smbiosview -t 3. Since I sent it 2 times, please refer the patch latest time. Mars -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72097):

[edk2-devel] [PATCH] ShellPkg: add more items for smbiosview -t 3 .

https://bugzilla.tianocore.org/show_bug.cgi?id=3177 Add ContainedElementCount, ContainedElementRecordLength and ContainedElements for smbiosview type 3. Signed-off-by: Mars CC Lin Cc: Zhichao Gao Cc: Philippe Mathieu-Daude Cc: Liming Gao --- .../SmbiosView/PrintInfo.c

[edk2-devel] implement about virtio-keyboard

Hi all, I boot vm with the virtio keyboard on aarch64. It looks UEFI lacks support for the virtio keyboard, so I can't do any keyboard input before the linux kernel driver loads, i.e. edit the grub boot menu. Is there any plan to support it? I find UsbKeyboardDevice attach on UsbIO which

[edk2-devel] [PATCH v2] ShellPkg: add more items for smbiosview -t 3 .

https://bugzilla.tianocore.org/show_bug.cgi?id=3177 Add ContainedElementCount, ContainedElementRecordLength and ContainedElements for smbiosview type 3. Signed-off-by: Mars CC Lin Cc: Zhichao Gao Cc: Philippe Mathieu-Daude Cc: Liming Gao --- .../SmbiosView/PrintInfo.c

Re: [edk2-devel] [PATCH v2 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK

Hi Sami, Yes this is a mistake, modifications to ScmiMessageIdBasexxx should actually be part of 'ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE' Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72042):

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Maurice, It’s doable  I prefer to accept today’s below 4G limitation to maintain simple implementation. Thanks, Ray From: Ma, Maurice Sent: Tuesday, February 23, 2021 3:26 PM To: Ni, Ray ; devel@edk2.groups.io; fanjianf...@byosoft.com.cn; Patrick Rudolph ; Dong, Guo ; Dong, Eric Cc: You,

Re: [edk2-devel] Duplicate Files for StandaloneMmDriverEntryPoint.h

On Tue, 23 Feb 2021 at 18:37, Laszlo Ersek wrote: > > Hi Michael, > > On 02/22/21 23:11, Michael Kubacki wrote: > > Is there a particular reason two copies of > > StandaloneMmDriverEntryPoint.h exist in the edk2 repo? > > > > 1. MdePkg > >

Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

Hi Nate and Heng, The RELEASE build now succeeds, but I noticed that DEBUG build still fails. I'm trying to fix it. Do you need me to submit another BZ ticket or use the same ticket? Best regards, Takuto Naito On Tue, Feb 23, 2021 at 7:27 AM Desimone, Nathaniel L <

Re: [edk2-devel] [PATCH] Fix wrong information of TigerLake in Readme.md

Reviewed-by: Sai Chaganty -Original Message- From: Luo, Heng Sent: Tuesday, February 23, 2021 6:05 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH] Fix wrong information of TigerLake in Readme.md Machine Name of TigerLake is TGL-U DDR4

Re: [edk2-devel] [PATCH v8 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject

On 2021-02-23 1:39 p.m., Laszlo Ersek wrote: On 02/22/21 08:19, Ankur Arora wrote: Add logic in EjectCpu() to do the actual the CPU ejection. On the BSP, ejection happens by first selecting the CPU via its QemuSelector and then sending the QEMU "eject" command. QEMU in-turn signals the remote

Re: [edk2-devel] [PATCH v1 1/2] ArmVirtPkg/PlatformCI: Add EDKII CI support for Kvmtool

Sami, Do you have these in a PR or somewhere online that is already merged? Obviously i can do that but usually developers already have that (either edk2 PR for ci testing or on their fork). one comment below. Thanks Sean On 1/22/2021 9:19 AM, Sami Mujawar wrote: Kvmtool is a virtual

[edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Device initialization polling Loop

https://bugzilla.tianocore.org/show_bug.cgi?id=3217 Current Ufs Pass thru driver polls for 5us and return success even when the timeout occurs. There are cards that can take upto 600ms for Init and hence increased the time out for fDeviceInit polling loop. Signed-off-by: Bandaru Cc: Mateusz

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

Hi Wu, Hao A I am trying to focus on merging patch#1 for now to unblock boot issues. March 6th might be too late, May I request you to expedite any other alternatives like exceptions/overrides? For the remaining two patches I will get back to you with the plan after discussing with WSIV and

Re: [edk2-devel] [PATCH v8 07/10] OvmfPkg/SmmCpuFeaturesLib: call CPU hot-eject handler

On 2021-02-23 9:18 a.m., Paolo Bonzini wrote: On 23/02/21 18:06, Laszlo Ersek wrote: On 02/23/21 08:45, Paolo Bonzini wrote: On 22/02/21 15:53, Laszlo Ersek wrote: + +  if (mCpuHotEjectData != NULL) { +    CPU_HOT_EJECT_HANDLER Handler; + +    Handler = mCpuHotEjectData->Handler; This patch

Re: [edk2-devel] [PATCH v8 08/10] OvmfPkg/CpuHotplugSmm: add EjectCpu()

On 2021-02-23 12:36 p.m., Laszlo Ersek wrote: superficial comments only; the patch is nearly ready: On 02/22/21 08:19, Ankur Arora wrote: Add EjectCpu(), which handles the CPU ejection, and provides a holding area for said CPUs. It is called via SmmCpuFeaturesRendezvousExit(), at the tail end

Re: [edk2-devel] [PATCH v2 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc

Hi Sami, The ArmPkg implements two versions of the PeCoffExtraActionLib library at: * ArmPkg/Library/DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.inf * ArmPkg/Library/RvdPeCoffExtraActionLib/RvdPeCoffExtraActionLib.inf They are explicitly built by being placed in a [Components] section of

Re: [edk2-devel] [PATCH v2 0/2] TigerlakeOpenBoard: Fix build errors with GCC5

Hi Takuto Naito, I think you can add comments in the same BZ ticket and then use it. Thanks, Heng From: devel@edk2.groups.io On Behalf Of Takuto Naito Sent: Wednesday, February 24, 2021 1:02 AM To: Desimone, Nathaniel L Cc: Chaganty, Rangasai V ; Luo, Heng ; devel@edk2.groups.io Subject: Re:

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

Hello Liming, I have a patch that would like to confirm with you that whether it can be merged into the upcoming edk2-stable202102 tag. This is a feature request: https://bugzilla.tianocore.org/show_bug.cgi?id=3217 In the BZ tracker, there are 3 improvements mentioned for UfsPassThruDxe.

Re: [edk2-devel] [PATCH v2 4/6] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 modules

Reviewed-by: Jiewen Yao > -Original Message- > From: Kun Qin > Sent: Wednesday, February 10, 2021 9:25 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 > Subject: [PATCH v2 4/6] SecurityPkg: Tcg2Smm: Separate Tcg2Smm into 2 > modules > >

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Thanks Kun, For putting the new library in MdePkg, I am not sure whether this is a similar case to SmmMemLib. I looped Jiewen, Liming and Mike to check if they have comments on this. Best Regards, Hao Wu From: Kun Qin Sent: Wednesday, February 24, 2021 3:30 AM To: devel@edk2.groups.io; Wu,

Re: [edk2-devel] [PATCH v2 5/6] SecurityPkg: Tcg2Smm: Added support for Standalone Mm

I am not sure if Tcg2MmDependencyLib is the best solution. It seems NULL lib instance. But I am not sure how it is used. Can we have an example in SecurityPkg.dsc? > -Original Message- > From: Kun Qin > Sent: Wednesday, February 10, 2021 9:25 AM > To: devel@edk2.groups.io > Cc: Yao,

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

Hi Jiewen, I agree with your assessment that it could have a PEI and potentially MM instance. Will remove the prefix and change them to `MmUnblockMemoryLib` in v3 patches. Thanks for the input. Regards, Kun From: Yao, Jiewen Sent: Tuesday, February 23, 2021 17:33

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Yes! It’s a bug in CpuDxe. I agree with your proposed fix. 3233 – CpuDxe may allocate above 4GB memory for GDT (tianocore.org) was submitted to capture the potential bug. From: devel@edk2.groups.io On Behalf Of Jeff Fan Sent: Tuesday,

[edk2-devel] [PATCH] Fix wrong information of TigerLake in Readme.md

Machine Name of TigerLake is TGL-U DDR4 RVP but no TGL-U LPDDR4 RVP REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3175 Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Heng Luo --- Platform/Intel/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] TianoCore Bug Triage - APAC / NAMO - Tue, 02/23/2021 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 23 February 2021, 6:30pm to 7:30pm, (GMT-08:00) America/Los Angeles *Where:* https://meetingsamer34.webex.com/meetingsamer34/j.php?MTID=mb96c5bd411bd010e1e6d43a6f6c65f45 View Event (

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Device initialization polling Loop

> -Original Message- > From: Bandaru, Purna Chandra Rao > Sent: Tuesday, February 23, 2021 10:32 PM > To: devel@edk2.groups.io > Cc: Bandaru, Purna Chandra Rao ; > Albecki, Mateusz ; Ni, Ray ; > Wu, Hao A > Subject: [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Device > initialization

Re: [edk2-devel] [PATCH v2 3/6] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst

Reviewed-by: Jiewen Yao > -Original Message- > From: Kun Qin > Sent: Wednesday, February 10, 2021 9:25 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 > Subject: [PATCH v2 3/6] SecurityPkg: Tcg2Smm: Switching from gSmst to gMmst > > This

Re: [edk2-devel] [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory interface for NVS region

Reviewed-by: Jiewen Yao > -Original Message- > From: Kun Qin > Sent: Wednesday, February 10, 2021 9:25 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, Rahul1 > Subject: [PATCH v2 6/6] SecurityPkg: Tcg2Acpi: Added unblock memory interface > for NVS

[edk2-devel] [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't.

[edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. Cc: Sai

[edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3224 Fix build errors caused by "-Werror=unused-but-set-variable" with GCC5. These build errors occur only with DEBUG target because RELEASE_GCC5_X64_CC_FLAGS has "-Wno-unused-but-set-variable", but DEBUG_GCC5_X64_CC_FLAGS doesn't. Cc: Sai

Re: [edk2-devel] [PATCH] Fix wrong information of TigerLake in Readme.md

Reviewed-by: Nate DeSimone > -Original Message- > From: Luo, Heng > Sent: Tuesday, February 23, 2021 6:05 PM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Desimone, > Nathaniel L > Subject: [PATCH] Fix wrong information of TigerLake in Readme.md > > Machine Name of TigerLake

Re: [edk2-devel] [PATCH edk2-platforms v1 1/2] TigerlakeSiliconPkg: Fix build error with GCC5

Reviewed-by: Heng Luo > -Original Message- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH edk2-platforms v1 2/2] TigerlakeOpenBoardPkg: Fix build error with GCC5

Reviewed-by: Heng Luo > -Original Message- > From: devel@edk2.groups.io On Behalf Of Takuto > Naito > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: DxeMmUnblockMemoryLib: Added definition and null instance

I feel the name is confusing. The class name is DxeMmUnblockMemoryLib. But actually, this is not related to DXE phase. I believe, it is also applicable to PEI phase, if we have a PEI instance. Please correct me if I am wrong. Also, we can have SMM instance, right? If that is true, then I

Re: [edk2-devel] [PATCH v2 5/6] SecurityPkg: Tcg2Smm: Added support for Standalone Mm

Hi Jiewen, This is essentially following the example of VariableStandaloneMm model here: StandaloneMmPkg/Library: Install Variable Arch Protocol · tianocore/edk2@326598e

Re: [edk2-devel] [PATCH] * ShellPkg: add the support to show Contained Element Count, Contained Element Record Length and Contained Elements

Hi Gao, I've attach the patch to the bugzilla. thanks for the suggestion. Mars -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72137): https://edk2.groups.io/g/devel/message/72137 Mute This Topic: https://groups.io/mt/80003667/21656

Re: [edk2-devel] [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5

Thank You Takuto! For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Takuto Naito > Sent: Tuesday, February 23, 2021 5:38 PM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [PATCH

Re: [edk2-devel] [PATCH edk2-platforms v1 0/2] TigerlakeOpenBoardPkg: Fix build error with GCC5

Thanks Takuto Naito! For the series.. Reviewed-by: Heng Luo > -Original Message- > From: Takuto Naito > Sent: Wednesday, February 24, 2021 9:38 AM > To: devel@edk2.groups.io > Cc: Takuto Naito ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > ; Luo, Heng > Subject: [PATCH

Re: [edk2-devel] [PATCH v8 08/10] OvmfPkg/CpuHotplugSmm: add EjectCpu()

superficial comments only; the patch is nearly ready: On 02/22/21 08:19, Ankur Arora wrote: > Add EjectCpu(), which handles the CPU ejection, and provides a holding > area for said CPUs. It is called via SmmCpuFeaturesRendezvousExit(), > at the tail end of the SMI handling. > > Also UnplugCpus()

Re: [edk2-devel] [PATCH v8 10/10] OvmfPkg/SmmControl2Dxe: negotiate CPU hot-unplug

On 02/22/21 08:19, Ankur Arora wrote: > Advertise OVMF support for CPU hot-unplug and negotiate it > if QEMU requests the feature. > > Cc: Laszlo Ersek > Cc: Jordan Justen > Cc: Ard Biesheuvel > Cc: Igor Mammedov > Cc: Boris Ostrovsky > Cc: Aaron Young > Ref:

Re: [edk2-devel] [PATCH v8 09/10] OvmfPkg/CpuHotplugSmm: do actual CPU hot-eject

On 02/22/21 08:19, Ankur Arora wrote: > Add logic in EjectCpu() to do the actual the CPU ejection. > > On the BSP, ejection happens by first selecting the CPU via > its QemuSelector and then sending the QEMU "eject" command. > QEMU in-turn signals the remote VCPU thread which context-switches >

Re: [edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue

On Tue, 23 Feb 2021 at 12:07, Ming Huang wrote: > > The register address of GICR_IPRIORITYR is in SGI_base frame. Add > IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise > GIC RAS error(Uncorrected software error) may report in ArmGicDxe. NOTE: missing sign-off Patch seems

Re: [edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue

On Tue, Feb 23, 2021 at 13:42:49 +0100, Ard Biesheuvel wrote: > On Tue, 23 Feb 2021 at 12:07, Ming Huang wrote: > > > > The register address of GICR_IPRIORITYR is in SGI_base frame. Add > > IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise > > GIC RAS error(Uncorrected

Re: [edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue

On 2021/2/23 下午7:06, Ming Huang wrote: The register address of GICR_IPRIORITYR is in SGI_base frame. Add IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise GIC RAS error(Uncorrected software error) may report in ArmGicDxe. --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 -

Re: [edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue

On Tue, Feb 23, 2021 at 20:58:14 +0800, Heyi Guo wrote: > > On 2021/2/23 下午7:06, Ming Huang wrote: > > The register address of GICR_IPRIORITYR is in SGI_base frame. Add > > IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise > > GIC RAS error(Uncorrected software error) may

[edk2-devel] [PATCH v3 00/26] Fix Ecc reported errors in ArmPkg

From: Pierre Gondois The Ecc tools available in the BaseTools package checks for good practice coding standards. Some errors reported while running Ecc on the ArmPkg require modifications. The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3 v2: For

[edk2-devel] [PATCH v3 02/26] ArmPkg: Fix Ecc error 8001 in SemihostLib

From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3

[edk2-devel] [PATCH v3 01/26] ArmPkg: Fix Ecc error 8001 in Chipset

From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Edk2 coding standard stating that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." the include guard of

[edk2-devel] [PATCH v3 03/26] ArmPkg: Fix Ecc error 8001 in ArmArchTimerLib

From: Pierre Gondois This patch fixes the following Ecc reported error: Only capital letters are allowed to be used for #define declarations Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3

[edk2-devel] [PATCH v3 04/26] ArmPkg: Fix Ecc error 9005 in CpuDxe

From: Pierre Gondois This patch fixes the following Ecc reported error: Only Doxygen commands '@bug', '@todo', '@example', '@file', '@attention', '@param', '@post', '@pre', '@retval', '@return', '@sa', '@since', '@test', '@note', '@par', '@endcode', '@code', '@{', '@}' are allowed to mark the

[edk2-devel] [PATCH v3 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc

From: Pierre Gondois This patch fixes the following Ecc reported error: There should be no unnecessary inclusion of library classes in the INF file This comes with the additional information: The Library Class [BootLogoLib] is not used in any platform The Library Class [DxeServicesLib] is not

[edk2-devel] [PATCH v3 06/26] ArmPkg: Fix Ecc error 10016 in StandaloneMmMmuLib

From: Pierre Gondois This patch fixes the following Ecc reported error: Module file has FILE_GUID collision with other module file The two .inf files with clashing GUID are: ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandaloneMmLib.inf As

[edk2-devel] [PATCH v3 07/26] ArmPkg: Fix Ecc error 10014 in ArmScmiDxe

From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/ArmScmiDxe/ArmScmiPerformanceProtocolPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiPrivate.h] [ArmPkg/Drivers/ArmScmiDxe/ScmiDxe.h]

[edk2-devel] [PATCH v3 08/26] ArmPkg: Fix Ecc error 10014 in GenericWatchdogDxe

From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdog.h] is existing in module ArmPkg/Drivers/GenericWatchdogDxe/GenericWatchdogDxe.inf but is not described in the INF file.

[edk2-devel] [PATCH v3 09/26] ArmPkg: Fix Ecc error 10014 in MmCommunicationDxe

From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Drivers/MmCommunicationDxe/MmCommunicate.h] is existing in module ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf but is not described in the INF file.

[edk2-devel] [PATCH v3 18/26] ArmPkg: Fix Ecc error 8005/8007 in ArmDisassemblerLib

From: Pierre Gondois This patch fixes the following Ecc reported error: 8005: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' 8007: There should be

[edk2-devel] [PATCH v3 19/26] ArmPkg: Fix Ecc error 8005 for SCMI_PROTOCOL_ID

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 20/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_TYPE

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 21/26] ArmPkg: Fix Ecc error 8005 for SCMI_STATUS

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 22/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 23/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_BASE

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 24/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_CLOCK

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 25/26] ArmPkg: Fix Ecc error 8005 for SCMI_CLOCK_RATE_FORMAT

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

[edk2-devel] [PATCH v3 10/26] ArmPkg: Fix Ecc error 10014 in SemihostLib

From: Pierre Gondois This patch fixes the following Ecc reported error: No used module files found The source files [ArmPkg/Library/SemihostLib/SemihostPrivate.h] is existing in module ArmPkg/Library/SemihostLib/SemihostLib.inf but is not described in the INF file. Signed-off-by: Pierre

[edk2-devel] [PATCH v3 11/26] ArmPkg: Remove ArmGic/ArmGicSecLib.c

From: Pierre Gondois Commit: 142fa386eb907df55c239311cd5fa2d40f5007dd removes the ArmGicSecLib. The file ArmGic/ArmGicSecLib.c was exclusively used by this library. Thus, this file should also be removed. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at:

[edk2-devel] [PATCH v3 12/26] ArmPkg: Fix Ecc error 5003 in ArmExceptionLib

From: Pierre Gondois This patch fixes the following Ecc reported error: Function name should be left justified, followed by the beginning of the parameter list, with the closing parenthesis on its own line, indented two spaces Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The

[edk2-devel] [PATCH v3 13/26] ArmPkg: Fix Ecc error 6001 in MmCommunicationDxe

From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. This patch replaces a "#if !defined [...]" statement by a "#ifndef [...]" statement, preventing Ecc to throw an error. Edk2 coding standard stating that:

[edk2-devel] [PATCH v3 14/26] ArmPkg: Fix Ecc error 6001 in ArmSoftFloatLib

From: Pierre Gondois This patch fixes the following Ecc reported error: All include file contents should be guarded by a #ifndef statement. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at: https://github.com/PierreARM/edk2/tree/1552_Ecc_ArmPkg_BIS_v3

[edk2-devel] [PATCH v3 15/26] ArmPkg: Rename include guard in ArmGicLib.h

From: Pierre Gondois Edk2 coding standard states that: "Names starting with one or two underscores, such as _MACRO_GUARD_FILE_NAME_H_, must not be used." Ref: https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification/ 5_source_files/53_include_files#

[edk2-devel] [PATCH v3 16/26] ArmPkg: Fix Ecc error 7008 for SCMI_CLOCK_RATE

From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at:

[edk2-devel] [PATCH v3 17/26] ArmPkg: Fix Ecc error 7008 for OPTEE_MESSAGE_PARAM

From: Pierre Gondois This patch fixes the following Ecc reported error: Complex types should be typedef-ed The error is due to the a nested structure declaration. Signed-off-by: Pierre Gondois Reviewed-by: Sami Mujawar --- The changes can be seen at:

[edk2-devel] [PATCH v3 26/26] ArmPkg: Fix Ecc error 8005 for SCMI_MESSAGE_ID_PERFORMANCE

From: Pierre Gondois This patch fixes the following Ecc reported error: Variable name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters 4. Global variable name must start with a 'g' Signed-off-by: Pierre Gondois

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/Arm: Fix Ecc error 7008 for SCMI_CLOCK_RATE

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#72047): https://edk2.groups.io/g/devel/message/72047 Mute This Topic: https://groups.io/mt/80563972/21656 Group Owner:

[edk2-devel] [PATCH edk2 v2 1/1] ArmPkg/ArmGic: Fix GICR_IPRIORITYR address wrong issue

The register address of GICR_IPRIORITYR is in SGI_base frame. Add IPRIORITY_ADDRESS macro for getting GICR_IPRIORITYR address. Otherwise GIC RAS error(Uncorrected software error) may report in ArmGicDxe. --- ArmPkg/Drivers/ArmGic/ArmGicLib.c | 5 - 1 file changed, 4 insertions(+), 1

Re: [edk2-devel] [PATCH v2 05/26] ArmPkg: Fix Ecc error 10006 in ArmPkg.dsc

Hi Pierre, Thanks for confirming that DebugPeCoffExtraActionLib & RvdPeCoffExtraActionLib are being built as part of the [Components]. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: Add more CRT functions

On Thu, Feb 18, 2021 at 03:13:38 +, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Leif, > Have time to review the v2 which was revised according to your comments on v1. Whoops, sorry. I am a bit unsure how to treat reviews of RedfishPkg, which I'm not a reviewer/maintainer for. If I

Re: [edk2-devel] [PATCH v3 0/3] ArmPkg: Fix several issues in OemMiscLib

On Mon, Feb 22, 2021 at 21:53:50 -0700, Rebecca Cran wrote: > Update OemMiscLib with the following changes: > > o Fixed ordering of return type and EFIAPI specifier. > o Renamed 'mHiiHandle' parameter in OemUpdateSmbiosInfo to 'HiiHandle'. > o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

Hi, Ray, Eric and Jeff, Sure, I am OK with that too. Thank you all for looking into it and provide a solution quickly. Regards Maurice From: Ni, Ray Sent: Tuesday, February 23, 2021 1:08 To: Ma, Maurice ; devel@edk2.groups.io; fanjianf...@byosoft.com.cn; Patrick Rudolph ; Dong, Guo ; Dong,

[edk2-devel] [edk2-platforms PATCH v4 0/4] Platform/Qemu/SbsaQemu: Add SMBIOS tables

o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are

  1   2   >