[edk2-devel] [PATCH] UefiPayloadPkg/PayloadLoader: Add more checks to verify ELF images

2021-06-12 Thread Ni, Ray
More checks are added to verify ELF image. ParseElfImage() is changed to InitializeElfContext() Signed-off-by: Ray Ni Cc: Marvin Häuser Cc: Guo Dong Cc: Benjamin You --- UefiPayloadPkg/PayloadLoaderPeim/ElfLib.h | 11 +- .../PayloadLoaderPeim/ElfLib/Elf32Lib.c | 38 ++--

Re: [edk2-devel] [PATCH v1 1/4] StandaloneMmPkg: Core: Spelling error in comment

2021-06-12 Thread Ard Biesheuvel
On Sat, 12 Jun 2021 at 05:44, Kun Qin wrote: > > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445 > > This change fixed a misspelling that was not caught by spell check. > > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Jiewen Yao > Cc: Supreeth Venkatesh > Cc:

Re: [edk2-devel] [PATCH v4 2/3] Silicon/Broadcom/Bcm283x: Clean up GpioPinSet function

2021-06-12 Thread Pete Batard
On 2021.06.07 08:53, Sunny Wang wrote: Make the changes below for making it clearer. - Rename GpioPinSet() to GpioPinConfigure() - Rename parameter Val to Config and change its type to BOOLEAN Cc: Samer El-Haj-Mahmoud Cc: Sami Mujawar Cc: Jeremy Linton Cc: Pete Batard Cc: Ard

Re: [edk2-devel] [PATCH v4 3/3] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS

2021-06-12 Thread Pete Batard
On 2021.06.07 08:53, Sunny Wang wrote: This change is based on edk2-platforms-raspberrypi-pl011-bth-noflow.diff in https://github.com/worproject/RPi-Bluetooth-Testing/ with the modifications and additional changes below for enabling Bluetooth and serial port (Mini UART) in Windows IOT. -

Re: [edk2-devel] Help with debugging

2021-06-12 Thread Andrew Fish via groups.io
Ethin, USB was designed in the 90’s and people actually worried about the number of Si gates in a mouse, so a vast majority of the complexity of USB is in the USB Host Controller (XHCI is the common host controller, aka HC). The devices are just end points on the bus. The end points are

Re: [edk2-devel] [PATCH v4 1/3] Platform/RaspberryPi: Dynamically build UARTs info in ACPI

2021-06-12 Thread Pete Batard
No more comments on this series for me. I have also tested this patch using Putty (serial) on Windows ARM64, to validate that COM1: was set to the serial output defined in config.txt, be it miniUART or PL011. The only thing I saw was that the baudrate for PL011 was double the one set in

[edk2-devel] [PATCH] UefiCpuPkg/PiSmmCpuDxeSmm: Initialize the fixed previous shadow stack token.

2021-06-12 Thread Sheng Wei
The fixed previous shadow stack token should be initialized as UINT64. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3192 Signed-off-by: Sheng Wei Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Cc: Jiewen Yao --- UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 2 +- 1 file

Re: 回复: [edk2-devel] [PATCH] EmulatorPkg: Update lldbefi.py to work with current lldb which uses python3

2021-06-12 Thread Rebecca Cran
Could someone commit this please? -- Rebecca Cran On 5/17/21 6:45 PM, gaoliming wrote: Rebecca: This change supports python2 & python3 both. So, I think this is a good fix. Reviewed-by: Liming Gao Thanks Liming -邮件原件- 发件人: devel@edk2.groups.io 代表 Rebecca Cran 发送时间: 2021年5月17日

[edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-12 Thread Rebecca Cran
TPM support hasn't been tested and any lines in the .dsc and .fdf files that appear to show support are bogus. Remove them. This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/BhyveX64.dsc | 64

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: Remove Xen remnants

2021-06-12 Thread Peter Grehan
On 6/13/21 7:07 AM, Rebecca Cran wrote: Several Xen remnants were left over from adapting the Ovmf code for Bhyve. Remove them. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 7 --- OvmfPkg/Bhyve/BhyveX64.dsc | 1 -

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

2021-06-12 Thread Peter Grehan
On 6/13/21 6:43 AM, Rebecca Cran wrote: TPM support hasn't been tested and any lines in the .dsc and .fdf files that appear to show support are bogus. Remove them. This fixes https://bugzilla.tianocore.org/show_bug.cgi?id=3354 . Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/BhyveX64.dsc |

[edk2-devel] [PATCH] BaseTools: Reset ERRORLEVEL in toolsetup.bat after edk2basetools check

2021-06-12 Thread Rebecca Cran
When using the in-source BaseTools, edksetup.bat will exit with an ERRORLEVEL of 1 because the line in toolsetup.bat "%PYTHON_COMMAND% -c "import edk2basetools" >NUL 2>NUL" fails. Ensure ERRORLEVEL is set to 0 when edksetup.bat or toolsetup.bat is successfully run. Signed-off-by: Rebecca Cran

Re: [edk2-devel] [PATCH v4 1/3] Platform/RaspberryPi: Dynamically build UARTs info in ACPI

2021-06-12 Thread Ard Biesheuvel
On Sat, 12 Jun 2021 at 15:40, Pete Batard wrote: > > No more comments on this series for me. > > I have also tested this patch using Putty (serial) on Windows ARM64, to > validate that COM1: was set to the serial output defined in config.txt, > be it miniUART or PL011. > > The only thing I saw

[edk2-devel] [PATCH] OvmfPkg/Bhyve: Remove Xen remnants

2021-06-12 Thread Rebecca Cran
Several Xen remnants were left over from adapting the Ovmf code for Bhyve. Remove them. Signed-off-by: Rebecca Cran --- OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.h | 7 --- OvmfPkg/Bhyve/BhyveX64.dsc | 1 - OvmfPkg/Bhyve/PlatformPei/Platform.h | 17

[edk2-devel] [PATCH] BaseTools: Remove check for Split.exe in toolset.bat

2021-06-12 Thread Rebecca Cran
Split is now a Python tool, so BaseTools\Bin\Win32\Split.exe no longer exists. Remove the check for it from toolsetup.bat to prevent the erroneous claim that the binary C tools are missing. Signed-off-by: Rebecca Cran --- BaseTools/toolsetup.bat | 1 - 1 file changed, 1 deletion(-) diff --git

[edk2-devel] [PATCH] BaseTools: Fix spelling of "overwrite" and "overwriting" in toolset.bat

2021-06-12 Thread Rebecca Cran
The words "overwrite" and "overwriting" are one word and shouldn't have hyphens. Signed-off-by: Rebecca Cran --- BaseTools/toolsetup.bat | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat index 4b5256ab6e..1fb44aaeff