[edk2-devel] [Patch V2] NetworkPkg: Making the HTTP IO timeout value programmable with PCD

2021-07-26 Thread Heng Luo
From: Zachary Clark-Williams REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507 HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout.

[edk2-devel] [PATCH] NetworkPkg: Making the HTTP IO timeout value programmable with PCD

2021-07-26 Thread Heng Luo
From: Zachary Clark-Williams HTTP boot has a default set forced timeout value of 5 seconds for getting the recovery image from a remote source. This change allows the HTTP boot flow to get the IO timeout value from the PcdHttpIoTimeout. PcdHttpIoTimeout value is set in platform code.

Re: [edk2-devel] [PATCH v2 2/2] UefiCpuPkg: ResetVector Tool additional debug prints

2021-07-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 23, 2021 4:40 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; > Kumar, Rahul1 ; De, > Debkumar ; Han, Harry ; West, > Catharine ; V, > Sangeetha > Subject: [PATCH v2 2/2] UefiCpuPkg:

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg: ResetVector Tool Support for Python 3

2021-07-26 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 23, 2021 4:40 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; > Kumar, Rahul1 ; De, > Debkumar ; Han, Harry ; West, > Catharine ; V, > Sangeetha > Subject: [PATCH v2 1/2] UefiCpuPkg:

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/27/2021 #cal-reminder

2021-07-26 Thread gaoliming
Hi, all The following issues will be reviewed in this week meeting. 3318 EDK2 Code mhaeu...@posteo.de UNCO Inconsistency between .rdata and .rodata sections Mon 05:01

[edk2-devel] [PATCH V3 10/10] OvmfPkg: Update ResetVector to support Tdx

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In the previous ResetVector code there are many SEV stuff mixed in common routines, such as SetCr3ForPageTables64. If Tdx stuff is added in this way then it is very hard to review and maintain. According to the suggestion

[edk2-devel] [PATCH V3 01/10] OvmfPkg: Add Tdx BFV/CFV PCDs and PcdOvmfImageSizeInKb

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx Virtual Firmware (TDVF) includes one Firmware Volume (FV) known as the Boot Firmware Volume (BFV). The FV format is defined in the UEFI Platform Initialization (PI) spec. BFV includes all TDVF components required during boot. TDVF also

[edk2-devel] [PATCH V3 02/10] OvmfPkg: Add Tdx metadata

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx Metadata describes the information about the image for VMM use. For example, the base address and length of the TdHob, TdMailbox, etc. Its offset is put in a GUID-ed structure which is appended in the GUID-ed chain from a fixed GPA

[edk2-devel] [PATCH V3 00/10] Add Intel TDX support in OvmfPkg/ResetVector

2021-07-26 Thread Min Xu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory Encryption (MKTME) with a new kind of virutal machines guest called a Trust Domain (TD). A

[edk2-devel] [PATCH V3 03/10] OvmfPkg: Set TdMailbox initial value and macros

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 In Tdx the memory region defined by PcdOvmfSecGhcbBackupBase is used as TdMailbox. It is initialized to all-0 by host VMM. Piece of the memory region TdMailbox[0x10, 0x20] is used as TDX_WORK_AREA. In this area a flag 'TDXG' is set so that

[edk2-devel] [PATCH V3 04/10] OvmfPkg: Add TDX_PT_ADDR defition in ResetVector.nasmb

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Tdx support 4-level paging or 5-level paging based on the GPAW. If 5-level page table is supported (GPAW is 52), a top level page directory pointers (1 * 256TB entry) is generated in the memory region defined by PcdOvmfSecPageTablesBase.

[edk2-devel] [PATCH V3 05/10] OvmfPkg: Add IntelTdx.asm in ResetVector

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 IntelTdx.asm includes below routines used in ResetVector - IsTdx Check if the running system is Tdx guest. - InitTdx This is the initialization code for Tdx guest. It sets TDX_WORK_AREA so that it can be used in later code. Also

[edk2-devel] [PATCH V3 06/10] OvmfPkg: Add AmdSev.asm in ResetVector

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 AmdSev.asm includes below routines: - CheckSevFeatures Check if Secure Encrypted Virtualization (SEV) features are enabled. - PreSetCr3ForPageTables64Sev It is called before SetCr3ForPageTables64 in SEV guests. -

[edk2-devel] [PATCH V3 07/10] OvmfPkg: Add ReloadFlat32

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Load the GDT and set the CR0, then jump to Flat 32 protected mode. After that CR4 is set. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Tom Lendacky Signed-off-by: Min

[edk2-devel] [PATCH V3 08/10] OvmfPkg: Add Init32

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 Init32.asm is the entry point of doing the 32-bit protected mode initialization. Here ReloadFlat32 is called. After that InitTdx is called to do Tdx initialization if it is Tdx guests. In the future if SEV has something to initialize,

[edk2-devel] [PATCH V3 09/10] OvmfPkg: Create Main.asm in ResetVector

2021-07-26 Thread Min Xu
RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 According to suggestion in https://edk2.groups.io/g/devel/message/78152 we drop UefiCpuPkg changes and focus on improving OvmfPkg. So Main.asm is created in OvmfPkg/ResetVector which is simply copied from UefiCpuPkg. In the next commit this

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 07/27/2021 #cal-reminder

2021-07-26 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/America/Los_Angeles X-LIC-LOCATION:America/Los_Angeles BEGIN:DAYLIGHT

[edk2-devel] [PATCH] SpcrFeaturePkg: Close the event after first callback.

2021-07-26 Thread Abdul Lateef Attar via groups.io
Adds CloseEvent in callback routine OutOfBandACPITableConstruction(), to avoid multiple installation of SPCR table. Cc: Isaac Oram Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Abdul Lateef Attar --- .../OutOfBandManagement/SpcrFeaturePkg/SpcrAcpiDxe/SpcrAcpi.c | 2 ++ 1 file changed, 2

Re: [edk2-devel] [edk2-platform PATCH v1 1/1] Platform/RaspberryPi: Make SetVariable return EFI_UNSUPPORTED at runtime

2021-07-26 Thread Sunny Wang
Please ignore this patch. Making gRT->SetVariable at runtime return EFI_UNSUPPORTED would cause some OSes' installation failure/error. I thought the latest OS may support UNSUPPORTED case, but it turned out still an error/failure. I checked both Ubuntu 21.04 and OpenSUSE 15.3 Leap, and both of

[edk2-devel] [edk2-platforms PATCH v2 2/2] Silicon/NXP/Pcf8563RealTimeClockLib: Clear Nanosecond field in GetTime

2021-07-26 Thread Masami Hiramatsu
Clear unsupported Nanosecond field of the EFI_TIME data structure. Without this fix, date/time commands on UEFI shell fail to set because of the invaild parameter error. This is tested on the SynQuacer DeveloperBox platform which also uses 'Pcf8563' RTC chip. Contributed-under: TianoCore

[edk2-devel] [edk2-platforms PATCH v2 0/2] Fix some issues on SynQuacer

2021-07-26 Thread Masami Hiramatsu
Hello, Here is the 2nd version of the patches to fix 2 issues on SynQuacer platform support. I and Sakamoto-san found these issues in edk2-test testcases on SynQuacer DeveloperBox platfrom. Previous version are here; https://edk2.groups.io/g/devel/message/77085

[edk2-devel] [edk2-platforms PATCH v2 1/2] Silicon/SynQuacer/OpteeRngDxe: Fix invalid parameter check

2021-07-26 Thread Masami Hiramatsu
Fix invalid parameter case according to the UEFI spec 2.9, section 37.5 EFI_RNG_PROTOCOL.GetRNG. The spec said, "RNGValue is null or RNGValueLength is zero." instead of "RNGValue is NULL and RNGValueLength is non-zero." This fixes the mOpteeRng::GetRNG() to check the invalid parameter case

Re: [edk2-devel] [PATCH 3/3] BaseTools: Drop check for distutils.utils

2021-07-26 Thread Yuwei Chen
This patch looks good to me. Reviewed-by: Yuwei Chen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Cole > Sent: Saturday, July 24, 2021 4:02 AM > To: devel@edk2.groups.io > Cc: Cole Robinson > Subject: [edk2-devel] [PATCH 3/3] BaseTools: Drop check for distutils.utils

[edk2-rfc] [edk2-devel] RFC: Common Design Proposal on Confidential Computing Support in OVMF

2021-07-26 Thread Yao, Jiewen
Hi I would like to raise the topic on a confidential computing support in OVMF. The main target is AMD SEV feature and Intel TDX feature in OVMF package. The goal is to create a guidance for our future confidential computing work and to better support review and maintenance. [Background] AMD

Re: [edk2-devel] [PATCH edk2-platforms v1 0/6] Enable edk2-platforms CI for JunoPkg

2021-07-26 Thread PierreGondois
Hi, The patch-serie needs modifications as the edk2 submodule added points to a personal repository, but are there other comments about the serie ? Regards, Pierre -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78170):

Re: [edk2-devel] [PATCH V2 0/4] Enable Dynamic ACPI for LS1046AFRWY

2021-07-26 Thread Vikas Singh via groups.io
Sunny,thanks for your review and PSB my remarks. From: Sunny Wang Sent: Monday, July 12, 2021 4:03 PM To: Vikas Singh ; devel@edk2.groups.io ; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ; l...@nuviainc.com Cc: Sami Mujawar ; l...@nuviainc.com ; Samer

Re: [edk2-devel] [PATCH v4 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-26 Thread Yao, Jiewen
Hi James You are right that initially EDKII did recommend to put a lib under Library dir. But with more and more feature, people start realizing that it is NOT efficient way to identify a *feature*. We changed the direction later - if we can define a feature dir, we can lib to feature dir. I

Re: [edk2-devel] [edk2-platform PATCH v1 1/1] Platform/RaspberryPi: Make SetVariable return EFI_UNSUPPORTED at runtime

2021-07-26 Thread Ard Biesheuvel
On Mon, 26 Jul 2021 at 09:18, Sunny Wang wrote: > > Please ignore this patch. Making gRT->SetVariable at runtime return > EFI_UNSUPPORTED would cause some OSes' installation failure/error. > I thought the latest OS may support UNSUPPORTED case, but it turned out still > an error/failure. I

[edk2-devel] [edk2-platforms][PATCH v2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

2021-07-26 Thread Benjamin Doron
BootManagerMenuApp is the default PcdBootManagerMenuFile. It allows choosing a boot device, but system configuration is performed in UiApp. Therefore, un-comment and fix UiApp boot option registration. Tested, UiApp can be entered through the new boot option. Cc: Eric Dong Cc: Liming Gao

Re: [edk2-devel] [edk2-platforms][PATCH v2] BoardModulePkg/BoardBdsHookLib: Register UiApp as boot option

2021-07-26 Thread Benjamin Doron
Sorry, this is actually v1 of the patch. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78181): https://edk2.groups.io/g/devel/message/78181 Mute This Topic: https://groups.io/mt/84469836/21656 Group Owner: devel+ow...@edk2.groups.io

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg/Test/TestPointCheckLib: Correctly print memory map entry

2021-07-26 Thread Benjamin Doron
In the case that there are too many EfiRuntimeServicesData entries, this was incorrectly printing the number of EfiRuntimeServicesCode entries. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Benjamin Doron ---

[edk2-devel] Missing TPM 2 related call to Tpm2HierarchyChangeAuth

2021-07-26 Thread Stefan Berger
Hello!   The TPM 2 code in EDK2 is missing an important call to Tpm2HierarchyChangeAuth for the platform hierarchy. We have to set the password of that hierarchy and discard the password. See also specs section 11:

Re: [edk2-devel] [PATCH V2 3/4] NXP/LS1046aFrwyPkg: Enable ConfigurationManager on LS1046AFRWY

2021-07-26 Thread Vikas Singh via groups.io
Sunny, Thank you for reviewing my code. Here are my remarks. PSB From: Sunny Wang Sent: Monday, July 12, 2021 4:07 PM To: Vikas Singh ; devel@edk2.groups.io Cc: Sami Mujawar ; l...@nuviainc.com ; Meenakshi Aggarwal (meenakshi.aggar...@nxp.com) ; Samer

Re: [edk2-devel] [PATCH v4 00/11] Measured SEV boot with kernel/initrd/cmdline

2021-07-26 Thread James Bottomley
On Mon, 2021-07-26 at 00:55 +, Yao, Jiewen wrote: > Hi James > "However, this ran into problems when it was decided AmdSev shouldn't > have it's own Library." > > I am not clear on the history. Would you please clarify why AmdSev > should not have its own library? The history predates me.

Re: [edk2-devel] [PATCH v2 0/4] ArmPlatformPkg: Add support to generate HEST ACPI table

2021-07-26 Thread Omkar Anand Kulkarni
Gentle reminder to review this patch series. Regards, Omkar > Changes since v1: > - Helper added for HEST ACPI table generation. > - Rebased to the latest upstream code. > > Hardware Error Source Table (HEST)[1] and Software Delegated Exception > Interface > (SDEI)[2] ACPI tables are used to

Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Platform/Sgi: Add platform support for firmware first error handling

2021-07-26 Thread Omkar Anand Kulkarni
Gentle reminder to review this patch series. Regards, Omkar > Changes since v1: > - Added Platform Error Handler DXE driver. > - Move the ACPI header values to common DSC include file. > - Rebased to the latest upstream code. > > This patch series introduces platform support for RAS using