Re: [edk2-devel] [PATCH V10 2/4] OvmfPkg: Clear WORK_AREA_GUEST_TYPE in Main.asm

2021-10-21 Thread Gerd Hoffmann
On Thu, Oct 21, 2021 at 08:17:32AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Previously WORK_AREA_GUEST_TYPE was cleared in SetCr3ForPageTables64. > This is workable for Legacy guest and SEV guest. But it doesn't work > after Intel TDX is introduced. It

[edk2-devel] Return EFI_INVALID_PARAMETER if attribute only has EFI_VARIABLE_NON_VOLATILE set

2021-10-21 Thread Sunny Wang
Hi Liming, Hao, and all Now we're checking the SCT runtime variable service test case. https://github.com/tianocore/edk2-test/blob/92a0343c1553342c53fae9d9d646b763add232c0/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c#L3401

Re: [edk2-devel] [PATCH V10 4/4] OvmfPkg: Enable TDX in ResetVector

2021-10-21 Thread Gerd Hoffmann
On Thu, Oct 21, 2021 at 08:17:34AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Intel's Trust Domain Extensions (Intel TDX) refers to an Intel technology > that extends Virtual Machines Extensions (VMX) and Multi-Key Total Memory > Encryption (MKTME) with a

Re: [edk2-devel] [PATCH 1/4] OvmfPkg: move tcg configuration to dsc and fdf include files

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: With this in place the tpm configuration is not duplicated for each of our four ovmf config variants (ia32, ia32x64, x64, amdsev) and it is easier to keep them all in sync when updating the tpm configuration. No functional change. Signed-off-by: Gerd

Re: [edk2-devel] [PATCH v6 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-21 Thread Guomin Jiang
Reviewed-by: Guomin Jiang > -Original Message- > From: Kuo, IanX > Sent: Monday, October 18, 2021 12:21 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Ni, Ray ; Kuo, > IanX ; Yao, Jiewen ; Wang, > Jian J ; Lu, XiaoyuX ; Jiang, > Guomin > Subject: [PATCH v6 2/3] CryptoPkg/CryptLib: Add

[edk2-devel] [PATCH 1/4] OvmfPkg: move tcg configuration to dsc and fdf include files

2021-10-21 Thread Gerd Hoffmann
With this in place the tpm configuration is not duplicated for each of our four ovmf config variants (ia32, ia32x64, x64, amdsev) and it is easier to keep them all in sync when updating the tpm configuration. No functional change. Signed-off-by: Gerd Hoffmann ---

[edk2-devel] [PATCH 0/4] OvmfPkg: rework TPM configuration.

2021-10-21 Thread Gerd Hoffmann
Allows to enable/disable TPM 1.2 support in OVMF. Allows to enable SHA-1 support for TPM hashing. Gerd Hoffmann (4): OvmfPkg: move tcg configuration to dsc and fdf include files OvmfPkg: create Tcg2ConfigPeiCompat12.inf OvmfPkg: rework TPM configuration OvmfPkg: add TPM2_SHA1_ENABLE build

[edk2-devel] [PATCH 2/4] OvmfPkg: create Tcg2ConfigPeiCompat12.inf

2021-10-21 Thread Gerd Hoffmann
Split Tcg2ConfigPei.inf into two variants: Tcg2ConfigPeiCompat12.inf with TPM 1.2 backward compatibility included and Tcg2ConfigPei.inf supporting TPM 2.0 only. This allows x86 builds to choose whenever TPM 1.2 support should be included or not by picking the one or the other inf file. Switch

[edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-21 Thread Gerd Hoffmann
Allows to compile OVMF without HashInstanceLibSha1, i.e. no SHA1 hash support in TPM/TCG modules. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 2 ++ OvmfPkg/OvmfTpmComponentsPei.dsc.inc | 2 ++ OvmfPkg/OvmfTpmDefines.dsc.inc | 1 + 3 files changed, 5

[edk2-devel] [PATCH 3/4] OvmfPkg: rework TPM configuration

2021-10-21 Thread Gerd Hoffmann
Rename TPM_ENABLE to TPM2_ENABLE and TPM_CONFIG_ENABLE to TPM2_CONFIG_ENABLE so they are in line with the ArmVirtPkg config option names. Add separate TPM1_ENABLE option for TPM 1.2 support. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 6 --

[edk2-devel] [PATCH v3] IntelSiliconPkg/IntelVTdDxe: Support Multi PCI Root Bus

2021-10-21 Thread Sheng Wei
Some system may has multi PCI root bus. It needs to use PciRootBridgeIo protocol to get the root bus count. Scan each root bus to get all devices. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3695 Signed-off-by: Robert Kowalewski Signed-off-by: Sheng Wei Cc: Jenny Huang Cc: Ray Ni

Re: [edk2-devel] [PATCH 4/4] OvmfPkg: add TPM2_SHA1_ENABLE build option

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Allows to compile OVMF without HashInstanceLibSha1, i.e. no SHA1 hash support in TPM/TCG modules. Does that then mean that the SHA1 bank in a TPM 2 stays untouched, meaning the PCRs there won't get extended even though the bank is there and

Re: [edk2-devel] [PATCH 2/4] OvmfPkg: create Tcg2ConfigPeiCompat12.inf

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Split Tcg2ConfigPei.inf into two variants: Tcg2ConfigPeiCompat12.inf with TPM 1.2 backward compatibility included and Tcg2ConfigPei.inf supporting TPM 2.0 only. This allows x86 builds to choose whenever TPM 1.2 support should be included or not by

Re: [edk2-devel] [PATCH 0/4] OvmfPkg: rework TPM configuration.

2021-10-21 Thread Stefan Berger
A few more comments to this series: - Is there a use case where TPM2_ENABLE_CONFIG is disabled, meaning where there should not be a TPM 2 menu entry? It's worth considering dropping this option because a user does need to have control over certain aspects of the TPM 2 configuration. Most of

Re: [edk2-devel] [PATCH 3/4] OvmfPkg: rework TPM configuration

2021-10-21 Thread Stefan Berger
On 10/21/21 8:20 AM, Gerd Hoffmann wrote: Rename TPM_ENABLE to TPM2_ENABLE and TPM_CONFIG_ENABLE to TPM2_CONFIG_ENABLE so they are in line with the ArmVirtPkg config option names. Add separate TPM1_ENABLE option for TPM 1.2 support. I tested this on Fedora and attached a TPM 1.2 to the VM

Re: [edk2-devel] [PATCH v6] UefiPayloadPkg: Remove SystemTableInfo GUID.

2021-10-21 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: Kesavan Balakrishnan, ThiyaguX Sent: Tuesday, October 19, 2021 11:05 PM To: devel@edk2.groups.io Cc: Kesavan Balakrishnan, ThiyaguX ; Ma, Maurice ; Dong, Guo ; Ni, Ray ; You, Benjamin ; Liu, Zhiguang Subject: [PATCH v6]

Re: [edk2-devel] [edk2-platforms][PATCH v5 00/46] Consolidate SpiFlashCommonLib instances

2021-10-21 Thread Nate DeSimone
Hi Michael, >From an implementation standpoint your change looks good! However it has been >very difficult to integrate it into the existing reference BIOS codebase due >to the fact that a backward incompatible change was made to PCH_SPI_PROTOCOL. For that reason, I would like to request that

Re: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/MultiPchPei: Open Source PEIM

2021-10-21 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Tuesday, October 19, 2021 8:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 1/2] WhitleySiliconPkg/MultiPchPei: Open Source

Re: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/Build: Remove MultiPchPei PEIM binary use

2021-10-21 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Tuesday, October 19, 2021 8:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V1 2/2] WhitleyOpenBoardPkg/Build: Remove

回复: [edk2-devel] Return EFI_INVALID_PARAMETER if attribute only has EFI_VARIABLE_NON_VOLATILE set

2021-10-21 Thread gaoliming
Sunny: Yes. Only EFI_VARIABLE_NON_VOLATILE attribute can’t be used by any module. So, I also think it is the invalid case. Thanks Liming 发件人: devel@edk2.groups.io 代表 Sunny Wang 发送时间: 2021年10月21日 18:19 收件人: Wu, Hao A ; gaoliming ; edk2-devel-groups-io 抄送: Samer El-Haj-Mahmoud ; Sunny

Re: [edk2-devel][edk2-platforms][PATCH V1 0/2] Eliminate MultiPchPei PEIM binary

2021-10-21 Thread Oram, Isaac W
Pushed as 63d520f943..06489b36ab -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Tuesday, October 19, 2021 8:00 PM To: devel@edk2.groups.io Cc: Oram, Isaac W Subject: [edk2-devel][edk2-platforms][PATCH V1 0/2] Eliminate MultiPchPei PEIM binary Open

Re: [edk2-devel] [PATCH V2 05/28] MdePkg: Add TdxLib to wrap Tdx operations

2021-10-21 Thread Min Xu
On October 14, 2021 1:30 PM, Gerd Hoffmann wrote: > > > > +UINT8 *mExtendBufferAddress = NULL; > > > > +TDX_EXTEND_BUFFER mExtendBuffer; > > > > + > > > > +/** > > > > + TD.RTMR.EXTEND requires 64B-aligned guest physical address of > > > > + 48B-extension data. In runtime we walk

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

2021-10-21 Thread Min Xu
On October 14, 2021 1:38 PM, Gerd Hoffmann wrote: > > > Calling CPUID should not be needed, we have a new fancy > > > ConfidentialComputing PCD for that now. > > The gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr is > defined in UefiCpuPkg. While BaseIoLibIntrinsicSev is in MdePkg. >

Re: [edk2-devel] [PATCH v3] IntelSiliconPkg/IntelVTdDxe: Support Multi PCI Root Bus

2021-10-21 Thread Ni, Ray
Wei, > + if (EFI_ERROR (Status)) { > +// > +// If PciRootBridgeIo protocol is not support, scan PCI device from root > bus 0x00. > +// > +Status = ScanPciBus(Context, Segment, 0x00, Callback); 1. Is the error handling necessary? In a simple client platform, there is only one

[edk2-devel] [edk2-non-osi][PATCH v4 2/2] edk2-non-osi: Add AmpereAltraBinPkg maintainers

2021-10-21 Thread Vu Nguyen via groups.io
Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ard Biesheuvel Cc: Nate DeSimone Signed-off-by: Vu Nguyen --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index

[edk2-devel] [edk2-non-osi][PATCH v4 1/2] AmpereAltraBinPkg: Add PciePhyLib library

2021-10-21 Thread Vu Nguyen via groups.io
Provide function to initialize the PCIe PHY on Ampere Altra processor. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ard Biesheuvel Cc: Nate DeSimone Signed-off-by: Vu Nguyen --- Silicon/Ampere/License.txt

[edk2-devel] [edk2-non-osi][PATCH v4 0/2] Introduce Silicon/Ampere and AmpereAltraBinPkg package

2021-10-21 Thread Vu Nguyen via groups.io
Create edk2-non-osi component holder for Ampere Libraries. This patchset also adds PciePhyLib which provides function to initialize PCIe PHY on Ampere Altra processor. Commits in this patchset can be found at: https://github.com/AmpereComputing/edk2-non-osi/tree/add-PciePhyLib Cc: Ard Biesheuvel

Re: [edk2-devel] [PATCH] MdePkg Cpuid.h: Define CPUID.(EAX=7,ECX=0):EDX[30]

2021-10-21 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Zeng, Star > Sent: Thursday, October 21, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Zeng, Star ; Kinney, Michael D > ; Liming Gao > ; Liu, Zhiguang ; Ni, Ray > > Subject: [PATCH] MdePkg Cpuid.h: Define CPUID.(EAX=7,ECX=0):EDX[30] >