Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

On Tue, Nov 02, 2021 at 08:50:05 +, Ryan Harkin wrote: > Hi Leif, > > There's a 00/16 in the series with a brief explanation that I'll paste here: Ah, I see. I was cc:d on all the patches, but no one was cc:d on the cover-letter. Thanks for forwarding! Probably still for the best if Bret

Re: [edk2-devel] [PATCH V4 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

Hi Min, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 02/11/2021 02:50 AM, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpm2MeasureBootLib supports TPM2 based measure boot. After CcMeasurementProtocol is

Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

On Mon, Nov 01, 2021 at 12:56:38 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF:

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

On Tue, Nov 02, 2021 at 10:05:56AM +, Yao, Jiewen wrote: > We can state, this driver is to support fixed frequency. > If a real platform happens to have fixed frequency, then it can be used. > > gEfiMdePkgTokenSpaceGuid.PcdFSBClock is defined in MdePkg. > The consumer need set PcdFSBClock.

Re: [edk2-devel] [PATCH v1 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

+ StandaloneMmPkg maintianers - this is their code. Sami: can you submit a patch to drop Supreeth please? / Leif On Mon, Nov 01, 2021 at 12:56:46 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > Drop X64 references. Update GUID. > > REF:

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

We can state, this driver is to support fixed frequency. If a real platform happens to have fixed frequency, then it can be used. gEfiMdePkgTokenSpaceGuid.PcdFSBClock is defined in MdePkg. The consumer need set PcdFSBClock. I don't see a need to bind to OVMF. Thank you Yao Jiewen >

Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev: Erase secret area content on ExitBootServices

On Tue, Nov 02, 2021 at 08:25:06AM +, Dov Murik wrote: > The confidential computing secrets area is marked as EfiBootServicesData > region, which means it is released for the OS use when the OS EFI stub > calls ExitBootServices. However, its content is not erased, and > therefore the OS might

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

Hi Gerd, (I assume your comments are for patch 2/2) On 02/11/2021 12:03, Gerd Hoffmann wrote: > On Tue, Nov 02, 2021 at 07:34:21AM +, Dov Murik wrote: >> The SEV launch secret area and the QEMU hashes table area were specified >> in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in

Re: [edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

On Mon, Nov 01, 2021 at 12:56:39 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Zhiguang Liu > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- > {ArmPkg =>

Re: [edk2-devel] [PATCH V4 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

Hi Min, Thank you for this patch. Please find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 02/11/2021 02:50 AM, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 DxeTpmMeasurementLib supports TPM based measurement in DXE phase. After CcMeasurementProtocol

Re: [edk2-devel] [PATCH v1 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

On Mon, Nov 01, 2021 at 12:56:45 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF:

Re: [edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

On Mon, Nov 01, 2021 at 12:56:44 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF:

Re: [edk2-devel] [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas

On Tue, Nov 02, 2021 at 07:34:20AM +, Dov Murik wrote: > The SEV launch secret area and the QEMU hashes table area were specified > in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPkgX64 and > in OvmgPkg/Microvm/MicrovmX64. > > This series adds theses MEMFD entries to both

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On Tue, Nov 02, 2021 at 07:34:21AM +, Dov Murik wrote: > The SEV launch secret area and the QEMU hashes table area were specified > in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPkgX64. > > Add them in OvmfPkgX64.fdf. > > After this change the two MEMFD descriptions are

[edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

Hi everyone: In order to support QXL display during the UEFI phase of the arm64 virtual machine, the modified code is as follows (based on master branch, commit id:17143c4837393d42c484b42d1789b85b2cff1aaf): diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc index

Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

Hi Bret, Is there some overall scope this set is aiming towards, or are these 16 unrelated patches to ArmPkg? Could you send out a cover-letter separately to clarify? Best Regards, Leif On Mon, Nov 01, 2021 at 12:56:33 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > Not sure

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg: Extend measurement of microcode patches to TPM

Hi Ray It is nice of you to review and give the brilliant comments, I will check and refine them one by one. Thank you Ray! BRs Longlong -Original Message- From: Ni, Ray Sent: Tuesday, November 2, 2021 11:30 AM To: devel@edk2.groups.io; Ni, Ray ; Yang, Longlong Cc: Dong, Eric ;

Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

Hi Leif, There's a 00/16 in the series with a brief explanation that I'll paste here: "This series of patch commits moves a number of modules and libraries around in order to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some duplicate code was abstracted, and

Re: [edk2-devel] [PATCH v1 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

On Mon, Nov 01, 2021 at 12:56:33 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > Not sure what all module types this HAS been validated against, but it > doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > Cc:

Re: [edk2-devel] [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

On Mon, Nov 01, 2021 at 12:56:34 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 The reference is good, but please still have a summary in the commit message. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan

Re: [edk2-devel] [PATCH v1 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

On Mon, Nov 01, 2021 at 12:56:36 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This extra interface is redundant and unnecessary. Dropping it is > more EDK2-ish. > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc:

Re: [edk2-devel] [PATCH V4 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

Hi Min, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 02/11/2021 02:50 AM, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625 CC guest is a Confidential Computing guest. If CC Guest firmware supports

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

Hi, > Do you think it should so generic that it can remove OvmfPkg dependency and > be moved to UefiCpuPkg? It's not fully standalone, the driver needs to know the lapic frequency (that is the reason why PcdFSBClock exists). For KVM this is easy, the lapic uses a fixed frequency so it can

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

On Mon, Nov 01, 2021 at 04:46:03PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > XenTimerDxe is a local Apic timer driver and it has nothing to do > with Xen. So rename it to LocalApicTimerDxe. > > After renaming, LocalApicTimerDxe is used in OvmfPkg if

Re: [edk2-devel] [PATCH v1 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

On Tue, Nov 02, 2021 at 09:34:27 +, Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:34 -0700, brbar...@microsoft.com wrote: > > From: Bret Barkelew > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 > > The reference is good, but please still have a summary in the commit

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

Hi Min I think it is good idea to rename to LocalApicTimeDxe. I double checked dependency in INF file. But I did not know why it depends upon OvmfPkg. === [LibraryClasses] UefiBootServicesTableLib BaseLib DebugLib UefiDriverEntryPoint LocalApicLib ... [Protocols]

Re: [edk2-devel] [PATCH V2 0/2] Rename XenTimerDxe to LocalApicTimerDxe

Usually, we put those information in the header of module INF file. > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, November 2, 2021 6:21 PM > To: devel@edk2.groups.io; Yao, Jiewen > Cc: Xu, Min M ; Ard Biesheuvel > ; Justen, Jordan L ; > Brijesh Singh ; Erdem Aktas > ;

[edk2-devel] [PATCH] OvmfPkg/AmdSev: Erase secret area content on ExitBootServices

The confidential computing secrets area is marked as EfiBootServicesData region, which means it is released for the OS use when the OS EFI stub calls ExitBootServices. However, its content is not erased, and therefore the OS might unintentionally reuse this sensitive memory area and expose the

Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

On Mon, Nov 01, 2021 at 12:56:37 -0700, brbar...@microsoft.com wrote: > From: Bret Barkelew > > This aligns better with Mu's philosophy around dependency structuring > and is one of the steps to enable Basecore to have zero CI dependencies > on other Mu repos. > > REF:

Re: [edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

On Mon, Nov 01, 2021 at 12:56:43 -0700, brbar...@microsoft.com wrote: > From: Sean Brogan > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Some description please. > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sean Brogan > Signed-off-by: Bret Barkelew > --- >

Re: [edk2-devel] [PATCH] Reallocate TPM Active PCRs based on platform support.

Hi, > You can see no reallocation is triggered; the unsupported PCR banks are left > active and no extend operations occur on them, thus leaving them uncapped. I have seen this effect too the compiling OVMF with SHA1 support disabled, the firmware left the SHA1 bank active then ... take

Re: [edk2-devel] 回复: [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to support reproduce builds

> -Original Message- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Monday, November 1, 2021 7:12 PM > To: Kinney, Michael D ; devel@edk2.groups.io > Cc: Liu, Zhiguang ; 'Michael Kubacki' > > Subject: [edk2-devel] 回复: [Patch V2 1/7] MdePkg/Include: Enhance DebugLib to >

[edk2-devel] [PATCH 0/2] OvmgPkg: Add SEV launch secret and hashes table areas

The SEV launch secret area and the QEMU hashes table area were specified in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPkgX64 and in OvmgPkg/Microvm/MicrovmX64. This series adds theses MEMFD entries to both targets. It allows QEMU to discover the secrets area when performing

[edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

The SEV launch secret area and the QEMU hashes table area were specified in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/OvmfPkgX64. Add them in OvmfPkgX64.fdf. After this change the two MEMFD descriptions are identical: $ sed -n -e '/FD.MEMFD/,/FV.SECFV/p' OvmfPkg/OvmfPkgX64.fdf |

[edk2-devel] [PATCH 2/2] OvmfPkg/Microvm: Add SEV launch secret and hashes table areas to MEMFD

The SEV launch secret area and the QEMU hashes table area were specified in the OvmfPkg/AmdSev/AmdSevX64 MEMFD but not in OvmfPkg/Microvm/MicrovmX64. Add them in MicrovmX64.fdf. After this change the two MEMFD descriptions are identical: $ sed -n -e '/FD.MEMFD/,/FV.SECFV/p'

Re: [edk2-devel][PATCH v4] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

Just a format issue (see inline comment). With it addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yang Jie > Sent: Friday, October 29, 2021 11:10 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Jiang, Guomin > ;

Re: [edk2-devel] [PATCH V4 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

May I know which platform you have run the test? I think we need cover both TD and TPM in real platform. > -Original Message- > From: Xu, Min M > Sent: Tuesday, November 2, 2021 10:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang ;

Re: [edk2-devel] [PATCH V4 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

May I know which platform you have run the test? I think we need cover both TD and TPM in real platform. > -Original Message- > From: Xu, Min M > Sent: Tuesday, November 2, 2021 10:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang ;

Re: [edk2-devel] [PATCH V4 1/3] MdePkg: Introduce CcMeasurementProtocol for CC Guest firmware

Reviewed-by: Jiewen Yao > -Original Message- > From: Xu, Min M > Sent: Tuesday, November 2, 2021 10:51 AM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Kinney, Michael D > ; Liming Gao ; Liu, > Zhiguang ; Yao, Jiewen ; > Wang, Jian J ; Lu, Ken ; Sami > Mujawar ; Gerd Hoffmann > Subject:

[edk2-devel][PATCH v3] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699 The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated interface VariableLockRequestToLock.c. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang

Re: [edk2-devel] [Patch V2 0/7] Reproduce builds across source format changes

Hi Liming, RELEASE in tools_def.txt only means disable symbols. It does not mean disable DEBUG() and ASSERT(). Some platforms use DEBUG/RELEASE build type to control DEBUG() and ASSERT(), but that is not required. In order to do binary build comparison, I am actually having to use NOOPT builds

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On 02/11/2021 15:29, Gerd Hoffmann wrote: > Hi, > >>> I'm wondering whenever you actually tried to boot a sev guest >>> in microvm? >> >> No I haven't tried. Do you want Microvm to be able to boot SEV guests, >> or do you intentionally want to keep functionality out so it stays small? > >

Re: [edk2-devel] [PATCH V3 10/29] UefiPayloadPkg: PreparePrepare UefiPayloadPkg to use TdxLib

On Mon, Nov 01, 2021 at 09:15:59PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > TdxLib is included in BaseXApicX2ApicLib. To prevent any build > breakage, update the UefiPayloadPkg.dsc to include the TdxLib > library. > > Cc: Guo Dong > Cc: Ray Ni > Cc:

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

On Tue, Nov 02, 2021 at 08:55:39PM +0800, Lange Tang wrote: > Hi everyone: > > > In order to support QXL display during the UEFI phase of the arm64 virtual > machine, Not going to fly. Use virtio-gpu instead. Anything with a virtual pci memory bar is going to have cache attribute problems on

Re: [edk2-devel][PATCH v3] MdeModulePkg/DxeCapsuleLibFmp: Use new Variable Lock interface

It looks like you have a typo in "LockVaraible". It might be a good idea to fix that. Best regards, Pedro On Tue, 2 Nov 2021, 06:38 Yang Jie, wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3699 > The code in MdeModulePkg\Library\DxeCapsuleLibFmp call the deprecated > interface

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

Hi, > +UINT64 mTdSharedPageMask = 0; > +UINT32 mTdMaxVCpuNum = 0; > +UINT32 mTdVCpuNum= 0; > +UINT64 > +EFIAPI > +TdSharedPageMask ( > + VOID > + ) > +{ > + UINT64 Status; > + UINT8 Gpaw; > + TD_RETURN_DATA

Re: [edk2-devel] [PATCH V3 11/29] UefiCpuPkg: Support TDX in BaseXApicX2ApicLib

On Mon, Nov 01, 2021 at 09:16:00PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > MSR is accessed in BaseXApicX2ApicLib. In TDX some MSRs are accessed > directly from/to CPU. Some should be accessed via explicit requests > from the host VMM using

Re: [edk2-devel] [PATCH V3 12/29] UefiCpuPkg: Define ConfidentialComputingGuestAttr

Hi, > .../Include/ConfidentialComputingGuestAttr.h | 25 +++ > MdePkg/MdePkg.dec | 4 +++ Subject doesn't match patch (UefiCpuPkg vs MdePkg). take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [PATCH v2 1/4] SecurityPkg: Store physical presence code by submitting to PreOS func

Modify SavePpRequest to look like its TPM 2 equivalent SaveTcg2PpRequest and have it submit the physical presence opcode to the PreOS function so that we can choose our own method for how to store it. Move the existing code into DxeTcgPhysicalPresenceLib.c and adapt the return codes. Cc: Jiewen

[edk2-devel] [PATCH v2 4/4] OvmfPkg: add TPM 1.2 config menu

From: Gerd Hoffmann When building OVMF with TPM 1.2 support enabled do also include the configuration menu. Suggested-by: Stefan Berger Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmComponentsDxe.dsc.inc | 1 + OvmfPkg/OvmfTpmDxe.fdf.inc | 1 + 2 files changed, 2 insertions(+)

[edk2-devel] [PATCH v2 0/4] Add support for TPM 1.2 Physical Presence Interface and Menu

This series adds support for the full TPM 1.2 Physical Presence Interface (PPI) and activates the TPM 1.2 menu at the end. PPI is a prerequisite for the menu to work. The modifications to the original code are mostly due to the fact that we are using a memory region for PPI in QEMU. I tried to

[edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

Enable the physical presence interface for TPM 1.2. It is required for the TPM 1.2 menu to work. The changes to DxeTcgPhysicalPresenceLib.c are due to the device we are using in QEMU for presenting the supported PPI commands and results to the OS via ACPI as well as to store the PPI opcode to

[edk2-devel] [PATCH v2 2/4] OvmfPkg: Copy TPM 1.2 DxeTcgPhysicalPresenceLib.c from SecuityPkg

Copy the TPM 1.2 physical presence interface support from SecurityPkg DxeTcgPhysicalPresenceLib.c along with its .inf and .uni files into OvmfPkg. Fix EFI_F_INFO and EFI_D_ERROR to meet code standards. Signed-off-by: Stefan Berger --- .../DxeTcgPhysicalPresenceLib.c | 1455

Re: [edk2-devel] [PATCH V3 05/29] UefiCpuPkg/CpuExceptionHandler: Add base support for the #VE exception

On Mon, Nov 01, 2021 at 09:15:54PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add base support to handle #VE exceptions. Update the common exception > handlers to invoke the VmTdExitHandleVe () function of the VmgExitLib > library when a #VE is

Re: [edk2-devel] About how to submit a new architecture called LoongArch

Chao, This is probably a little out of date, but in case it helps http://vzimmer.blogspot.com/2014/11/porting-to-new-architecture.html?m=1 > On Nov 2, 2021, at 7:32 AM, gaoliming wrote: > > Chao: > Can you follow Mike's suggestion to share the your code change in your > personal GitHub repo

Re: [edk2-devel] [PATCH V3 03/29] UefiCpuPkg: Extend VmgExitLibNull to handle #VE exception

On Mon, Nov 01, 2021 at 09:15:52PM +0800, Min Xu wrote: > RFC： https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > VmgExitLib performs the necessary processing to handle a #VC exception. > VmgExitLibNull is a NULL instance of VmgExitLib which provides a > default limited interface. In this

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

On 11/2/21 8:53 AM, Dov Murik wrote: On 02/11/2021 15:29, Gerd Hoffmann wrote: Hi, I'm wondering whenever you actually tried to boot a sev guest in microvm? No I haven't tried. Do you want Microvm to be able to boot SEV guests, or do you intentionally want to keep functionality out so

Re: [edk2-devel] [PATCH V3 04/29] OvmfPkg: Extend VmgExitLib to handle #VE exception

Hi, > +MmioExit ( > + IN OUT EFI_SYSTEM_CONTEXT_X64 *Regs, > + IN TDCALL_VEINFO_RETURN_DATA *Veinfo > + ) > +{ > + do { > +OpCode = *Rip++; > +if (OpCode == 0x66) { > + OpSize = 2; Oh, wow. So the VE exit data doesn't provide the information which io/mmio access

Re: [edk2-devel] [PATCH 1/2] OvmfPkg/OvmfPkgX64: Add SEV launch secret and hashes table areas to MEMFD

Hi, > > I'm wondering whenever you actually tried to boot a sev guest > > in microvm? > > No I haven't tried. Do you want Microvm to be able to boot SEV guests, > or do you intentionally want to keep functionality out so it stays small? Need to look at it on a case by case base. It is

Re: [edk2-devel] [PATCH V3 13/29] MdePkg: Add macro to check SEV/TDX guest

On Mon, Nov 01, 2021 at 09:16:02PM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > Add macros CC_GUEST_IS_TDX/CC_GUEST_IS_SEV to check SEV/TDX guest. > > Cc: Michael Roth > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Eric Dong > Cc: James Bottomley > Cc: Min Xu >

回复: [edk2-devel] About how to submit a new architecture called LoongArch

Chao: Can you follow Mike's suggestion to share the your code change in your personal GitHub repo as the first step? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Michael D > Kinney > 发送时间: 2021年10月29日 13:19 > 收件人: devel@edk2.groups.io; kilater...@163.com; Kinney, Michael D >

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the same in https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning Thanks, Vineel -Original Message- From: Wu, Jiaxin Sent: Monday,

Re: [edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

Thanks for incorporating the feedback. Few more minor comments based on the new patch: 1. The description of "DieIndex" perhaps should be modified to " Index of the die in the package" to make it more apt. 2. The description of "DieId" perhaps should be modified to " Unique ID specific to the

Re: [edk2-devel] [edk2-[PATCH v1 0/2] APIC table updates

The series has been pushed as 34df404~..30865b8 -Original Message- From: Abdul Lateef Attar Sent: Friday, October 22, 2021 7:48 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Liming Gao ; Dong, Eric Subject: [edk2-[PATCH v1 0/2] APIC table updates Fixes the

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

Good call. Maintainers, your opinion? - Bret From: Leif Lindholm via groups.io Sent: Tuesday, November 2, 2021 2:55 AM To: brbar...@microsoft.com Cc: devel@edk2.groups.io; Ard

Re: [edk2-devel] [PATCH v1 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

Will address. On Tue, Nov 2, 2021 at 2:57 AM Leif Lindholm wrote: > > On Mon, Nov 01, 2021 at 12:56:43 -0700, brbar...@microsoft.com wrote: > > From: Sean Brogan > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 > > Some description please. > > > Cc: Leif Lindholm > > Cc: Ard

[edk2-devel] [PATCH v2 00/16] Un-siloing Arm common code

This series of patch commits moves a number of modules and libraries around in order to better un-silo the Arm-specific code. Unnecessary abstractions were removed, some duplicate code was abstracted, and generally things were cleaned up so that common code (e.g. MdePkg, MdeModulePkg,

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Thanks a lot Maciej. Much appreciated. From: Rabeda, Maciej Sent: Tuesday, November 2, 2021 12:54 PM To: devel@edk2.groups.io; vinee...@microsoft.com; Wu, Jiaxin; vineel.kovv...@gmail.com; Rabeda, Maciej; Yao, Jiewen; Jancarlo Perez; Mike Turner; Sean Brogan;

Re: [edk2-devel] 回复: [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Thanks Liming. I will send a v2 patch with that change. -bob -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming via groups.io Sent: Monday, November 1, 2021 7:12 PM To: devel@edk2.groups.io; Bob Morgan Cc: 'Jian J Wang' ; 'Guomin Jiang' Subject: 回复: [edk2-devel]

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Hi Vineel, I will integrate the change to edk2 tomorrow. For now: Reviewed-by: Maciej Rabeda Thanks, Maciej On 02-Nov-21 19:57, Vineel Kovvuri via groups.io wrote: Hi Folks, Thanks for reviewing the patch. May I know what are the next steps to get it in to edk2? I have already updated the

[edk2-devel] [PATCH v2 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

From: Bret Barkelew TODO: Might keep the name of the .inf. Pending discussion. This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF:

[edk2-devel] [PATCH v2 06/16] ArmPkg and BaseTools: Move the GccLto binaries from ArmPkg to BaseTools

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3650 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Bob Feng Cc:

[edk2-devel] [PATCH v2 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

From: Bret Barkelew Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan Signed-off-by: Bret Barkelew --- {ArmPkg/Include => MdePkg/Include/AArch64}/AsmMacroIoLibV8.h | 0 {ArmPkg/Include => MdePkg/Include/Arm}/AsmMacroIoLib.h |

[edk2-devel] [PATCH v2 08/16] MdePkg: Create the MMU access lib to abstract memory protection settings

From: Bret Barkelew There are a number of Arm-specific accesses that are abstracted behind this. It may need to be refactored to work better across architectures. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Sean Brogan

[edk2-devel] [PATCH v2 01/16] ArmPkg/ArmMmuBaseLib: Disallow STANDALONE_MM

From: Bret Barkelew Not sure what all module types this HAS been validated against, but it doesn't work with STANDALONE_MM or STANDALONE_MM_CORE. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew

[edk2-devel] [PATCH v2 02/16] ArmPkg/ArmMmuStandaloneMmLib: Update to match ArmMmuLib

From: Bret Barkelew Drop switch from the custom "StandaloneMmMmuLib" class to the more generic "ArmMmuLib" class and add the missing functions to fulfill that interface. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan

[edk2-devel] [PATCH v2 04/16] ArmPkg: Disavow StandaloneMmMmuLib. It's just ArmMmuLib

From: Bret Barkelew This extra interface is redundant and unnecessary. Dropping it is more EDK2-ish. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew Reviewed-by: Leif Lindholm --- ArmPkg/ArmPkg.dec

[edk2-devel] [PATCH v2 03/16] ArmPkg/StandaloneMmCoreEntryPoint: Swap to ArmMmuLib

From: Bret Barkelew StandaloneMmMmuLib has been turned into an implementation of the ArmMmuLib class (without any change to the interface itself), so this module can now change its dependency. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3647 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc:

[edk2-devel] [PATCH v2] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

Enhance RelocateCapsuleToRam() to skip creation of the Capsule on Disk file name capsule if PcdSupportUpdateCapsuleReset feature is not enabled. This avoids an EFI_UNSUPPORTED return status from UpdateCapsule() when the file name capsule is encountered and PcdSupportUpdateCapsuleReset is FALSE.

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v1 05/16] ArmPkg and MdePkg: Move the Arm CompilerIntrinsicsLib to MdePkg

I’d be amenable to that. @Sean? - Bret From: Leif Lindholm via groups.io Sent: Tuesday, November 2, 2021 2:51 AM To: brbar...@microsoft.com Cc: devel@edk2.groups.io; Ard

[edk2-devel] [PATCH v2 09/16] MdeModulePkg: Swap to MmuLib instead of Arm-specific lib

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Liming Gao Cc: Sean Brogan Signed-off-by: Bret Barkelew --- MdeModulePkg/Core/DxeIplPeim/Arm/DxeLoadFunc.c | 4 ++-- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf

[edk2-devel] [PATCH v2 10/16] StandaloneMmPkg: Switch to the MmuLib abstraction

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3651 Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew ---

[edk2-devel] [PATCH v2 11/16] ArmPkg: Add Basic MMU Lib for Arm silicon

From: Sean Brogan The previously Arm-specific "ArmMmuLib" has been generalized as "MmuLib". The Arm implementation of this lib can still use the existing library logic to back it. As such, this implementation is currently just a shim to the old library, while enabling higher-level code to be

[edk2-devel] [PATCH v2 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 14/16] ArmPkg/Library: Convert StandaloneMmCoreEntryPoint to Arm-only

From: Bret Barkelew Drop X64 references. Update GUID. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Sean Brogan Signed-off-by: Bret Barkelew ---

[edk2-devel] [PATCH v2 13/16] ArmPkg: Move the StandaloneMmCoreEntryPoint lib to ArmPkg

From: Bret Barkelew This aligns better with Mu's philosophy around dependency structuring and is one of the steps to enable Basecore to have zero CI dependencies on other Mu repos. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar

[edk2-devel] [PATCH v2 15/16] ArmPkg/ArmPkg.dsc: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPkg/ArmPkg.dsc | 8 1 file changed, 8 insertions(+) diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc index

[edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3652 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sean Brogan Signed-off-by: Bret Barkelew --- ArmPlatformPkg/ArmPlatformPkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [edk2-devel] [PATCH v1 07/16] ArmPkg and MdePkg: Move the AsmMacroIoLib from ArmPkg to MdePkg

Will address. Thanks! On Tue, Nov 2, 2021 at 2:25 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:39 -0700, brbar...@microsoft.com wrote: > > From: Bret Barkelew > > > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > >

Re: [edk2-devel] [PATCH v1 12/16] ArmPkg: Move the StandaloneMmCpu driver to ArmPkg

If the implementation didn't make so many calls into Arm-specific libs for SMC servicing, it could stay right where it is. It's just that untangling that Gordian knot is outside my ken. On Tue, Nov 2, 2021 at 3:00 AM Leif Lindholm wrote: > On Mon, Nov 01, 2021 at 12:56:44 -0700,

Re: [edk2-devel] [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg SpiFvbServiceSmm

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel Subject: [PATCH v6 26/52] WhitleyOpenBoardPkg: UseIntelSiliconPkg

Re: [edk2-devel] [PATCH v6 41/52] CoffeelakeSiliconPkg/BasePchSpiCommonLib: Identify flash regions by GUID

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [edk2-devel] [PATCH v6 41/52]

Re: [edk2-devel] [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and Protocol

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH v6 42/52] CoffeelakeSiliconPkg: Update for SPI2 PPI and

Re: [edk2-devel] [PATCH v6 43/52] CometlakeOpenBoardPkg: Remove unnecessary gPchSpiPpiGuid reference

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Chaganty, Rangasai V ; Kethi Reddy, Deepika ; Esakkithevar, Kathappan

Re: [edk2-devel] [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 48/52] SimicsIch10Pkg/BasePchSpiCommonLib: Identify flash regions by GUID

Re: [edk2-devel] [PATCH v6 51/52] TigerlakeSiliconPkg/SpiSmm: Update for SPI2 Protocol

Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Michael Kubacki Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Desimone, Nathaniel L ; Luo, Heng Subject: [edk2-devel] [PATCH v6 51/52]

Re: [edk2-devel] [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol

Reviewed-by: Nate DeSimone -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 3:09 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Desimone, Nathaniel L Subject: [PATCH v6 49/52] SimicsIch10Pkg/PchSpiSmm: Update for SPI2 Protocol From: Michael

Re: [edk2-devel] [PATCH v6 00/52] Consolidate SpiFlashCommonLib instances

The series has been pushed as 04bfa22~..bae4725 Thank you for all the excellent work on this Michael! -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chiu, Chasel ; Kethi Reddy, Deepika ;

[edk2-devel] [PATCH v1] Maintainers.txt: Change SimicsOpenBoardPkg Maintainer

To help keep edk2-platforms healthy, I would like to offer to maintain SimicsOpenBoardPkg, SimicsX58SktPkg, and SimicsIch10Pkg. The current maintainer for those packages has changed jobs and is no longer active in the community. Cc: Agyeman Prince Cc: Leif Lindholm Cc: Michael D Kinney

Re: [edk2-devel] [PATCH v6 33/52] PurleyOpenBoardPkg: Add SpiFlashCommonLib.h

Reviewed-by: Nate DeSimone I will correct the commit message during the upstreaming process. Thanks, Nate -Original Message- From: mikub...@linux.microsoft.com Sent: Thursday, October 28, 2021 1:43 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; Chiu, Chasel

  1   2   >