Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Hi, Abner Other patches are still in review. I am thinking if this patch can be in a separate patch-sets so that you can merge it to EmbeddedPkg? What's your thought? Thanks Min From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, January 27, 2022 9:56 AM To: Xu, Min M ;

Re: [edk2-devel] [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM override

Reviewed-by: Ray Ni -Original Message- From: Kinney, Michael D Sent: Saturday, January 22, 2022 9:41 AM To: devel@edk2.groups.io Cc: Wu, Hao A ; Ni, Ray ; Zeng, Star Subject: [Patch 1/1] MdeModulePkg/Bus/Pci/PciBusDxe: Support platform PCI ROM override REF:

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

This is the PR: https://github.com/tianocore/edk2/pull/2444 From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 11:46 AM To: Xu, Min M ; devel@edk2.groups.io Cc: Leif Lindholm ; Ard Biesheuvel ; Schaefer, Daniel Subject: Re: [edk2-devel] [PATCH 1/1]

Re: [edk2-devel] question: is it feasible to execute a UEFI-BIOS using x86 instructions on non-x86 platforms?

https://www.suse.com/c/revolutionizing-arm-technology-x86_64-option-rom-aarch64/ https://www.workofard.com/2020/12/aarch64-option-roms-for-amd-gpus/ > On Jan 26, 2022, at 3:26 PM, Michael Holzer > wrote: > >  > RAID disc controller cards usually have a built-in configuration program in >

Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

yes, I can do that if you separate it to a standalone patch. This change doesn't hurt others. Abner From: Xu, Min M Sent: Thursday, January 27, 2022 10:39 AM To: Chang, Abner (HPS SW/FW Technologist) ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH V2

Re: [edk2-devel] [PATCH 1/1] BaseTools: Enable GNU make parallel jobs by default

Hi Steven, I'd suggest appending the threads number to the --jobs FLAG. The threads number can be got via build.py ThreadNum(), and suggest testing the incremental build functionality. Thanks, Bob -Original Message- From: Shi, Steven Sent: Monday, January 17, 2022 10:43 PM To:

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Merged. From: devel@edk2.groups.io on behalf of Min Xu Sent: Thursday, January 27, 2022 12:39 PM To: devel@edk2.groups.io ; Chang, Abner (HPS SW/FW Technologist) Cc: Leif Lindholm ; Ard Biesheuvel ; Schaefer, Daniel (ROM Janitor) Subject: Re: [edk2-devel]

Re: [edk2-devel][PATCH] BaseTools/GenFw: Enhance to add export table in PE-COFF

Hi Michael, Thanks for your response. Sorry I didn't give enough context for my question, I mean the ' SizeOfInitializedData' in Optional header of PE-COFF file. SizeOfInitializedData The size of the initialized data section, or the sum of all such sections if there are multiple data sections.

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Reviewed-by: Abner Chang Please create a PR (give me the link) for running Core CI, I will merge it once it gets passed through. Thanks Abner From: Min Xu Sent: Thursday, January 27, 2022 11:36 AM To: devel@edk2.groups.io Cc: Min Xu ; Leif Lindholm ; Ard

Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Sure. The standalone patch is sent out. PR: https://github.com/tianocore/edk2/pull/2444 From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, January 27, 2022 11:01 AM To: Xu, Min M ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c

[edk2-devel] [PATCH 1/1] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3814 CompressedDataLength is declared as UINTN which is UINT64 in X64 arch. But the second parameter of UefiDecompressGetInfo() is declared as UINT32. So a build error is triggered. To declare CompressedDataLength as UINT32 to fix the build

[edk2-devel] Updated Event: TianoCore Community Meeting - EMEA / NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

[edk2-devel] Updated Event: TianoCore Community Meeting - APAC/NAMO #cal-invite

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [PATCH V5 17/33] OvmfPkg: Update Sec to support Tdx

Hi, > PcdTdxAcceptPageSize is added for page accepting. Currently TDX supports > 4K and 2M accept page size. The default value is 4K. Is there a good reason to not use 2M by default? In case that fails the code will fallback to 4K pages, so there isn't an obvious reason for that ... >

Re: [edk2-devel] [PATCH V5 14/33] OvmfPkg: Add IntelTdx.h in OvmfPkg/Include/IndustryStandard

On Sun, Jan 23, 2022 at 09:36:45AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > IntelTdx.h defines the defitions used by TDX in OvmfPkg: > - Mailbox related defitions,such as the data structure, command code, >AP relocation defitions. > -

Re: [edk2-devel] [PATCH V5 18/33] OvmfPkg: Check Tdx in QemuFwCfgPei to avoid DMA operation

Hi, > +BOOLEAN > +QemuFwCfgIsTdxGuest ( > + VOID > + ) > +{ > + CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER *CcWorkAreaHeader; > + > + CcWorkAreaHeader = (CONFIDENTIAL_COMPUTING_WORK_AREA_HEADER > *)FixedPcdGet32 (PcdOvmfWorkAreaBase); > + return (CcWorkAreaHeader != NULL &&

Re: [edk2-devel] [PATCH 00/24] CryptoPkg/openssl: update openssl submodule to v3.0

Hi, > I think adding intrinsic libraries is a mixed bag, for the following > reasons: > > 1) The intrinsic libraries are completely internal to the compilers. > Breaking down that toolchain/code barrier is not a good idea if we want the > project to compile using a good variety of compilers.

Re: [edk2-devel] [PATCH V5 22/33] OvmfPkg: Add PlatformInitLib

On Sun, Jan 23, 2022 at 09:36:53AM +0800, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > There are multi-variants of PlatformPei in OvmfPkg, for example, > - OvmfPkg/PlatformPei > - OvmfPkg/Bhyve/PlatformPei > - OvmfPkg/XenPlatformPei > These PlatformPeis share a

Re: [edk2-devel][PATCH V1 1/1] ReadMe.rst: Fix broken license links

Reviewed-by: Michael D Kinney Mike > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, January 26, 2022 12:08 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm ; Kinney, > Michael D > Subject: [edk2-devel][PATCH V1 1/1] ReadMe.rst: Fix broken license links >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Convert BmLoadOption to Variable Policy

It's been a week since I sent this out: could someone review it please? Thanks. Rebecca Cran On 1/19/22 14:01, Rebecca Cran wrote: Since the Variable Lock protocol is deprecated, convert locking of PlatformRecovery in EfiBootManagerLoadOptionToVariable to use the Variable Policy protocol.

[edk2-devel] question: is it feasible to execute a UEFI-BIOS using x86 instructions on non-x86 platforms?

RAID disc controller cards usually have a built-in configuration program in their BIOS. Some cards added a UEFI-BIOS but still only build this for x86 platforms. I wonder if it is feasible to execute this code on the growing number of non-x86

Re: [edk2-devel] [PATCH] MdeModulePkg/Variable: Make only EFI_VARIABLE_NON_VOLATILE invalid

Thanks, Liming. -Original Message- From: gaoliming Sent: 18 January 2022 05:25 To: devel@edk2.groups.io; gaolim...@byosoft.com.cn; Sunny Wang Cc: 'Heinrich Schuchardt' ; G Edhaya Chandran ; Samer El-Haj-Mahmoud Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/Variable: Make only

Re: [edk2-devel][PATCH] BaseTools/GenFw: Enhance to add export table in PE-COFF

Are you referring to "static data"? If so, no. That is allocated at boot time and placed into the appropriate handler information structures. The items in the export table for a given PRM Module are: 1. PRM handler count 2. Platform GUID (automatically applied from the DSC

[edk2-devel][PATCH V1 1/1] ReadMe.rst: Fix broken license links

Several of the license links are broken due to use of backslashes. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Isaac Oram --- ReadMe.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ReadMe.rst b/ReadMe.rst index 8f5db11281..3225dc0900

Re: [edk2-devel] [PATCH V5 05/33] OvmfPkg: Extend VmgExitLib to handle #VE exception

Hi, > + Write = Veinfo->ExitQualification.Io.Direction ? FALSE : TRUE; > + Size = Veinfo->ExitQualification.Io.Size + 1; > + Port = Veinfo->ExitQualification.Io.Port; Ah, very nice, the instruction decoder replaced by three lines of code ;) Acked-by: Gerd Hoffmann take care, Gerd

Re: [edk2-devel][PATCH] BaseTools/GenFw: Enhance to add export table in PE-COFF

Hi Michael, Sure, I will include you if any update on PRM functionality. BTW, I have a question about InitializedData, does it include export section or not? Thanks. Regards, Lisa -Original Message- From: Michael Kubacki Sent: 2022年1月22日 10:50 To: devel@edk2.groups.io; Huang,

Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Hi Min, Would you please create a PR for this and point me to the link? Thanks Abner From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, January 25, 2022 11:09 PM To: devel@edk2.groups.io ; min.m...@intel.com Subject: RE: [edk2-devel] [PATCH V2 01/10]

Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Hi, Abner This is the PR of the patch-sets. https://github.com/tianocore/edk2/pull/2313 Thanks Min From: devel@edk2.groups.io On Behalf Of Abner Chang Sent: Thursday, January 27, 2022 8:43 AM To: devel@edk2.groups.io; Xu, Min M Subject: Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build

[edk2-devel] 回复: [Patch 1/2] BaseTools: Update brotli submodule

Does this updated patch pass CI? Thanks Liming > -邮件原件- > 发件人: Bob Feng > 发送时间: 2022年1月26日 16:30 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao ; Yuwei Chen > ; Pedro Falcato > 主题: [Patch 1/2] BaseTools: Update brotli submodule > > REF:

回复: [edk2-devel] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Convert BmLoadOption to Variable Policy

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Rebecca Cran > 发送时间: 2022年1月27日 7:23 > 收件人: devel@edk2.groups.io > 抄送: Jian J Wang ; Liming Gao > ; Zhichao Gao ; Ray Ni > > 主题: Re: [edk2-devel] [PATCH 1/1] MdeModulePkg/UefiBootManagerLib: > Convert BmLoadOption to Variable Policy > > It's

回复: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Jake Garver > via groups.io > 发送时间: 2022年1月21日 7:58 > 收件人: devel@edk2.groups.io; jbra...@nvidia.com; > ashishsin...@nvidia.com > 抄送: Jake Garver > 主题: [edk2-devel] [PATCH] BaseTools: Fix error leg in DscBuildData.py > >

Re: [edk2-devel] [PATCH V2 01/10] EmbeddedPkg: Fix a build error in FwVol.c in X64 arch

Hi Min, Did you get the reviewed-by for other patches? Just let me know when the review process is done, I can then merge the patch to EmbeddedPkg. Regards, Abner From: Xu, Min M Sent: Thursday, January 27, 2022 8:58 AM To: devel@edk2.groups.io ; Chang, Abner

Re: [edk2-devel] 回复: [Patch 1/2] BaseTools: Update brotli submodule

Yes. it passed the edk2 CI https://github.com/tianocore/edk2/pull/2442 Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Thursday, January 27, 2022 9:12 AM To: Feng, Bob C ; devel@edk2.groups.io Cc: Chen, Christine ; 'Pedro Falcato' Subject:

[edk2-devel] [Patch 2/2] MdeModulePkg: update brotli submodule

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3417 Update the brotli submodule to the latest commit (f4153a0) so that the build isn't broken in GCC 11 compilers. Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Cc: Pedro Falcato Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 1/2] BaseTools: Update brotli submodule

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3417 Update the brotli submodule to the latest commit (f4153a0) so that the build isn't broken in GCC 11 compilers. Signed-off-by: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Cc: Pedro Falcato --- BaseTools/Source/C/BrotliCompress/GNUmakefile