[edk2-devel] [PATCH] bRefClkFreq UFS card attribute need to be programmed after fDeviceInit

2022-03-25 Thread Bandaru, Purna Chandra Rao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3886 bRefClkFreq UFS card attribute need to be read and written after successful fDeviceInit and NOP response so that link will be stable. Cc: Wu Hao A Cc: Albecki Mateusz Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Purna Chandra Rao

Re: [edk2-devel] [PATCH v2 14/17] Silicon/Ampere: Update ArmPlatformLib to work with changed ARM_CORE_INFO

2022-03-25 Thread Leif Lindholm
Hi Nhi, On Sun, Dec 19, 2021 at 10:35:41 +0700, Nhi Pham via groups.io wrote: > Hi Rebecca, > > Leif is merging the rest of Altra port to the edk2-platforms which has SRAT > ACPI table consuming the CPU Core Info table. Therefore, we will need to fix > the SRAT too. I would defer the fix until

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Andrew Fish via groups.io
>From an UEFI point of view if you own the memory you can do what you want with >it. The UEFI Spec does not deal with paging but the PI Spec does have >abstractions for how the CPU operates via the CPU ARCH Protocol [1]. So for example if you want to write protect the page tables, add guard

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Pedro Falcato
Andrew, Marvin, Thanks for the quick responses. I'll give you a rundown of asan/kasan: You create a big (16TB in PML5-less x86) virtual mapping for ASAN, each byte in the shadow map represents 8 bytes of address space, and you poison/unpoison memory as you go and allocate chunks of the address

[edk2-devel] [PATCH v1 01/28] MdeModulePkg: Add a new GUID

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add a new Variable Store Guid. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dec | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git

[edk2-devel] Question on Iscsi Boot

2022-03-25 Thread brodiepetersen1
Hello I am currently using the tianocore uefi running on xcpng and am trying to connect an iscsi drive from truenas scale but cant seem to get it to mount. I know truenas is exporting the block device as windows can see it but i can not get it to mount in the uefi. if any one has an idea id

[edk2-devel] [PATCH v1 02/28] SecurityPkg: Add new GUIDs

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new GUIDs Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/SecurityPkg.dec | 43 +++- 1 file changed, 42 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 04/28] MdeModulePkg: Add reference to new Ppi Guid

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference to gEfiPeiVariableStoreDiscoveredPpiGuid Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdePkg/Include/Ppi/ReadOnlyVariable2.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)

[edk2-devel] [PATCH v1 13/28] SecurityPkg: Fix GetVariableKey API

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Fix GetVariableKey API to match changes in header files. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/VariableKeyLibNull/VariableKeyLibNull.c | 6 +++--- 1 file changed, 3

[edk2-devel] [PATCH v1 12/28] SecurityPkg: Add new variable types and functions

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new variable encryption/decryption function prototypes. Add new variable digest structure. Add new Protected variable function prototypes. Update RPMC APIs to Add an index because there are more than one counter. Cc: Jian J Wang Cc:

[edk2-devel] [PATCH v1 06/28] MdeModulePkg: Add new include files

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add EncryptionVariableLib.h for confidentiality and ProtectedVariableLib.h for integrity Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Library/EncryptionVariableLib.h | 165

[edk2-devel] [PATCH v1 15/28] SecurityPkg: Add VariableKey library function

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide VariableKey function that retrieves the key for integrity and/or confidentiality of variables Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v1 19/28] SecurityPkg: Add references to new *.inf files

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add references to the different *ProtectedVariableLib.inf. Also add references to VariableKeyLibNull.inf, EncryptionVariableLibNull.inf, ProtectedVariableNull.inf. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah

[edk2-devel] [PATCH v1 16/28] SecurityPkg: Add EncryptionVariable lib with AES

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add encryption/decryption of protected variable functionality. Add functions to get/set cipher data of a protected variable. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v1 14/28] SecurityPkg: Add null encryption variable libs

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide null ecryption variable libraries. These will be used by default. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/EncryptionVariableLibNull/EncryptionVariableLibNull.inf |

[edk2-devel] [PATCH v1 08/28] MdeModulePkg: Add new Variable functionality

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Provide new APIs for retrieving variable information. Add new function stubs for retrieving Protected variable information. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v1 20/28] ArmVirtPkg: Add reference to ProtectedVariableNull

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Need reference to ProtectVariableNullLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Nishant C Mistry Signed-off-by: Judah Vang --- ArmVirtPkg/ArmVirtQemu.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[edk2-devel] [PATCH v1 18/28] MdeModulePkg: Reference Null ProtectedVariableLib

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Make reference to new Null ProtectVariableLib by default. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/MdeModulePkg.dsc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH v1 24/28] OvmfPkg: Add ProtectedVariableLib reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Jiewen Yao Cc: Min Xu Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Tom Lendacky Cc: Nishant C Mistry Signed-off-by: Judah Vang ---

[edk2-devel] [PATCH v1 22/28] EmulatorPkg: Add ProtectedVariable reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Andrew Fish Cc: Ray Ni Cc: Nishant C Mistry Signed-off-by: Judah Vang --- EmulatorPkg/EmulatorPkg.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 27/28] OvmfPkg: Add ProtectedVariable reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Sebastien Boeuf Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/CloudHv/CloudHvX64.dsc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [PATCH v1 25/28] OvmfPkg: Add ProtectedVariableLib reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Rebecca Cran Cc: Peter Grehan Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Bhyve/BhyveX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff

[edk2-devel] [PATCH v1 28/28] CryptoPkg: Enable cypto HMAC KDF library

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 RPMC features requires HMAC-SHA256 support during SMM phase. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Cc: Nishant C Mistry Signed-off-by: Judah Vang --- CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +- 1

[edk2-devel] [PATCH v1 23/28] OvmfPkg: Add ProtectedVariable reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/OvmfPkgIa32.dsc| 3 ++-

[edk2-devel] [PATCH v1 11/28] SecurityPkg: Update RPMC APIs with index

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Update RPMC APIs with index parameter. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff

[edk2-devel] [PATCH v1 26/28] OvmfPkg: Add ProtectedVariableLib reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Gerd Hoffmann Cc: Nishant C Mistry Signed-off-by: Judah Vang --- OvmfPkg/Microvm/MicrovmX64.dsc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v1 21/28] UefiPayloadPkg: Add ProtectedVariable reference

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add reference for ProtectedVariableLib. Cc: Jian J Wang Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Cc: Sean Rhodes Cc: Nishant C Mistry Signed-off-by: Judah Vang --- UefiPayloadPkg/UefiPayloadPkg.dsc | 4 +++- 1 file

[edk2-devel] [PATCH v1 05/28] MdeModulePkg: Add new ProtectedVariable GUIDs

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new ProtectVariable GUIDs. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Include/Guid/ProtectedVariable.h | 22 1 file changed, 22 insertions(+) diff --git

[edk2-devel] [PATCH v1 10/28] SecurityPkg: Add new KeyService types and defines

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add new KeyService types and defines. Cc: Jian J Wang Cc: Jiewen Yao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- SecurityPkg/Include/Ppi/KeyServicePpi.h | 57 1 file changed, 57 insertions(+) diff --git

[edk2-devel] [PATCH v1 07/28] MdeModulePkg: Add Null ProtectedVariable Library

2022-03-25 Thread Judah Vang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594 Add Null ProtectedVariable Library. Cc: Jian J Wang Cc: Liming Gao Cc: Nishant C Mistry Signed-off-by: Judah Vang --- MdeModulePkg/Library/ProtectedVariableLibNull/ProtectedVariableLibNull.inf | 34 ++

Re: [edk2-devel] [PATCH 0/6] [RFC] Rework UefiCpuPkg

2022-03-25 Thread Abner Chang
Hi Mike, In the v2, I moved two of OpenSBI header files to under MdePkg/Include/IndustryStadard (patch 5/8). However, it looks to me not quite proper to have those files there. Seems to keeping those files under UefiCpuPkg makes more sense. What do you think? Abner

[edk2-devel] [PATCH V2 1/8] [RFC] UefiCpuPkg: Classify IA32/X64 modules in DSC file

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 This is the first step of reworking on UefiCpuPkg in order to accommodating all processor architectures in UEfiCpuPkg. Classify UefiCpuPkg modules to IA32 and X64 sections in DSC file. Move the module to Common section if more than one archs can

[edk2-devel] [PATCH V2 2/8] [RFC] UefiCpuPkg/Include: Add header files of RISC-V processor architecture

2022-03-25 Thread Abner Chang
(This is migrated from edk2-platforms:Silicon/RISC-V) https://bugzilla.tianocore.org/show_bug.cgi?id=3860 RISC-V processor architecture definitions. Signed-off-by: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrew Fish Cc: Leif Lindholm Cc:

[edk2-devel] [PATCH V2 3/8] [RFC] UefiCpuPkg/BaseUefiCpuLib: Add RISC-V RISCV64 instace

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 Add BaseUefiCpuLib instance for RISC-V RISCV64 arch. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sunil V L Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Chao Li

[edk2-devel] [PATCH V2 0/8] Rework UefiCpuPkg

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 This is the project having rework on UefiCpuPkg in order to support a variety of processor architectures. Some modules under UefiCpuPkg are required to be abstract for the different archs. In V2: - I moved two RISC-V OpenSBI header files to

[edk2-devel] [PATCH V2 5/8] [RFC] MdePkg/Include: Add RISC-V OpenSBI header files

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 RiscVOpensbiTypes.h: The header file for building RISC-V OpenSBI library. RiscVOpenSBI.h: The header file of using OpenSBI library. Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer M: Liming Gao [lgao4] R: Zhiguang Liu

[edk2-devel] [PATCH V2 4/8] [RFC] UefiCpuPkg/RiscVOpensbLib: Add opensbi submodule

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 (This is migrated from edk2-platforms:Silicon/RISC-V) Add RISC-V opensbi as the submoudle under UefiCpuPkg/Library/RISC-V Signed-off-by: Abner Chang Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Daniel Schaefer Cc: Sunil V L Cc: Andrew

[edk2-devel] [PATCH V2 7/8] [RFC] UefiCpuPkg/Library: Add RiscVOpensbiLib

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 (This is migrated from edk2-platforms:Silicon/RISC-V) EDK2 RISC-V OpenSBI library which pull in external source files under UefiCpuPkg/Library/RISC-V/RiscVOpensbiLib/opensbi to the build process. Signed-off-by: Abner Chang Co-authored-by:

[edk2-devel] [PATCH V2 6/8] [RFC] BaseTools/Conf: Relocate RiscVOpensbiTypes.h

2022-03-25 Thread Abner Chang
Relocation of RiscVOpensbiTypes.h, which is under: MdePkg/Include/IndustryStandard/ Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Cc: Sunil V L Cc: Leif Lindholm Cc: Michael D Kinney Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen --- BaseTools/Conf/tools_def.template | 2 +- 1

[edk2-devel] [PATCH V2 8/8] [RFC] UefiCpuPkg: Update YAML file for RISC-V arch

2022-03-25 Thread Abner Chang
https://bugzilla.tianocore.org/show_bug.cgi?id=3860 Signed-off-by: Abner Chang Co-authored-by: Daniel Schaefer Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Sunil V L Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Chao Li --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 60

Re: [edk2-devel] [PATCH v2 0/2] MdeModulePkg: fix checks for NVM command set

2022-03-25 Thread Mara Sophie Grosch via groups.io
Hi, thanks for merging, though I already had a pull request for it and you now used the bounce email address for the commit author ^^' It's ok, just wanted to make sure you know that groups.io pitfall for the next :) Best regards and many thanks for your time Mara Sophie Grosch

Re: [edk2-devel] [PATCH v2 0/2] MdeModulePkg: fix checks for NVM command set

2022-03-25 Thread Wu, Hao A
Oh Sorry, will double check to avoid such mistake. Best Regards, Hao Wu From: littlefox via groups.io Sent: Friday, March 25, 2022 4:45 PM To: Wu; Wu, Hao A ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH v2 0/2] MdeModulePkg: fix checks for NVM command set Hi, thanks for merging,

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Marvin Häuser
Hey Pedro, ASan is somewhat listed for „LLVM Optimizations“. A quick and dirty reference for UEFI UBSan can be found here: https://github.com/acidanthera/OpenCorePkg/tree/master/Library/OcGuardLib I don’t think you need to strictly adhere to the UEFI spec for debug tooling. I cannot check the

[edk2-devel] [PATCH v1 1/1] CryptoPkg: Redefinition bug in CrtLibSupport.h.

2022-03-25 Thread Li, Zhihao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3885 Parallel hash patch redefines uint_64 type in CrtLibSupport.h which has been defined in openssl/include/openssl/e_os2.h. CryptMd5.c including e_os2.h cause redefinition bug. Cc: Jiewen Yao jiewen@intel.com Cc: Jian J Wang

[edk2-devel] [PATCH 1/1] CryptoPkg: update openssl submodule to 1.1.1n

2022-03-25 Thread Gerd Hoffmann
Pick up bugfixes from latest openssl release. Includes CVE-2022-0778 fix (I don't think edk2 is affected though due to EC being disabled). Signed-off-by: Gerd Hoffmann --- CryptoPkg/Library/OpensslLib/openssl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git