[AMD Official Use Only - General]
Mike how about we take this way,
* Add a section in EDK II C Coding standard spec for the module naming rule
(you listed above). The naming rule covers the modules under edk2 and
edk2-platforms.
* Add a EDKII Wiki page for "The Principles of EDK2
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Tuesday, September 27, 2022 3:08 PM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem
> ; Gerd Hoffmann ; James
> Bottomley ; Yao, Jiewen
> Subject: [PATCH V2 1/1] OvmfPkg/PeilessStartupLib: move
From: Min M Xu
PeilessStartupLib is running in SEC phase. In this phase global variable
is not allowed to be modified. This patch moves mPageTablePool to stack
and pass it as input parameter between functions.
Cc: Erdem Aktas
Cc: Gerd Hoffmann
Cc: James Bottomley
Cc: Jiewen Yao
Hi Zack,
1.
> + Status = UnicodeStrToAsciiStrS (Profile->Password, (CHAR8
> + *)AsciiPassword, ((StrLen (Profile->Password) + 1) * sizeof (CHAR8)));
I think we should remove '* sizeof (CHAR8)' because the third parameter is the
length of string but not size of the memory:
Status =
From: Zhihao Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4083
In CPU relaxed mode, it doesn't reset the value of
mSmmMpSyncData->AllApArrivedWithException when BSP exit smm mode.
So this patch will reset this variable.
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Zhihao Li
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
C code changes for building EDK2 LoongArch platform.
For definitions of PE/COFF and LOONGARCH relocation types, see the
"Machine Types" and "Basic Relocation Types" sections of this URL for
LOONGARCH values:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
BaseTools define template files changes for building EDK2 LoongArch
platform.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Chao Li
Co-authored-by: Dongyan Qian
Co-authored-by: Baoqi Zhang
Reviewed-by: Liming Gao
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Python code changes for building EDK2 LoongArch platform.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Reviewed-by: Liming Gao
---
BaseTools/Source/Python/Common/DataType.py| 21
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 ProcessorBin.h and add LoongArch to Makefiles.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Reviewed-by: Liming Gao
---
BaseTools/Source/C/GNUmakefile
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
EDK CI for LoongArch64 architecture
Enable LoongArch64 architecture for LoongArch64 EDK2 CI testing.
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 architecture on LoongArch64 EDK2 CI.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
.azurepipelines/Ubuntu-GCC5.yml | 3 ++-
1 file changed, 2 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 architecture on LoongArch64 EDK2 CI testing.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
.pytool/CISettings.py | 5 -
1 file changed, 4 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 sections in MdePkg.dec and LOONGARCH64 ProcessorBind.h
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Co-authored-by: Dongyan Qian
Reviewed-by: Michael D
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch processor related definitions.
For the Http boot and PXE boot types seeing this URL section "Processor
Architecture Type" for the LOONGARCH values:
https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xhtml
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch LOONGARCH64 BaseLib functions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Reviewed-by: Michael D Kinney
---
MdePkg/Include/Library/BaseLib.h |
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Implement LoongArch cache maintenance functions in
BaseCacheMaintenanceLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
.../BaseCacheMaintenanceLib.inf
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
LoongArch MMIO library instance, use the IoLibNoIo.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
.../Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 10
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch image relocation.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Reviewed-by: Michael D Kinney
---
MdePkg/Library/BasePeCoffLib/BasePeCoff.c | 3 +-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Implement LoongArch CPU related functions in BaseCpuLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
MdePkg/Library/BaseCpuLib/BaseCpuLib.inf | 7 ++-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Support LoongArch cache related functions.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
---
.../BaseSynchronizationLib.inf| 6 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 architecture for BaseSafeIntLib library.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf | 9 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 architecture to the Logo.
Cc: Zhichao Gao
Cc: Ray Ni
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
Reviewed-by: Zhichao Gao
---
MdeModulePkg/Logo/Logo.inf | 3 ++-
1 file changed, 2 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
HTTP/PXE boot LOONGARCH64 related definitions for EDK2 CI.
For the LOONGARCH values, please seeing following URL section
"Processor Architecture Types":
https://www.iana.org/assignments/dhcpv6-parameters/dhcpv6-parameters.xhtml
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture to SecurityPkg for EDK2 CI testing.
Cc: Jiewen Yao
Cc: Jian J Wang
Signed-off-by: Chao Li
Reviewed-by: Jiewen Yao
---
SecurityPkg/SecurityPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture to ShellPkg for EDK2 CI testing.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
Reviewed-by: Zhichao Gao
---
ShellPkg/ShellPkg.dsc | 3 ++-
1 file changed, 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture to UnitTestFramworkPkg for LOONGARCH64 EDK2
CI.
Cc: Michael D Kinney
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
UnitTestFrameworkPkg/UnitTestFrameworkPkg.dsc | 3 ++-
1 file changed, 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture to MdePkg/DxeServiceLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
MdePkg/Library/DxeServicesLib/DxeServicesLib.inf | 4 ++--
1 file
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
LoongArch doesn't have SMM by now.
Cc: Jian J Wang
Cc: Liming Gao
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
MdeModulePkg/MdeModulePkg.dsc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Implement LoongArch DxeIPL instance.
Cc: Liming Gao
Cc: Guomin Jiang
Signed-off-by: Chao Li
Co-authored-by: Baoqi Zhang
Reviewed-by: Liming Gao
---
MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 6 +-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch64 architecture in to NetworkPkg.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
NetworkPkg/Network.dsc.inc | 3 ++-
1 file changed, 2 insertions(+), 1
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add Loongson and LOONGARCH to "words" section in cspell.base.yaml file
to avoid spelling check error.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LoongArch in INF for building CapsuleRuntimeDxe LoongArch64 image.
Cc: Liming Gao
Cc: Guomin Jiang
Sigend-off-by: Chao Li
Reviewed-by: Michael D Kinney
---
.../Universal/CapsuleRuntimeDxe/CapsuleRuntimeDxe.inf| 9 +
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
UEFI Spec V2.10 already supports LoongArch and all changes of this
commit passwed Azure CI testing, so let's enable it in EDK2. This commit
contains 35 patches, with patch 0 is the cover and the rest being the
LoongArch base code.
Changes
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
DebugSupport.h is all defined by UEFI Spec, most of the code
doesn't fit EDKII coding style, add it to IgnoreFiles field to
make CI ECC check pass.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Chao Li
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture for EDK2 CI testing.
Cc: Ray Ni
Signed-off-by: Chao Li
Reviewed-by: Liming Gao
---
FatPkg/FatPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/FatPkg/FatPkg.dsc
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture for EDK2 CI testing.
Cc: Liming Gao
Cc: Michael D Kinney
Cc: Guomin Jiang
Cc: Wei6 Xu
Signed-off-by: Chao Li
Reviewed-by: Liming Gao
---
FmpDevicePkg/FmpDevicePkg.dsc | 3 ++-
1 file changed, 2
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture for EDK2 CI testing.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Chao Li
Reviewed-by: Jiaxin Wu
---
NetworkPkg/NetworkPkg.dsc | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH architecture for EDK2 CI testing.
Cc: Maciej Rabeda
Cc: Jiaxin Wu
Cc: Siyuan Fu
Signed-off-by: Chao Li
Reviewed-by: Jiaxin Wu
---
NetworkPkg/HttpBootDxe/HttpBootDhcp4.h | 3 +++
1 file changed, 3 insertions(+)
diff
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
Add LOONGARCH64 architecture for EDK2 CI testing.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Xiaoyu Lu
Cc: Guomin Jiang
Signed-off-by: Chao Li
Reviewed-by: Jiewen Yao
---
CryptoPkg/CryptoPkg.dsc | 3 ++-
Hi Mike,
I have converted the inline assembly code to ASM code, please review this patch
again, thanks!
Thanks,
Chao
On 9月 27 2022, at 7:13 晚上, Chao Li wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
>
> Support LoongArch cache related functions.
> Cc: Michael D
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4053
If the new Arch register is defined in BaseLib.h when running
the CI tests, it will give an ECC check error. Add the
LoongArch register defined in the IgnoreFiles field to make
the CI ECC check pass.
Cc: Michael D Kinney
Cc: Liming Gao
Hi Pierre,
Apologies for delay in feedback.
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Pierre Gondois
The ArmMonitorLib provides an abstract interface to issue
an HyperVisor Call (HVC) or System Monitor Call (SMC) depending
on the default conduit.
The PcdMonitorConduitHvc PCD
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add a Null instance of ArmHvcLib in case of library dependencies.
Signed-off-by: Pierre Gondois
---
ArmPkg/ArmPkg.dsc | 1 +
ArmPkg/Library/ArmHvcNullLib/ArmHvcNullLib.c | 29
On 9/19/2022 12:21 PM, PierreGondois wrote:
+[Defines]
+ INF_VERSION= 0x0001001B
Should this be 0x0001001D, since 1.29 is the latest revision of the INF
specification?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The True Random Number Generator (TRNG) library defines an
interface to access the entropy source on a platform. On
platforms that do not have access to
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The NIST Special Publications 800-90A, 800-90B and 800-90C
provide recommendations for random number generation. The
NIST 800-90C, Recommendation for
On 9/19/2022 12:21 PM, PierreGondois wrote:
+/** Monitor call.
+
+ An HyperVisor Call (HVC) or System Monitor Call (SMC) will be issued
+ depending on the default conduit. PcdMonitorConduitHvc determines the type
+ of the call: if true, do an HVC.
+
+ @param [in, out] ArgsArguments for
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Sami Mujawar
Bugzilla: 3668 (https://bugzilla.tianocore.org/show_bug.cgi?id=3668)
The Arm True Random Number Generator Firmware, Interface 1.0,
Platform Design Document
(https://developer.arm.com/documentation/den0098/latest/)
defines
On 2022-09-19 12:21, pierre.gond...@arm.com wrote:
From: Sami Mujawar
Define a PCD 'PcdMonitorConduitHvc' to select the conduit to use for
monitor calls. PcdMonitorConduitHvc is defined as FALSE by default,
meaning the SMC conduit is enabled as default.
Adding PcdMonitorConduitHvc allows
Can someone please help with this.
This issue is observed on all our machines.
Command to compile:
python -u boot_images/boot_tools/buildex.py -t Makena -v WP -r DEBUG
Logs:
testSurrogatePairUnicodeCharInUtf8FileWithBom (CheckUnicodeSourceFiles.Tests)
... ok
testUtf16InUniFile
Did you recently upgrade to Python 3.9. Are you using the latest version of
BaseTools?
I see an issue that was fixed in BaseTools in August 2020 that may be related.
https://edk2.groups.io/g/devel/message/64002
https://github.com/tianocore/edk2/commit/5d8648345cd9ad729837118c731063c59edea192
Hello all,
I just noticed the v2.10 of the UEFI spec. It adds the following define
#define EFI_2_100_SYSTEM_TABLE_REVISION ((2<<16) | (100)
However, the revision field is documented as
"""
The revision of the EFI Specification to which this table conforms.
The upper 16 bits of this field
On 9/19/2022 12:21 PM, PierreGondois wrote:
;/**
@@ -19,11 +19,11 @@
;**/
;UINT64
;EFIAPI
-;ArmReadIdIsar0 (
+;ArmGetFeatRng (
; VOID
; );
;
-ArmReadIdIsar0
+ArmGetFeatRng
mrs x0, id_aa64isar0_el1 // Read ID_AA64ISAR0 Register
ret
Should we be masking the register
This commit is a code optimization to allow bigger seperate stack size in
ArchSetupExceptionStack. In previous code logic, CPU_STACK_ALIGNMENT bytes
will be wasted if StackTop is already CPU_STACK_ALIGNMENT aligned.
Signed-off-by: Dun Tan
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
---
Merged https://github.com/tianocore/edk2/pull/3420
> -Original Message-
> From: Yao, Jiewen
> Sent: Tuesday, September 27, 2022 4:22 PM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Aktas, Erdem ; Gerd Hoffmann
> ; James Bottomley
> Subject: RE: [PATCH V2 1/1] OvmfPkg/PeilessStartupLib:
When read a variable in PEI, it will find it first in the HOB, then find in
variable store. When find in variable store, it will check the variable state,
but find in HOB, it doesn't check the state, so if the variable was changed, it
will find the obsolete variable in the HOB.
Signed-off-by:
Mike,
Has following content already been documented somewhere?
It looks good to me. Very good abstraction of existing cases. Maybe there are
some lib/modules that don’t follow this rule. But the number should be very
small.
But I didn’t check how ARM constructs the pkg. So it’s very welcomed to
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
09/27/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220816T024022Z
The [Arch] refers to the Processor Architecture.
The [Module] refer to the EDK2 module.
The [X86] refers to both IA32 and X64.
The principles to create the X86 folder in the module:
1. When X86-vendor's implementation is introduced to the existing module:
1. The folder reconstruction:
A-1.
[AMD Official Use Only - General]
From: devel@edk2.groups.io On Behalf Of Ni, Ray via
groups.io
Sent: Wednesday, September 28, 2022 11:34 AM
To: devel@edk2.groups.io; Chang, Abner
Cc: Kinney, Michael D ; Sunil V L
; lichao ; Kirkendall, Garrett
; Grimes, Paul ; He, Jiangang
; Attar,
[AMD Official Use Only - General]
We had the conversation this morning regarding the proper place for the
file/module naming rule.
The proposal is the naming rule content would be documented in "edk2 C coding
standard spec", and the "The principles of EDK2 module reconstruction for
archs"
Abner,
I think we Mike’s first email regarding the package structure is a good
guideline regarding how to place the modules.
What we are discussing is how to organize the module internal contents for
different archs. Do you agree?
I want to clarify this so we have a clear boundary between the
Reviewed-by: Ray Ni
> -Original Message-
> From: Tan, Dun
> Sent: Wednesday, September 28, 2022 9:52 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Kumar,
> Rahul R
> Subject: [PATCH] UefiCpuPkg/CpuExceptionHandlerLib: Code optimization to
> allow bigger stack
>
> This
[AMD Official Use Only - General]
From: Ni, Ray
Sent: Wednesday, September 28, 2022 1:43 PM
To: devel@edk2.groups.io; Chang, Abner
Cc: Kinney, Michael D ; Sunil V L
; lichao ; Kirkendall, Garrett
; Grimes, Paul ; He, Jiangang
; Attar, AbdulLateef (Abdul Lateef)
; Leif Lindholm ; Andrew
65 matches
Mail list logo
