Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/DxeImageVerificationLib: Check result of GetEfiGlobalVariable2

2023-03-21 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/4155 > -Original Message- > From: Yao, Jiewen > Sent: Tuesday, March 21, 2023 10:29 AM > To: kra...@redhat.com; devel@edk2.groups.io > Cc: Pawel Polawski ; Wang, Jian J > ; Oliver Steffen ; Xu, Min M > ; Marvin Häuser ; > jma...@redhat.com >

Re: [edk2-devel] [PATCH 1/9] OvmfPkg: Replace static struct initialization with ZeroMem call

2023-03-21 Thread Gerd Hoffmann
On Tue, Mar 21, 2023 at 07:30:32PM -0600, Rebecca Cran wrote: > Replace the static struct initialization with a call to ZeroMem to avoid > generating a call to memset in certain build configurations. > > Signed-off-by: Rebecca Cran Reviewed-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-21 Thread Tinh Nguyen via groups.io
Thanks Oliver will be improved in the next version - Tinh On 3/21/2023 11:57 PM, Oliver Smith-Denny wrote: One nit below, otherwise: Reviewed-by: Oliver Smith-Denny Thanks! On 3/20/2023 8:16 PM, Tinh Nguyen via groups.io wrote: The BIOS Firmware Version in the SMBIOS Type 0 can be

Re: [edk2-devel] [PATCH v3 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-21 Thread Tinh Nguyen via groups.io
Hi Leif, Do you have any concerns? Could I add you to the review list? Thanks, Tinh On 3/21/2023 10:16 AM, Tinh Nguyen wrote: The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from the fixed PcdFirmwareVersionString or platform specific OemMiscLib. In fact, the support from

Re: [edk2-devel] [PATCH 2/3] MdeModulePkg/Logo: Add a PCD to control the position of the Logo

2023-03-21 Thread Ni, Ray
Can the below solution work for you? 1. create a new Logo driver in UefiPayloadPkg 2. That logo driver defines a PCD such as MSPreferedLogoLocation, depending on its value, the driver returns the proper X/Y location. I am trying to avoid changing the simple/sample one for a specific need.

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

2023-03-21 Thread Sheng Lean Tan
> Another reminder, thanks. > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101484): https://edk2.groups.io/g/devel/message/101484 Mute This Topic: https://groups.io/mt/97727098/21656 Group Owner: devel+ow...@edk2.groups.io

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

2023-03-21 Thread Sheng Lean Tan
Another reminder, thanks. > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#101483): https://edk2.groups.io/g/devel/message/101483 Mute This Topic: https://groups.io/mt/97727097/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH] UefiCpuPkg: Solve that stack top address is not mapped in pagetable

2023-03-21 Thread Yuanhao Xie
For the case CPU logic index is 0, RSP points to the very top of all AP stacks. That address is not mapped in page table. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Ted Kuo --- UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm | 1 + 1 file changed, 1

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

2023-03-21 Thread Ni, Ray
> + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > + { > +X2Apic = TRUE; Gerd, I agree with your needs that want X2 APIC even the actual processor number in BIOS phase <= 255. Question: Is it possible

[edk2-devel] Set PCIE MMIO Range as XD attribute

2023-03-21 Thread Yoshinoya
Hi, On x86 platform, there is cpu feature called as execute disable bit(aka: XD). At BIOS stage, usually allocates an address range as PCIE MMIO range. Is there a simple mechanism to set this PCIE MMIO rage's attribute as XD? Thanks -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all

Re: [edk2-devel] [PATCH V5 4/8] OvmfPkg/PlatformPei: Update ReserveEmuVariableNvStore

2023-03-21 Thread joeyli via groups.io
Hi Min M Xu, I have filed a EDK2 bug relates to this patch: Bug 4379 - Got NvVarStore FV headers were invalid when using OVMF with AMD SEV https://bugzilla.tianocore.org/show_bug.cgi?id=4379 I got a "NvVarStore FV headers were invalid." assert when using OVMF with AMD SEV. After reverted

Re: [edk2-devel] [PATCH v1 0/4] Bug fixes for DynamicTablesPkg and ArmVirtPkg/kvmtool

2023-03-21 Thread PierreGondois
Hello Sami, Just for the record, for PATCH 3/4, a similar solution was used in: commit 0b58c4894dad ("MdeModulePkg/PciHostBridgeDxe: Add CpuArch protocol dependency") Reviewed-by: Pierre Gondois Regards, Pierre On 3/20/23 15:05, Sami Mujawar wrote: This patch series has the following fixes

Re: [edk2-devel] [PATCH v4 10/12] UefiCpuPkg: Fix conditionally uninitialized variables

2023-03-21 Thread Michael Kubacki
I spoke to Erich offline and he mentioned that a previous coding practice he used specified unsigned integer literals when intended so he applied that here. Thanks, Michael On 3/10/2023 5:59 PM, Michael Kubacki wrote: Erich introduced this particular change, he may be able to provide more

Re: [edk2-devel] [PATCH 1/1] UefiCpuPkg/MpInitLib: fix apic mode for cpu hotplug

2023-03-21 Thread Gerd Hoffmann
On Tue, Mar 21, 2023 at 07:28:44AM +, Ni, Ray wrote: > > + } else if ((PcdGet32 (PcdCpuBootLogicalProcessorNumber) > 0) && > > + (PcdGet32 (PcdCpuMaxLogicalProcessorNumber) > 255)) > > + { > > +X2Apic = TRUE; > > Gerd, > I agree with your needs that want X2 APIC even the

Re: [edk2-devel] [PATCH v3 1/8] ManageabilityPkg: Add Readme file

2023-03-21 Thread Leif Lindholm
Minor nit: On Tue, Mar 21, 2023 at 11:21:06 +0800, Chang, Abner via groups.io wrote: > From: Abner Chang > > Add Readme file of edk2 platform ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Nickle Wang > Cc: Igor Kulchytskyy >

Re: [edk2-devel] [PATCH v3 6/8] ManageabilityPkg: Implement Ipmi Protocol/Ppi

2023-03-21 Thread Leif Lindholm
On Tue, Mar 21, 2023 at 11:21:45 +0800, Chang, Abner via groups.io wrote: > From: Abner Chang > > Add Ipmi Protocol/Ppi/SMM implementations. > The underlying implementation of transport > interface depends on the binded > ManageabilityTransportLib. > > Signed-off-by: Abner Chang > Cc: Liming

[edk2-devel] [PATCH] Platform/Qemu/Sbsa: Update TF-A binaries to enable Neoverse-N1

2023-03-21 Thread Marcin Juszkiewicz
From: Marcin Juszkiewicz Update the TF-A binaries to have Neoverse-N1 support. This support was merged into TF-A: https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/19863 This allows SBSA Reference Platform to use Arm v8.2 cpu without using "max" cpu. Signed-off-by: Marcin

Re: [edk2-devel] [PATCH v3 8/8] edk2-platforms: Maintainers.txt

2023-03-21 Thread Leif Lindholm
On Tue, Mar 21, 2023 at 11:21:47 +0800, abner.ch...@amd.com wrote: > From: Abner Chang > > Add maintainer and reviewer of ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Abdul Lateef Attar > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nickle

Re: [edk2-devel] [PATCH v3 3/8] ManageabilityPkg: Add NULL ManageabilityTransportLib

2023-03-21 Thread Leif Lindholm
On Tue, Mar 21, 2023 at 11:21:42 +0800, Chang, Abner via groups.io wrote: > From: Abner Chang > > The NULL instance of ManageabilityTransportLib > library. > > Signed-off-by: Abner Chang > Cc: Liming Gao > Cc: Isaac Oram > Cc: Nate DeSimone > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc:

Re: [edk2-devel] [PATCH v2 RESEND 4/4] Maintainers.txt: Adds AMD/BoardPkg and AMD/PlatformPkg maintainers

2023-03-21 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[AMD Official Use Only - General] Hi Leif, AMD/BoardPkg will implements modules specific to boards(one or more motherboards). It will not contain any module specific to Platform or Silicon, which are part of MinPlatformPkg. How about just Min prefix? AMD/MinBoardPkg (I am avoiding the

Re: [edk2-devel] [PATCH v3 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version

2023-03-21 Thread Oliver Smith-Denny
One nit below, otherwise: Reviewed-by: Oliver Smith-Denny Thanks! On 3/20/2023 8:16 PM, Tinh Nguyen via groups.io wrote: The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from the fixed PcdFirmwareVersionString or platform specific OemMiscLib. In fact, the support from OemMiscLib

Re: [edk2-devel] [PATCH] Platform/Qemu/Sbsa: Update TF-A binaries to enable Neoverse-N1

2023-03-21 Thread Ard Biesheuvel
On Tue, 21 Mar 2023 at 15:09, Marcin Juszkiewicz wrote: > > From: Marcin Juszkiewicz > > Update the TF-A binaries to have Neoverse-N1 support. > > This support was merged into TF-A: > > https://review.trustedfirmware.org/c/TF-A/trusted-firmware-a/+/19863 > > This allows SBSA Reference Platform

Re: [edk2-devel] [PATCH v3 8/8] edk2-platforms: Maintainers.txt

2023-03-21 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Leif Lindholm > Sent: Tuesday, March 21, 2023 7:50 PM > To: Chang, Abner > Cc: devel@edk2.groups.io; Attar, AbdulLateef (Abdul Lateef) > ; Michael D Kinney > ; Liming Gao ; > Isaac Oram ; Nickle Wang > Subject: Re: [PATCH

Re: [edk2-devel] [PATCH v3 3/8] ManageabilityPkg: Add NULL ManageabilityTransportLib

2023-03-21 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Leif Lindholm > Sent: Tuesday, March 21, 2023 8:07 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Liming Gao ; Isaac Oram > ; Nate DeSimone > ; Nickle Wang ; > Igor Kulchytskyy ; Attar, AbdulLateef (Abdul Lateef) > >

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

2023-03-21 Thread Isaac Oram
Reviewed-by: Isaac Oram In the future, please CC maintainers from https://github.com/iworam/edk2-platforms/blob/master/Maintainers.txt in the commit messages. -Original Message- From: Patrick Rudolph Sent: Monday, March 20, 2023 1:53 AM Cc: devel@edk2.groups.io;

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

2023-03-21 Thread Isaac Oram
Reviewed-by: Isaac Oram -Original Message- From: devel@edk2.groups.io On Behalf Of Patrick Rudolph Sent: Monday, March 20, 2023 1:53 AM Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; Kinney, Michael D ; Chaganty, Rangasai V ; Oram, Isaac W ; Desimone, Nathaniel L ; Gao, Liming

Re: [edk2-devel] [edk2-platforms][PATCH 2/2][RESEND] PlatformPayloadFeaturePkg.py: Add Linux support

2023-03-21 Thread Isaac Oram
Pushed as 8efa4f42b5..d7466862b7 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, March 21, 2023 12:33 PM To: Rudolph, Patrick Cc: devel@edk2.groups.io; quic_llind...@quicinc.com; Kinney, Michael D ; Chaganty, Rangasai V ; Desimone, Nathaniel L ;

Re: [edk2-devel] [edk2-platforms][PATCH 1/2][RESEND] PlatformPayloadFeaturePkg.dsc: Add missing packages

2023-03-21 Thread Isaac Oram
Pushed as 8efa4f42b5..d7466862b7 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, March 21, 2023 1:09 PM To: devel@edk2.groups.io; Rudolph, Patrick Cc: quic_llind...@quicinc.com; Kinney, Michael D ; Chaganty, Rangasai V ; Desimone, Nathaniel L ;

Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

2023-03-21 Thread Isaac Oram
Series Reviewed-by: Isaac Oram -Original Message- From: Mike Maslenkin Sent: Saturday, March 11, 2023 3:30 AM Cc: devel@edk2.groups.io; Mike Maslenkin ; Arunk ; Oram, Isaac W ; Desimone, Nathaniel L ; Gao, Liming Subject: [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

[edk2-devel] [PATCH 1/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-03-21 Thread Albecki, Mateusz
bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=4011 Currently AHCI driver will try to retry all failed packets regardless of the failure cause. This is a problem in password unlock flow where number of password retries is tracked by the device. If user passes a wrong password Ahci

[edk2-devel] [PATCH 0/1] MdeModulePkg/Ahci: Skip retry for non-transient errors

2023-03-21 Thread Albecki, Mateusz
Fix for the recovery logic which causes hdd unlock to fail if user supplies incorrect password. Every failed packet used to be recovered which is causing the incorrect password to be tried multiple times. This patch series fixes the logic to only retry commands that failed due to CRC error. BZ:

[edk2-devel] [PATCH 5/6] UefiCpuPkg/CpuDxe: Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-21 Thread Ni, Ray
CPUID enumeration of MAX_PA is unaffected by TME-MK activation and will continue to report the maximum physical address bits available for software to use, irrespective of the number of KeyID bits. So, we need to check if TME is enabled and adjust the PA size accordingly. Signed-off-by: Ray Ni

[edk2-devel] [PATCH 6/6] UefiCpuPkg/MtrrTest: Add test cases for TME-MK enable case

2023-03-21 Thread Ni, Ray
When TME-MK is enabled, the MtrrLib should substract the TME-MK reserved bits from the max PA returned from CPUID instruction. The new test case guarantees such behavior in MtrrLib. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Michael D Kinney Cc: Ahmad Anadani

[edk2-devel] [PATCH 3/6] UefiCpuPkg/MtrrLib: Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-21 Thread Ni, Ray
CPUID enumeration of MAX_PA is unaffected by TME-MK activation and will continue to report the maximum physical address bits available for software to use, irrespective of the number of KeyID bits. So, we need to check if TME is enabled and adjust the PA size accordingly. Signed-off-by: Ray Ni

[edk2-devel] [PATCH 2/6] UefiCpuPkg/MtrrTest: Only claim CPUID max leaf as 1

2023-03-21 Thread Ni, Ray
MtrrLib code queries the CPUID leaf 7h result if support. Update Test code temporary to claim the CPUID only supports max leaf as 1 so MtrrLib skips to query CPUID leaf 7h. Signed-off-by: Ray Ni Cc: Eric Dong Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Michael D Kinney Cc: Ahmad Anadani ---

[edk2-devel] [PATCH 0/6] Substract TME-MK KEY_ID_BITS from CPU max PA

2023-03-21 Thread Ni, Ray
Ray Ni (6): MdePkg: Add TME-MK related CPUID and MSR definitions UefiCpuPkg/MtrrTest: Only claim CPUID max leaf as 1 UefiCpuPkg/MtrrLib: Substract TME-MK KEY_ID_BITS from CPU max PA UefiCpuPkg/CpuDxe: Refactor to use CPUID definitions UefiCpuPkg/CpuDxe: Substract TME-MK KEY_ID_BITS

[edk2-devel] [PATCH 4/6] UefiCpuPkg/CpuDxe: Refactor to use CPUID definitions

2023-03-21 Thread Ni, Ray
The patch does not change any code behavior but only refactors by: * replaces the hardcode 0x8000 with CPUID_EXTENDED_FUNCTION * replaces the hardcode 0x8008 with CPUID_VIR_PHY_ADDRESS_SIZE * replace "UINT32 Eax" with "CPUID_VIR_PHY_ADDRESS_SIZE_EAX VirPhyAddressSize" Signed-off-by:

[edk2-devel] [PATCH 1/6] MdePkg: Add TME-MK related CPUID and MSR definitions

2023-03-21 Thread Ni, Ray
TME (Total Memory Encryption) is the capability to encrypt the entirety of physical memory of a system. TME-MK (Total Memory Encryption-Multi-Key) builds on TME and adds support for multiple encryption keys. The patch adds some necessary CPUID/MSR definitions for TME-MK. Signed-off-by: Ray Ni

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Ni, Ray
Just notice there will be an IS_POW2 macro. Gerd, can you help to clean MtrrLib to use the macro? Today it’s using an internal local function as below: BOOLEAN MtrrLibIsPowerOfTwo ( IN UINT64 Operand ) { ASSERT (Operand != 0); return (BOOLEAN)((Operand & (Operand - 1)) == 0); }

[edk2-devel] [PATCH v3] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-21 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4377 Fix below warnings generated by NASM X64 build: /X64/FspHelper.iii:26: warning: signed dword value exceeds bounds /X64/FspHelper.iii:35: warning: signed dword value exceeds bounds /X64/FspApiEntryT.iii:320: warning: dword data exceeds

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-21 Thread Chiu, Chasel
Hello, Thanks for all the feedbacks and suggestions from everybody! I have sent V3 patch accordingly, please help to review again: https://edk2.groups.io/g/devel/message/101526 Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, March 21, 2023 4:05 PM

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, March 21, 2023 #cal-reminder

2023-03-21 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, March 21, 2023 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH edk2-platforms 0/2] IpmiFeaturePkg: small fixes

2023-03-21 Thread Isaac Oram
Series pushed as d7466862b7..4811c37ae3 -Original Message- From: devel@edk2.groups.io On Behalf Of Isaac Oram Sent: Tuesday, March 21, 2023 1:44 PM To: Mike Maslenkin Cc: devel@edk2.groups.io; Arunk ; Desimone, Nathaniel L ; Gao, Liming Subject: Re: [edk2-devel] [PATCH edk2-platforms

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Michael D Kinney
Hi Gerd, A few comments included below. Thanks, Mike > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, March 2, 2023 10:51 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Wang, Jian J ; Yao, > Jiewen ; Marvin Häuser ; James > Bottomley ; Michael

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: Rename IS_ALIGNED macros to avoid name collisions

2023-03-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann > Sent: Thursday, March 2, 2023 10:51 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Wang, Jian J ; Yao, > Jiewen ; Marvin Häuser ; James > Bottomley ;

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Michael D Kinney
I am suggesting adding “minimum” because aligning to a boundary could be to the next one or any multiples past that. For example, offset is 1, and alignment request is 4. The obvious result is 3, but 7, 11, 15, 19, … also satisfy the current description. Mike From: Marvin Häuser Sent:

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Michael D Kinney
Ok. No objections to current description. Mike From: Marvin Häuser Sent: Tuesday, March 21, 2023 3:44 PM To: Kinney, Michael D Cc: Gerd Hoffmann ; devel@edk2.groups.io; Ard Biesheuvel ; Wang, Jian J ; Yao, Jiewen ; James Bottomley ; Michael Roth ; Wu, Hao A ; Oliver Steffen ; Xu, Min M ;

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.

2023-03-21 Thread Nate DeSimone
Reviewing this code in more detail... I think clearing the upper 32-bits is a bug. These functions are supposed to return pointers, and since this is X64 code those pointers could be anywhere in address space. The fact that the FSP is in XIP NEM, which on current Intel platforms just happens to

Re: [edk2-devel] [PATCH 4/5] MdeModulePkg: Consume new alignment-related macros

2023-03-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney >michael.d.kin...@intel.com> > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, March 2, 2023 10:51 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Wang, Jian J ; Yao, > Jiewen ; Marvin Häuser ; James > Bottomley ; Michael

Re: [edk2-devel] [PATCH 2/5] OvmfPkg: Rename IS_ALIGNED macros to avoid name collisions

2023-03-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd Hoffmann > Sent: Thursday, March 2, 2023 10:51 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Wang, Jian J ; Yao, > Jiewen ; Marvin Häuser ; James > Bottomley ;

Re: [edk2-devel] [PATCH 5/5] OvmfPkg: Consume new alignment-related macros

2023-03-21 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Gerd Hoffmann > Sent: Thursday, March 2, 2023 10:51 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Gerd Hoffmann > ; Wang, Jian J ; Yao, > Jiewen ; Marvin Häuser ; James > Bottomley ; Michael Roth > ; Wu, Hao A ; Kinney,

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Marvin Häuser
Hi Mike, > On 21. Mar 2023, at 22:37, Kinney, Michael D > wrote: > > Hi Gerd, > > A few comments included below. > > Thanks, > > Mike > >> -Original Message- >> From: Gerd Hoffmann mailto:kra...@redhat.com>> >> Sent: Thursday, March 2, 2023 10:51 PM >> To: devel@edk2.groups.io

Re: [edk2-devel] [PATCH 3/5] MdePkg/Base.h: Introduce various alignment-related macros

2023-03-21 Thread Marvin Häuser
On 21. Mar 2023, at 23:29, Kinney, Michael D wrote: I am suggesting adding “minimum” because aligning to a boundary could be to the next one or any multiples past that.   For example, offset is 1, and alignment request is 4.  The obvious result is 3, but 7, 11, 15, 19, …  also satisfy

Re: [edk2-devel] [PATCH 2/5] OvmfPkg: Rename IS_ALIGNED macros to avoid name collisions

2023-03-21 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, March 22, 2023 5:41 AM > To: devel@edk2.groups.io; kra...@redhat.com > Cc: Ard Biesheuvel ; Wang, Jian J > ; Yao, Jiewen ; Marvin > Häuser ; James Bottomley ; > Michael Roth ; Wu, Hao A ; > Oliver

Re: [edk2-devel] [PATCH 5/5] OvmfPkg: Consume new alignment-related macros

2023-03-21 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Kinney, Michael D > Sent: Wednesday, March 22, 2023 5:41 AM > To: Gerd Hoffmann ; devel@edk2.groups.io > Cc: Ard Biesheuvel ; Wang, Jian J > ; Yao, Jiewen ; Marvin > Häuser ; James Bottomley ; > Michael Roth ; Wu, Hao A ; > Oliver

[edk2-devel] [PATCH 4/9] BaseTools: Remove VS2008, 2010, 2012 and 2013 toolchain definitions

2023-03-21 Thread Rebecca Cran
With recent changes, Visual Studio versions older than VS2015 are unable to build EDK2 code. To avoid confusion, remove VS2008, 2010, 2012 and 2013 toolchain definitions from Conf/tools_def.template, leaving only versions that can be used to successfully build firmware. Signed-off-by: Rebecca

[edk2-devel] [PATCH 6/9] MdePkg: Remove VS2008-VS2013 remnants

2023-03-21 Thread Rebecca Cran
Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from MdePkg. Signed-off-by: Rebecca Cran --- MdePkg/Include/Ia32/ProcessorBind.h | 8 ++-- MdePkg/Include/X64/ProcessorBind.h | 8 ++-- 2 files changed, 4 insertions(+), 12 deletions(-) diff

[edk2-devel] [PATCH 7/9] edksetup.bat: Remove VS2008-VS2013 remnants

2023-03-21 Thread Rebecca Cran
Since Visual Studio versions older than VS2015 are no longer supported, remove mention of them from edksetup.bat. Signed-off-by: Rebecca Cran --- edksetup.bat | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/edksetup.bat b/edksetup.bat index 7ad137bb3e9b..2fdf130e00e2

[edk2-devel] [PATCH 0/9] BaseTools,CryptoPkg,MdePkg,OvmfPkg: Delete CLANG35,CLANG38 and update CLANGDWARF, delete VS 2008-2013, EBC

2023-03-21 Thread Rebecca Cran
Update the toolchain definitions: - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64 and IA32. - Remove VS2008, VS2010, VS2012 and VS2013. - Remove EBC compiler definitions. Full removal of EBC support

[edk2-devel] [PATCH 1/9] OvmfPkg: Replace static struct initialization with ZeroMem call

2023-03-21 Thread Rebecca Cran
Replace the static struct initialization with a call to ZeroMem to avoid generating a call to memset in certain build configurations. Signed-off-by: Rebecca Cran --- OvmfPkg/Library/PlatformInitLib/MemDetect.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 2/9] CryptoPkg: Add CLANGDWARF and remove CLANG35 and CLANG38 compiler flags

2023-03-21 Thread Rebecca Cran
With the removal of CLANG35 and CLANG38 and the update of the CLANGDWARF toolchain definition in Conf/tools_def.txt update the compiler flags in BaseCryptLib and OpensslLib. Signed-off-by: Rebecca Cran --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 3 +--

[edk2-devel] [PATCH 3/9] BaseTools: Update CLANGDWARF toolchain and remove CLANG35 and CLANG38

2023-03-21 Thread Rebecca Cran
Update the CLANGDWARF toolchain definition with the settings from CLANG38, and delete the CLANG35 and CLANG38 toolchains. The existing CLANGDWARF toolchain definition used ld.lld, but this causes the following linker errors when building OvmfPkgX64.dsc: ld.lld: error: relocation R_X86_64_64

[edk2-devel] [PATCH 8/9] BaseTools: Remove unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS defs

2023-03-21 Thread Rebecca Cran
Remove the unused IPHONE_TOOLS and SOURCERY_CYGWIN_TOOLS definitions from Conf/tools_def.template. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 4 1 file changed, 4 deletions(-) diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template

[edk2-devel] [PATCH 9/9] BaseTools: Remove EBC (EFI Byte Code) compiler definitions

2023-03-21 Thread Rebecca Cran
The edk2-stable202302 release was the last to support building EFI Byte Code drivers. Remove the definitions for Intel's EBC compiler from Conf/tools_def.template. Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 98 1 file changed, 98 deletions(-) diff

[edk2-devel] [PATCH 5/9] BaseTools: Remove VS2008-VS2013 remnants

2023-03-21 Thread Rebecca Cran
Remove remnants of Visual Studio 2008-2013 support from Signed-off-by: Rebecca Cran --- BaseTools/Conf/tools_def.template | 12 BaseTools/Scripts/SetVisualStudio.bat | 22 +-- BaseTools/Scripts/ShowEnvironment.bat | 44 -- BaseTools/get_vsvars.bat | 13

Re: [edk2-devel] [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix error handling

2023-03-21 Thread Ni, Ray
Just found "if (!Buffer)" doesn't follow EDK2 coding style. I changed to "if (Buffer == NULL) {" in final merge PR. > -Original Message- > From: Gerd Hoffmann > Sent: Friday, March 10, 2023 8:49 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Oliver Steffen ; > Gerd Hoffmann ; Kumar, Rahul

[edk2-devel] [Patch 0/2] Add and use FirmwareVolumeShadowPpi

2023-03-21 Thread Michael D Kinney
Add FirmwareVolumeShadow PPI to shadow an FV to memory. and use it to shadow FVs to memory. Cc: Jiewen Yao Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Patel Umang Umang Patel (2): MdeModulePkg/Include/Ppi: Add FirmwareVolumeShadowPpi SecurityPkg/FvReportPei: Use FirmwareVolumeShadowPpi

[edk2-devel] [Patch 1/2] MdeModulePkg/Include/Ppi: Add FirmwareVolumeShadowPpi

2023-03-21 Thread Michael D Kinney
From: Umang Patel Add FirmwareVolumeShadow PPI to shadow an FV to memory. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Patel Umang --- .../Include/Ppi/FirmwareVolumeShadowPpi.h | 61 +++ MdeModulePkg/MdeModulePkg.dec | 3 + 2 files changed, 64

[edk2-devel] [Patch 2/2] SecurityPkg/FvReportPei: Use FirmwareVolumeShadowPpi

2023-03-21 Thread Michael D Kinney
From: Umang Patel If FirmwareVolumeShadow PPI is available, then use it to shadow FVs to memory. Otherwise fallback to CopyMem(). Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Patel Umang --- SecurityPkg/FvReportPei/FvReportPei.c | 37 -

[edk2-devel] [PATCH v4 0/9] Introduce ManageabilityPkg

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang edk2 ManageabilityPkg is introduced to provide edk2 drivers and libraries for industry platform management standards, such as PLDM (Platform Level Data Model), MCTP (Management Component Transfer Protocol), IPMI (Intelligent Platform Management Interface) and others. The

[edk2-devel] [PATCH v4 7/9] ManageabilityPkg: Implement Ipmi Protocol/Ppi

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang Add Ipmi Protocol/Ppi/SMM implementations. The underlying implementation of transport interface depends on the binded ManageabilityTransportLib. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor

[edk2-devel] [PATCH v4 9/9] edk2-platforms: Maintainers.txt

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang Add maintainer and reviewer of ManageabilityPkg. Signed-off-by: Abner Chang Cc: Abdul Lateef Attar Cc: Leif Lindholm Cc: Michael D Kinney Cc: Liming Gao Cc: Isaac Oram Cc: Nickle Wang Reviewed-by: Michael D Kinney Reviewed-by: Nickle Wang --- Maintainers.txt | 7

[edk2-devel] [PATCH v4 8/9] ManageabilityPkg: Add IpmiProtocol to Manageability Package

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Nickle Wang ---

[edk2-devel] [PATCH v4 2/9] ManageabilityPkg: Initial package

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang Initial commit of ManageabilityPkg Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy Reviewed-by: Abdul Lateef Attar Reviewed-by: Nickle Wang ---

[edk2-devel] [PATCH v4 3/9] ManageabilityPkg: Add ManageabilityTransportLib header file

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang Add ManageabilityTransportLib header file to package. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../ManageabilityPkg/ManageabilityPkg.dec | 5 +

[edk2-devel] [PATCH v4 4/9] ManageabilityPkg: Add NULL ManageabilityTransportLib

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang The NULL instance of ManageabilityTransportLib library. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar --- .../ManageabilityPkg/ManageabilityPkg.dsc | 4 +-

[edk2-devel] [PATCH v4 5/9] ManageabilityPkg: Add ManageabilityTransportHelperLib

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang The helper functions library facilitates reducing duplicated code in the manageability transport library instances. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Abdul Lateef Attar ---

[edk2-devel] [PATCH v4 6/9] ManageabilityPkg/ManageabilityTransportKcsLib

2023-03-21 Thread Chang, Abner via groups.io
From: Abner Chang This is the KCS manageability transport library instance follows the design guidance described in Readme file under ManageabilityPkg. Signed-off-by: Abner Chang Cc: Liming Gao Cc: Isaac Oram Cc: Nate DeSimone Cc: Abdul Lateef Attar Cc: Nickle Wang Cc: Igor Kulchytskyy