Tom,
I would assume this won't break any AMD system because the CPUID bit doesn't
declare this feature.
Gerd,
This is needed by Intel platform for TME-MK. Can you help to analyze if it has
any impact to OVMF? I assume no.
Thanks,
Ray
From: devel@edk2.groups.io On Behalf Of Ni, Ray
Sent:
Reviewed-by: Ray Ni
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Thursday, March 30, 2023 6:37 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray
> Subject: [edk2-devel] [Patch 1/1]
> PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe: PcdRtcDefaultYear
>
> + mov eax, 1
>
> + cpuid
>
> + mov ecx, MSR_IA32_BIOS_SIGN_ID
>
> + rdmsr ; Get current microcode signature
>
> + xor eax, eax
>
> + test edx, edx
>
> + jnz Exit2
>
1. SDM uses following assembly to read current microcode signature.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access platform registers.
These enhancements providing a set of APIs
Python/Python3.6.8: migration of edk2module from chipsec repo
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4161
This patch merges the enhancements done by chipsec
tool to edk2 module into edk2-libc repo.
The chipsec enhancements can be used for various
other Python based tools to access
Reviewed-by: Ted Kuo
-Original Message-
From: devel@edk2.groups.io On Behalf Of Chiu, Chasel
Sent: Wednesday, March 29, 2023 11:44 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star ; Ni, Ray
Subject: [edk2-devel] [PATCH v2] IntelFsp2Pkg:
On Wed, 29 Mar 2023 at 12:22, Rebecca Cran wrote:
>
> On 3/28/23 12:12 PM, Ard Biesheuvel wrote:
> > What kind of errors are you seeing after adding -Wl,--no-pie,--no-relax ?
>
> I realized I didn't really try it after I thought you had said it was
> causing corruption.
>
> After adding those
Hi Ard,
I am occassionally seeing the following error when trying to run the
Kvmtool guest firmware.
add-symbol-file
w:\workspace\Build\ArmVirtKvmTool-AARCH64\DEBUG_GCC5\AARCH64\PcAtChipsetPkg\PcatRealTimeClockRuntimeDxe\PcatRealTimeClockRuntimeDxe\DEBUG\PcRtc.dll
0xBBF8
On Wed, 29 Mar 2023 at 01:32, Rebecca Cran wrote:
>
> For a while I've been irritated at having to open a web browser to check
> the status of CI tasks for my GitHub PRs.
>
> Fortunately I mentioned on the UEFI Talkbox channel about wanting to
> write a tool that uses the GitHub API to query the
Hi Rohit,
Thank you for this patch, and apologies for the delay in reply.
I have a few minor suggestions marked inline as [SAMI].
Other than that, I would like to see a corresponding patch to add MPAM
support to Acpiview.
With that addressed,
Reviewed-by: Sami Mujawar
regards,
Sami
Reviewed-by: Gua Guo
-Original Message-
From: Wu, LinusX
Sent: Wednesday, March 29, 2023 6:52 PM
To: devel@edk2.groups.io
Cc: Wu, LinusX ; Dong, Guo ; Ni, Ray
; Rhodes, Sean ; Lu, James
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Support more input parameter
From: Linus Wu
REF:
On Wed, 29 Mar 2023 at 12:49, Sami Mujawar wrote:
>
> Hi Ard,
>
> I am occassionally seeing the following error when trying to run the
> Kvmtool guest firmware.
>
> add-symbol-file
>
From: Linus Wu
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4386
Add additional input parameter support
--SpecRevision: user input spec version
--Revision: user input revision
--ProducerId: producer company name
1. UniversalPayloadBuild.py 2. Downgrade spec revision from 0.9 to 0.7
Cc:
On Tue, 28 Mar 2023 at 19:31, Rebecca Cran wrote:
>
> Update the toolchain definitions:
>
> - Delete the CLANG35 and CLANG38 toolchains, and replace CLANG38 with
> CLANGDWARF, updating it to support ARM and AARCH64 in addition to X64
> and IA32.
>
> - Remove GCC48 and GCC49.
>
> - Remove
Hi EDK2 Devel team,
Here got the compiling error, provided the call stack for tracing. Thank you!
1. EDK2 (https://github.com/tianocore/edk2.git):
a107ad0f623669c72997443dc0431eeb732f81a0
2. Edk2Platforms (https://github.com/tianocore/edk2-platforms.git):
On 3/29/23 1:39 AM, Ard Biesheuvel wrote:
Could we perhaps do
GCC49 -> GCC
GCC5 -> GCCLTO
?
As with CLANG35/38, the GCCx names have become rather obsolete, so I'd
prefer to have a set of more generic names, and a sliding window of
supported versions that can be documented in
Reviewed-by: Gua Guo
-Original Message-
From: Wu, LinusX
Sent: Wednesday, March 29, 2023 6:21 PM
To: devel@edk2.groups.io
Cc: Wu, LinusX ; Dong, Guo ; Ni, Ray
; Rhodes, Sean ; Lu, James
; Guo, Gua
Subject: [PATCH] UefiPayloadPkg: Support more input parameter
From: Linus Wu
REF:
On Wed, 29 Mar 2023 at 13:28, Leif Lindholm wrote:
>
> On Wed, Mar 29, 2023 at 09:39:56 +0200, Ard Biesheuvel wrote:
> > > > - Remove GCC48 and GCC49.
> > >
> > > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another
> > > GCC tool chain with LTO enable option.
> > >
> > > They
On 3/28/23 12:12 PM, Ard Biesheuvel wrote:
What kind of errors are you seeing after adding -Wl,--no-pie,--no-relax ?
I realized I didn't really try it after I thought you had said it was
causing corruption.
After adding those flags I was able to verify (via "strace
--trace=process -f")
On Wed, Mar 29, 2023 at 09:39:56 +0200, Ard Biesheuvel wrote:
> > > - Remove GCC48 and GCC49.
> >
> > GCC49 is one GCC tool chain without LTO enable option. GCC5 is another GCC
> > tool chain with LTO enable option.
> >
> > They have the different usage. I suggest to keep GCC49 and GCC5 both, and
On Wed, Mar 29, 2023 at 08:50:24AM +, Xie, Yuanhao wrote:
> Hi Gerd,
>
> Could you please provide me more information, like where does it hang, ad
> what build and boot options you use
qemu-system-x86_64 -display none -accel kvm -smp 2 -M q35 \
-bios
Reviewed-by: Igor Kulchytskyy
-Original Message-
From: Nickle Wang
Sent: Wednesday, March 29, 2023 1:33 AM
To: devel@edk2.groups.io
Cc: Abner Chang ; Igor Kulchytskyy ; Nick
Ramirez
Subject: [EXTERNAL] [PATCH v4] RedfishPkg/RedfishPlatformCredentialIpmiLib:
IPMI implementation
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4391
FSP should support the scenario that CPU microcode already loaded
before calling LoadMicrocodeDefault(), in this case it should return
directly without spending more time.
Also the LoadMicrocodeDefault() should only attempt to load one
[AMD Official Use Only - General]
Reviewed-by: Abner Chang
> -Original Message-
> From: Nickle Wang
> Sent: Wednesday, March 29, 2023 2:14 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
> ; Nick Ramirez
> Subject: [PATCH v2 2/3] RedfishPkg: Redfish discover driver
Bug fix:
- function stack fault
- properly handle "SubnetAddrInfoIPv6" when there is no IPv6 support
- copy-n-paste error in RedfishGetHostInterfaceProtocolData()
- fix typo
Enhancement:
- Redfish discover driver now can configure host IP address based on
the information from SMBIOS type 42
Bug fix:
- function stack fault
- config handler driver requires the dependency of Redfish Credential
Protocol
- incorrect caller id installation when failed to perform init()
- fix typo
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner
Fix implicit conversion issue in JsonLib.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Library/JsonLib/JsonLib.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Fix variety issues in RedfishPkg, including coverity issue,
typo, coding bugs and improve driver binding code flow in
RedfishDiscoverDxe driver.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Nickle Wang (3):
RedfishPkg/JsonLib: address coverity issue
Hi Gerd,
Could you please provide me more information, like where does it hang, ad what
build and boot options you use
I used this image
https://www.kraxel.org/repos/images/fedora-30-efi-systemd-i686.qcow2.xz, and
extracted the kernel from second partition (VFAT) of
On Wed, 29 Mar 2023 at 03:20, gaoliming via groups.io
wrote:
>
> Rebecca:
>
>
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Rebecca Cran
> > 发送时间: 2023年3月29日 1:31
> > 收件人: devel@edk2.groups.io; Oliver Smith-Denny ;
> > Guomin Jiang ; Xiaoyu Lu ;
> > Jian J Wang ; Jiewen Yao ;
> > Ard
On Mon, 27 Mar 2023 at 17:02, Gerd Hoffmann wrote:
>
> Increase the chance that CI finds bugs in MP changes.
>
> Signed-off-by: Gerd Hoffmann
Merged as #4205
Thanks
> ---
> OvmfPkg/PlatformCI/PlatformBuildLib.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
Hi Nhi,
Thanks - this was a lot easier to review.
For the series:
Reviewed-by: Leif Lindholm
Pushed as 4811c37ae347..d8d167f11ac5.
/
Leif
On Wed, Mar 29, 2023 at 11:32:37 +0700, Nhi Pham wrote:
> This patchset adds support for Ampere Altra Max processor and updates for some
> bugfixes.
>
Thanks a lot Leif for the quick review and merging.
Best regards,
Nhi
On 3/29/2023 11:07 PM, Leif Lindholm wrote:
Hi Nhi,
Thanks - this was a lot easier to review.
For the series:
Reviewed-by: Leif Lindholm
Pushed as 4811c37ae347..d8d167f11ac5.
/
Leif
On Wed, Mar 29, 2023 at 11:32:37
Reviewed-by: Michael D Kinney
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Rebecca Cran
> Sent: Wednesday, March 29, 2023 10:35 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming ;
> Feng, Bob C
> Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt:
Update Maintainers.txt for BaseTools: move Bob Feng from being a
maintainer to reviewer, and add myself (Rebecca Cran) as a new
maintainer.
Signed-off-by: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
---
Maintainers.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Kadapathri, Ajay
> Sent: Monday, March 27, 2023 1:05 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Kinney, Michael D
> ; Jayaprakash, N
>
> Subject: [edk2-libc Patch 1/1] Python/Python3.6.8: migration of edk2module
>
On Mon, Mar 27, 2023 at 13:00:55 +0200, Ard Biesheuvel wrote:
> Implement version 2 of the memory attributes table, which now contains a
> flag informing the OS whether or not code regions may be mapped with CFI
> mitigations such as IBT or BTI enabled.
>
> This series covers roughly the
On Mon, 27 Mar 2023 at 15:30, Leif Lindholm wrote:
>
> On Mon, Mar 27, 2023 at 13:01:10 +0200, Ard Biesheuvel wrote:
> > UEFI v2.10 introduces a new flag to the memory attributes table to
> > inform the OS whether or not runtime services code regions were emitted
> > by the compiler with guard
On Wed, Mar 29, 2023 at 18:47:50 +0200, Ard Biesheuvel wrote:
> On Mon, 27 Mar 2023 at 15:30, Leif Lindholm wrote:
> >
> > On Mon, Mar 27, 2023 at 13:01:10 +0200, Ard Biesheuvel wrote:
> > > UEFI v2.10 introduces a new flag to the memory attributes table to
> > > inform the OS whether or not
Hi Ajay,
Looks like inf file is missing some dependencies (Libs and nasm file). Due to
this the code doesn't build after applying the patch.
So, please fix this and resubmit the updated patch request.
"C:\Program Files (x86)\Microsoft Visual
Hi Ray,
One comment below.
Mike
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Liu, Zhiguang
>
> Subject: [PATCH 1/6] MdePkg: Add TME-MK related CPUID and MSR definitions
>
> TME
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Anadani, Ahmad
>
> Subject: [PATCH 4/6] UefiCpuPkg/CpuDxe: Refactor to use
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Anadani, Ahmad
>
> Subject: [PATCH 3/6] UefiCpuPkg/MtrrLib: Substract
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Anadani, Ahmad
>
> Subject: [PATCH 2/6] UefiCpuPkg/MtrrTest: Only claim
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Anadani, Ahmad
>
> Subject: [PATCH 5/6] UefiCpuPkg/CpuDxe: Substract
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Ni, Ray
> Sent: Tuesday, March 21, 2023 4:57 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Kumar, Rahul R
> ; Gerd Hoffmann ; Kinney,
> Michael D ; Anadani, Ahmad
>
> Subject: [PATCH 6/6] UefiCpuPkg/MtrrTest: Add test
If you agree with the change from Uint32 -> Uint32[2], then with that change
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Kinney, Michael D
> Sent: Wednesday, March 29, 2023 3:15 PM
> To: Ni, Ray ; devel@edk2.groups.io
> Cc: Gao, Liming ; Liu, Zhiguang
> ; Kinney,
Add bounds checks of PcdRtcDefaultYear to guarantee that the year
is always between PcdMinimalValidYear and PcdMaximalValidYear.
This is required to make the following commit a backwards compatible
change and guarantee and invalid year is never set.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Rebecca Cran
Sent: Thursday, March 30, 2023 1:35 AM
To: devel@edk2.groups.io
Cc: Rebecca Cran ; Gao, Liming ;
Feng, Bob C
Subject: [edk2-devel] [PATCH 1/1] Maintainers.txt: BaseTools Bob Feng ->
49 matches
Mail list logo
