[edk2-devel] [PATCH 3/3] UefiCpuPkg/CpuMpPei: Use CpuPageTableLib to set memory attribute.

Currently, there are code to set memory attribute in CpuMpPei module. However, the code doesn't handle the case of 5 level paging. Use the CpuPageTableLib to set memory attribute for two purpose: 1. Add 5 level paging support 2. Clean up code Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc:

[edk2-devel] [PATCH 1/3] UefiCpuPkg/CpuPageTableLib: Init local variable before using it.

The local variable OneOfPagingEntry is used before initialized, this may cause reserved bit in page table entry is set especially in PAE paging mode. The bug is random because it depends on the value in stack. Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Laszlo Ersek Signed-off-by:

[edk2-devel] [PATCH 2/3] UefiCpuPkg/CpuPageTableLib/TestCase: Refine test case for PAE paging.

Refine test case: 1. Check PAE paging reserved bits is zero. 2. Set stack as random value. Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Cc: Laszlo Ersek Signed-off-by: Zhiguang Liu --- .../UnitTest/CpuPageTableLibUnitTestHost.inf | 3 +++ .../CpuPageTableLib/UnitTest/RandomTest.c | 23

[edk2-devel] [PATCH] NetworkPkg: Triger timely scan only if not connect to AP

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 When UEFI Wi-Fi is in BSS connected state, the platform is considered as a static and Wi-Fi roaming support is not needed. Wifi connection manager should not initiate Scan requests in this state affect BSS client connectivity and must be

Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

Hello Ray, Is the patch acceptable as it is ? Or is there something to modify before I send a new version ? Regards, Pierre On 11/22/23 08:54, Pierre Gondois wrote: Hello Ray, On 11/22/23 01:03, Ni, Ray wrote: These ACPI methods were there since long ago. Why do you only add the related

[edk2-devel] [PATCH v1 1/1] .git-blame-ignore-revs: Ignore recent uncrustify commits

From: Michael Kubacki Includes two recent Uncrustify formatting commits to prevent them from showing in git blame. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc: Rebecca Cran Signed-off-by: Michael Kubacki --- .git-blame-ignore-revs | 4 1 file changed, 4 insertions(+)

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 27, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 27, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, November 27, 2023 #cal-notice

*Tools, CI, Code base construction meeting series* *When:* Monday, November 27, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Remove myself as a tools maintainer

Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, November 27, 2023 11:45 AM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Chris Fernald > ; Joey Vagedes ; Leif > Lindholm ; Gao, Liming > ; Kinney, Michael D > ; Sean Brogan >

Re: [edk2-devel] BaseTools KeyError When Building EmulatorPkg

On Monday, November 27th, 2023 at 2:43 PM, Sean via groups.io wrote: > In the meantime there are two easy workarounds (pick one).  > > 1. Create your venv named something like "venv" instead of ".venv".  It just > must come later in the default directory sort than "Basetools". > > or > > 2.

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

On Tue, Nov 21, 2023 at 2:17 AM Chiu, Chasel wrote: > > > Hi Laszlo, > > I think you have to clone all the required repos. > edk2 repository > git clone https://github.com/tianocore/edk2.git > > edk2-platforms repository > git clone https://github.com/tianocore/edk2-platforms.git > > edk2-non-osi

[edk2-devel] [PATCH v1 1/1] ArmPkg/ArmMmuLib: Use function pointer type

From: Michael Kubacki mReplaceLiveEntryFunc is a function pointer but assigned as a VOID* pointer: mReplaceLiveEntryFunc = *(VOID **)GET_GUID_HOB_DATA (Hob); This leads to the Visual Studio warning: nonstandard extension, function/data pointer conversion in expression This change

[edk2-devel] [PATCH v1 0/2] ArmPkg/CpuDxe: Use upper and lower attributes

From: Michael Kubacki This series contains two changes: 1. To fix a compiler warning with the current state of code. 2. To update the code to pass the integer width needed for a comparison to set EFI_MEMORY_XP in the GCD attribute returned for a given page attribute. Cc: Leif Lindholm

[edk2-devel] [PATCH v1 2/2] ArmPkg/Drivers/CpuDxe: Use lower and upper attributes

From: Michael Kubacki GetNextEntryAttribute() is currently applying a 64-bit mask (TT_ATTRIBUTES_MASK) to a 32-bit descriptor value (EntryType). The original descriptor was 64 bits containing the upper and lower attributes which are included in TT_ATTRIBUTES_MASK. The PrevEntryAttribute

[edk2-devel] [PATCH v1 1/2] ArmPkg/Drivers/CpuDxe: Explicitly cast table entry

From: Michael Kubacki GetNextEntryAttribute() assigns a 64-bit integer to 32-bit integers. This change explicitly casts the assigned value as UINT32 to prevent the following Visual Studio compiler warning: '=': conversion from 'UINT64' to 'UINT32', possible loss of data Cc: Leif Lindholm

[edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix Build

Updates Microcode and Silicon FV sizes so they can accomodate the newest content. Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../BoardMtOlympus/OpenBoardPkg.fdf | 25 +++ 1 file changed, 14 insertions(+), 11 deletions(-) diff --git

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2-platforms/Features to PACKAGES_PATH

Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Nate DeSimone --- Platform/Intel/build.cfg | 5 +++-- Platform/Intel/build_bios.py | 11 +++ 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/Platform/Intel/build.cfg b/Platform/Intel/build.cfg index

[edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools for Python 3.x

PatchFv tools now run on Python 3.x Cc: Chasel Chiu Cc: Liming Gao Cc: Eric Dong Signed-off-by: Nate DeSimone --- .../MinPlatformPkg/Tools/PatchFv/PatchBfv.py | 35 .../Tools/PatchFv/PatchBinFv.py | 69 .../Tools/PatchFv/RebaseBinFv.py |

[edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build

Adds SmmLockBox driver which is needed to build with the newest version of MinPlatformPkg Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- .../Intel/PurleyOpenBoardPkg/BoardMtOlympus/OpenBoardPkg.dsc | 3 ++- .../Intel/PurleyOpenBoardPkg/BoardTiogaPass/OpenBoardPkg.dsc | 3 ++- 2 files

Re: [edk2-devel] BaseTools KeyError When Building EmulatorPkg

@Ryder We have identified the issue. A new issue will be created here Issues · tianocore/edk2-basetools (github.com) to track it. In the meantime there are two easy workarounds (pick one). 1. Create your venv named something like "venv"

Re: [edk2-devel] [PATCH v3 0/2] OvmfPkg: Enable measured direct boot on AMD SEV-SNP

On 3/20/23 05:06, Gerd Hoffmann wrote: On Thu, Mar 02, 2023 at 09:15:30AM +, Dov Murik wrote: AMD SEV and SEV-ES support measured direct boot with kernel/initrd/cmdline hashes injected by QEMU and verified by OVMF during boot. To enable the same approach for AMD SEV-SNP, we declare the

Re: [edk2-devel] [PATCH 0/2] SEV-SNP guest support fixes

On 11/17/23 15:43, Tom Lendacky wrote: On 11/7/23 03:55, Gerd Hoffmann wrote: On Mon, Nov 06, 2023 at 04:45:29PM -0600, Tom Lendacky wrote: This patch series provides fixes around AP startup and sorting: - The CPUID_EXTENDED_TOPOLOGY CPUID leaf takes a sub-leaf as input. The    current

Re: [edk2-devel] BaseTools KeyError When Building EmulatorPkg

We are looking at it. It seems to be a problem in the edk2-basetools but at this point it still isn't obvious. You can do a 'pip uninstall edk2-basetools' and then I would expect your build would work. I also see that you didn't build edk2 basetools (step 6) documented here:

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

Hi Laszlo, Thanks for your support too! By the way, do we still plan to remove LgacyBiosMpTable.h? We can follow up with relevant OpenBoardPkg fixes if that's the goal. Thanks, Chasel > -Original Message- > From: Laszlo Ersek > Sent: Thursday, November 23, 2023 2:05 AM > To:

Re: [edk2-devel] [PATCH v5 00/16] Add ImagePropertiesRecordLib and Fix MAT Bugs​

On Mon, 27 Nov 2023 at 19:18, Taylor Beebe wrote: > > v5: > This version is purely an update of commit messages and orientation. > No code changes were made. > - Split patch 9 into 3 separate patches so each fix is in its own > commit. > - Updated the commit comment of patch 11 to add context.

[edk2-devel] [PATCH v5 06/16] MdeModulePkg: Update MemoryAttributesTable.c to Reduce Global Variable Use

This patch updates MemoryAttributesTable.c to reduce reliance on global variables and allow some logic to move to a library. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 102

[edk2-devel] [PATCH v5 09/16] MdeModulePkg: Fix MAT Descriptor Count Calculation

|4K PAGE|DATA|CODE|DATA|CODE|DATA|4K PAGE| Say the above memory region is currently one memory map descriptor. The above image memory layout example contains two code sections oriented in a way that maximizes the number of descriptors which would be required to describe each section. NOTE: It's

[edk2-devel] [PATCH v5 08/16] MdeModulePkg: Add ImagePropertiesRecordLib Host-Based Unit Test

Create a host-based unit test for the ImagePropertiesRecordLib SplitTable() logic. This test has 4 cases which tests different potential image and memory map layouts. 3/4 of these tests fail with the logic in its current state to provide proof of the bugs in the current MAT logic. Cc: Jian J Wang

[edk2-devel] [PATCH v5 11/16] MdeModulePkg: Fix MAT SplitTable() Logic

SplitTable() does not properly handle the case where there is an odd number of code regions within a loaded image. When there are an odd number of code regions, at least one image region descriptor is overwritten with uninitialized memory which has caused crashes in the right conditions. This

[edk2-devel] [PATCH v5 15/16] MdeModulePkg: Add Logic to Create/Delete Image Properties Records

Add logic to create and delete image properties records. Where applicable, redirect existing code to use the new library. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao ---

[edk2-devel] [PATCH v5 12/16] MdeModulePkg: Add NULL checks and Return Status to ImagePropertiesRecordLib

Update function headers to clarify the contract of each function and improve readability. Add NULL checks to all functions that take a pointer as an argument. Add return status to functions that may need to return early due to invalid input. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi

[edk2-devel] [PATCH v5 13/16] UefiCpuPkg: Use Attribute From SMM MemoryAttributesTable if Nonzero

PiSmmCore fetches the EFI memory map and calls SplitTable() to split each loaded image section into its own descriptor with EFI_MEMORY_XP marking data sections and EFI_MEMORY_RO marking code sections. The SMM MAT logic is almost identical to the DXE MAT logic but goes a step further and also

[edk2-devel] [PATCH v5 05/16] UefiPayloadPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Taylor Beebe Reviewed-by: Michael D Kinney Reviewed-by: Gua Guo --- UefiPayloadPkg/UefiPayloadPkg.dsc | 1 + 1 file changed, 1 insertion(+)

[edk2-devel] [PATCH v5 07/16] MdeModulePkg: Move Some DXE MAT Logic to ImagePropertiesRecordLib

Move some DXE MAT logic to ImagePropertiesRecordLib to consolidate code and enable unit testability. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao --- MdeModulePkg/Core/Dxe/Misc/MemoryAttributesTable.c | 774

[edk2-devel] [PATCH v5 10/16] MdeModulePkg: Fix MAT SplitRecord() Logic

SplitRecord() does not handle the case where a memory descriptor describes an image region plus extra pages before or after the image region. This patch fixes this case by carving off the unrelated regions into their own descriptors. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by:

[edk2-devel] [PATCH v5 00/16] Add ImagePropertiesRecordLib and Fix MAT Bugs​

v5: This version is purely an update of commit messages and orientation. No code changes were made. - Split patch 9 into 3 separate patches so each fix is in its own commit. - Updated the commit comment of patch 11 to add context. v4: - Expose additional functions in the Library API - Add NULL

[edk2-devel] [PATCH v5 01/16] MdeModulePkg: Add ImagePropertiesRecordLib

Create a library for manipulating image properties records. The library is currently blank and will be filled in a future patch to help with reviewer readability. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao ---

[edk2-devel] [PATCH v5 02/16] ArmVirtPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffmann Signed-off-by: Taylor Beebe Reviewed-by: Michael D Kinney --- ArmVirtPkg/ArmVirt.dsc.inc | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [PATCH v5 03/16] EmulatorPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Taylor Beebe Reviewed-by: Michael D Kinney --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc

[edk2-devel] [PATCH v5 04/16] OvmfPkg: Add ImagePropertiesRecordLib Instance

Add an instance of ImagePropertiesRecordLib which will be used by the DXE Core. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Taylor Beebe Reviewed-by: Michael D Kinney Acked-by: Jiewen Yao --- OvmfPkg/AmdSev/AmdSevX64.dsc| 1 +

[edk2-devel] [PATCH v5 14/16] MdeModulePkg: Transition SMM MAT Logic to Use ImagePropertiesRecordLib

Now that the bugs are fixed in the MAT logic, we can remove the duplicate logic from PiSmmCore/MemoryAttributesTable.c and use ImagePropertiesRecordLib instead. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin Wu Cc: Ray Ni Signed-off-by: Taylor Beebe Reviewed-by: Liming Gao ---

[edk2-devel] [PATCH v5 16/16] MdeModulePkg: Update DumpImageRecord() in ImagePropertiesRecordLib

Update DumpImageRecord() to be DumpImageRecords(), and improve the debug output. The function will output at DEBUG_INFO instead, and the function will be run in DXE and SMM MAT logic when the MAT is installed at EndOfDxe on DEBUG builds. Cc: Jian J Wang Cc: Liming Gao Cc: Dandan Bi Cc: Jiaxin

Re: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLibIntrinsic.inf

Hi Mike and Liming, Could you help to review this patch set? It's to remove string IO instruction in BaseIoLibIntrinsic and simplify BaseIoLibIntrinsic. Thanks, Dun -Original Message- From: Laszlo Ersek Sent: Monday, November 13, 2023 9:08 PM To: devel@edk2.groups.io; Ni, Ray ; Tan,

Re: [edk2-devel] [PATCH 1/1] StandaloneMmPkg/Core: Restart dispatcher once MmEntryPoint is registered

> // > MM_CORE_MMI_HANDLERS mMmCoreMmiHandlers[] = { > + { MmDriverDispatchHandler, , NULL, > TRUE }, Should we need define a new HandlerType name instead of using the gEfiEventDxeDispatchGuid? We just need a simple MM Dispatch Event, which is trigged by IPL to dispatch again

Re: [edk2-devel] [edk2-redfish-client][PATCH] RedfishClientPkg/ComputerSystemCollectionDxe: handle more scenarios

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:13 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH] >

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2-platforms/Features to PACKAGES_PATH

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Add edk2- >

[edk2-devel] [edk2-redfish-client][PATCH 1/1] RedfishClientPkg/RedfishFeatureCoreDxe: fix incorrect URI issue

-Fix incorrect URI issue. There is missing "/" while StartUpFeatureDriver() recursively calls itself. -Fix typo. -Update function name to follow the naming style. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nick Ramirez --- .../RedfishFeatureCoreDxe.h

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/1] RedfishClientPkg/RedfishFeatureCoreDxe: fix incorrect URI issue

[AMD Official Use Only - General] Looks good. Please go ahead to merge it. Reviewed-by: > -Original Message- > From: Nickle Wang > Sent: Tuesday, November 28, 2023 9:16 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject:

[edk2-devel] [PATCH v2] NetworkPkg: Triger regularly scan only if not connect to AP

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4605 When UEFI Wi-Fi is in BSS connected state, the platform is considered as a static and Wi-Fi roaming support is not needed. Wifi connection manager should not initiate Scan requests in this state affect BSS client connectivity and must be

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python Interpreter Name

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Replace Python > Interpreter Name > >

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg: Fix Build > > Adds SmmLockBox driver which

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver enhancement.

[AMD Official Use Only - General] > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver >

Re: [edk2-devel] [PATCH v1 1/1] .git-blame-ignore-revs: Ignore recent uncrustify commits

Reviewed-by: Michael D Kinney > -Original Message- > From: mikub...@linux.microsoft.com > Sent: Monday, November 27, 2023 4:17 PM > To: devel@edk2.groups.io > Cc: Andrew Fish ; Leif Lindholm > ; Kinney, Michael D > ; Rebecca Cran > Subject: [PATCH v1 1/1] .git-blame-ignore-revs: Ignore

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 28, 2023 #cal-reminder

*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Tuesday, November 28, 2023 6:30pm to 7:30pm (UTC-08:00) America/Los Angeles *Where:*

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/6] RedfishClientPkg/RedfishETagDxe: fix issue and enhancement.

[AMD Official Use Only - General] Hi Nickle, The code change generally looks fine. However, we can improve the debug code enablement in the source file. I had created a BZ ticket (Bug #4606 ) for this enhancement and assigned it to myself. For this change, Reviewed-by: Abner Chang >

Re: [edk2-devel] [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python Interpreter Name

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] WhitleyOpenBoardPkg: Replace Python > Interpreter Name > >

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/6] RedfishClientPkg/RedfishConfigLangMapDxe: fix issue and enhancement.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 2/6] >

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of PYTHON_HOME

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, November 17, 2023 10:36 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Remove usage of >

Re: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools for Python 3.x

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Gao, Liming > ; Dong, Eric > Subject: [edk2-platforms][PATCH v1] MinPlatformPkg: Update PatchFv Tools

Re: [edk2-devel] [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix Build

Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Monday, November 27, 2023 5:04 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel > Subject: [edk2-platforms][PATCH v1] PurleyOpenBoardPkg/BoardMtOlympus: Fix > Build > > Updates

Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: remove references

> -Original Message- > From: Pedro Falcato > Sent: Monday, November 27, 2023 3:14 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Laszlo Ersek ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > > Subject: Re: [edk2-devel] [edk2-platforms PATCH 1/2] WhitleyOpenBoardPkg: > remove

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/6] RedfishClientPkg/ConverterLib: fix empty attribute value issue

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 4/6]

[edk2-devel] [edk2-platforms][PATCH] MinPlatformPkg: should build Performance driver only when perf enabled

Should build FirmwarePerformancePei only when perf enabled. Avoiding unconditional compilation of performance PEI drivers can save 2KB(LZMA compressed) in PostMem FV, small but important. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Signed-off-by: Yi Li ---

Re: [edk2-devel] [edk2-redfish-client][PATCH 5/6] RedfishClientPkg/Features: fix NULL cached handler issue.

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 5/6]

Re: [edk2-devel] [edk2-redfish-client][PATCH 6/6] RedfishClientPkg/RedfishFeatureUtilityLib: add string NULL check

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 23, 2023 10:34 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 6/6] >

Re: [edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port

On Tue, Nov 28, 2023 at 8:27 AM Chang, Abner via groups.io wrote: > > From: Abner Chang > > BZ #4607 > Create a PCD for the default Redfish service port. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > RedfishPkg/RedfishPkg.dec

[edk2-devel] [PATCH] RedfishPkg/HostInterfaceBmcUsbNic: Set default Redfish service port

From: Abner Chang BZ #4607 Create a PCD for the default Redfish service port. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishPkg/RedfishPkg.dec | 8 ++-- .../PlatformHostInterfaceBmcUsbNicLib.inf

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver enhancement.

Hi Abner, Thanks for your review. Please find my comment below. > This may spend some time on network to get the whole resource from URI if the > resource size is big, but we just need the information of ETAG header. We can > think of using HEAD HTTP method. > However, this seems fine for now as

Re: [edk2-devel] [edk2-redfish-client][PATCH 3/6] RedfishClientPkg: feature driver enhancement.

[AMD Official Use Only - General] Thanks Nickle, I just created BZ #4608 to track this TODO item. For this patch, Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Tuesday, November 28, 2023 2:44 PM > To: Chang, Abner ; devel@edk2.groups.io > Cc: Igor