Re: [edk2-devel] [PATCH V2 0/2] Add DECLARE_LENGTH opcode of dependency expression

2023-12-29 Thread Li, Yi
Hello, any comments about this patch series? -Original Message- From: devel@edk2.groups.io On Behalf Of Li, Yi Sent: Wednesday, December 20, 2023 9:55 AM To: devel@edk2.groups.io Cc: Li, Yi1 ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Xu, Wei6 Subject: [edk2-devel] [PATCH V2

Re: [edk2-devel] [PATCH V2 0/2] Update keybaord map based on UEFI spec 2.10

2023-12-29 Thread Li, Yi
Hello, any comments about this patch series? -Original Message- From: devel@edk2.groups.io On Behalf Of Li, Yi Sent: Monday, December 25, 2023 10:23 AM To: devel@edk2.groups.io Cc: Li, Yi1 ; Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Rebecca Cran ; Feng, Bob C ; Chen, Christine

Re: [edk2-devel][edk2-platforms][PATCH v3] MinPlatformPkg: Support SecFspWrapperPlatformSecLib in X64

2023-12-29 Thread Chaganty, Rangasai V
Hi Ted, I see good improvements on V3. Thanks! Few comments/feedback: 1. Minor feedback - The module name choice SecFspWrapperPlatformSecLibFspO.inf is assuming FSP owning reset vector will be part of FSP-O. it's an implementation choice. Perhaps consider the name to be

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of callback in EFI_FORM_BROWSER2_PROTOCOL

2023-12-29 Thread Felix Polyudov via groups.io
Reviewed by: Felix Polyudov -Original Message- From: Tan, Ming Sent: Monday, December 25, 2023 3:20 AM To: Felix Polyudov Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Li, Yi1 ; Ren, SuqiangX Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the comments of

Re: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of CapsuleImageSize on EFI_CAPSULE_HEADER

2023-12-29 Thread Felix Polyudov via groups.io
Reviewed by: Felix Polyudov -Original Message- From: Tan, Ming Sent: Monday, December 25, 2023 3:25 AM To: Felix Polyudov Cc: Kinney, Michael D ; Gao, Liming ; Liu, Zhiguang ; Li, Yi1 ; Ren, SuqiangX Subject: [EXTERNAL] RE: [edk2-devel] [PATCH 1/1] MdePkg: Update the definition of

Re: [edk2-devel] [RFC][PATCH 0/2] Introduce HTTPS Platform TLS policy

2023-12-29 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] > -Original Message- > From: Michael Brown > Sent: Friday, December 29, 2023 8:01 AM > To: devel@edk2.groups.io; Chang, Abner > Cc: Saloni Kasbekar ; Zachary Clark-williams > ; Nickle Wang ; Igor > Kulchytskyy > Subject: Re: [edk2-devel] [RFC][PATCH