*Tools, CI, Code base construction meeting series*
*When:*
Monday, April 1, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Patch pushed:
https://github.com/tianocore/edk2-platforms/commit/ce4b8e394077f7f10ace2c6e96767f676c000355
Thanks,
Chasel
> -Original Message-
> From: Pabba, PhanindraX Babu
> Sent: Wednesday, March 27, 2024 2:27 PM
> To: devel@edk2.groups.io
> Cc: Pabba, PhanindraX Babu ; Chiu,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4713
In UEFI_Spec_2_10_Aug29.pdf page 1694 section 35.5.4 for
EFI_BROWSER_ACTION_FORM_OPEN:
NOTE: EFI_FORM_BROWSER2_PROTOCOL.BrowserCallback() cannot be used with
this browser action because question values have not been retrieved yet.
So
[AMD Official Use Only - General]
Hi Nickle,
Use Uri makes sense to me. Thanks! Please go ahead to merge it.
Reviewed-by: Abner Chang .
> -Original Message-
> From: Nickle Wang
> Sent: Monday, April 1, 2024 10:38 PM
> To: devel@edk2.groups.io
> Cc: Chang, Abner ; Igor Kulchytskyy
>
>
Taylor:
Thanks for you detail information. I understand this problem. I agree your
fix. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Taylor Beebe
> 发送时间: 2024年3月29日 8:28
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' ; 'Bob Feng'
> ;
Update Spdm.h to support 1.2 new features, such as:
Authentication and measurement. It wil be used in DeviceSecurity.
The DeviceSecurity feature is from
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Add support for
TCG PC Client Platform Firmware Profile Specification 1.06.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdePkg/Include/IndustryStandard/Spdm.h| 4 +-
.../IndustryStandard/UefiTcgPlatform.h| 186
According to UEFI 2.10 spec 3.3 Globally Defined Variables section,
add devAuthBoot GlobalVariable.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdePkg/Include/Guid/GlobalVariable.h | 8 +++-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2479
In PFP spec 1.06, platform firmware records the device certificate and
device measurement for each SPDM responder.
This PATCH set implement the DeviceSecurityLib to support spdm device
Authentication and Measurement.
Libspdm as submodule
Add EV_EFI_SPDM_DEVICE_POLICY support for MeasureVariable.
Cc: Liming Gao
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
MdeModulePkg/MdeModulePkg.dec | 5 +++
.../Variable/RuntimeDxe/Measurement.c | 38 ---
.../RuntimeDxe/VariableRuntimeDxe.inf
Add DeviceSecurity submodule libspdm.
Cc: Sean Brogan
Cc: Joey Vagedes
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Wenxing Hou
---
.pytool/CISettings.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/.pytool/CISettings.py b/.pytool/CISettings.py
index ec3beb0dcf..314758da32
Add new api Tpm2ExtendNvIndex.
It is uesd in HashCompleteAndExtend when PcrIndex > MAX_PCR_INDEX.
Cc: Jiewen Yao
Cc: Rahul Kumar
Signed-off-by: Wenxing Hou
---
SecurityPkg/Include/Library/Tpm2CommandLib.h | 23 +++-
.../HashLibBaseCryptoRouterDxe.c | 88 +++--
libspdm is submodule, which will be used in DeviceSecurity.
Cc: Andrew Fish
Cc: Michael D Kinney
Cc: Michael D Kinney
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
.gitmodules| 3 +++
SecurityPkg/DeviceSecurity/SpdmLib/libspdm | 1 +
2 files changed, 4
libspdm is submodule to support DeviceSecurity feature.
Cc: Jiewen Yao
Signed-off-by: Wenxing Hou
---
SecurityPkg/DeviceSecurity/SpdmLib/libspdm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/DeviceSecurity/SpdmLib/libspdm
Zifang and Yuting:
The change looks good. But, there are two ways for error report. One is
gCVfrErrorHandle.HandleWarning, another is DefaultValueError. Can we always
use gCVfrErrorHandle.HandleWarning?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Zhang, Zifeng
> 发送时间:
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, April 2, 2024
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Refer to Uefi spec 2.10 section 12.3.3, Add a new retval
EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx
and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke().
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Qingyu
---
.../VirtualKeyboardFeaturePkg/VirtualKeyboardDxe/Keyboard.c
Hi Yi,
As you suggested, modified the changes and gave PR. Here I have attached the
Link for reference.
https://github.com/tianocore/edk2/pull/5507
Thanks,
Sountharya
-Original Message-
From: Li, Yi1
Sent: Thursday, March 28, 2024 7:17 AM
To: devel@edk2.groups.io; Sountharya N
Cc:
*** BLURB HERE ***
Sachin Ganesh (5):
MdePkg: Add definition for NVMe Over Fabric Device Path
MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
MdePkg: Use newly defined Unaccepted Memory Type
MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
MdePkg: Update to PI 1.8
EFI_RESOURCE_MEMORY_UNACCEPTED has been officially defined in the PI
1.8 specification. So all temporary solutions have been replaced with
the actual definition.
Cc: Liming Gao
Cc: Felix Polyudov
Cc: Dhanaraj V
Signed-off-by: Sachin Ganesh
---
MdeModulePkg/Core/Dxe/Gcd/Gcd.c | 10
Defined Encrypted and Special Purpose resource attributes as
defined in PI 1.8 Specification
Cc: Liming Gao
Cc: Felix Polyudov
Cc: Dhanaraj V
Signed-off-by: Sachin Ganesh
---
MdePkg/Include/Pi/PiHob.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdePkg/Include/Pi/PiHob.h
Added WaitOnEvent() function to EFI_DELAYTED_DISPATCH_PPI.
Modified DispatchRegister() parameter list.
Cc: Liming Gao
Cc: Felix Polyudov
Cc: Dhanaraj V
Signed-off-by: Sachin Ganesh
---
MdePkg/Include/Ppi/DelayedDispatch.h | 24 +++-
1 file changed, 23 insertions(+), 1
Revision macros have been updated to indicate PI 1.8 specification
support
Cc: Liming Gao
Cc: Felix Polyudov
Cc: Dhanaraj V
Signed-off-by: Sachin Ganesh
---
MdePkg/Include/Pi/PiDxeCis.h | 6 +++---
MdePkg/Include/Pi/PiMmCis.h | 6 +++---
MdePkg/Include/Pi/PiMultiPhase.h | 6 ++
In accordance with UEFI 2.10 Specification:
Adding definition for NVMe Over Fabric (NVMe-oF) Device Path
of Messaging Sub-Type.
Cc: Liming Gao
Cc: Felix Polyudov
Cc: Dhanaraj V
Signed-off-by: Sachin Ganesh
---
MdePkg/Include/Protocol/DevicePath.h | 22 ++
1 file changed,
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, April 1, 2024
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
Hi Sam,
See comments below...
+SHELL_STATUS
+DisplayRtProperties (
+ IN UINT64 Address
+ )
+{
+ EFI_RT_PROPERTIES_TABLE *RtPropertiesTable;
+ UINT32 RtServices;
+ SHELL_STATUSShellStatus;
+ EFI_STATUS Status;
+
+ ShellStatus = SHELL_SUCCESS;
+
+
Hi,
Please remove 'Reviewed-by: @yi1...@intel.com' and send V2 patch to
devel@edk2.groups.io by send-email.
Generate V2 patch:
Add '--subject-prefix="PATCH V2" ' when you format patch:
git format-patch --subject-prefix="PATCH V2" ...
The content of patch looks good to me, will give you my
Aaron:
Per the specification, it is valid to publish all ACPI table in
EfiAcpiMemoryNVS.
So, I have no other comments for this patch. Reviewed-by: Liming Gao
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Aaron Li
> 发送时间: 2024年4月1日 10:32
> 收件人: devel@edk2.groups.io; Liming
Thanks, Mike!
I merged this pull request.
Regards,
Nickle
> -Original Message-
> From: Mike Maslenkin
> Sent: Wednesday, March 27, 2024 5:19 AM
> To: Nickle Wang
> Cc: Chang, Abner ; devel@edk2.groups.io; Igor
> Kulchytskyy
> Subject: Re: [edk2-redfish-client][RFC PATCH 0/3]
This adds an additional option to the dmem UEFI shell command for verbose
dumping of a couple of UEFI tables.
The tables specified are the RT Properties Table, the Image Execution Table,
and the Conformance Profiles table.
Supporting objects are added in the .inf and .uni files relating to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the Image Execution Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
Notes:
v3:
- fixed build erros
- added setwidth formatting to output
- properly using Address
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented dumping of the UEFI Conformance Profiles Table using Dmem.c
Additionally added the base support for the table with new
header file ConformanceProfiles.h (Cc'd maintainers of MdePkg for this)
Cc: Ray Ni
Cc: Zhichao Gao
Cc:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4352
Implemented the dumping of the UEFI RT Properties Table using Dmem.c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Sam Kaynor
---
Notes:
v3:
- fixed build errors
- properly using Address variable
Introduce SecureBoot driver to support
/redfish/v1/Systems/SYS/SecureBoot resource.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishClientComponents.dsc.inc | 2 +
RedfishClientPkg/RedfishClientLibs.dsc.inc| 4 +
-Release Etag and PendingSettingUri resources.
-Update function header for GetHttpResponseEtag() and
GetHttpResponseLocation(). Caller has to release returned
memory buffer from these two functions.
-Fix typo.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
> On Mar 31, 2024, at 8:39 PM, John Chew wrote:
>
> On Sat, Mar 30, 2024 at 06:10 AM, Andrew Fish wrote:
> You can make a ReadOnly file system out of contents on an FV (Firmware
> Volume):
> https://github.com/tianocore/edk2/tree/master/MdeModulePkg/Universal/FvSimpleFileSystemDxe
> FV is
Hi Abner,
Sorry for the delayed response.
Patch looks good to me.
Regards,
Mike.
On Mon, Apr 1, 2024 at 4:23 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> Hi Mike,
> Just letting you know that I merged this patch set to clean up the backlogs.
> I believe your comment was
Private->Uri is initialized after calling SetRedfishSettingsObjectsUri()
but it is used in SetRedfishSettingsObjectsUri function. Use input
parameter "Uri" instead.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 1/3] MinPlatformPkg: Remove the
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 13:59
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2] MinPlatformPkg: Corret
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 2/3] MinPlatformPkg: Get CoreType
Reviewed-by: Ray Ni
Thanks,
Ray
From: Tan, Dun
Sent: Monday, April 1, 2024 14:04
To: devel@edk2.groups.io
Cc: Ni, Ray ; Lou, Yun ; Chiu, Chasel
; Desimone, Nathaniel L
; Liming Gao ; Dong,
Eric
Subject: [edk2-platforms V2 3/3] MinPlatformPkg: Sort
This global variable mForceX2ApicId is not assigned
to any value in code and will be initialized to 0 when
the driver is loaded. So remove the global variable
and related code that will not be executed.
Signed-off-by: Dun Tan
Cc: Ray Ni
Cc: Jason Lou
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc:
Add a new field CoreType in EFI_CPU_ID_ORDER_MAP
and get CoreType for all cores.
Signed-off-by: Dun Tan
Cc: Ray Ni
Cc: Jason Lou
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
---
Platform/Intel/MinPlatformPkg/Acpi/AcpiTables/AcpiPlatform.c | 50
Sort ApicIdOrderTable by following special rules:
1. Make sure BSP is the first entry.
2. For APs, big core first, then small core.
With this implementation, BIOS can present cores in order
of relative performance in MADT. Linux OS would schedule
cores by the order that they are presented in the
This patch set is to sort ApicIdOrderTable by following special rules:
1. Make sure BSP is the first entry.
2. For APs, big core first, then small core.
With this implementation, BIOS can present cores in order of relative
performance in MADT.
Linux OS would schedule cores by the order that they
46 matches
Mail list logo
