Use MdeModulePkg declaration of ResetSystem function, comment the one
in platform source code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
Cc: David Wei
Cc: Yi Qian
Reviewed-by: Yi Qian
---
Vlv2TbltDevicePkg/PlatformPei/Platform.c | 1 -
Vlv2TbltDevice
Use HpetTimerDxe instead of SmartTimer protocol. Retire 8259 as well.
Tested boot to Win10x64 successfully.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
Cc: David Wei
Cc: Yi Qian
Reviewed-by: Yi Qian
---
Vlv2TbltDevicePkg/PlatformPkg.fdf | 4
Laszlo,
I am still working on how to pre-view these changes as they
would appear on the website once checked in.
There are 4 files patched. Only the following one is
accessible from GitHub pages.
https://www.tianocore.org/legalese.html
The other three files appear to be old informatio
Reviewed by Qian, Yi
Thanks
Qian Yi
-Original Message-
From: Sun, Zailiang
Sent: Wednesday, April 17, 2019 5:21 PM
To: devel@edk2.groups.io
Cc: Wei, David ; Qian, Yi
Subject: [PATCH] Vlv2TbltDevicePkg: Remove ResetSystem declaration
Use MdeModulePkg declaration of ResetSystem function,
Hi Laszlo,
Yes. The commit message is very important. I'll care more on the commit message
in future code review.
For this patch I'll ask submitter to enter a BZ and refine this patch commit
message.
Thanks,
Bob
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: W
Thank you all.
I will update the patch according to Laszlo's comments before commit the patch.
Thanks,
Dandan
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Wednesday, April 17, 2019 6:53 PM
> To: Ard Biesheuvel ; Bi, Dandan
>
> Cc: edk2-devel-groups-io ; Ca
On Wed, 17 Apr 2019 at 18:00, Wu, Hao A wrote:
>
> > -Original Message-
> > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> > Sent: Thursday, April 18, 2019 12:45 AM
> > To: Laszlo Ersek
> > Cc: edk2-devel-groups-io; Wang, Jian J; Wu, Hao A; Ni, Ray; Gary Ching-Pang
> > Lin
> > S
> -Original Message-
> From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org]
> Sent: Thursday, April 18, 2019 12:45 AM
> To: Laszlo Ersek
> Cc: edk2-devel-groups-io; Wang, Jian J; Wu, Hao A; Ni, Ray; Gary Ching-Pang
> Lin
> Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManager
Hi Laszlo,
Thanks a lot. You are right. I have updated my filter setting and it works fine.
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, April 17, 2019 9:34 PM
> To: devel@edk2.groups.io; Ga
Andrew:
Yes. GenFw has -z option to clear debug entry data as zero. I try GenFw with
-e PEIM –z together. But, I find the generated EFI image is wrong. I have
submitted BZ https://bugzilla.tianocore.org/show_bug.cgi?id=1727 for it. I will
fix it.
Thanks
Liming
From: devel@edk2.groups.io [mail
These are being removed as they have been replaced
with the python build scripts
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Ankit Sinha
Cc: Michael D Kinney
Cc: Isaac W Oram
Cc: Liming Gao
Cc: Bowen Zhou
Cc: Shifei A Lu
Contributed-under: TianoCore Contribution Agreement 0.1
Signed-off-by:
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#39274): https://edk2.groups.io/g/devel/message/39274
Mute This Topic: https://groups.io/mt/31217734/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/
This change allows building all the platforms in Platform/Intel with
a single python script. This script works with python 2.7
and python 3.7
Files Added:
* BuildBios.py: the main build script
build.cfg: contains general/default build settings
* ClevoOpenBoardPkg/N1xxWU/buildConfig.cfg: contain
Updated the build instructions to include
the python script build instructions
Cc: Michael Kubacki
Cc: Michael D Kinney
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Ankit Sinha
Cc: Bowen Zhou
Cc: Shifei A Lu
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Agyeman
---
ReadMe
Most recent ARM-TF ComPhy PCIE initialization routines check
additional mode parameter in order to determine, where the SMC
is called from (OS / firmware). Adjust to that.
This patch fixes the Linux boot with DT.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
On 2019-04-17 07:59:41, Laszlo Ersek wrote:
> On 04/17/19 13:44, Andrew Fish wrote:
>
> > Sorry I digressed into the C specification discussion, and did not
> > deal with the patch in general. My point is the original code is legal
> > C code. If you lookup CWE-119 it is written as a restriction o
Ard,
śr., 17 kwi 2019 o 20:30 Ard Biesheuvel napisał(a):
>
> On Wed, 17 Apr 2019 at 11:27, Ard Biesheuvel
> wrote:
> >
> > On Wed, 17 Apr 2019 at 11:06, Marcin Wojtas wrote:
> > >
> > > Linux MTD subsystem enables the SPI controller clock
> > > only when explicitly accessing the device. Becaus
Andrew,
My suggestion is to read the 3 bytes and shift and or to build 24-bit value.
That is what is in the patch at the bottom. It uses an extra layer of macros
that I am not in favor of. There is an additional email with a proposed
approach that makes the use of the array members more obvio
Mike,
I kind of ratholed us on alignment when Laszlo was more concerned about strict
aliasing and the effective type rule. Sorry! I don't think your proposal fixes
the effective type issue, and actually may make it worse if I'm correct.
It seems like the safest thing to do is read byte by byte
Laszlo,
We should also be able to do a consistent fix without
adding any new unions or macros:
#define FFS_FILE_SIZE(FfsFileHeaderPtr) ((UINT32)( \
(((EFI_FFS_FILE_HEADER *) (UINTN) FfsFileHeaderPtr)->Size[0] ) | \
(((EFI_FFS_FILE_HEADER *) (UINTN) FfsFileHeaderPtr)->Size[1] << 8 ) | \
On Wed, 17 Apr 2019 at 11:27, Ard Biesheuvel wrote:
>
> On Wed, 17 Apr 2019 at 11:06, Marcin Wojtas wrote:
> >
> > Linux MTD subsystem enables the SPI controller clock
> > only when explicitly accessing the device. Because of that,
> > using variables stored in the SPI flash could cause a hang
>
On Wed, 17 Apr 2019 at 11:06, Marcin Wojtas wrote:
>
> Linux MTD subsystem enables the SPI controller clock
> only when explicitly accessing the device. Because of that,
> using variables stored in the SPI flash could cause a hang
> when this clock remained disabled.
>
> Such issue was prevented w
From: Hanna Hawa
Update PCD paramters to be 64 bit, so that to add more flexibility
for the platforms in terms of configuring memory-mapped SPI access.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Marcin Wojtas
---
Silicon/Marvell/Marvell.dec |
From: Kornel Duleba
This path enables support for reading variables directly from flash without
relying on it to be memory mapped. It adds PcdSpiMemoryMapped PCD that
allows to switch between the modes. When in non-memory-mapped mode the
driver will copy the variables from flash to previously all
Hi,
Here's another short patchset from my stack. The changes
introduce support additional method of preventing hang
when accessing variables from the OS.
Also a support is added for platforms with the SPI whose
memory-mapped access is not configured (or even possible).
The patches are available i
Linux MTD subsystem enables the SPI controller clock
only when explicitly accessing the device. Because of that,
using variables stored in the SPI flash could cause a hang
when this clock remained disabled.
Such issue was prevented when booting with the default
DTB - see commit 124073e4d440 ("Marv
Laszlo,
I have been following this thread. I think the style
used here to access the 3 array elements to build the
24-bit size value is the best approach. I prefer this
over adding the union.
I agree there is a read overrun issue when using UINT32 to
read the Size[3] array contents.
I do not t
> On Apr 16, 2019, at 11:52 PM, Liming Gao wrote:
>
> /Build/OvmfX64/RELEASE_GCC5/X64/MdeModulePkg/Application/UiApp/UiApp/DEBUG/UiApp.dll
> is generated by GenFw tool. When GenFw tool convert ELF image to EFI image,
> it inserts the debug entry with the below string.
> <>
Liming,
Is there
https://bugzilla.tianocore.org/show_bug.cgi?id=1656
Change the EDK II C Coding Standards Specification to state that
the preferred license of the EDK II is the BSD+Patent License and
that file headers should use SPDX license identifiers.
Remove the requirement that there are no blank lines betwee
Laszlo,
It is a good idea to relax the requirement of no blank
lines between the copyright and SPDX identifier.
I will send a V2.
Mike
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Tuesday, April 16, 2019 5:54 AM
> To: Kinney, Michael D ;
> devel@edk2.gro
On Wed, 17 Apr 2019 at 06:09, Laszlo Ersek wrote:
>
> On 04/17/19 08:40, Ard Biesheuvel wrote:
> > As reported by Gary, the recent LoadImage/StartImage changes to
> > accommodate dispatching PE/COFF images built for foreign architectures
> > may result in a crash when loading an IA32 option ROM in
Hi,
On 4/15/19 2:50 PM, Ard Biesheuvel wrote:
On Mon, 8 Apr 2019 at 17:33, Jeremy Linton wrote:
The mcbin (and likely others) have a nonstandard uart clock.
This means that the earlycon programming will incorrectly set
the baud rate if it is specified. The way around this is to tell
the kerne
On Wed, 17 Apr 2019 at 02:32, Marcin Wojtas wrote:
>
> Generic handling of the PMU interrupts in UEFI and Linux with
> ACPI require enabling a dedicated handler in the EL3.
> Extend the PlatInitDxe with enabler code.
>
> Because for DT world the EL3 service must remain disabled,
> switch it off in
On 04/17/19 13:44, Andrew Fish wrote:
> Sorry I digressed into the C specification discussion, and did not
> deal with the patch in general. My point is the original code is legal
> C code. If you lookup CWE-119 it is written as a restriction on what
> the C language allows.
>
> As I mentioned cas
This change needs to use new build_rule.txt. When call edksetup.bat, please try
'edksetup.bat Reconfig'. This command will copy build_rule.txt into Conf
directory.
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ryszard
> Knop
"TianoCore Bug Triage - EMEA / NAMO" Reminder
When: Monday, 22 April 2019
7:00am to 8:00am
(GMT-07:00) America/Los Angeles
Where: https://zoom.us/j/670172897
Description: Join Zoom Meeting
https://zoom.us/j/670172897 ( https://zoom.us/j/670172897 )
One tap mobile
+1720707269
Hi Zhichao,
On 04/17/19 02:26, Gao, Zhichao wrote:
> Hi Phil,
>
> Sorry I missed this email again.
>
> When you reply to me, I get the email from the groups.io. It is not directly
> to me.
That's strange, because Phil's answer addressed both you, and the list.
Unless you have some kind of de-
Hi,
On 04/17/19 04:02, Fan, ZhijuX wrote:
> As the Dict is unordered, an error occurs when using the Dict
> while creating a new item.So for now, use OrdereDict instead
> of Dict.
this problem statement is impenetrable.
- What is the exact symptom?
- What triggers it, and where?
- When we make
On 04/17/19 08:40, Ard Biesheuvel wrote:
> As reported by Gary, the recent LoadImage/StartImage changes to
> accommodate dispatching PE/COFF images built for foreign architectures
> may result in a crash when loading an IA32 option ROM into a X64 VM
> running OVMF:
>
> Loading driver at 0x0007E5
> On Apr 17, 2019, at 3:29 AM, Laszlo Ersek wrote:
>
> Hi Andrew,
>
> On 04/17/19 01:25, Andrew Fish wrote:
>>
>>
>>> On Apr 16, 2019, at 11:48 AM, Jordan Justen
>>> wrote:
>>>
>>> On 2019-04-16 03:59:48, Laszlo Ersek wrote:
On 04/16/19 11:04, Jordan Justen wrote:
> On 2019-04-15
On 04/17/19 09:16, Ard Biesheuvel wrote:
> On Tue, 16 Apr 2019 at 23:40, Dandan Bi wrote:
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
>>
>> Remove ShellBinPkg from edk2.
>> If developers work on current edk2 master and still want to use Shell
>> binary after this removal, they c
Hi Andrew,
On 04/17/19 01:25, Andrew Fish wrote:
>
>
>> On Apr 16, 2019, at 11:48 AM, Jordan Justen
>> wrote:
>>
>> On 2019-04-16 03:59:48, Laszlo Ersek wrote:
>>> On 04/16/19 11:04, Jordan Justen wrote:
On 2019-04-15 09:15:31, Laszlo Ersek wrote:
> On 04/14/19 09:19, Jordan Justen wr
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Wednesday, April 17, 2019 10:02 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:Makefiles cause data errors on some platforms
As the Dict is unordered, an error occurs when using the D
On 04/16/19 18:50, Philippe Mathieu-Daudé wrote:
> Hi Laszlo,
>
> On 4/16/19 12:59 PM, Laszlo Ersek wrote:
>> On 04/16/19 11:04, Jordan Justen wrote:
>>> On 2019-04-15 09:15:31, Laszlo Ersek wrote:
On 04/14/19 09:19, Jordan Justen wrote:
> On 2019-04-12 16:31:20, Laszlo Ersek wrote:
>
On 04/16/19 20:48, Jordan Justen wrote:
> On 2019-04-16 03:59:48, Laszlo Ersek wrote:
>> On 04/16/19 11:04, Jordan Justen wrote:
>>> On 2019-04-15 09:15:31, Laszlo Ersek wrote:
On 04/14/19 09:19, Jordan Justen wrote:
> On 2019-04-12 16:31:20, Laszlo Ersek wrote:
>> RH covscan justified
Generic handling of the PMU interrupts in UEFI and Linux with
ACPI require enabling a dedicated handler in the EL3.
Extend the PlatInitDxe with enabler code.
Because for DT world the EL3 service must remain disabled,
switch it off in the ExitBootServicesEvent. Its execution
depends on the gEdkiiPl
Use MdeModulePkg declaration of ResetSystem function, comment the one
in platform source code.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
Cc: David Wei
Cc: Yi Qian
---
Vlv2TbltDevicePkg/PlatformPei/Platform.c | 1 -
Vlv2TbltDevicePkg/PlatformPei/Platfo
Reviewed by Qian YI
Thanks
Qian Yi
-Original Message-
From: Sun, Zailiang
Sent: Wednesday, April 17, 2019 3:24 PM
To: devel@edk2.groups.io
Cc: Wei, David ; Qian, Yi
Subject: [PATCH] Vlv2TbltDevicePkg: Retire 8254 timer and 8259 module
Use HpetTimerDxe instead of SmartTimer protocol. Re
Use HpetTimerDxe instead of SmartTimer protocol. Retire 8259 as well.
Tested boot to Win10x64 successfully.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Zailiang Sun
Cc: David Wei
Cc: Yi Qian
---
Vlv2TbltDevicePkg/PlatformPkg.fdf | 4
Vlv2TbltDevicePkg/Pla
On Tue, 16 Apr 2019 at 23:40, Dandan Bi wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1675
>
> Remove ShellBinPkg from edk2.
> If developers work on current edk2 master and still want to use Shell
> binary after this removal, they can get it from source code in the Assets
> part o
50 matches
Mail list logo
