Reviewed-by: Liming Gao
>-Original Message-
>From: Bi, Dandan
>Sent: Monday, April 29, 2019 10:16 AM
>To: devel@edk2.groups.io
>Cc: Gao, Liming
>Subject: [patch 03/11] IntelFrameworkModulePkg: Remove
>PcdFrameworkCompatibilitySupport usage
>
>REF:
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Dandan Bi
>Sent: Monday, April 29, 2019 10:16 AM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D ; Steele, Kelly
>; Gao, Liming
>Subject: [edk2-devel] [patch 07/11]
This is a shell application to dump dynamic PCD settings.
Type DumpDynPcd -?/h/H to get help information.
Type DumpDynPcd -v/V to get version information.
Type DumpDynPcd [PcdName] to get Pcd information.
https://bugzilla.tianocore.org/show_bug.cgi?id=1541
v2:1.Add static for global variables.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Dandan Bi
Sent: Monday, April 29, 2019 10:16 AM
To: devel@edk2.groups.io
Cc: Feng, Bob C ; Gao, Liming
Subject: [edk2-devel] [patch 01/11] BaseTools/VfrCompile: Remove
On Thu, May 2, 2019 at 03:11 AM, wrote:
>
> Hi Laszlo,
As you suggested in the in-line mail I have found a machine which supports EPT
technology in our lab environment. And to maintain a homogeneous KVM Host
environment used qemu-kvm packages which comes with the default repo.The thing
is
Zhiju,
Please split the long line into multiple <=80char lines, using the backslash so
that the patch is easy to review.
Also, would you please update the BZ to add the new error message?
Thanks,
Bob
-Original Message-
From: Fan, ZhijuX
Sent: Tuesday, April 30, 2019 10:13 AM
To:
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Tuesday, April 30, 2019 10:16 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:The code used to test python module is moved to
edksetup
This problem has nothing to do with the file system, We just use the filename
as a string to compare with other strings
Our unittest tested minplatform, Ovmf. This problem was found when building a
platform inside Intel.
We've tested it on Linux and Windows.
Any question, please let me know.
This is a shell application to dump dynamic PCD settings.
Type DumpDynPcd -?/h/H to get help information.
Type DumpDynPcd -v/V to get version information.
Type DumpDynPcd [PcdName] to get Pcd information.
https://bugzilla.tianocore.org/show_bug.cgi?id=1541
v2:1.Add static for global variables.
This brings up a question? Do we tests on a file system that is case sensitive?
Is this just lack of a test case?
Thanks,
Andrew Fish
> On May 6, 2019, at 7:22 PM, Fan, ZhijuX wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773
>
> Build break if C file suffixes of named .C
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1773
Build break if C file suffixes of named .C instead of .c
Code not recognize filenames with .C suffixes.
This patch adds code to Support both .c file and .C file
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
> -Original Message-
> From: Gao, Liming
> Sent: Monday, May 6, 2019 1:22 AM
> To: Kubacki, Michael A ; Leif Lindholm
> ; devel@edk2.groups.io
> Cc: Andrew Fish ; Laszlo Ersek ;
> Kinney, Michael D ; Ard Biesheuvel
>
> Subject: RE: [edk2-devel] [edk2-platforms] [RFC] Migrate
I think this has been discussed previously, but since time has passed
I'd like to check again: is there any possibility of having the DebugPkg
from https://github.com/andreiw/andreiw-wip/tree/master/uefi/DebugPkg
added to the main edk2 repo in some way (perhaps not as DebugPkg, but
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Monday, May 6, 2019 10:35 AM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:ECC report errors on account of analyze special
characters
Comments for Laszlo's question (11).
> -Original Message-
> From: Gao, Liming
> Sent: Sunday, May 5, 2019 11:22 PM
> To: Laszlo Ersek ; devel@edk2.groups.io
> Cc: Wu, Jiaxin ; Ye, Ting ; Fu, Siyuan
>
> Subject: RE: [edk2-devel] [Patch v3 2/3] NetworkPkg: Add DSC/FDF include
> segment
Zhiju,
Please refine the commit message. This issue looks a must-have problem not a
random problem.
Thanks,
Bob
-Original Message-
From: Fan, ZhijuX
Sent: Monday, May 6, 2019 1:20 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:Optimize code to
Hi Maggie,
The patch is good, only small comments for the commit message. Please remove
the "Contributed-under: ... " part, this is not needed now.
Please update the patch and send to me. I will help to submit it.
Reviewed-by: Eric Dong
Thanks,
Eric
> -Original Message-
> From: Chu,
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Monday, May 6, 2019 5:16 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH 1/3] BaseTools:Delete FrameworkDatabase from BaseTools/Conf
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
The
Hi Hao,
Shenglei has sync with me before about this gap. Both me and Liming is fine
with this change.
Thanks,
Eric
> -Original Message-
> From: Wu, Hao A
> Sent: Monday, May 6, 2019 9:14 PM
> To: Zhang, Shenglei ; Dong, Eric
> ; devel@edk2.groups.io
> Cc: Wang, Jian J ; Ni, Ray ; Zeng,
> On May 6, 2019, at 11:23 AM, Laszlo Ersek wrote:
>
> On 05/05/19 17:21, Liming Gao wrote:
>> Reply for the comments in the patch content.
>>> -Original Message-
>>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>>> Sent: Monday, April 29, 2019 9:05 PM
>>> To: devel@edk2.groups.io;
On 05/05/19 17:21, Liming Gao wrote:
> Reply for the comments in the patch content.
>> -Original Message-
>> From: Laszlo Ersek [mailto:ler...@redhat.com]
>> Sent: Monday, April 29, 2019 9:05 PM
>> To: devel@edk2.groups.io; Gao, Liming
>> Cc: Wu, Jiaxin ; Ye, Ting ; Fu,
>> Siyuan
>>
On 05/05/19 04:17, Gao, Zhichao wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412
>
> Original logic:
> Connect the graphics device -> connect it as graphics consoles
> and initialize its parameters(Mode = -1, invalid) -> connect it
> as console spliter and add the device to the
On 05/03/19 23:41, Brian J. Johnson wrote:
> On 5/2/19 2:33 PM, sean.brogan via groups.io wrote:
>> Brian,
>>
>> I would really like to hear about the challenges your team faced and
>> issues that caused those solutions to be unworkable. Project Mu has
>> and continues to invest a lot in testing
Hi Udit,
There is a case specification and user guide documentation available here
(inside documentation.zip):
http://www.uefi.org/sites/default/files/resources/UEFI2.6SCTII_Final_Release.zip
Thanks,
Supreeth
-Original Message-
From: Udit Kumar
Sent: Monday, May 6, 2019 5:49 AM
To:
On 05/05/19 09:50, Gao, Zhichao wrote:
> From: Bret Barkelew
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1772
>
> Add a useful definition of reset data for capsule function. And add
> two guids gCapsuleArmedResetGuid and gCapsuleUpdateCompleteResetGuid.
>
> Cc: Jian J Wang
> Cc:
From: Jonathan Watt
Fixes `bcfg boot -opt #` handling of the "#" option number to be
consistent with the other commands. Removes a footgun that bit me
and corrupted a different boot option than the one I meant to edit.
https://github.com/jwatt/edk2/tree/bcfg_args_fix
Jonathan Watt (1):
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
> Ersek
> Sent: Monday, May 6, 2019 10:28 PM
> To: devel@edk2.groups.io; Gao, Liming ; Wu, Jiaxin
>
> Subject: Re: [edk2-devel] [Patch v4 3/3] NetworkPkg: Add package level
> include DSC
Dandan,
Can you please help to review?
Thanks,
Ray
> -Original Message-
> From: jw...@jwatt.org [mailto:jw...@jwatt.org]
> Sent: Monday, May 6, 2019 9:03 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray
> Subject: [PATCH v1 1/1] ShellPkg/UefiShellBcfgCommandLib: Fix '-opt'
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, May 6, 2019 7:54 PM
> To: Gao, Liming ; devel@edk2.groups.io
> Subject: Re: [edk2-devel] [Patch v4 3/3] NetworkPkg: Add package level
> include DSC file
>
> On 05/05/19 16:53, Gao, Liming wrote:
> >>
Loop in Eric.
Hello Shenglei,
One general level comment, could you help to follow the recommendation in
https://edk2.groups.io/g/devel/message/39655?p=,,,20,0,0,0::Created,,UefiDebugLibStdErr,20,2,0,3131
to add 'static' for global variables/functions whose scope is limited
within a single
On 05/06/19 13:06, Philippe Mathieu-Daudé wrote:
> On 5/4/19 2:07 AM, Laszlo Ersek wrote:
>> In the MemMapInitialization() function, we currently have a common
>> PciSize assignment, shared between i440fx and q35. In order to simplify
>> the rest of this series, lift and duplicate the assignment
On 05/05/19 16:53, Gao, Liming wrote:
>> -Original Message-
>> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Laszlo
>> Ersek
>> Sent: Tuesday, April 30, 2019 10:42 PM
>> To: devel@edk2.groups.io; Gao, Liming
>> Subject: Re: [edk2-devel] [Patch v4 3/3] NetworkPkg:
On 5/4/19 2:07 AM, Laszlo Ersek wrote:
> In the MemMapInitialization() function, we currently assign PciBase
> different values, on both branches of the board type check. Hoist the
> PciBase assignment from the i440fx branch in front of the "if". This is a
> no-op for the i440fx branch. On the q35
On 5/4/19 2:07 AM, Laszlo Ersek wrote:
> In the MemMapInitialization() function, we currently have a common
> PciSize assignment, shared between i440fx and q35. In order to simplify
> the rest of this series, lift and duplicate the assignment identically to
> both board-specific branches.
>
> Cc:
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
The FrameworkDatabase was already obsolete,
So, FrameworkDatabase can be removed from Vlv2TbltDevicePkg.
This patch is going to fix this issue.
Cc: Zailiang Sun
Cc: Yi Qian
Signed-off-by: Zhiju.Fan
---
Vlv2TbltDevicePkg/bldX64.bat | 1
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1627
The FrameworkDatabase was already obsolete,
So, FrameworkDatabase can be removed from BaseTools/Conf,
ArmPlatformPkg, Vlv2TbltDevicePkg, Conf/ReadMe.txt.
Zhiju Fan (3):
BaseTools:Delete FrameworkDatabase from BaseTools/Conf
>-Original Message-
>From: Kubacki, Michael A
>Sent: Friday, May 03, 2019 5:16 AM
>To: Leif Lindholm ; devel@edk2.groups.io
>Cc: Gao, Liming ; Andrew Fish ;
>Laszlo Ersek ; Kinney, Michael D
>; Ard Biesheuvel
>Subject: RE: [edk2-devel] [edk2-platforms] [RFC] Migrate devel-MinPlatform
37 matches
Mail list logo
