[edk2-devel] [PATCH v2 1/2] UefiCpuPkg/MpInitLib: increase NumApsExecuting only for ApInitConfig

2019-06-04 Thread Ni, Ray
NumApsExecuting is only used when InitFlag == ApInitConfig for counting the processor count. The patch changes Ia32 version of waking up vector assembly code to align to x64 version of waking up vector assembly code. After the change both versions of waking up vector increase NumApsExecuting when

[edk2-devel] [PATCH v2 2/2] UefiCpuPkg/MpInitLib: Decrease NumApsExecuting only for ApInitConfig

2019-06-04 Thread Ni, Ray
The patch fixes the bug that the memory under 1MB is modified by firmware in S3 boot. Root cause is a racing condition in MpInitLib: 1. BSP: WakeUpByInitSipiSipi is set by NotifyOnS3SmmInitDonePpi() 2. BSP: WakeUpAP() wakes all APs to run certain procedure. 2.1. AllocateResetVector() uses <1MB

[edk2-devel] [PATCH v2 0/2] Fix the issue that OS complains memory < 1MB changes across S3

2019-06-04 Thread Ni, Ray
v2: Answer Laszlo's comments: 1. Add 1/2 patch to change IA32 waking up vector assembly code to increase NumApsExecuting only for ApInitConfig. 2. Change 2/2 patch to remove the unnecessary debug messages. Ray Ni (2): UefiCpuPkg/MpInitLib: increase NumApsExecuting only for

Re: [edk2-devel] Build error in CryptoPkg on FreeBSD

2019-06-04 Thread Wang, Jian J
Rebecca, You may help to fix it. We don't have FreeBSD machine and are not familiar with build env in it. Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > rebe...@bluestop.org > Sent: Wednesday, June 05, 2019 9:52 AM > To:

[edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-04 Thread Xiaoyu Lu
When use clang-3.8 to build the NetworkPkg, compiler optimization may use memcpy for memory copy. For example: CryptoPkg/Library/OpensslLib/openssl/ssl/ssl_rsa.c:918: undefined reference to `memcpy'` Compiler optimization is sophisticated, but we can work around it use

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer

2019-06-04 Thread Liming Gao
This change will be added after 201905 stable tag. >-Original Message- >From: Zhu, Yonghong >Sent: Wednesday, June 05, 2019 8:51 AM >To: devel@edk2.groups.io >Cc: Feng, Bob C ; Gao, Liming >Subject: [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer > >As Yonghong has some

[edk2-devel] Build error in CryptoPkg on FreeBSD

2019-06-04 Thread rebecca
I know it's not an officially supported platform, but a recent update has broken building CryptoPkg under FreeBSD. I've tried building both Armada80x0McBin (shown below) and OvmfPkg, and both fail. "/usr/local/bin/aarch64-unknown-freebsd13.0-gcc" 

[edk2-devel] [PATCH v4 2/2] MdeMoudlePkg/CapsulePei: Substantial change on UefiCapsule.c

2019-06-04 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853 AreCapsulesStaged do not need to return the status, only boolean result is useful. So directly return a boolean value. Cannot initialize the variable at its definition. GetScatterGatherHeadEntries: use allocated buffer instead of fixed

[edk2-devel] [PATCH v4 0/2] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-04 Thread Gao, Zhichao
v1: Sperate the capsule check function from GetCapsuleDescriptors and name it to AreCapsulesStaged. Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. And optimize its to remove the duplicated code. V2: Clarify the changes of the patch and descript in the commit message. V3: Add the

Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"

2019-06-04 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Laszlo Ersek >Sent: Wednesday, June 05, 2019 2:59 AM >To: edk2-devel-groups-io >Cc: Ard Biesheuvel ; Wu, Hao A >; Wang, Jian J ; Gao, Liming >; Ni, Ray ; Zeng, Star >

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure

2019-06-04 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Wang, Jian J >Sent: Wednesday, June 05, 2019 5:19 AM >To: devel@edk2.groups.io >Cc: Bi, Dandan ; Lu, XiaoyuX >Subject: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-04 Thread Liming Gao
Another one is to fix Maintainers.txt. [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network >-Original Message- >From: Wang, Jian J >Sent: Wednesday, June 05, 2019 5:21 AM >To: devel@edk2.groups.io; Kinney, Michael D ; >Gao, Liming >Cc:

[edk2-devel] [edk2-platforms: PATCH 1/2] Marvell/Armada7k8k: Remove unused compatible string from UART node

2019-06-04 Thread Marcin Wojtas
Linux FWTS test of the ARM SBSA compliance suite fail on using unsupported _CID in UART node. Remove it. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Armada7k8k/AcpiTables/Armada70x0Db/Dsdt.asl| 1 -

[edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-04 Thread Laszlo Ersek
When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may find that the extended config space is not (fully) implemented. In LocatePciExpressCapabilityRegBlock(), "CapabilityEntry" may be read as 0x_ at a given config space offset, after which the loop gets stuck spinning on

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-04 Thread Wang, Jian J
There's a fix for build failure. *[edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure Regards, Jian > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Wednesday, June 05, 2019 4:29 AM > To: Gao, Liming

[edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure

2019-06-04 Thread Wang, Jian J
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1878 This issue is specific to VS2017 which tries to resolve symbol referenced by a symbol not really referenced eventually. ossl_init_load_crypto_strings -> err_load_crypto_strings_int (not really referenced) -> ERR_load_OSSL_STORE_strings

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada7k8k: Introduce SMBIOS/DMI support

2019-06-04 Thread Marcin Wojtas
wt., 4 cze 2019 o 22:14 Leif Lindholm napisał(a): > > On Tue, Jun 04, 2019 at 01:39:07PM -0500, Jeremy Linton wrote: > > Hi Marcin, > > > > On 6/4/19 12:53 PM, Marcin Wojtas via Groups.Io wrote: > > > Fill in the basic requirements of the SMBIOS specification by specifying > > > the minimum

Re: [edk2-devel] [Patch V2] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Michael D Kinney
Thanks Laszlo. I will send a V3 with the updated links. Mike > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Laszlo Ersek > Sent: Tuesday, June 4, 2019 11:58 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: Re: [edk2-devel]

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-04 Thread Michael D Kinney
Hello, The patches for edk2-stable201905 were reviewed this morning. The following 2 patches are in scope for the hard freeze. * [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed" * [edk2-devel] [Patch V2] edk2: Update additional licenses in

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada7k8k: Introduce SMBIOS/DMI support

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 01:39:07PM -0500, Jeremy Linton wrote: > Hi Marcin, > > On 6/4/19 12:53 PM, Marcin Wojtas via Groups.Io wrote: > > Fill in the basic requirements of the SMBIOS specification by specifying > > the minimum required structures. The basic fixup is performed. > > CPU/DRAM

[edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"

2019-06-04 Thread Laszlo Ersek
This reverts commit 7cea4d71a8a87a93924a07ab32348332f5881ef9. Said commit was not suitable for pushing during the edk2-stable201905 hard feature freeze; it was pushed only by mistake. The subject line referenced EmulatorPkg, but the patch changed MdeModulePkg/UiApp, regressing the display of the

Re: [edk2-devel] [Patch V2] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Laszlo Ersek
Hi Mike, On 06/04/19 20:40, Michael D Kinney wrote: > Update the list of additional licenses in Readme.md. For additional > licenses from a git submodule, provide a link to the license file > in the remote git repository. This makes the links in Readme.md > when viewed from the edk2 repository

Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Leif Lindholm
:) For future reference: - browse to file - click the "history" button - click the "<>" button for the top commit ("Browse the repository at this point in history") - browse to the file again (If someone has a less tedious route I'd appreciate it, but it works.) / Leif On Tue, Jun 04,

[edk2-devel] [Patch V2] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Michael D Kinney
Update the list of additional licenses in Readme.md. For additional licenses from a git submodule, provide a link to the license file in the remote git repository. This makes the links in Readme.md when viewed from the edk2 repository GitHub landing page https://github.com/tianocore/edk2/

Re: [edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada7k8k: Introduce SMBIOS/DMI support

2019-06-04 Thread Jeremy Linton
Hi Marcin, On 6/4/19 12:53 PM, Marcin Wojtas via Groups.Io wrote: Fill in the basic requirements of the SMBIOS specification by specifying the minimum required structures. The basic fixup is performed. CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size is calculated from the

Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Michael D Kinney
Leif, I was wanting to figure out how to do the direct link to the license material. Thanks for providing that! I will send V2. Mike > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > On Behalf Of Leif Lindholm > Sent: Tuesday, June 4, 2019 11:00 AM > To:

Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 10:12:48AM -0700, Michael D Kinney wrote: > * Remove refrences EdkCompatibilityPkg > * Update link to OpenSSL to https://github.com/openssl/openssl > * Add link to https://github.com/ucb-bar/berkeley-softfloat-3 > for ArmSoftFloatLib Bikeshed warning: > Signed-off-by:

Re: [edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Laszlo Ersek
On 06/04/19 19:12, Michael D Kinney wrote: > * Remove refrences EdkCompatibilityPkg > * Update link to OpenSSL to https://github.com/openssl/openssl > * Add link to https://github.com/ucb-bar/berkeley-softfloat-3 > for ArmSoftFloatLib > > Signed-off-by: Michael D Kinney > --- > Readme.md | 4

[edk2-devel] [edk2-platforms: PATCH v4] Marvell/Armada7k8k: Introduce SMBIOS/DMI support

2019-06-04 Thread Marcin Wojtas
Fill in the basic requirements of the SMBIOS specification by specifying the minimum required structures. The basic fixup is performed. CPU/DRAM frequency is obtained via SampleAtResetlib and the DRAM size is calculated from the information stored in the HOB list. Add new Armada SmbiosPlatformDxe

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
Hi Liming, Sure. Here is what I get after building our NIC driver binary with VS2015x86 and VS2017 toolchains: pcfist@pcfist-pc:/mnt/c/src/uefi/udk2018$ du -h Build/xgbe_atl/RELEASE_VS2015x86/X64/xgbe_atl.efi Build/xgbe_atl/RELEASE_VS2017/X64/xgbe_atl.efi 36K    

[edk2-devel] [Patch] edk2: Update additional licenses in Readme.md

2019-06-04 Thread Michael D Kinney
* Remove refrences EdkCompatibilityPkg * Update link to OpenSSL to https://github.com/openssl/openssl * Add link to https://github.com/ucb-bar/berkeley-softfloat-3 for ArmSoftFloatLib Signed-off-by: Michael D Kinney --- Readme.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network

2019-06-04 Thread Laszlo Ersek
On 06/04/19 16:35, Leif Lindholm wrote: > On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote: >> MdeModulePkg/Universal/Network has been moved to NetworkPkg. So, >> MdeModulePkg/Universal/Network can be removed in Maintainers.txt. >> >> Signed-off-by: Liming Gao >> Cc: Andrew Fish >> Cc:

[edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
I have noticed the resulting binaries are about twice as large when using VS2017 toolchain compared to the ones built with VS2015. It appears this is caused by /WHOLEARCHIVE linker flag used by this toolchain. This flag was previously removed from VS2015 toolchain due to compatibility issues. I

[edk2-devel] [PATCH v1 0/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Roman Agafonov
This patch removes /WHOLEARCHIVE flag from VS2017 toolchain configuration to reduce the size of resulting binaries. GitHub branch: https://github.com/pcfist/edk2/tree/fix_vs2017_linker_config Roman Agafonov (1): BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-04 Thread Liming Gao
Can you show the size data with VS2017 and VS2015 for the same code? Thanks Liming > -Original Message- > From: Roman Agafonov [mailto:roman.agafo...@aquantia.com] > Sent: Tuesday, June 4, 2019 11:41 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao, Liming ; > Zhu, Yonghong >

[edk2-devel] Tentative:TianoCore Community Meeting - EMEA/NAMO

2019-06-04 Thread Nate DeSimone
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41870): https://edk2.groups.io/g/devel/message/41870 Mute This Topic: https://groups.io/mt/31927809/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] Accepted: TianoCore Community Meeting - APAC/NAMO

2019-06-04 Thread Nate DeSimone
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41869): https://edk2.groups.io/g/devel/message/41869 Mute This Topic: https://groups.io/mt/31927806/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] Accepted: TianoCore Design / Bug Triage - EMEA

2019-06-04 Thread Nate DeSimone
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41868): https://edk2.groups.io/g/devel/message/41868 Mute This Topic: https://groups.io/mt/31927802/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] Upcoming Event: TianoCore Design / Bug Triage - EMEA - Wed, 06/05/2019 8:00am-9:00am #cal-reminder

2019-06-04 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Design / Bug Triage - EMEA *When:* Wednesday, 5 June 2019, 8:00am to 9:00am, (GMT-07:00) America/Los Angeles *Where:* https://zoom.us/j/695893389 View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=488405 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network

2019-06-04 Thread Leif Lindholm
On Tue, Jun 04, 2019 at 10:10:59PM +0800, Liming Gao wrote: > MdeModulePkg/Universal/Network has been moved to NetworkPkg. So, > MdeModulePkg/Universal/Network can be removed in Maintainers.txt. > > Signed-off-by: Liming Gao > Cc: Andrew Fish > Cc: Laszlo Ersek > Cc: Leif Lindholm > Cc:

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-04 Thread Liming Gao
Ard: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, June 4, 2019 9:42 PM > To: Gao, Liming > Cc: devel@edk2.groups.io; Ni, Ray ; Leif Lindholm > ; Laszlo Ersek ; > Kinney, Michael D ; Liu, Zhiguang > ;

[edk2-devel] [PATCH] SecurityPkg: Add a PCD to skip Hdd password prompt

2019-06-04 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1876 Add a PCD for skipping Hdd password prompt. If device is in the locked status while attempting to skip password prompt, device will keep locked and system continue to boot. If device is in the unlocked status while attempting to skip password

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-04 Thread Ard Biesheuvel
On Tue, 4 Jun 2019 at 15:40, Gao, Liming wrote: > > Ard: > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > > Biesheuvel > > Sent: Tuesday, June 4, 2019 7:53 PM > > To: edk2-devel-groups-io ; Ni, Ray > > ; Leif Lindholm ; Gao, Liming

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-04 Thread Liming Gao
Ard: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Tuesday, June 4, 2019 7:53 PM > To: edk2-devel-groups-io ; Ni, Ray ; > Leif Lindholm ; Gao, Liming > ; Laszlo Ersek ; Kinney, Michael D > > Cc: Liu, Zhiguang ;

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-04 Thread Ard Biesheuvel
On Tue, 4 Jun 2019 at 10:50, Ni, Ray wrote: > > Zhiguang, > I made a mistake here. > I thought you changed the EmulatorPkg to not display the CPU speed > but actually what you changed impacts all platforms. > With this change, OVMF cannot show the CPU speed either. > > Can you please roll back

Re: [edk2-devel] Help needed in building UEFI qcow2 images

2019-06-04 Thread Laszlo Ersek
Pavan, On 06/03/19 21:21, Pavan Kumar Aravapalli wrote: > * We have CentOS flavoured qcow2 image which is used to boot Guest > VM's in Apache CloudStack. We are trying to enable these CentOS > qcow2 images with UEFI support. I told you weeks ago to take this question to the CentOS mailing

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Decrease NumApsExecuting only for ApInitConfig

2019-06-04 Thread Ni, Ray
> -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Monday, June 3, 2019 11:21 PM > To: devel@edk2.groups.io; Ni, Ray > Cc: Dong, Eric ; Sathyanarayanan, Nandagopal > > Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Decrease > NumApsExecuting

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-04 Thread Ni, Ray
Zhiguang, I made a mistake here. I thought you changed the EmulatorPkg to not display the CPU speed but actually what you changed impacts all platforms. With this change, OVMF cannot show the CPU speed either. Can you please roll back this changes (if it was pushed in)? To close the Bugzilla, I

Re: [edk2-devel] [RFC][edk2-platform][Add new packages in Platform\Intel directory]

2019-06-04 Thread Oram, Isaac W
Eric, I have envisioned less granular packages for advanced features. One of the goals for MinPlatform is to improve usability during porting. The idea is that you would do basic board porting with minimal effort to get your system functional. Then you would enable additional features by

Re: [edk2-devel] [PATCH V3 1/2] MdeModulePkg: Add a pcd to set the OS indications bit

2019-06-04 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, June 4, 2019 9:05 AM > To: devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ;

Re: [edk2-devel] [PATCH V3 2/2] MdeModulePkg/BdsDxe: Use a pcd to control PlatformRecovery

2019-06-04 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Tuesday, June 4, 2019 9:05 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Ni, Ray ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; >