Re: [edk2-devel][Patch] IntelFspPkg: Remove them

2019-06-05 Thread Nate DeSimone
Please commit Chasel's fix for https://edk2.groups.io/g/devel/topic/31860753#41659 Once Chasel's fix is committed... Reviewed-by: Nate DeSimone -Original Message- From: Ni, Ray Sent: Thursday, May 16, 2019 1:38 AM To: Chiu, Chasel ; Desimone, Nathaniel L ; Zeng, Star Cc:

[edk2-devel] Printing git commit in build

2019-06-05 Thread Udit Kumar
Dear Community, I like to print git commit id, which printing UEFI firmware build information. Could you help, how I can collect ' git describe' information in C file. Thanks Udit -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online

Re: [edk2-devel] Hard Feature Freeze starts now for edk2-stable201905

2019-06-05 Thread Liming Gao
Last one for edk2-stable201905. This one just adds the missing PrintLib in OpensslLib. PrintLib is the basic library to be included in every platform. So, this change risk is low. [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library Thanks Liming > -Original

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library

2019-06-05 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Wang, Jian J > Sent: Thursday, June 6, 2019 10:57 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Bi, Dandan > Subject: [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing > library > >

Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Marc W Chen
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 5, 2019 8:00 PM > To: Chen, Marc W ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Ard Biesheuvel > ; Anthony Perard ; > Julien Grall ; Marc-André Lureau > ;

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Liming Gao
Fish: From: af...@apple.com [mailto:af...@apple.com] Sent: Thursday, June 6, 2019 11:39 AM To: devel@edk2.groups.io; Lu, XiaoyuX Cc: Gao, Liming ; Bi, Dandan ; Wang, Jian J Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem On Jun 4, 2019, at

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Andrew Fish via Groups.Io
> On Jun 4, 2019, at 11:33 PM, Xiaoyu Lu wrote: > > Hi Liming, > >> -Original Message- >> From: Gao, Liming >> Sent: Wednesday, June 5, 2019 1:57 PM >> To: devel@edk2.groups.io ; Lu, XiaoyuX >> mailto:xiaoyux...@intel.com>> >> Cc: Bi, Dandan

Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "UefiPayloadPkg: Remove legacy PIC 8259 driver"

2019-06-05 Thread Liming Gao
Push @b66c4c4ff918f3663baca7a9321ecd8837cd8522 > -Original Message- > From: Dong, Guo > Sent: Wednesday, June 5, 2019 11:21 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > Subject: RE: [PATCH for-edk2-stable201905] Revert "UefiPayloadPkg: Remove > legacy

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Liming Gao
Push @98d8f194e5a646b25b3390825c92949a76689d75 > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming > Gao > Sent: Wednesday, June 5, 2019 3:56 PM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: Re:

[edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix build break caused by missing library

2019-06-05 Thread Wang, Jian J
CryptoPkg\Library\Include\CrtLibSupport.h maps str interfaces to edk2 PrintLib interfaces but related module inf file don't claim the use of it. This will cause unresolved symbol issue with VS2017 build which has enabled strict symbol check. This patch resolves the problem by adding PrintLib

[edk2-devel] [PATCH] BaseTools:Build cache support the cache files for library package

2019-06-05 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1867 Current build cache cannot store the cache for library package. build -p MdePkg\MdePkg.dsc -a IA32 -b DEBUG -t VS2015x86 --hash --binary-destination=BinCache After build, the expected result is the BinCache folder is generated and the MdePkg

Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

2019-06-05 Thread Zhang, Chao B
Hi Felix: We did this design for security consideration. For Solution B: 1) We don't want to introduce PartitionDxe and FatDxe into our trust boundary. It brings in new attack surface 2) We reuse PEI storage stack as it is simple. But PEI FAT reduced attach surface by only

Re: [edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Remove redundant comments

2019-06-05 Thread Dong, Eric
Reviewed-by: Eric Dong > -Original Message- > From: Bi, Dandan > Sent: Wednesday, June 5, 2019 3:42 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Gao, Liming > Subject: [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Remove > redundant comments > > Cc: Eric Dong > Cc:

[edk2-devel] [PATCH] BaseTools:Build Cache output notification message

2019-06-05 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1868 Build need output the cache miss or hit notification message when consume the build cache. Current build does not output any message which is not clear for user to know whether the module built result is from cache or not. This patch adds

Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

2019-06-05 Thread Michael D Kinney
Hi Felix, For (1), this is a limitation of UEFI Capsule On Disk for capsules that must be processed before End of DXE. This solution only work for EFI System Partitions that can be accessed from PEI. Platforms that require the use of a UEFI Driver loaded from a PCI Option ROM to access the EFI

Re: [edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

2019-06-05 Thread Felix Polyudov
1. It looks like the implementation processes capsule files in PEI. According to UEFI specification capsule files are stored on the active ESP. Not every UEFI boot device can be accessed in PEI. For example, RAID connected to the PCI plug in card cannot be accessed in PEI. 2. Solution B) below

Re: [edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

2019-06-05 Thread Felix Polyudov
1. It is my understanding that edk2 convention is to keep each PPI in a separate header file. If this is the case, new PPI definition should not be added to BootInRecoveryMode.h. 2. gEfiPeiBootInCapsuleOnDiskModePpiGuid is a bad name. New PPI is not defined by UEFI/PI specifications and as such

Re: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: FSP 2.1 SEC handling.

2019-06-05 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Friday, May 31, 2019 4:43 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-devel] [PATCH 2/2]

Re: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: FSP 2.1 SEC handling.

2019-06-05 Thread Nate DeSimone
Hi Chasel, FSP_TEMP_RAM_EXIT_PPI is defined by the FSP 2.1 specification. The definition for it should not go in KabyLakeSiliconPkg, it should be placed in IntelFsp2Pkg/Include/Ppi. Thanks, Nate -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Friday, May

Re: [edk2-devel] [PATCH 2/2] KabylakeOpenBoardPkg: Support DynamicExPCD from FSP.

2019-06-05 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Friday, May 31, 2019 4:42 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH 2/2] KabylakeOpenBoardPkg: Support DynamicExPCD from FSP.

Re: [edk2-devel] [PATCH 1/2] KabylakeSiliconPkg: Support DynamicExPCD from FSP.

2019-06-05 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Chiu, Chasel Sent: Friday, May 31, 2019 4:42 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V ; Desimone, Nathaniel L Subject: [PATCH 1/2] KabylakeSiliconPkg: Support DynamicExPCD from FSP.

Re: [edk2-devel] [PATCH] IntelFsp2Pkg/SplitFspBin.py: Revert FSP 1.x support.

2019-06-05 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Chiu, Chasel Sent: Friday, May 31, 2019 12:09 AM To: devel@edk2.groups.io Cc: Gao, Liming Subject: [edk2-devel] [PATCH] IntelFsp2Pkg/SplitFspBin.py: Revert FSP 1.x support. This reverts commit:

Re: [edk2-devel] [RFC] Proposal to move IntelSiliconPkg from edk2 repo to edk2-platforms repo

2019-06-05 Thread Chaganty, Rangasai V
/master/Silicon/Intel seems to be the logical place for this package but other suggestions are welcome. Regards, Sai -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#41958): https://edk2.groups.io/g/devel/message/41958 Mute This Topic:

Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Laszlo Ersek
On 06/05/19 14:00, Laszlo Ersek wrote: > On 06/05/19 13:14, Marc W Chen wrote: >> Query the supported attributes firstly, then AND (&&) both >> VGA_IO and VGA_IO_16. > > I don't think you mean "logical AND" above. On second thought, you do mean "logical AND" above, it's just that the wording is

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: don't use WHOLEARCHIVE linker flag for VS2017 toolchain

2019-06-05 Thread Liming Gao
I build edk2 OVMF with VS2015 and VS2017. Their image size are almost same. Have you the additional options to disable the optimization? In fact, /GL option will remove the unused function and logic. > -Original Message- > From: Roman Agafonov [mailto:roman.agafo...@aquantia.com] >

[edk2-devel][Patch v2 7/7] MdeModulePkg: Add Capsule On Disk APIs into CapsuleLib.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 CoDCheckCapsuleOnDiskFlag() is to check if CapsuleOnDisk flag in "OsIndications" Variable is enabled. It is used to indicate whether capsule on disk is provisioned in normal boot path. CoDClearCapsuleOnDiskFlag() is to to clear

[edk2-devel][Patch v2 3/7] MdeModulePkg: Add CapsuleOnDiskLoadPei PEIM.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This module provides PPI to load Capsule On Disk temp relocation file from Root Directory file system, retrieve the capsules from the temp file and create capsule hobs for these capsules. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch v2 5/7] MdeModulePkg/CapsuleRuntimeDxe: Introduce PCD to control this feature.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 Introduce PcdCapsuleInRamSupport to turn on/off Capsule In Ram feature. Platform could choose to drop CapsulePei/CapsuleX64 and not to support Capsule In Ram. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang Signed-off-by: Wei6 Xu ---

[edk2-devel][Patch v2 2/7] MdeModulePkg: Add Capsule On Disk related definition.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This patch will add Capsule On Disk related definition, including GUID, PPI and PCDs: The Capsule On Disk Name GUID indicates the capsule is to store Capsule On Disk file names. The Pei Capsule On Disk PPI provides service to retrieve

[edk2-devel][Patch v2 0/7] Implement Capsule On Disk.

2019-06-05 Thread Xu, Wei6
V2: Fix Ecc check failure. V1: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This patch set implements Capsule On Disk. Depends on whether platform supports Capsule-In-Ram, Capsule On Disk feature is composed of 2 solutions: Solution A): Load capsules out of TCB, rely on

[edk2-devel][Patch v2 6/7] MdeModulePkg/DxeIpl: Support Capsule On Disk.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 If Capsule On Disk mode, call Capsule On Disk Load PPI to load capsules. When it fails, still goes to Firmware Update boot path. BDS will clear corresponding indicator and reboot later on. Cc: Jian J Wang Cc: Hao A Wu Cc: Chao B Zhang

[edk2-devel][Patch v2 1/7] MdePkg: Add Pei Boot In CapsuleOnDisk Mode Ppi definition.

2019-06-05 Thread Xu, Wei6
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1852 This PPI indicates current boot mode is capsule on disk mode. Cc: Michael D Kinney Cc: Liming Gao Cc: Chao B Zhang Signed-off-by: Wei6 Xu --- MdePkg/Include/Ppi/BootInRecoveryMode.h | 9 - MdePkg/MdePkg.dec

Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "UefiPayloadPkg: Remove legacy PIC 8259 driver"

2019-06-05 Thread Guo Dong
Sorry missed the notice on the code freeze. Thanks Liming to create this patch. Reviewed-by: Guo Dong > -Original Message- > From: Gao, Liming > Sent: Wednesday, June 5, 2019 12:48 AM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Dong, Guo > ; You, Benjamin > Subject: [PATCH

Re: [edk2-devel] [RFC] Proposal to move IntelSiliconPkg from edk2 repo to edk2-platforms repo

2019-06-05 Thread Liming Gao
Have BZ for this change? Which stable tag is it for? Thanks Liming From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zeng, Star Sent: Wednesday, June 5, 2019 10:33 PM To: devel@edk2.groups.io; Chaganty, Rangasai V Cc: Kinney, Michael D ; Ni, Ray ; Zeng, Star ; Yao, Jiewen

Re: [edk2-devel] [RFC] Proposal to move IntelSiliconPkg from edk2 repo to edk2-platforms repo

2019-06-05 Thread Zeng, Star
Just curious about where the IntelSiliconPkg will be put in edk2-platforms repo? Thanks, Star From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Chaganty, Rangasai V Sent: Wednesday, May 22, 2019 3:13 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Ni, Ray Subject:

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-05 Thread Zeng, Star
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 5, 2019 4:03 PM > To: Ni, Ray ; Gao, Liming ; > ard.biesheu...@linaro.org; Leif Lindholm ; Kinney, > Michael D ; Liu, Zhiguang > ; Justen, Jordan L ; > Andrew

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure

2019-06-05 Thread Wang, Jian J
Laszlo, > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, June 05, 2019 7:00 PM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Bi, Dandan ; Lu, XiaoyuX > Subject: Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib:

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-05 Thread Ard Biesheuvel
On Wed, 5 Jun 2019 at 12:15, Laszlo Ersek wrote: > > On 06/05/19 11:25, Ard Biesheuvel wrote: > > On Tue, 4 Jun 2019 at 23:44, Laszlo Ersek wrote: > >> > >> When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may > >> find that the extended config space is not (fully)

Re: [edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Laszlo Ersek
On 06/05/19 13:14, Marc W Chen wrote: > Query the supported attributes firstly, then AND (&&) both > VGA_IO and VGA_IO_16. I don't think you mean "logical AND" above. And if you mean "bitwise AND", then "&&" is incorrect. > Since the supported attributes should > only have VGA_IO or VGA_IO_16

Re: [edk2-devel] [PATCH v2 0/2] Fix the issue that OS complains memory < 1MB changes across S3

2019-06-05 Thread Laszlo Ersek
On 06/05/19 07:49, Ni, Ray wrote: > v2: > Answer Laszlo's comments: > 1. Add 1/2 patch to change IA32 waking up vector assembly code to increase >NumApsExecuting only for ApInitConfig. > 2. Change 2/2 patch to remove the unnecessary debug messages. > > Ray Ni (2): >

[edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Marc W Chen
Query the supported attributes firstly, then AND (&&) both VGA_IO and VGA_IO_16. Since the supported attributes should only have VGA_IO or VGA_IO_16 set, the result of AND (&&) is either VGA_IO or IO_16. Then the result can be passed to PciIo->Attributes() to set the attributes. Signed-off-by:

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure

2019-06-05 Thread Laszlo Ersek
Hi Jian, On 06/04/19 23:18, Wang, Jian J wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1878 > > This issue is specific to VS2017 which tries to resolve symbol referenced > by a symbol not really referenced eventually. > > ossl_init_load_crypto_strings > ->

[edk2-devel] [PATCH] OvmfPkg/QemuVideoDxe: Shouldn't assume system in VGA alias mode.

2019-06-05 Thread Marc W Chen
Query the supported attributes firstly, then AND (&&) both VGA_IO and VGA_IO_16. Since the supported attributes should only have VGA_IO or VGA_IO_16 set, the result of AND (&&) is either VGA_IO or IO_16. Then the result can be passed to PciIo->Attributes() to set the attributes. Signed-off-by:

Re: [edk2-devel] [RFC PATCH 0/2] BaseTools: add script to set up git environment

2019-06-05 Thread Bob Feng
Hi Leif, https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers is a great resource. It's very useful. I tested this scripts. I found a minor issue that I have a local edk2 repo which was cloned by the command: "git clone

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-05 Thread Laszlo Ersek
On 06/05/19 11:25, Ard Biesheuvel wrote: > On Tue, 4 Jun 2019 at 23:44, Laszlo Ersek wrote: >> >> When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may >> find that the extended config space is not (fully) implemented. In >> LocatePciExpressCapabilityRegBlock(),

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-05 Thread Ard Biesheuvel
On Tue, 4 Jun 2019 at 23:44, Laszlo Ersek wrote: > > When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may > find that the extended config space is not (fully) implemented. In > LocatePciExpressCapabilityRegBlock(), "CapabilityEntry" may be read as > 0x_ at a given

Re: [edk2-devel] [PATCH for-next] MdeModulePkg/PciBusDxe: catch unimplemented extended config space reads

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/4/19 11:44 PM, Laszlo Ersek wrote: > When assigning a physical PCIe device to a QEMU/KVM guest, PciBusDxe may > find that the extended config space is not (fully) implemented. In > LocatePciExpressCapabilityRegBlock(), "CapabilityEntry" may be read as > 0x_ at a given config space

Re: [edk2-devel] [Patch V3] edk2: Update additional licenses in Readme.md

2019-06-05 Thread Philippe Mathieu-Daudé
On 6/5/19 3:15 AM, Michael D Kinney wrote: > Update the list of additional licenses in Readme.md. For additional > licenses from a git submodule, provide a link to the license file > in the remote git repository. This makes the links in Readme.md > when viewed from the edk2 repository GitHub

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer

2019-06-05 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Zhu, Yonghong Sent: Wednesday, June 5, 2019 8:51 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [Patch] Maintainers.txt: Remove Yonghong from BaseTools Reviewer As Yonghong has some other focus, remove him from the

Re: [edk2-devel] [PATCH] CryptoPkg/OpensslLib: fix VS2017 build failure

2019-06-05 Thread Liming Gao
Push @0a1b13fd4d2210e2c379ace4fd961fb80126b7e9 > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Liming > Gao > Sent: Wednesday, June 5, 2019 8:23 AM > To: devel@edk2.groups.io; Wang, Jian J > Cc: Bi, Dandan ; Lu, XiaoyuX > Subject: Re:

Re: [edk2-devel] [Patch] Maintainers.txt: Remove Network maintainers for MdeModulePkg/Universal/Network

2019-06-05 Thread Liming Gao
Push @cbfdc1b2df65dee011cf33add1dff88de3d9c46d > -Original Message- > From: Laszlo Ersek [mailto:ler...@redhat.com] > Sent: Wednesday, June 5, 2019 12:56 AM > To: Leif Lindholm ; Gao, Liming > > Cc: devel@edk2.groups.io; Andrew Fish ; Kinney, Michael D > > Subject: Re: [Patch]

Re: [edk2-devel] Help needed in building UEFI qcow2 images

2019-06-05 Thread Gerd Hoffmann
Hi, > However: you're using a systemd-related UEFI boot loader, and I have > no clue whether it implements the above-referenced "fallback" > behavior. For now, I would suggest trying the shim+grub2 variant, and > even Fedora 29 rather than Fedora 28: > "fedora-29-efi-grub2-x86_64.qcow2.xz". I

Re: [edk2-devel] [PATCH for-edk2-stable201905] Revert "EmulatorPkg: don't display the cpu current speed"

2019-06-05 Thread Laszlo Ersek
On 06/05/19 02:23, Liming Gao wrote: > Reviewed-by: Liming Gao Thanks, patch pushed as commit be689ecc93e5. Laszlo >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Laszlo Ersek >> Sent: Wednesday, June 05, 2019 2:59 AM >> To:

Re: [edk2-devel] [Patch V2] EmulatorPkg: don't diaplay the cpu current speed

2019-06-05 Thread Laszlo Ersek
On 06/05/19 03:10, Ni, Ray wrote: > Hi everyone, > > Hao pushed the patch because: > 1. it's a bug fix > 2. it got a R-b. > I don't think it's his fault. > > For #1, it's gap in process. > For #2, it's my fault. Because even the patch title says EmulatorPkg but the > patch itself changes

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Liming Gao
That good enough. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: Lu, XiaoyuX > Sent: Wednesday, June 5, 2019 3:51 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
Yes I verify them. build -p OvmfPkg/OvmfPkgX64.dsc -a X64 -t CLANG38 and build -p OvmfPkg/OvmfPkgIA32.dsc -a IA32 -t CLANG38 with qemu-system-x86_64 > -Original Message- > From: Gao, Liming > Sent: Wednesday, June 5, 2019 3:37 PM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Bi, Dandan

[edk2-devel] [PATCH for-edk2-stable201905] Revert "UefiPayloadPkg: Remove legacy PIC 8259 driver"

2019-06-05 Thread Liming Gao
This reverts commit a1539c46958fb896dee8f7987f4a98e9f9d10796. This change will be pushed after edk2-stable201905 Cc: Maurice Ma Cc: Guo Dong Cc: Benjamin You Signed-off-by: Liming Gao --- UefiPayloadPkg/UefiPayloadPkg.fdf| 1 + UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 +

Re: [edk2-devel] [Patch V3] edk2: Update additional licenses in Readme.md

2019-06-05 Thread Ard Biesheuvel
On Wed, 5 Jun 2019 at 03:15, Michael D Kinney wrote: > > Update the list of additional licenses in Readme.md. For additional > licenses from a git submodule, provide a link to the license file > in the remote git repository. This makes the links in Readme.md > when viewed from the edk2

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Liming Gao
Do you cover IA32 & X64 arch both, and verify Ovmf boot? > -Original Message- > From: Lu, XiaoyuX > Sent: Wednesday, June 5, 2019 3:35 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix

Re: [edk2-devel] UefiPayloadPkg: Remove legacy PIC 8259 driver

2019-06-05 Thread Liming Gao
Ard: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Wednesday, June 5, 2019 2:25 PM > To: edk2-devel-groups-io ; Ma, Maurice > ; Laszlo Ersek ; Leif > Lindholm ; Gao, Liming ; > Kinney, Michael D > Cc: Dong, Guo ;

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
Liming, > -Original Message- > From: Gao, Liming > Sent: Wednesday, June 5, 2019 3:28 PM > To: Lu, XiaoyuX ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > CLANG38 IA32 build problem > > Xiaoyu: > > >

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Liming Gao
Xiaoyu: > -Original Message- > From: Lu, XiaoyuX > Sent: Wednesday, June 5, 2019 2:34 PM > To: Gao, Liming ; devel@edk2.groups.io > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 > IA32 build problem > > Hi Liming, > > >

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix CLANG38 IA32 build problem

2019-06-05 Thread Xiaoyu Lu
Hi Liming, > -Original Message- > From: Gao, Liming > Sent: Wednesday, June 5, 2019 1:57 PM > To: devel@edk2.groups.io; Lu, XiaoyuX > Cc: Bi, Dandan ; Wang, Jian J > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg/IntrinsicLib: Fix > CLANG38 IA32 build problem > > Xiaoyu: > >