REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
Remove API specifier AreCapsulesStaged and GetScatterGatherHeadEntries
because they are internal used.
Add space between function name and bracket.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Cc: Sean Brogan
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
Rename the MACRO from MAX_SG_LIST_HEADS to DEFAULT_SG_LIST_HEADS.
GetScatterGatherHeadEntries: use allocated buffer instead of fixed
array to handle the condition which the SG list is larger then the
array size.
Cc: Jian J Wang
Cc: Hao A
v1:
Sperate the capsule check function from GetCapsuleDescriptors
and name it to AreCapsulesStaged.
Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries.
And optimize its to remove the duplicated code.
V2:
Clarify the changes of the patch and descript in the commit
message.
V3:
Add the
From: Bret Barkelew
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
Code change form Mu project:
https://github.com/microsoft/mu_basecore/blob/release/201903/
MdeModulePkg/Universal/CapsulePei/UefiCapsule.c#L801
Separate the capsule check function from GetCapsuleDescriptors
to
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1853
AreCapsulesStaged do not need to return the status, only boolean
result is useful. So directly return a boolean value.
Cannot initialize the variable at its definition.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming
Hello Ard and Leif,
I saw Ming Huang validated the patch (OS boot):
Hisilicon/D0x: Use StatusCode Router & Handler in MdeModulePkg
https://edk2.groups.io/g/devel/message/41419
(Thanks a lot for the validation effort.)
Do you have remaining concerns for review this series?
Thanks in advance.
Reviewed-by: Zhichao Gao
I would collect the R-B and send to the maintainer to push.
Thanks,
Zhichao
> -Original Message-
> From: PierreGondois [mailto:pierre.gond...@arm.com]
> Sent: Thursday, June 6, 2019 8:29 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao,
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Thursday, June 6, 2019 7:18 PM
> To: Gao, Zhichao
> Cc: devel@edk2.groups.io; Wang, Jian J ; Wu, Hao A
> ; Ni, Ray ; Zeng, Star
> ; Gao, Liming ; Sean Brogan
> ; Michael Turner
> ; Bret Barkelew
>
>
Sorry for late update.
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Friday, June 7, 2019 4:48 PM
> To: devel@edk2.groups.io
> Cc: sami.muja...@arm.com; Carsey, Jaben ; Ni,
> Ray ; Gao, Zhichao ;
> matteo.carl...@arm.com;
Pete:
The change is good. Reviewed-by: Liming Gao
In fact, I send this patch before.
https://edk2.groups.io/g/devel/message/41480?p=,,,20,0,0,0::Created,,Network,20,2,0,31819937
But, I don't get the response. Then, I think this platform is out of
maintain.
Thanks
Liming
>-Original
10 matches
Mail list logo
