Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Build cache cannot store the cache files for library package

2019-06-16 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Steven Shi Sent: Tuesday, June 11, 2019 2:33 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [edk2-devel] [PATCH v2

Re: [edk2-devel] [PATCH 2/3 V2] Platform/Intel:Add build parameter to support Binary Cache

2019-06-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Fan, ZhijuX > Sent: Monday, June 17, 2019 1:11 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Shi, Steven ; Lu, Shifei A ; > Zhou, > Bowen ; Oram, Isaac W ; > Chiu, Chasel ; Kubacki, Michael A > ; Desimone,

Re: [edk2-devel] [PATCH 1/3 V2] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

2019-06-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Fan, ZhijuX > Sent: Monday, June 17, 2019 1:10 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C ; > Shi, Steven ; Lu, Shifei A ; > Zhou, > Bowen ; Oram, Isaac W ; > Chiu, Chasel ; Kubacki, Michael A > ; Desimone,

[edk2-devel] [edk2-platforms] [patch] Platform/Intel/DebugFeaturePkg: Update PCD type

2019-06-16 Thread Dandan Bi
Add PcdAcpiDebugEnable and PcdAcpiDebugBufferSize into following section which platform can customize the type by itself. [PcdsFixedAtBuild,PcdsPatchableInModule,PcdsDynamic,PcdsDynamicEx] Cc: Eric Dong Cc: Liming Gao Signed-off-by: Dandan Bi ---

[edk2-devel] [PATCH 2/3 V2] Platform/Intel:Add build parameter to support Binary Cache

2019-06-16 Thread Fan, ZhijuX
Need extend the options in the Intel/build_bios.py file to support Binary Cache. --hash: Enable hash-based caching during build process. --binary-destination: Generate a cache of binary files in the specified directory. --binary-source: Consume a cache of binary files from the

[edk2-devel] [PATCH 1/3 V2] Intel/Readme.md:Add instructions about Binary Cache in Readme.md

2019-06-16 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1784 BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1785 Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming

[edk2-devel] [PATCH 0/3] Makes binary cache available in Platform/Intel

2019-06-16 Thread Fan, ZhijuX
Add detailed instructions about Binary Cache in Readme.md, Extend options to support Binary Cache in the Kabylake build bld.bat file, Purley build bld.bat file, build_bios.py Cc: Liming Gao Cc: Bob Feng Cc: Steven Shi Cc: Shifei A Lu Cc: Xiaohu Zhou Cc: Isaac W Oram Cc: Chasel Chiu Cc:

Re: [edk2-devel] [PATCH 3/6] MdeModulePkg/UefiBootManagerLib: Change performance code

2019-06-16 Thread Dandan Bi
> -Original Message- > From: Wu, Hao A > Sent: Friday, June 14, 2019 4:44 PM > To: Gao, Zhichao ; devel@edk2.groups.io; Bi, > Dandan ; Gao, Liming ; Ni, > Ray > Cc: Bret Barkelew ; Wang, Jian J > ; Zeng, Star > Subject: RE: [PATCH 3/6] MdeModulePkg/UefiBootManagerLib: Change >

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Chiu, Chasel
Hi Star, Since FspmArchConfigPpi.h also having Ppi postfix, we would like to align this for TemPRamExitPpi.h in IntelFsp2Pkg. Thanks! Chasel > -Original Message- > From: Zeng, Star > Sent: Monday, June 17, 2019 9:51 AM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone,

Re: [edk2-devel] [PATCH v2 1/1] BaseTools:Build Cache output notification message

2019-06-16 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: Shi, Steven Sent: Friday, June 14, 2019 7:45 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C ; Rodriguez, Christian ; Fan, ZhijuX Subject: [PATCH v2 1/1] BaseTools:Build Cache output notification message

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Ni, Ray
Chasel, I found another instance of this PPI in edk2-platforms/Silicon/Intel/KabylakeSiliconPkg/Include/Ppi. Will you remove that one after this is checked in? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chiu, > Chasel > Sent: Monday, June 17, 2019 10:42

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
Reviewed-by: Star Zeng -Original Message- From: Chiu, Chasel Sent: Monday, June 17, 2019 10:42 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Zeng, Star Subject: [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883 Add

[edk2-devel] [PATCH v2] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Chiu, Chasel
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1883 Add header file for FSP_TEMP_RAM_EXIT_PPI which is defined by FSP 2.1 spec. Test: Build successfully. Cc: Nate DeSimone Cc: Star Zeng Signed-off-by: Chasel Chiu --- IntelFsp2Pkg/Include/Ppi/TempRamExitPpi.h | 52

[edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Produce NVM Express PassThru PPI

2019-06-16 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1879 This commit will add codes to produce the NVM Express PassThru PPI. Signed-off-by: Maggie Chu Cc: Hao A Wu Cc: Jian J Wang Cc: Ray Ni Cc: Star Zeng --- MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c | 26 +++

[edk2-devel] [PATCH] MdeModulePkg: Add definitions for NVM Express Passthru PPI

2019-06-16 Thread Maggie Chu
https://bugzilla.tianocore.org/show_bug.cgi?id=1879 This commit will add the definitions of Nvm Express PassThru PPI. This PPI will provide services that allow NVM commands to be sent to NVM Express devices during PEI phase. More specifically, the PPI will provide services to: * Sends an NVM

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
And the 'Ppi' postfix seems not needed in the file name. Thanks, Star > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Zeng, Star > Sent: Sunday, June 16, 2019 9:11 PM > To: Chiu, Chasel ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ;

Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg: Refer to Shell app via its declared GUID

2019-06-16 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Saturday, June 15, 2019 4:33 AM > To: devel@edk2.groups.io; Wu, Hao A > Cc: Ni, Ray; Justen, Jordan L; Ard Biesheuvel > Subject: Re: [edk2-devel] [PATCH v3 4/4] OvmfPkg:

Re: [edk2-devel] [PATCH] SourceLevelDebugPkg: Add lacking instances for build only

2019-06-16 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, June 13, 2019 4:04 PM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Bret Barkelew; Gao, Liming; Sean Brogan; Michael Turner; Leif Lindholm > Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-discuss] WriteSections64()

2019-06-16 Thread Russell Peterson
Hi, Ard. -bash-4.2$ readelf -S /x/edk2/Build/RELEASE_GCC5/AARCH64/MdeModulePkg/Universal/Network/DpcDxe/DpcDxe/DEBUG/DpcDxe.dll There are 25 section headers, starting at offset 0x2a940: Section Headers: [Nr] Name Type Address Offset Size

Re: [edk2-devel] [PATCH] IntelFsp2Pkg: add TempRamExitPpi.h.

2019-06-16 Thread Zeng, Star
Hi Chasel, Two minor feedbacks. 1. The spec defines the return status below, should we follow it? EFI_SUCCESS FSP execution environment was initialized successfully. EFI_INVALID_PARAMETER Input parameters are invalid. EFI_UNSUPPORTED The FSP calling conditions were not met. EFI_DEVICE_ERROR