Sorry, I missed the first mail.
I saw there is no V2 tag in this series, so I think it is the first mail. My
apology.
I have no concern on FitGen - it is Intel only. You can check in at first.
FMMT/FCE is common. I think BaseTools is more proper place.
"It is not validated" - it seems a weird ju
S3Lib and RecoveryLib have been deprecated since 2009.
There is no code using AcpiS3ResumeOs() interface in S3Lib
and PeiRecoverFirmware() interface in RecoveryLib.
So they can be removed from edk2 repo.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Cc: Liming Gao
Shenglei Zhang (4):
PeiS3Lib has been deprecated since 2009 so remove it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1299
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../Library/PeiS3Lib/PeiS3Lib.c | 45 ---
.../IntelFrameworkModulePkg.dsc | 1 -
.../Library/Pe
PeiRecoveryLib has been deprecated since 2009 so remove it.
https://bugzilla.tianocore.org/show_bug.cgi?id=1299
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
.../Library/PeiRecoveryLib/PeiRecoveryLib.c | 44 --
.../IntelFrameworkModulePkg.dsc | 1 -
.../Libra
S3Lib.h and PeiS3LibNull have been deprecated since 2009, so remove them.
https://bugzilla.tianocore.org/show_bug.cgi?id=1299
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Signed-off-by: Shenglei Zhang
---
.../Library/PeiS3LibNull/PeiS3LibNull.c | 29
MdeModule
RecoveryLib.h and PeiRecoveryLibNull have been deprecated from 2009,
so remove them.
https://bugzilla.tianocore.org/show_bug.cgi?id=1299
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Ray Ni
Cc: Star Zeng
Signed-off-by: Shenglei Zhang
-SPDX-License-Identifier: BSD-2-Clause-Patent
-
-**/
-#include
-#includ
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1929
Some Linux servers do not have BC installed,so errors occur.
So the judgment was changed to avoid this error.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiju.Fan
---
edksetup.sh | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
Jiewen:
I give the comments
https://edk2.groups.io/g/devel/message/42545?p=,,,20,0,0,0::Created,,FMMT,20,2,0,32013143
for the patch BaseTools/FCE: Add a tool FCE
I give new proposal https://edk2.groups.io/g/devel/message/42546 for those
tools.
Thanks
Liming
> -Original Message-
> F
HI
I saw some conflict:
=
BaseTools/FCE: Add a tool FCE
Add FMMT and FCE into Platform/Intel/Tools.
=
I agree that FitGet goes to Intel silicon.
Should we put both FCE/FMMT to BaseTools?
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io [mailto:deve
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855
UniTool is one python script to generate UQI (Universal Question
Identifier) unicode string for HII question PROMPT string. UQI
string can be used to identify each HII question.
The scripts function will sync up UQI definitions with uni files
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855
GenBiosId is a tool to generate the BIOS ID binary file which uses
the data from the configuration file.
This tool can be run in both Py2 and Py3.
This patch is going to add GenBiosId to Platform/Intel/Tools
Cc: Liming Gao
Cc: Bob Feng
Cc:
The utility of this tool is part of build process for IA32/X64 FD.
It generates FIT table.
https://bugzilla.tianocore.org/show_bug.cgi?id=1849
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Silicon/Intel/Tools/FitGen/FitGen.c| 3137
Silicon/Intel/Too
Add FMMT, BfmLib and FCE into Makefile and GNUMakefile.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Platform/Intel/Tools/GNUmakefile | 30 +
Platform/Intel/Tools/Makefile| 33
2 files changed, 63 insertions(+)
Add FitGen into Makefile and GNUMakefile.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Shenglei Zhang
---
Silicon/Intel/Tools/GNUmakefile | 34 +
Silicon/Intel/Tools/Makefile| 31 ++
2 files changed, 65 insertions(+)
create mode 10
Add FMMT and FCE into Platform/Intel/Tools.
Add FitGen into Silicon/Intel/Tools.
https://bugzilla.tianocore.org/show_bug.cgi?id=1847
https://bugzilla.tianocore.org/show_bug.cgi?id=1848
https://bugzilla.tianocore.org/show_bug.cgi?id=1849
Cc: Bob Feng
Cc: Liming Gao
Shenglei Zhang (6):
Platform/
Push @425d8d487fe20e76281fd7da074592508d03f9c0
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Thursday, June 20, 2019 10:50 PM
> To: Gao, Liming ; Kinney, Michael D
> ; devel@edk2.groups.io
> Cc: Sami Mujawar ; nd
> Subject: RE: [edk2-devel] [PATCH v1
Thanks Leif to point out.
Other comment:
Would you please describe the delta between v1, v2 and v3?
I have reviewed the v1. Please share with us on what is updated in v2 and v3.
Thank you
Yao Jiewen
> -Original Message-
> From: Leif Lindholm [mailto:leif.lindh...@linaro.org]
> Sent: Th
We can review for your code change. And for our personal point, the change is
OK.
But we can't verify this patch on our platform. For the patch which is not, it
is better to do a test and get a tested-by from someone.
Thanks,
Zhichao
> -Original Message-
> From: Krzysztof Koch [mailto:k
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> rebe...@bluestop.org
> Sent: Friday, June 21, 2019 6:24 AM
> To: devel@edk2.groups.io; Wu, Hao A
> Cc: ler...@redhat.com; Leif Lindholm; Kinney, Michael D; Andrew Fish;
> Justen, Jordan L; Ard Bie
On Thu, 2019-06-20 at 16:46 +0200, Laszlo Ersek wrote:
> > Please submit a PR to OpenSSL to add 'no-store' if you really don't
> > want it.
>
> I actually agree about "no-store"; please see point (1) in my earlier
> review here:
>
> 0c5b5e95-cb2c-75af-a30b-015dac14b91c@redhat.com">http://mid.mail
On 2019-06-10 02:06, Wu, Hao A wrote:
> Hello all,
>
> Driven by the issue raised and discussions with thread:
> https://edk2.groups.io/g/devel/topic/31907735#42076
>
> This RFC proposal is raised to work out a fine-grained review ownership
> for MdeModulePkg.
Being an RFC, I think this should be
On 06/20/19 19:32, David Woodhouse wrote:
> On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote:
>> If it's possible, please write a non-empty commit message body, for each
>> patch in this series. Just one sentence on this patch would be nice.
>
>
> The comnit comment isn't empty. It has one s
On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
>
> Also, fix a small typo.
>
> This fixes bug 447:
>
> https://bugzilla.tianocore.org/show_bug.cgi?id=447
>
> Signed-off-by: Stepha
On Thu, 2019-06-20 at 18:12 +0200, Laszlo Ersek wrote:
> If it's possible, please write a non-empty commit message body, for each
> patch in this series. Just one sentence on this patch would be nice.
The comnit comment isn't empty. It has one sentence "LegacyBios: set
NumberBbsEntries to the siz
On 06/19/19 07:51, Dong, Eric wrote:
> Add MM Mp Protocol in PiSmmCpuDxeSmm driver.
>
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Eric Dong
> ---
> UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.c | 375 +++
> UefiCpuPkg/PiSmmCpuDxeSmm/MpProtocol.h | 283 +++
> UefiC
On 06/19/19 07:51, Dong, Eric wrote:
> PI spec added a new protocol named MM MP protocol. This protocol allows
> for better remote queuing of execution of procedures on an AP.
> This extends the existing procedures to allow:
> 1. A function to be called in blocking and non-blocking manner explicitl
Hi Eric,
On 06/19/19 07:51, Dong, Eric wrote:
> EFI MM MP Protocol is defined in the PI 1.7 specification.
I can only offer regression-testing for this series. I'll report back
with such results hopefully soon.
Regarding the above sentence. I think we should clarify it. The MM MP
protocol is pre
On 06/19/19 14:44, David Woodhouse wrote:
> Signed-off-by: David Woodhouse
> ---
> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> b/OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c
> index 05e3ffd2bb
On Thu, 2019-06-20 at 16:41 +0200, Laszlo Ersek wrote:
> On 06/20/19 10:59, David Woodhouse wrote:
> > On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote:
> > > In 2013, you submitted the following patch:
> > >
> > > OvmfPkg: Don't build in QemuVideoDxe when we have CSM
> > >
> > > The threa
On Thu, Jun 20, 2019 at 05:29:55PM +0200, Laszlo Ersek wrote:
> Hi Leif,
>
> On 06/14/19 22:21, Leif Lindholm wrote:
> > Add Ard and Leif as responsible for any path matching
> > F: */Arm/
> > F: */AArch64/
> >
> > Signed-off-by: Leif Lindholm
> > ---
> > Maintainers.txt | 8
> > 1 fil
On 06/19/19 11:35, Leif Lindholm wrote:
> On Wed, Jun 19, 2019 at 05:09:40AM +, Wu, Hao A wrote:
>> Hello all,
>>
>> As suggested by Ray and Leif, modules (with wildcard) in MdeModulePkg are
>> classified to a list of features.
>>
>> Please note that:
>> * The below list is a draft at this mome
Hi Leif,
On 06/14/19 22:21, Leif Lindholm wrote:
> Add Ard and Leif as responsible for any path matching
> F: */Arm/
> F: */AArch64/
>
> Signed-off-by: Leif Lindholm
> ---
> Maintainers.txt | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> ind
On Thu, Jun 20, 2019 at 05:13:53PM +0200, Laszlo Ersek wrote:
> On 06/14/19 22:21, Leif Lindholm wrote:
> > Add comment describing new F: and X: tags for associating maintainership
> > sections with specific filesystem paths, including wildcards.
> >
> > Add global section associating *all* code w
On Thu, 2019-06-20 at 16:27 +0200, Laszlo Ersek wrote:
> It is indeed the bug that you think it is ("From code inspection I'd
> have guessed that the code would tolerate *any* valid certificate, even
> for a host other than the one it actually attempted to connect to.")
:)
> I'm CC'ing you on the
Hi Leif,
On 06/14/19 22:21, Leif Lindholm wrote:
> Changes are available directly from:
> https://git.linaro.org/people/leif.lindholm/edk2.git/log/?h=upstreaming/git-maintainer-rfc
>
> This series adds new tags to the Maintainers.txt format, making it possible
> to describe which filesystem paths
On 06/14/19 22:21, Leif Lindholm wrote:
> Add comment describing new F: and X: tags for associating maintainership
> sections with specific filesystem paths, including wildcards.
>
> Add global section associating *all* code with devel@edk2.groups.io,
> and add a magic '' F: tag directing all modi
Adding maintainers to cc.
Hi Imran,
On Tue, Jun 18, 2019 at 07:27:54PM -0700, Imran Desai wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
>
> EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
> banks. This digest algorithm is part of the China Crypto alg
Hi,
Is there any way I can help to get this patch merged upstream?
Kind regards,
Krzysztof
-Original Message-
From: devel@edk2.groups.io On Behalf Of Carsey, Jaben
via Groups.Io
Sent: Wednesday, June 12, 2019 21:58
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Ni, Ray ; Gao, Zhichao ;
Hi,
Do you need any help from me to get this patch merged?
Kind regards,
Krzysztof
-Original Message-
From: Gao, Liming
Sent: Thursday, June 13, 2019 13:05
To: devel@edk2.groups.io; Krzysztof Koch
Cc: Carsey, Jaben ; Ni, Ray ; Gao,
Zhichao ; Kinney, Michael D
; Sami Mujawar ; Matt
On 06/20/19 09:54, David Woodhouse wrote:
> On Wed, 2019-06-19 at 03:19 -0400, Xiaoyu Lu wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881
>>
>> Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure
>> remove useless file in OpensslLib[Crypto].inf,
>> but we use process_files.py to g
Reviewed-by: Bob Feng
-Original Message-
From: Fan, ZhijuX
Sent: Thursday, June 20, 2019 2:08 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C
Subject: [PATCH] BaseTools:Add import in FvImageSection
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1872
Since MultipleWorkspa
On 06/20/19 10:59, David Woodhouse wrote:
> On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote:
>> In 2013, you submitted the following patch:
>>
>> OvmfPkg: Don't build in QemuVideoDxe when we have CSM
>>
>> The thread starts here:
>>
>> https://www.mail-archive.com/edk2-devel@lists.sourcef
Hello David,
On 06/20/19 14:35, David Woodhouse wrote:
> On Thu, 2019-06-20 at 11:27 +, Sivaraman Nainar wrote:
>> This support added when we integrating "TianoCore Bug 960
>> (HTTPS_HostName_Validation)". This has the support for performing
>> Host Name validation during HTTP Operations.
>
>
On Thu, 2019-06-20 at 14:57 +0200, Laszlo Ersek wrote:
> (updating Ray's email)
>
> On 06/20/19 00:19, David Woodhouse wrote:
> >
> > > the driver is thoroughly commented. See especially the
> > > DriverInitialize() function. Can you determine which one(s) of those
> > > statements doesn't / don'
(updating Ray's email)
On 06/20/19 00:19, David Woodhouse wrote:
>
>> the driver is thoroughly commented. See especially the
>> DriverInitialize() function. Can you determine which one(s) of those
>> statements doesn't / don't hold any longer?
>>
>> Or maybe IncompatiblePciDeviceSupportDxe works
On Thu, 2019-06-20 at 11:27 +, Sivaraman Nainar wrote:
> This support added when we integrating "TianoCore Bug 960
> (HTTPS_HostName_Validation)". This has the support for performing
> Host Name validation during HTTP Operations.
Hm, I can't see bug 960, at least not without and account — and
Hello :
This support added when we integrating "TianoCore Bug 960
(HTTPS_HostName_Validation)". This has the support for performing Host Name
validation during HTTP Operations.
-Siva
-Original Message-
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of David
Woodhous
On Wed, 2019-06-19 at 11:51 +, Sivaraman Nainar wrote:
> Can you please help to confirm the behavior
>
> From: Sivaraman Nainar
> Sent: Friday, June 7, 2019 2:48 PM
> To: devel@edk2.groups.io
> Subject: reg: Multiple Host Name Certificate
>
> Hello:
>
> Can someone help to confirm if EDK2 supp
On Thu, Jun 20, 2019 at 03:45:43PM +0800, Liming Gao wrote:
> Based on the proposal https://edk2.groups.io/g/devel/message/42546,
> Platform/Intel/Tools and Silicon/Intel/Tools directory will be created to
> include some tools for the platform integration. Now, those tools are used
> and verified b
On Wed, 2019-06-19 at 23:57 +0200, Laszlo Ersek wrote:
> In 2013, you submitted the following patch:
>
> OvmfPkg: Don't build in QemuVideoDxe when we have CSM
>
> The thread starts here:
>
> https://www.mail-archive.com/edk2-devel@lists.sourceforge.net/msg01871.html
>
> After an update:
>
On Wed, 2019-06-19 at 03:19 -0400, Xiaoyu Lu wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881
>
> Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure
> remove useless file in OpensslLib[Crypto].inf,
> but we use process_files.py to generate files.
> So exclude err_all.c file in pr
Based on the proposal https://edk2.groups.io/g/devel/message/42546,
Platform/Intel/Tools and Silicon/Intel/Tools directory will be created to
include some tools for the platform integration. Now, those tools are used
and verified by Intel platform.
Signed-off-by: Liming Gao
Cc: Ard Biesheuvel
Cc
52 matches
Mail list logo