Re: [edk2-devel] [PATCH V3] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-23 Thread Bob Feng 
Hi Zhiju,

+with open(LogPath, 'w+') as log:
+  for line in content:
+log.write(line)
+print("Log save to file: %s" % LogPath)
+log.close()

log.close() is not correct.

Others are fine for me.

Thanks,
Bob

-Original Message-
From: Fan,

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-23 Thread rebecca
On 2019-06-20 20:33, Fan, ZhijuX wrote: > - ret=`echo "$origin_version < $python_version" |bc` > - if [ "$ret" -eq 1 ]; then > + if [ "$origin_version" \< "$python_version" ]; then > origin_version=$python_version > export PYTHON_COMMAND=$python >fi I

Re: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-23 Thread Liming Gao
Zhiju: The change is good. What test have you done? Thanks Liming > -Original Message- > From: Fan, ZhijuX > Sent: Friday, June 21, 2019 10:33 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] BaseTools:Linux changes the way the latest version is judged >

Re: [edk2-devel] [PATCH] BaseTools:Remove unused Edk2\BuildNotes2.txt

2019-06-23 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Fan, ZhijuX > Sent: Tuesday, June 18, 2019 2:55 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Feng, Bob C > Subject: [PATCH] BaseTools:Remove unused Edk2\BuildNotes2.txt > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1889

Re: [edk2-devel] [PATCH] MdeModulePkg/PeiMain: Substantial change for PeiAllocatePool

2019-06-23 Thread Wu, Hao A
> -Original Message- > From: Gao, Liming > Sent: Tuesday, June 18, 2019 1:16 PM > To: Wu, Hao A; devel@edk2.groups.io; ler...@redhat.com; Gao, Zhichao > Cc: Bret Barkelew; Wang, Jian J; Ni, Ray; Zeng, Star; Sean Brogan; Michael > Turner > Subject: RE: [edk2-devel] [PATCH]

[edk2-devel] [Patch 2/2] BaseTools: Move Build Cache related function out of CreateAsBuiltInf

2019-06-23 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1932 There are two functions in current CreateAsBuiltInf, Copy Binary files to build cache folder and create asbuild inf file. This patch is to separate UpdateBuildCache and CreateAsBuiltInf into two functions. Signed-off-by: Bob Feng Cc:

[edk2-devel] [Patch 1/2] BaseTools: refine CreateAsBuiltInf function

2019-06-23 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1932 ModuleAutogen.CreateAsBuiltInf IsOnlyCopy parameter and related function can be moved out of CreateAsBuiltInf, so that CreateAsBuiltInf is more clean. Cc: Liming Gao Cc: Steven Shi Cc: Christian Rodriguez Signed-off-by: Bob Feng ---

[edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

2019-06-23 Thread Bob Feng
https://bugzilla.tianocore.org/show_bug.cgi?id=1932 In current implementation, there are 2 functions in CreateAsBuiltInf, one is create asbuildinf, the other is update build cache. They should be separated. Feng, Bob C (2): BaseTools: refine CreateAsBuiltInf function BaseTools: Move Build

Re: [edk2-devel] [PATCH v5 0/5] MdeModulePkg/CapsulePei: Optimize the CapsulePei

2019-06-23 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Thursday, June 13, 2019 3:49 PM > To: Gao, Zhichao; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew; Leif

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-23 Thread Wu, Hao A
Hello all, With Leif's comment on the better usage of the wildcard character & 'X:' tag: https://edk2.groups.io/g/devel/message/42587 The list is updated as shown below. Also, I forgot to mention that some directory/file may be classified into multiple classes. I think it is a valid case, for

Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei: Produce NVM Express PassThru PPI

2019-06-23 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, June 18, 2019 8:34 PM > To: devel@edk2.groups.io; Chu, Maggie > Cc: Wang, Jian J; Ni, Ray; Zeng, Star > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/NvmExpressPei:

Re: [edk2-devel] [PATCH] MdeModulePkg: Add definitions for NVM Express Passthru PPI

2019-06-23 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Wu, Hao A > Sent: Tuesday, June 18, 2019 8:34 PM > To: Chu, Maggie; devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg: Add definitions

[edk2-devel] [patch 0/2] Edk2Setup: Enahnce edk2setup batch files

2019-06-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693 Patch 1 remove nt32 related flags in bat files. Patch 2 setup for different VS tool chains. Cc: Bob Feng Cc: Liming Gao Dandan Bi (2): Edk2: Remove nt32 related flag in bat files Edk2Setup: Support different VS tool chain setup

[edk2-devel] [patch 2/2] Edk2Setup: Support different VS tool chain setup

2019-06-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693 This patch is to update edksetup with additional option: VS2017 VS2015 VS2013 VS2012 to setup different VS environment. And will report error if the specified VS tool is not installed. For VS2017, also consider the case that only VS2017

[edk2-devel] [patch 1/2] Edk2Setup: Remove nt32 related flag in bat files

2019-06-23 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1693 NT32Pkg has been removed, remove nt32 related flags in bat files. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Dandan Bi --- BaseTools/toolsetup.bat | 8 edksetup.bat| 23 +-- 2 files changed, 1