[edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Add memory pointer check

2019-06-24 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1935 Before use the memory that is allocated through AllocateZeroPool, we should check the memory pointer is valid to avoid using the NULL pointer. Add check for VariableArrayAddress that is returned from GetScatterGatherHeadEntries. If it is

Re: FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-24 Thread rebecca
On 2019-06-24 20:18, Fan, ZhijuX wrote: > Using "-lt" will report the following errors, but "\<" will not > 3.6: integer expression expected > 3.7: integer expression expected > > if [[ "$origin_version" < "$python_version" ]];then > It is equivalent to > if [ "$origin_version" \<

FW: [edk2-devel] [PATCH] BaseTools:Linux changes the way the latest version is judged

2019-06-24 Thread Fan, ZhijuX
Using "-lt" will report the following errors, but "\<" will not 3.6: integer expression expected 3.7: integer expression expected if [[ "$origin_version" < "$python_version" ]];then It is equivalent to if [ "$origin_version" \< "$python_version" ];then These two approaches work Any question,

Re: [edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: Enable MM MP Protocol.

2019-06-24 Thread Dong, Eric
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Friday, June 21, 2019 12:45 AM > To: devel@edk2.groups.io; Dong, Eric > Cc: Ni, Ray > Subject: Re: [edk2-devel] [Patch 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: > Enable MM MP

Re: [edk2-devel] [PATCH 4/7] MdeModulePkg/UefiBootManagerLib: export EfiBootManagerGetBootDescription()

2019-06-24 Thread Ni, Ray
David, I am afraid it will cause issues when exposing EfiBootManagerGetBootDescription(). If you check the implementation, this API visits mPlatformBootDescriptionHandlers. mPlatformBootDescriptionHandlers is modified by another already-exposed API EfiBootManagerRegisterBootDescriptionHandler().

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling

2019-06-24 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Monday, June 24, 2019 7:39 PM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Wu, Hao A > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix > unaligned data transfer handling > > Test info: > > Tested UFS

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection

2019-06-24 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Monday, June 24, 2019 7:33 PM > To: devel@edk2.groups.io; Albecki, Mateusz > Cc: Wu, Hao A > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: > Refactor UFS device presence detection > > Test info: > > Tested device

Re: [edk2-devel] [PATCH 6/7] MdeModulePkg/UefiBootManagerLib: describe VirtIO devices correctly

2019-06-24 Thread Ni, Ray
> > > In general I think this approach is viable; at the worst we might have to gate > the code with a Feature PCD. Let's see what Ray says. > > Thanks > Laszlo > > > +Description = L"VirtIO Device"; > > +break; > > + } > > } > > + > > +Description = L"Misc

Re: [edk2-devel] [Patch 0/2] Remove IntelSiliconPkg that has been moved to edk2-platform repo

2019-06-24 Thread Liming Gao
Push @ 370f16c5489609062d8ee0940f29f6c3393f1b68..48c921a79f0fbb477046cf3b0bf71a2dd42e0c74 >-Original Message- >From: Chaganty, Rangasai V >Sent: Tuesday, June 18, 2019 2:00 PM >To: Gao, Liming ; Ni, Ray >Cc: devel@edk2.groups.io >Subject: RE: [Patch 0/2] Remove IntelSiliconPkg that has

Re: [edk2-devel] [PATCH 7/7] OvmfPkg: don't assign PCI BARs above 4GiB when CSM enabled

2019-06-24 Thread Laszlo Ersek
On 06/22/19 00:31, David Woodhouse wrote: > Mostly, this is only necessary for devices that the CSM might have > native support for, such as VirtIO and NVMe; PciBusDxe will already > degrade devices to 32-bit if they have an OpROM. > > However, there doesn't seem to be a generic way of requesting

Re: [edk2-devel] [PATCH 6/7] MdeModulePkg/UefiBootManagerLib: describe VirtIO devices correctly

2019-06-24 Thread Laszlo Ersek
On 06/22/19 00:31, David Woodhouse wrote: > I know, I said it was Someone Else's Problem. But it annoyed me. > > My initial thought was to look for VIRTIO_DEVICE_PROTOCOL on the same > handle but I don't think I can do that if I can't rely on VirtIO being > present in the build. This will do. >

Re: [edk2-devel] [PATCH 5/7] OvmfPkg/LegacyBiosDxe: Use EfiBootManagerGetBootDescription()

2019-06-24 Thread Laszlo Ersek
On 06/22/19 00:31, David Woodhouse wrote: > No longer call all NVMe & VirtIO devices just "Harddisk". Admittedly, > VirtIO disks are now just called 'Misc Device' instead, but at least > that is now Someone Else's Problem™. > > Signed-off-by: David Woodhouse > --- >

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-24 Thread Yao, Jiewen
thanks How about to put driversample to ui? How about to put iommu to device? thank you! Yao, Jiewen > 在 2019年6月25日，上午4:30，Laszlo Ersek 写道： > >> On 06/24/19 03:16, Wu, Hao A wrote: >> Hello all, >> >> With Leif's comment on the better usage of the wildcard character & 'X:' tag: >>

Re: [edk2-devel] [PATCH 2/7] OvmfPkg/LegacyBbs: Add boot entries for VirtIO and NVME devices

2019-06-24 Thread Laszlo Ersek
On 06/22/19 00:31, David Woodhouse wrote: > Iterate over the available block devices in much the same way as > BdsLibEnumerateAllBootOption() does, but limiting to those devices > which are PCI-backed, which can be represented in the BbsTable. > > One day we might need to extend the BbsTable to

Re: [edk2-devel] [PATCH 4/7] MdeModulePkg/UefiBootManagerLib: export EfiBootManagerGetBootDescription()

2019-06-24 Thread Laszlo Ersek
On 06/22/19 00:31, David Woodhouse wrote: > It would be useful for LegacyBiosDxe to be able to get descriptive names > for block devices, for legacy boot options. It gets a bit confusing when > they're all called "Harddisk". > > Since we have a collection of the special cases for various types of

Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-24 Thread Laszlo Ersek
On 06/25/19 00:08, Laszlo Ersek wrote: > On 06/21/19 12:59, David Woodhouse wrote: >> Adding a generic way for block devices to report a human-readable >> description in order to kill off all the device-type-specific functions >> in BmBootDescription.c presumably *would* involve actually

Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-24 Thread Laszlo Ersek
On 06/21/19 12:59, David Woodhouse wrote: > On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote: I think your note on patch#2 is valuable too and should be captured in the commit message body. Please consider formulating it with a bit more neutral tone :) >>> >>> I would prefer to

Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-24 Thread Laszlo Ersek
On 06/24/19 13:48, David Woodhouse wrote: > On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote: >> My past mistake doesn't excuse the current commit message ;) >> >> Anyway, I intentionally didn't ask for just repeating the commit msg >> title in the commit msg body. You could mention why the

Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-06-24 Thread Laszlo Ersek
(+Mike) On 06/24/19 17:53, Tomas Pilar (tpilar) wrote: > Switching to this library enables capsule support for FMP devices. > This will allow testing of FMP for PCI devices using OVMF and PCI > passthrough as well as software parts of the FMP API. > > Simple tests show that a capsule with an

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Move checksum part for valid microcode data

2019-06-24 Thread Laszlo Ersek
On 06/24/19 08:14, Zhichao Gao wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1934 > > Originally, the checksum part would done before verfiy the microcode > data. Which meas the checksum would be done for a meaningless data. > It would cause a incorrect TotalSize (the size of

Re: [edk2-devel] [RFC] Fine-grained review ownership for MdeModulePkg

2019-06-24 Thread Laszlo Ersek
On 06/24/19 03:16, Wu, Hao A wrote: > Hello all, > > With Leif's comment on the better usage of the wildcard character & 'X:' tag: > https://edk2.groups.io/g/devel/message/42587 > > The list is updated as shown below. > > Also, I forgot to mention that some directory/file may be classified into

Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py

2019-06-24 Thread Laszlo Ersek
On 06/21/19 10:37, Wang, Jian J wrote: > Hi David, > > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of David >> Woodhouse >> Sent: Friday, June 21, 2019 6:34 AM >> To: devel@edk2.groups.io; ler...@redhat.com; Lu, XiaoyuX >> >> Cc: Wang,

[edk2-devel] [PATCH] ArmVirtPkg: handle NETWORK_TLS_ENABLE in ArmVirtQemu*

2019-06-24 Thread Laszlo Ersek
Port the [LibraryClasses], [PcdsFixedAtBuild] and [Components] settings that are related to NETWORK_TLS_ENABLE from OvmfPkg to ArmVirtPkg. ArmVirtXen is not modified because it doesn't include the edk2 network stack. (This change is now simpler than it would have been when TianoCore#1009 was

Re: [edk2-devel] [PATCH v3 2/5] SecurityPkg: introduce the SM3 digest algorithm

2019-06-24 Thread Imran Desai
Hello Jiewen, v1 was the first attempt to send in the patch for enabling SM3 measured boot. v2 addresses the review comments from https://www.mail-archive.com/devel@edk2.groups.io/msg02412.html v3 addresses the review comments from https://www.mail-archive.com/devel@edk2.groups.io/msg03358.html

[edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-06-24 Thread Tomas Pilar (tpilar)
Switching to this library enables capsule support for FMP devices. This will allow testing of FMP for PCI devices using OVMF and PCI passthrough as well as software parts of the FMP API. Simple tests show that a capsule with an embedded driver now updates using CapsuleApp. Cc: Jordan Justen Cc:

Re: [edk2-devel] [Patch 0/2] BaseTools: Separate current CreateAsBuiltInf function into two

2019-06-24 Thread Carsey, Jaben
Reviewed-by: Jaben Carsey Much clearer code to see what's actually happening. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Bob Feng > Sent: Sunday, June 23, 2019 6:51 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch 0/2]

[edk2-devel] [PATCH] MinPlatformPkg: FSP Python script to python 3.x.

2019-06-24 Thread Chiu, Chasel
https://bugzilla.tianocore.org/show_bug.cgi?id=1930 Updated FSP Python script to support both 2.x and 3.x. Test: . Verified with Python 2.7.12 and 3.6.6. . Verified tool result is the same before the change. . Both py -2 and py -3 built binary can boot. Cc: Michael Kubacki Cc: Nate

[edk2-devel] [PATCH] IntelFsp2Pkg: FSP Python scripts to support 3.x.

2019-06-24 Thread Chiu, Chasel
https://bugzilla.tianocore.org/show_bug.cgi?id=1930 Updated FSP Python scripts to support both 2.x and 3.x. Test: . Verified with Python 2.7.12 and 3.6.6. . Verified tool result is the same before the change. . Both py -2 and py -3 built binary can boot. Cc: Maurice Ma Cc: Nate DeSimone

Re: [edk2-devel] [PATCH V4] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-24 Thread Bob Feng 
Reviewed-by: Bob Feng 

-Original Message-
From: Fan, ZhijuX 
Sent: Monday, June 24, 2019 6:26 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C 
Subject: [PATCH V4] BaseTools:Add DetectNotUsedItem.py to

Re: [edk2-devel] [edk2] [PATCH] OvmfPkg: QemuVideoDxe: Int10h stub for Windows 2008 R2 SP1 (stdvga, QXL)

2019-06-24 Thread David Woodhouse
On Thu, 2019-06-20 at 16:41 +0200, Laszlo Ersek wrote: > We've never merged pull requests before, but I remember that you prefer > those (because you dislike an edk2 subsys maintainer rebasing your > branch from your original fork-off point). So I'm not asking for the > patch email because I

Re: [edk2-devel] [PATCH 1/2] LegacyBios: set NumberBbsEntries to the size of BbsTable

2019-06-24 Thread David Woodhouse
On Thu, 2019-06-20 at 22:35 +0200, Laszlo Ersek wrote: > My past mistake doesn't excuse the current commit message ;) > > Anyway, I intentionally didn't ask for just repeating the commit msg > title in the commit msg body. You could mention why the pre-patch > expression (1 + 2 *

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Fix unaligned data transfer handling

2019-06-24 Thread Albecki, Mateusz
Test info: Tested UFS enumeration in EFI shell and it is passing on real HW with Samsung device. Tested read/write to UFS device in EFI shell. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Albecki, Mateusz > Sent: Friday, June 21, 2019

[edk2-devel] [edk2-platform patch V2] Platform/Intel:Add UniTool into edk2-platforms/Platform/Intel/Tools

2019-06-24 Thread Fan, ZhijuX
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1855 UniTool is one python script to generate UQI (Universal Question Identifier) unicode string for HII question PROMPT string. UQI string can be used to identify each HII question. The scripts function will sync up UQI definitions with uni files

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Refactor UFS device presence detection

2019-06-24 Thread Albecki, Mateusz
Test info: Tested device presence detection before and after change on real hardware. No functional change in UFS detection. > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Albecki, Mateusz > Sent: Friday, June 21, 2019 5:27 PM > To:

Re: [edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-06-24 Thread Tomas Pilar (tpilar)
On 24/06/2019 12:15, Ard Biesheuvel wrote: > On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: >> Switching to this library enables capsule support for FMP devices. Simple >> tests show that a capsule with an embedded driver now updates using >> CapsuleApp. >> >> Cc: Jordan Justen >> Cc:

Re: [edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-06-24 Thread Ard Biesheuvel
On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote: > > Switching to this library enables capsule support for FMP devices. Simple > tests show that a capsule with an embedded driver now updates using > CapsuleApp. > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Signed-off-by:

[edk2-devel] [PATCH v1] OvmfPkg: Use DxeRuntimeCapsuleLib from DxeCapsuleLibFmp in X64 builds

2019-06-24 Thread Tomas Pilar (tpilar)
Switching to this library enables capsule support for FMP devices. Simple tests show that a capsule with an embedded driver now updates using CapsuleApp. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Tomas Pilar --- OvmfPkg/OvmfPkgX64.dsc | 2 +- 1 file changed, 1

[edk2-devel] [PATCH V4] BaseTools:Add DetectNotUsedItem.py to Edk2\BaseTools\Scripts

2019-06-24 Thread Fan, ZhijuX 
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1850

This script is used to Detect unreferenced PCD and GUID/Protocols/PPIs.
The input parameters are Dec file and package directory.

This script can be run in

Re: [edk2-devel] [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-24 Thread Wu, Hao A
> -Original Message- > From: Wu, Hao A > Sent: Monday, June 24, 2019 4:15 PM > To: Albecki, Mateusz; devel@edk2.groups.io > Subject: RE: [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement > revision 3 of SdMmcOverrideProtocol > > > -Original Message- > > From: Albecki, Mateusz > >

Re: [edk2-devel] [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

2019-06-24 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Friday, June 21, 2019 11:12 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCH v3 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision > 3 of SdMmcOverrideProtocol > > From: "Albecki, Mateusz" Hello, Some

Re: [edk2-devel] [PATCH v3 1/2] MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase

2019-06-24 Thread Wu, Hao A
> -Original Message- > From: Albecki, Mateusz > Sent: Friday, June 21, 2019 11:12 PM > To: devel@edk2.groups.io > Cc: Albecki, Mateusz; Wu, Hao A > Subject: [PATCH v3 1/2] MdeModulePkg/SdMmcOverride: Add > GetOperatingParam notify phase > >

Re: [edk2-devel] [Patch 2/2] BaseTools: Move Build Cache related function out of CreateAsBuiltInf

2019-06-24 Thread Steven Shi
Reviewed-by: Steven Shi > -Original Message- > From: Feng, Bob C > Sent: Monday, June 24, 2019 9:52 AM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Shi, Steven ; > Gao, Liming ; Rodriguez, Christian > > Subject: [Patch 2/2] BaseTools: Move Build Cache related function out of >

Re: [edk2-devel] [Patch 1/2] BaseTools: refine CreateAsBuiltInf function

2019-06-24 Thread Steven Shi
Reviewed-by: Steven Shi > -Original Message- > From: Feng, Bob C > Sent: Monday, June 24, 2019 9:51 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Shi, Steven ; > Rodriguez, Christian ; Feng, Bob C > > Subject: [Patch 1/2] BaseTools: refine CreateAsBuiltInf function > > BZ:

[edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Move checksum part for valid microcode data

2019-06-24 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1934 Originally, the checksum part would done before verfiy the microcode data. Which meas the checksum would be done for a meaningless data. It would cause a incorrect TotalSize (the size of microcode data), then incorrect checksum and