On 2019-07-29 19:24:00, wrote:
> On 2019-07-24 16:56, Jordan Justen wrote:
> > Reviewed-by: Jordan Justen
> >
> > On 2019-07-24 14:44:05, Rebecca Cran wrote:
> >> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
> >> disk. Since newer versions run without any disks, remove
Yes, we will remove them later after confirming no impact to all platforms.
Regards,
Chasel
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, July 30, 2019 11:46 AM
> To: Chiu, Chasel ; devel@edk2.groups.io
> Cc: Kubacki, Michael A ; Sinha, Ankit
> ; Desimone, Nathaniel L
>
>
Mike:
OK. If so, the consumer code also need to obviously include vendor header
file, such as #include . Right?
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, July 30, 2019 11:42 AM
> To: Gao, Liming ; Ni, Ray ;
> devel@edk2.groups.io; Kinney, Michael D
Chasel:
This is a good enhancement. With this change, can
RebaseAndPatchFspBinBaseAddress.py and PatchFspBinFvsBaseAddress.py be removed?
Thanks
Liming
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, July 29, 2019 7:07 PM
> To: devel@edk2.groups.io
> Cc: Kubacki, Michael A ;
Liming,
There is an unresolved discussion on the location of this
file in the MdePkg. I prefer a vendor name in the path.
MdePkg/Include/Register/Intel/Cpuid.h
Also, after this file is moved to MdePkg, we can enter
new BZs to update all the modules that call AsmCpuid and
AsmCpuidEx to use
The change is good to me. Reviewed-by: Liming Gao
> -Original Message-
> From: Ni, Ray
> Sent: Wednesday, July 24, 2019 6:00 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Dong, Eric ; Laszlo
> Ersek
> Subject: [PATCH V2 5/6] MdePkg/Cpuid.h: Move Cpuid.h from
For this patch, I am OK to add it into edk2-staging/UEFI_PCI_ENHANCE-2 first,
and for further discussion.
Thanks
Liming
> -Original Message-
> From: Javeed, Ashraf
> Sent: Monday, July 29, 2019 10:40 PM
> To: Yao, Jiewen ; devel@edk2.groups.io; Gao, Liming
>
> Cc: Kinney, Michael D ;
Reviewed-by: Liming Gao
> -Original Message-
> From: Chen, Marc W
> Sent: Monday, July 29, 2019 4:41 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Ni, Ray
> Subject: [PATCH V3] MdePkg: Add PI 1.5 SmramMemoryReserve HOB file
>
> This is a special GUID
On 2019-07-24 16:56, Jordan Justen wrote:
> Reviewed-by: Jordan Justen
>
> On 2019-07-24 14:44:05, Rebecca Cran wrote:
>> $ADD_QEMU_HDA was added because QEMU used to refuse to run without a
>> disk. Since newer versions run without any disks, remove it.
>>
>> Signed-off-by: Rebecca Cran
Hi Phil,
Thanks for your comments. I agree it will be easier to review if this patch is
split into multiple smaller ones.
Since the later patches in Multiple-process autogen patch series are based on
this patch. It will be bigger effort to recreate this whole patch series. So
I'd like to
Reviewed-by: Jian J Wang
> -Original Message-
> From: Gao, Zhichao
> Sent: Tuesday, July 30, 2019 9:48 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [PATCH] CryptoPkg/BaseCryptLib: Use cmp-operator for non-
> Boolean comparisons
>
> REF:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2027
Refer to CSS_2_1 5.7.2.1 "Non-Boolean comparisons must use a
compare operator (==, !=, >, < >=, <=).", use compare operator
for the non-boolean comparisons.
Cc: Jian Wang
Cc: Ting Ye
Signed-off-by: Zhichao Gao
---
Philippe:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Philippe Mathieu-Daudé
> Sent: Tuesday, July 30, 2019 1:49 AM
> To: Laszlo Ersek ; devel@edk2.groups.io; Xu, Wei6
>
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: Re:
Thanks for the good catch!
I have corrected BZ and will update subject from next patch.
Thanks!
Chasel
> -Original Message-
> From: Laszlo Ersek [mailto:ler...@redhat.com]
> Sent: Monday, July 29, 2019 9:47 PM
> To: devel@edk2.groups.io; Chiu, Chasel
> Cc: Kubacki, Michael A ; Sinha,
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Agyeman, Prince
> Sent: Tuesday, July 30, 2019 2:05 AM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
> ; Kubacki, Michael A
> ; Kinney,
Hi Nate,
Reviewed-by: Michael D Kinney
Overall, the series looks good. There are some minor issues
in the commit messages:
* "reviewed-by" should be "Reviewed-by"
* Names should first name then last name with no commas.
* Subject should contain package/module followed by the brief
Cc: Ankit Sinha
Cc: Nate DeSimone
Cc: Michael Kubacki
Cc: Michael D Kinney
Cc: Jiewen Yao
Signed-off-by: Agyeman
---
.../Microcode/MicrocodeUpdates.inf | 1 +
.../Microcode/mC0806EA_00B4.mcb | Bin 0 -> 99328 bytes
2 files changed, 1 insertion(+)
create mode
In commit 1fce963d89f3e we reduced the level of information printed
by PeCoffLoaderRelocateImageExtraAction() but we did not update the
similar PeCoffLoaderUnloadImageExtraAction() function.
PeCoffLoaderUnloadImageExtraAction() prints helpful debugger commands
for source level debugging. These
Fix a pair of trivial typos by inserting a space.
Cc: Leif Lindholm
Cc: Ard Biesheuvel
Signed-off-by: Philippe Mathieu-Daude
---
.../DebugPeCoffExtraActionLib/DebugPeCoffExtraActionLib.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
This look like a good clean up to remove the PDF file.
Can you please enter a BZ for this. This patch was already
reviewed in the devel branch, and I prefer to add it in
its current form and look into the conversion from PDF
to a text file as an additional task.
Thanks,
Mike
> -Original
On 7/29/19 6:09 PM, Laszlo Ersek wrote:
> On 07/29/19 16:38, Philippe Mathieu-Daudé wrote:
>> Hi,
>>
>> On 7/26/19 5:10 AM, Xu, Wei6 wrote:
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
>>>
>>> When driver is unloaded, the ExitBootSerivesEvent must be closed at
>>> the same time.
Thank you for the reviews
Pushed at 9181684081..52e4b254f6
Mike
From: Marcin Wojtas [mailto:m...@semihalf.com]
Sent: Wednesday, July 24, 2019 1:46 PM
To: Kinney, Michael D
Cc: edk2-devel-groups-io ; Leif Lindholm
; Ard Biesheuvel
Subject: Re: [edk2-platforms Patch 0/3] Replace BSD License
I will update and resubmit for item a (add NULL) and item b (remove duplicate
EVP_PKEY_CTX_free) but the changing the code as suggested looks more complex to
me. I think the user of the label follows the pattern of other EDK2 code. A
single if with multiple function calls and relying on short
On 07/29/19 16:38, Philippe Mathieu-Daudé wrote:
> Hi,
>
> On 7/26/19 5:10 AM, Xu, Wei6 wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
>>
>> When driver is unloaded, the ExitBootSerivesEvent must be closed at
>> the same time. Otherwise exception will occur when
I did discuss this option with Ray; the thing is there is already a pair of
protocols defined to retrieve platform policy - PCI Platform Protocol and its
alias PCI Override Protocol; a new protocol would be third one for the same
purpose, to be consumed by the PCI Bus driver or PCI Root Bridge
The purpose of XenPlatformLib is to regroup the few functions that are
used in several places to detect if Xen is detected, and to get the
XenInfo HOB.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Notes:
v4:
- fix
When the Xen PVH entry point has been used, hvmloader hasn't run and
hasn't prepared an E820 table. The only way left to get an E820 table
is to ask Xen via an hypercall, the call can only be made once so keep
the result cached for later.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
This patch replace the XenDetected() function by the one in
XenPlatformLib.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Notes:
v4:
- removed gEfiXenInfoGuid from Guids list.
v3:
- new patch, splited
"OvmfPkg/8254TimerDxe" is replaced with a Xen-specific
EFI_TIMER_ARCH_PROTOCOL implementation. Also remove
8259InterruptControllerDxe as it is not used anymore.
This Timer uses the local APIC timer as time source as it can work on
both a Xen PVH guest and an HVM one.
Based on the
Replace the XenDetected() implementation by the one from
XenPlatformLib.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Notes:
v4:
- removed gEfiXenInfoGuid from Guids list and the associated include of
The XenPlatformPei needs to make hypercalls, but the XenHypercallLib was
initialised before the HyperPage was ready. Now that XenPlatformPei has
initialised the HyperPage, reinitialise the XenHypercallLib.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
EFI_XEN_OVMF_INFO is only useful to retrieve the E820 table. The
mXenHvmloaderInfo isn't used yet, but will be use in a further patch to
retrieve the E820 table.
Also remove the unused pointer from the XenInfo HOB as that information
is only useful in the XenPlatformPei.
Ref:
If the firmware have been started via the Xen PVH entry point, a RSDP
pointer would have been provided. Use it.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Notes:
v4:
- fix coding style
v3:
- patch
Linux panic if the VGA region isn't reserved.
When Linux is booted on EFI system, it expects the memory at 0xa to
_not_ be conventional memory. Otherwise a variable isn't initialised
properly and Linux panic when a virtual console/terminal is asked to be
created.
See for more detail:
We are going to replace XenDetected() implementation in
PlatformBootManagerLib by the one in XenPlatformLib.
PlatformBootManagerLib's implementation does cache the result of
GetFirstGuidHob(), so we do something similar in XenPlatformLib.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow
the same value to be used in a different module.
The reason for the number of page to be 4 doesn't exist anymore, so
simply remove the comment.
Signed-off-by: Anthony PERARD
---
OvmfPkg/OvmfPkg.dec | 3 +++
When running as a Xen PVH guest, there is no CMOS to read the memory
size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can
work without CMOS by reading the e820 table.
Rework XenPublishRamRegions to also care for the reserved and ACPI
entry in the e820 table. The region that was
PcdFSBClock is used by SecPeiDxeTimerLibCpu, the TimerLib
implementation. It will also be used by XenTimerDxe. Override
PcdFSBClock to match Xen vLAPIC timer frequency.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
Notes:
Check if there's a start of the day struct provided to PVH guest, save
the ACPI RSDP address for later.
This patch import import arch-x86/hvm/start_info.h from xen.git.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
Notes:
XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the
Grant Tables.
The call is only done if it is necessary, we simply detect if the
guest is PVH, as in this case there is currently no PCI bus, and no
PCI Xen platform device which would start the XenIoPciDxe and allocate
the space
This new XenHvmloaderDetected() return true if the hvmloader firmware
has runned before OVMF.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
Notes:
v3:
- Added one sentence in the commit message.
On a Xen PVH guest, none of the existing serial or console interface
works, so we add a new one, based on XenConsoleSerialPortLib, and
implemented via SerialDxe.
That is a simple console implementation that can works on both PVH
guest and HVM guests, even if it rarely going to be use on HVM.
XenPvhDetected() can be used to figure out if OVMF has started via the
Xen PVH entry point.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
OvmfPkg/XenPlatformPei/Platform.h | 5 +
OvmfPkg/XenPlatformPei/Xen.c | 13
We are going to need to make an hypercall in order to retreive the E820
table from the hypervisor before been able to setup the memory.
Calling XenConnect earlier will allow to setup the XenHypercallLib
earlier to allow to make hypercalls.
While here, add some comments in XenConnect().
Ref:
The informations to make a XENMEM_memory_map hypercall is copied over
from the public header of the Xen Project, with the type name modified
to build on OVMF.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
Notes:
v3:
-
Move XenRealTimeClockLib from ArmVirtPkg to OvmfPkg so it can be used
from the OvmfPkg by the following patch, "OvmfPkg/OvmfXen: use
RealTimeClockRuntimeDxe from EmbeddedPkg"
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Allow to use Xen hypercalls earlier, during the PEIM stage, but
XenHypercallLibInit() must be called once the XenInfo HOB is created
with the HyperPage setup.
Change the return value of XenHypercallLibInit so failure can be
detected when the call shouldn't fail, but still have the constructor
A Xen PVH guest doesn't have a RTC that OVMF would expect, so
PcatRealTimeClockRuntimeDxe fails to initialize and prevent the
firmware from finish to boot. To prevent that, we will use
XenRealTimeClockLib which simply always return the same time.
This will work on both Xen PVH and HVM guests.
When running in a Xen PVH guest, there's nothing to do in
PciAcpiInitialization() because there isn't any PCI bus. When the Host
Bridge DID isn't recognised, simply continue. (The value of
PcdOvmfHostBridgePciDevId would be 0 because it isn't set.)
Ref:
Use the already checked pointer mXenHvmloaderInfo to retrieve the E820
table produced by hvmloader.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
OvmfPkg/XenPlatformPei/Xen.c | 18 +-
1 file changed, 9
When the device ID of the host bridge is unknown, check if we are
running as a PVH guest as there is no PCI bus in that case.
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
Signed-off-by: Anthony PERARD
Acked-by: Laszlo Ersek
---
Notes:
v3:
- Remove use of
OvmfXen is a copy of OvmfX64, removing VirtIO and some SMM.
This new platform will be changed to make it works on two types of Xen
guest: HVM and PVH.
Compare to OvmfX64, this patch:
- changed: PLATFORM_GUID, OUTPUT_DIRECTORY, FLASH_DEFINITION
- removed: VirtioLib class resolution
- removed:
Introduce XenResetVector, a copy of OvmfPkg/ResetVector, with one
changes:
- SEC_DEFAULT_CR0: enable cache (bit 30 or CD set to 0)
Xen copies the OVMF code to RAM, there is no need to disable cache.
This new module will later be modified to add a new entry point, more
detail in a following
As described in the Xen PVH documentation [1], "ebx: contains the
physical memory address where the loader has placed the boot start info
structure". To have this pointer saved to be able to use it later in the
PEI phase, we allocate some space in the MEMFD for it. We use 'XPVH' as
a signature
This patch changes the flash device image of OvmfXen to make it look
like it's an ELF. For this, we replace the empty embedded variable store
by a binary array, which is a ELF file header.
The ELF header explain to a loader to load the binary at the address
1MB, then jump to the PVH entry point
Introduce XenPlatformPei, a copy of OvmfPkg/PlatformPei without some
of QEMU specific initialization, Xen does not support QemuFwCfg.
This new module will be adjusted to accommodate Xen PVH.
fw_cfg dependents that have been removed, which are dynamically skipped
when running PlatformPei on Xen:
This patch allows the ResetVector to be run indenpendently from build
time addresses.
The goal of the patch is to avoid having to create RAM just below 4G
when creating a Xen PVH guest while being compatible with the way
hvmloader currently load OVMF, just below 4G.
Only the new PVH entry point
Patch series available in this git branch:
https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.platform-xen-pvh-v4
Changes in v4:
- patch "OvmfPkg/XenPlatformPei: Reserve hvmloader's memory only when it has
run" was removed, and instead a different change is done in
The ACPI Timer isn't present in a PVH guest, but local APIC works on
both PVH and HVM.
Note that the use of SecPeiDxeTimerLibCpu might be an issue with a
driver of type DXE_RUNTIME_DRIVER. I've attempted to find out which of
the DXE_RUNTIME_DRIVER uses the TimerLib at runtime. I've done that by
Add missing dependency on PciLib
and remove extra includes of OvmfPlatforms.h.
Signed-off-by: Anthony PERARD
Reviewed-by: Laszlo Ersek
---
Notes:
v2:
- also add PciLib.h include to the .c
- and remove extra include of OvmfPlatforms.h
Add a new entry point for Xen PVH that enter directly in 32bits.
Information on the expected state of the machine when this entry point
is used can be found at:
https://xenbits.xenproject.org/docs/unstable/misc/pvh.html
Also, compare to the original file [1], the two `nop' of the "resetVector"
Hello Yao Jeiwen,
Thanks for reviewing in detail!
I used the PCIe attribute in the context of my ECR; say MPS is a PCI standard
feature which has to be set to defined set of values only, thus I called it as
its attributes.
I had updated about this latest additional PCI feature (CTO) inclusion
Hi Bob,
On 7/29/19 10:44 AM, Bob Feng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
>
> The WorkspaceAutoGen.__InitWorker function is too long, it's hard
> to read and understand.
> This patch is to separate the __InitWorker into multiple small ones.
Patch looks good, however
On 7/29/19 5:40 AM, Zhang, Shenglei wrote:
> Cc: Jiewen Yao
> Cc: Jian Wang
> Cc: Chao Zhang
> Signed-off-by: Shenglei Zhang
> ---
> SecurityPkg/SecurityPkg.dec | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/SecurityPkg.dec b/SecurityPkg/SecurityPkg.dec
Hi,
On 7/25/19 7:35 PM, Nate DeSimone wrote:
> From: Jiewen Yao
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao
> Reviewed-by: Vincent Zimmer
> ---
> ... Production RULAC click-through_3-14-18.pdf | Bin 487917 -> 0 bytes
>
Hi,
On 7/26/19 5:10 AM, Xu, Wei6 wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2012
>
> When driver is unloaded, the ExitBootSerivesEvent must be closed at
> the same time. Otherwise exception will occur when ExitBootServices.
>
> Cc: Michael D Kinney
> Cc: Liming Gao
>
On 07/29/19 13:07, Chiu, Chasel wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
>
> PcdFsp*BaseAddress now will be updated in FDF basing
> on flash map.
> DSC will only define types of those PCDs and always
> having 0 as default.
> New script added to only rebase FSP binary
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Saturday, July 27, 2019 11:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Laszlo Ersek ;
> Vanguput, Narendra K
> Subject: [PATCH 2/3] UefiCpuPkg/PiSmmCpu: Refine CR2 save/restore logic
>
> Because
Forgot to mention: since we want to handle device policy, another option is to
create PCI_DEVICE_POLICY_PROTOCOL. No need to update previous one.
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Yao, Jiewen
> Sent:
I think the request makes sense.
I am not sure if I understand your question on PCI attributes. It is generic
concept and defined in UEFI spec. Here we are discussing device policy in PCIE
spec.
I checked ECR in https://bugzilla.tianocore.org/show_bug.cgi?id=1954, it
defines
typedef struct {
On 07/27/19 05:28, Ni, Ray wrote:
> Commit c60d36b4d1ee1f69b7cca897d3621dfa951895c2
> * UefiCpuPkg/SmmCpu: Block access-out only when static paging is used
>
> updated page fault handler to treat SMM access-out as allowed
> address when static paging is not used.
>
> But that commit is not
On 07/27/19 05:28, Ni, Ray wrote:
> Because IsStaticPageTableEnabled() is added for both IA32 and x64
> build, the CR2 save/restore logic can be refined:
> 1. Remove arch specific SaveCr2() / RestoreCr2() implementation;
> 2. Conditionally save and restore CR2 in SmiRendezvous().
>
>
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Saturday, July 27, 2019 11:29 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Wang, Jian J
> Subject: [PATCH 3/3] UefiCpuPkg/PiSmmCpu: Allow SMM access-out when
> static paging is OFF
>
> Commit
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ni,
> Ray
> Sent: Saturday, July 27, 2019 11:29 AM
> To: devel@edk2.groups.io
> Cc: Laszlo Ersek
> Subject: [edk2-devel] [PATCH 1/3] UefiCpuPkg/PiSmmCpu: Add Internal
>
Hi Ray,
On 07/27/19 05:28, Ni, Ray wrote:
> The internal function reflects the status whether static page table
> is enabled.
>
> Signed-off-by: Ray Ni
> Cc: Laszlo Ersek
> Cc: Eric Dong ---
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 16
>
My response inline below...
Thanks
Ashraf
> -Original Message-
> From: Yao, Jiewen
> Sent: Monday, July 29, 2019 2:26 PM
> To: Javeed, Ashraf ; devel@edk2.groups.io; Gao,
> Liming
> Cc: Kinney, Michael D ; Ni, Ray
>
> Subject: RE: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH V2]
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
PcdFsp*BaseAddress now will be updated in FDF basing
on flash map.
DSC will only define types of those PCDs and always
having 0 as default.
New script added to only rebase FSP binary without
patching DSC file.
Test: interanl platform
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
PcdFsp*BaseAddress now will be updated in FDF basing
on flash map.
DSC will only define types of those PCDs and always
having 0 as default.
Test: interanl platform booted with this patch.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
Add python script which will rebase FSP binary without
patching platform DSC for Fsp*BaseAddress PCDs.
Those base address PCD will be updated in FDF basing
on flash map.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
PcdFsp*BaseAddress now will be updated in FDF basing
on flash map.
DSC will only define types of those PCDs and always
having 0 as default.
Test: interanl platform booted with this patch.
Cc: Michael Kubacki
Cc: Ankit Sinha
Cc: Nate
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1863
Consume RebaseFspBinBaseAddress.py which will only rebase
FSP binary without patching platform DSC.
Cc: Michael Kubacki
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Chasel Chiu
---
Platform/Intel/build_bios.py | 7 ++-
1 file
Hi Bob,
On 07/29/19 10:44, Bob Feng wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
>
> In order to improve the build performance, we implemented
> multiple-processes AutoGen. This change will reduce 20% time
> for AutoGen phase.
>
> The design document can be got from:
>
Oh. This patch is for staging. Not for EDKII master, right?
If so, I have no concern.
For the master, I think MdePkg should only include what has been defined.
For this patch, I am curious on how to maintain the compatibility?
For example, what happen, if PCIE 5.0 or PCIE 6.0 add new device
Sure.
Thanks,
Marc
> -Original Message-
> From: Gao, Liming
> Sent: Monday, July 29, 2019 4:29 PM
> To: devel@edk2.groups.io; Chen, Marc W
> Cc: Kinney, Michael D ; Ni, Ray
>
> Subject: RE: [edk2-devel] [PATCH V2] MdePkg: Add PI 1.5
> SmramMemoryReserve HOB file
>
> Marc:
>
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
1. Set Log queue maxsize as thread number * 10
2. enhance ModuleUniqueBaseName function
3. fix bugs of build option pcd in sub Process
4. enhance error handling
5. fix bug in the function of duplicate modules handling.
Cc: Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
python3 change the module name of Queue to queue.
python3 add a new log handler of QueueHandler.
This patch is to make Multiple process AutoGen
feature work for python2
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Add shared data for autogen processes.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 3 ++-
BaseTools/Source/Python/build/build.py | 10 ++
2 files changed, 8
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
In order to improve the build performance, we implemented
multiple-processes AutoGen. This change will reduce 20% time
for AutoGen phase.
The design document can be got from:
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The WorkspaceAutoGen.__InitWorker function is too long, it's hard
to read and understand.
This patch is to separate the __InitWorker into multiple small ones.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
To support Ctrl+S and Ctrl+Q, we enable block queue
for log.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/Common/EdkLogger.py | 10 ++
BaseTools/Source/Python/build/build.py | 8 +---
2 files
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Build tool supports user to specify the conf folder.
To make the build options be evaluated at the beginning
of launching build, extract the buildoption function
from build.py to a new .py file.
Signed-off-by: Bob Feng
Cc: Liming Gao
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
AutoGen processes race the logfile. To resolve this issue,
this patch create a LogAgent thread in main process to write
the log content to console or file, Other process will send
the log content to the LogAgent.
Cc: Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
The build config files are target.txt, build rule, tooldef
During a build, the config is not changed, so the object to
handle them need to be singleton.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
Assign the Module AutoGen tasks into multiple
sub process.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
.../Source/Python/AutoGen/AutoGenWorker.py| 162 ++
BaseTools/Source/Python/AutoGen/DataPipe.py | 6 +
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1875
These functions are used for get platform scope
build options. They will be used in later patches.
Cc: Liming Gao
Signed-off-by: Bob Feng
---
BaseTools/Source/Python/AutoGen/AutoGen.py| 10 +-
Marc:
Normally, gEfiGuidCName matches GUID C Macro name. Can you follow this rule?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Marc W Chen
>Sent: Monday, July 29, 2019 4:05 PM
>To: devel@edk2.groups.io
>Cc: Kinney, Michael D
Hi Yao Jiewen,
Can you please elaborate your concern?
The PCI Platform Protocol / PCI Override Protocol are defined in PI Spec 1.7.
These same protocols are enhanced here.
The producer would be the platform firmware, and consumer would be the
MdeModulePkg's PCI Bus driver.
The detailed document
This is a special GUID extension Hob to describe SMRAM memory regions
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Ray Ni
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2020
Signed-off-by: Marc W Chen
---
MdePkg/Include/Guid/SmramMemoryReserve.h | 45
Hi
I think this policy protocol should be EDKII specific. Currently it is no in PI
spec.
Should it be in MdeModulePkg ?
Thank you
Yao Jiewen
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Monday, July 29, 2019 3:52 PM
>
1 - 100 of 110 matches
Mail list logo
