Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Michael D Kinney
>Sent: Friday, August 16, 2019 10:15 AM
>To: devel@edk2.groups.io
>Cc: Justen, Jordan L ; Ni, Ray ;
>Andrew Fish
>Subject: [edk2-devel] [Patch V4 10/10]
Reviewed-by: Eric Dong
> -Original Message-
> From: Kuo, Donald
> Sent: Thursday, August 15, 2019 5:11 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Zeng, Star ; Dong, Eric
> ; Chan, Amy ; Chaganty,
> Rangasai V
> Subject: [PATCH] UefiCpuPkg: Adding a new TSC library by using
Reviewed-by: Eric Dong
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 4:15 PM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray ; Laszlo
> Ersek
> Subject: [edk2-devel] [PATCH 1/1]
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 1:42 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject:
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 15, 2019 3:38 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben ; Ni, Ray ;
> Gao, Zhichao
> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift
> logical
For this patch set,
Reviewed-by: Bob Feng
-Original Message-
From: Shi, Steven
Sent: Thursday, August 15, 2019 10:26 PM
To: devel@edk2.groups.io
Cc: Gao, Liming ; Feng, Bob C ;
Rodriguez, Christian ; Johnson, Michael
; ler...@redhat.com; leif.lindh...@linaro.org;
af...@apple.com;
Krzysztof:
Can you submit BZ in https://bugzilla.tianocore.org/ for this change?
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Krzysztof Koch
>Sent: Thursday, August 15, 2019 9:11 PM
>To: devel@edk2.groups.io
>Cc: Carsey,
Pushed at 8906f076de35b222a7d62bcf6ed1a4a2498a5791
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Wang, Jian J
> Sent: Thursday, August 15, 2019 4:59 PM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Ye, Ting
> Subject:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Supports new logic which test current value before write new value.
Only write new value when current value not same as new value.
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 29
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Add below new micros which test the current value before write the new
value. Only write new value when current value not same as new value.
CPU_REGISTER_TABLE_TEST_THEN_WRITE32
CPU_REGISTER_TABLE_TEST_THEN_WRITE64
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2040
Below code is current implementation:
if (MsrRegister[ProcessorNumber].Bits.Lock == 0) {
CPU_REGISTER_TABLE_WRITE_FIELD (
ProcessorNumber,
Msr,
MSR_IA32_FEATURE_CONTROL,
MSR_IA32_FEATURE_CONTROL_REGISTER,
Signed-off-by: Eric Dong
Cc: Ray Ni
Reviewed-by: Laszlo Ersek
---
UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 104 ++
1 file changed, 62 insertions(+), 42 deletions(-)
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c
index
v4 changes:
1. Split Reserved field and use one byte as TestThenWrite field.
v3 changes:
1. Avoid changing exist API CpuRegisterTableWrite, add new API
CpuRegisterTableTestThenWrite which align new adds macros.
Only 1/6 patch been changed in v3.
V2 changes:
1. Split CR read/write action in to
Signed-off-by: Eric Dong
Cc: Ray Ni
Acked-by: Laszlo Ersek
---
.../CpuFeaturesInitialize.c | 110 ++
1 file changed, 63 insertions(+), 47 deletions(-)
diff --git a/UefiCpuPkg/Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c
Eric:
>-Original Message-
>From: Dong, Eric
>Sent: Friday, August 16, 2019 10:20 AM
>To: Zeng, Star ; devel@edk2.groups.io
>Cc: Ni, Ray ; Laszlo Ersek ; Yao,
>Jiewen ; Gao, Liming ;
>Kinney, Michael D
>Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test
>Then Write"
Comment below:
> -Original Message-
> From: Paolo Bonzini [mailto:pbonz...@redhat.com]
> Sent: Friday, August 16, 2019 12:21 AM
> To: Laszlo Ersek ; devel@edk2.groups.io; Yao, Jiewen
>
> Cc: edk2-rfc-groups-io ; qemu devel list
> ; Igor Mammedov ;
> Chen, Yingwen ; Nakajima, Jun
> ;
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 16, 2019 10:08 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Yao,
> Jiewen ; Gao, Liming ; Kinney,
> Michael D ; Zeng, Star
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add
* Disable XCODE5 compiler optimizations fort Unix/Host.
* Disable inline of SecGdbScriptBreak() to improve
compatibility with XCODE5
* For X64 XCODE5 builds place output Host application
in $(BIN_DIR) to match all other EmulatorPkg Host
application builds.
Cc: Jordan Justen
Cc: Andrew Fish
https://bugzilla.tianocore.org/show_bug.cgi?id=162
Update EmulatorPkg specific modules and libraries to use
safe string functions in BaseLib and safe PcdSetxx()
functions in PcdLib. With these updates, the define
DISABLE_NEW_DEPRECATED_INTERFACES is enabled in the DSC
file.
Cc: Jordan Justen
* Fix uninitialized Private->ReadBuffer.
* Remove old debug code that generates an exception.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Unix/Host/BerkeleyPacketFilter.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git
Shenglei,
Sorry that I forgot to mention that these two inf files are generated by
process_files.pl
in the same folder. Please file another BZ to update this perl script to add
those header
files into inf file.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io
https://bugzilla.tianocore.org/show_bug.cgi?id=2056
The IA32 build of the EmulatorPkg for VS20xx does not boot
because the default value of PCD PcdPeiServicesTablePage
rarely succeeds to be mapped on IA32 Windows Host Environments.
Change the DEC default value for this PCD to a value that
is
The local variable PpiArray[10] is declared in middle
of the SEC module _ModuleEntryPoint(). When building
for XCODE5 with optimizations enabled, this results in
corruption and an exception. The fix is to move the
declaration of PpiArray[10] to the standard location
at the beginning of the
Fix scripts to support lldb symbolic debugging when
using XCODE5 tool chain.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
EmulatorPkg/Unix/lldbefi.py | 8 +---
EmulatorPkg/build.sh| 17 ++---
2 files changed, 7 insertions(+), 18
https://bugzilla.tianocore.org/show_bug.cgi?id=2055
Remove the use of the defines UNIX_SEC_BUILD and
WIN_SEC_BUILD. This simplifies the build command
for the EmulatorPkg. Instead, use !if statements
in the DSC file using $(ARCH) and $(FAMILY) to
determine if the build is for a Windows or POSIX
Disable TftpDynamicCommand for XCODE5 because this command
places HII content in an PE/COFF resource section that is not
supported by the XCODE5 tool chain, and the missing HII
content causes the load of this command to ASSERT().
Disable the LogoDxe module that places the logo bitmap in
a PE/COFF
New in V4 (Resolve XCODE5 issues)
==
* Disable inline if SecGdbScriptBreak() for XCODE5 issues
* Disable XCODE5 compiler optimizations of Unix/Host
* Fix Host output location for XCODE5 X64 builds
* Update lldb scripts for XCODE5 symbiolic debugging
* Clean up
Add -gdwarf to XCODE5 X64 builds to generate symbols for
source level debug using lldb.
Cc: Jordan Justen
Cc: Ray Ni
Cc: Michael D Kinney
Signed-off-by: Andrew Fish
---
BaseTools/Conf/tools_def.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
Add NOOPT to BUILD_TARGETS in DSC file.
Cc: Jordan Justen
Cc: Andrew Fish
Cc: Ray Ni
Signed-off-by: Michael D Kinney
Reviewed-by: Hao A Wu
Reviewed-by: Jordan Justen
---
EmulatorPkg/EmulatorPkg.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
> -Original Message-
> From: Dong, Eric
> Sent: Friday, August 16, 2019 9:27 AM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test
> Then Write" Macros.
>
> > -Original Message-
> >
Thanks, we use the latest commit and it works well now.
Thanks,
Fan
-Original Message-
From: Laszlo Ersek [mailto:ler...@redhat.com]
Sent: Tuesday, August 13, 2019 8:23 PM
To: devel@edk2.groups.io; Chen, Farrah
Cc: Hao, Xudong
Subject: Re: [edk2-devel] ovmf build fail with gcc
> -Original Message-
> From: Zeng, Star
> Sent: Friday, August 16, 2019 9:15 AM
> To: Dong, Eric ; devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Zeng,
> Star
> Subject: RE: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test
> Then Write" Macros.
>
>
>
> > -Original
> -Original Message-
> From: Dong, Eric
> Sent: Thursday, August 15, 2019 10:51 AM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Laszlo Ersek ; Zeng,
> Star
> Subject: [Patch v3 1/6] UefiCpuPkg/RegisterCpuFeaturesLib: Add "Test Then
> Write" Macros.
>
> REF:
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, August 15, 2019 4:31 PM
> To: Wu, Hao A; Zhang, Shenglei; devel@edk2.groups.io
> Cc: Bi, Dandan
> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> PageMapLevel5Entry
>
> That's fine. Thanks!
>
>
Hello,
I initially raised this question in a new TimerLib patch[1], but as the
discussion was getting more distracted, I decided to create a separate thread
in hopes new people could join.
The issue is that our UEFI bootloader needs to obtain TSC frequency to pass it
to our specialised
Hi David,
Here are my comments:
1. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0"
from your commit message as it is no longer needed.
2. Please don't add this entry: WhiskeylakeURvp =
WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/build_config.cfg
WhiskeylakeOpenBoardPkg
Hi David,
Here are my comments:
1. What is the purpose of this driver? My guess this is just a dummy driver
that provides the EFI_SIO_PROTOCOL and does resource management without
actually accessing the SIO?
2. All of the copyright years need to be updated to 2019.
3. Please remove "
Vitaly,
When implementing a UEFI Application, if you want maximum compatibility, you
should use UEFI Services/Protocols and minimize as many HW assumptions as
possible.
I understand, especially for accurate time and clock related services, the that
the UEFI Specification defined
On Thu, 15 Aug 2019 17:00:16 +0200
Laszlo Ersek wrote:
> On 08/14/19 16:04, Paolo Bonzini wrote:
> > On 14/08/19 15:20, Yao, Jiewen wrote:
> >>> - Does this part require a new branch somewhere in the OVMF SEC code?
> >>> How do we determine whether the CPU executing SEC is BSP or
> >>>
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io
> [mailto:devel@edk2.groups.io] On Behalf Of vit9696 via
> Groups.Io
> Sent: Tuesday, August 13, 2019 1:17 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel] [PATCH v2 1/1] MdePkg: Add
>
On 15/08/19 11:55, Yao, Jiewen wrote:
> Hi Paolo
> I am not sure what do you mean - "You do not need a reset vector ...".
> If so, where is the first instruction of the new CPU in the virtualization
> environment?
> Please help me understand that at first. Then we can continue the discussion.
On Wed, 14 Aug 2019 16:04:50 +0200
Paolo Bonzini wrote:
> On 14/08/19 15:20, Yao, Jiewen wrote:
> >> - Does this part require a new branch somewhere in the OVMF SEC code?
> >> How do we determine whether the CPU executing SEC is BSP or
> >> hot-plugged AP?
> > [Jiewen] I think this is
On 08/14/19 16:04, Paolo Bonzini wrote:
> On 14/08/19 15:20, Yao, Jiewen wrote:
>>> - Does this part require a new branch somewhere in the OVMF SEC code?
>>> How do we determine whether the CPU executing SEC is BSP or
>>> hot-plugged AP?
>> [Jiewen] I think this is blocked from hardware
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1923
Fix the issue that the GenFds multi-thread will build fail
if enable the build cache together.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Steven Shi
---
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 23
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1951
Current build cache use the module's [self.Arch][self.Name]
info as the ModuleAutoGen object key in hash list and dictionary.
The [self.Arch][self.Name] is not safe as the module key because
there could be two modules
From: "Shi, Steven"
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2079
The Basetool CopyFileOnChange() and SaveFileOnChange()
functions might raise the IOError occasionally when build
in Windows with multi-process and build cache enabled.
The CopyFileOnChange() and SaveFileOnChange() might
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1927
Current cache hash algorithm does not parse and generate
the makefile to get the accurate dependency files for a
module. It instead use the platform and package meta files
to get the module depenedency in a quick but
From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1925
When a module build cache miss, add support to print the first
cache missing file path and name.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Steven Shi
---
BaseTools/Source/Python/AutoGen/AutoGenWorker.py | 2 ++
From: "Shi, Steven"
This patch set is for the 201908 stable tag
Enhance the edk2 build cache with below patches:
Patch 01/05: Improve the cache hit rate through new cache checkpoint and hash
algorithm
Patch 02/05: Print more info to explain why a module build cache miss
Patch 03/05: Fix the
Check if global (in the scope of the DBG2 parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
Check if global (in the scope of the GTDT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
Check if the MadtInterruptControllerType and
MadtInterruptControllerLength pointers have been successfully updated
before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
Check if global (in the scope of the IORT parser) pointers have been
successfully updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
Check if the NumberOfPrivateResources, ProcessorTopologyStructureType
and ProcessorTopologyStructureLength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
1. Check if the 'Number of System Localities' provided can be
represented in the SLIT table. The table 'Length' field is a 32-bit
value while the 'Number of System Localities' field is 64-bit long.
2. Check if the SLIT matrix fits in the table buffer. If N is the SLIT
locality count, then the
For fields outside the buffer length provided, reset any pointers,
which were supposed to be updated by a ParseAcpi() function call to
NULL. This way one can easily validate if a pointer was successfully
updated.
The ParseAcpi() function parses the given ACPI table buffer by a
number of bytes
Check if XsdtAddress pointer has been successfully updated before it
is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | 12
1
Check if global pointers have been successfully updated before they
are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c | 14
++
1
Hi Leif,
On 2019.08.15 13:13, Leif Lindholm wrote:
On Mon, Aug 12, 2019 at 02:06:34PM +0100, Pete Batard wrote:
The Raspberry Pi 3 platform currently has 2 different models, each with a
different Device Tree. Rather than embedding a single one, and requiring
users to manually provide the
Prevent the use of invalid pointers when parsing ACPI tables in the UEFI
shell acpiview tool.
The parsing of ACPI tables is often controlled with the values read
earlier from the same table. For example, the 'Offset' or 'Count' fields
found in a structure are later used to parse the
Check if SlitSystemLocalityCount pointer has been successfully updated
before it is used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Slit/SlitParser.c | 16
Check if SratRAType and SratRALength pointers have been successfully
updated before they are used for further table parsing.
Signed-off-by: Krzysztof Koch
---
Notes:
v1:
- Test against NULL pointers [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c |
On Thu, Aug 15, 2019 at 10:15:48AM +, Andy Hayes wrote:
> Thanks very much for the very quick feedback from both of you - I
> really appreciate it. I'll fix the issues that you pointed out and
> re-submit the patch.
Thanks!
> I've been testing the build with VisualStudio 2015 and GCC 7.3.
On Mon, Aug 12, 2019 at 02:06:34PM +0100, Pete Batard wrote:
> The Raspberry Pi 3 platform currently has 2 different models, each with a
> different Device Tree. Rather than embedding a single one, and requiring
> users to manually provide the other, this patch ensures that we now embed
> both and
Hi Donald,
Glad to hear it helped a little, and sorry for some outdated quotes.
Your clarification regarding model range is very helpful. Xeon W being client
and thus having client clock makes sense, though I must say it was quite not
obvious. I was referring to the same SDM table, and it
Jian,
Yes, you are right.
According to CCS_2_1_Draft, 4.3.3.3, Pointer variables may optionally be
prefixed with a 'p'.
So please skip this change.
Thanks,
Shenglei
> -Original Message-
> From: Wang, Jian J
> Sent: Thursday, August 15, 2019 5:01 PM
> To: Zhang, Shenglei ;
On 08/13/19 13:30, Anthony PERARD wrote:
> Patch series available in this git branch:
> https://xenbits.xen.org/git-http/people/aperard/ovmf.git
> br.platform-xen-pvh-v5
>
> Changes in v5:
> - patch 23 got a rework of the lapic range skipping
> - small fixups in patch 20, 22, 23, 31, 32, 33.
>
Hi Paolo
I am not sure what do you mean - "You do not need a reset vector ...".
If so, where is the first instruction of the new CPU in the virtualization
environment?
Please help me understand that at first. Then we can continue the discussion.
Thank you
Yao Jiewen
> -Original Message-
On 08/15/19 11:40, Laszlo Ersek wrote:
> On 08/13/19 13:31, Anthony PERARD wrote:
>> Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow
>> the same value to be used in a different module.
>>
>> The reason for the number of page to be 4 doesn't exist anymore, so
>> simply remove
On 08/13/19 13:31, Anthony PERARD wrote:
> XenIoPvhDxe use XenIoMmioLib to reserve some space to be use by the
> Grant Tables.
>
> The call is only done if it is necessary, we simply detect if the
> guest is PVH, as in this case there is currently no PCI bus, and no
> PCI Xen platform device
On 08/13/19 13:31, Anthony PERARD wrote:
> Introduce PcdXenGrantFrames to replace a define in XenBusDxe and allow
> the same value to be used in a different module.
>
> The reason for the number of page to be 4 doesn't exist anymore, so
> simply remove the comment.
>
> Signed-off-by: Anthony
On 08/13/19 13:31, Anthony PERARD wrote:
> On a Xen PVH guest, none of the existing serial or console interface
> works, so we add a new one, based on XenConsoleSerialPortLib, and
> implemented via SerialDxe.
>
> That is a simple console implementation that can work on both PVH
> guest and HVM
Eric:
I push the change for edk2platform.
And, I push the remaining patches
a6ee24fbddcd901347014e045611eb6108f4f741..a5944b6a13e227da23daa0ab59b5d6f4b06bb49b
Thanks
Liming
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Liming Gao
>Sent:
On 08/13/19 13:31, Anthony PERARD wrote:
> When running as a Xen PVH guest, there is no CMOS to read the memory
> size from. Rework GetSystemMemorySize(Below|Above)4gb() so they can
> work without CMOS by reading the e820 table.
>
> Rework XenPublishRamRegions to also care for the reserved and
Hi Leif, Ard, Christopher,
Haojian and I have tested the driver on 2 platforms, any further comments on
this?
Thanks
Tien Hock
> -Original Message-
> From: Haojian Zhuang
> Sent: Tuesday, July 30, 2019 3:33 PM
> To: Loh, Tien Hock ; leif.lindh...@linaro.org;
>
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1909
Cc: Ray Ni
Cc: Star Zeng
Cc: Eric Dong
Cc: Amy Chan
Cc: Rangasai V Chaganty
Signed-off-by: Donald Kuo
---
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.c | 41 +++
UefiCpuPkg/Library/CpuTimerLib/BaseCpuTimerLib.inf | 35 +++
Shenglei,
I remember the edk2 coding style allows prefix 'p' (optional) to represent a
pointer variable.
Regards,
Jian
> -Original Message-
> From: Zhang, Shenglei
> Sent: Thursday, August 15, 2019 4:49 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [PATCH
On 08/13/19 13:31, Anthony PERARD wrote:
> When the Xen PVH entry point has been used, hvmloader hasn't run and
> hasn't prepared an E820 table. The only way left to get an E820 table
> is to ask Xen via an hypercall. We keep the result cached to avoid
> making a second hypercall which would give
Reviewed-by: Jian J Wang
> -Original Message-
> From: Zhang, Shenglei
> Sent: Tuesday, August 13, 2019 4:50 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Ye, Ting
> Subject: [PATCH 1/1] CryptoPkg/OpensslLib: Add missing header files in INF
> file
>
> The header files are used
On 08/13/19 13:31, Anthony PERARD wrote:
> XenPvhDetected() can be used to figure out if OVMF has started via the
> Xen PVH entry point.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD
> Acked-by: Laszlo Ersek
> ---
>
> Notes:
> v5:
> - in
Update pHkdfCtx to PHkdfCtx, to follow the variable naming
rule.
Cc: Jian Wang
Cc: Ting Ye
Signed-off-by: Shenglei Zhang
---
.../Library/BaseCryptLib/Kdf/CryptHkdf.c | 22 +--
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git
Reviewed-by: Liming Gao
>-Original Message-
>From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
>Zhang, Shenglei
>Sent: Tuesday, August 13, 2019 4:50 PM
>To: devel@edk2.groups.io
>Cc: Wang, Jian J ; Ye, Ting
>Subject: [edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Add
Hi Vitaly,
Appreciated for reviewing very detail. And looks your captured some piece of
code is older version. And should be ok, I do got your point.
Item #1
- I do missed RegEax error handling in case for
CpuidCoreClockCalculateTscFrequency () should return 0 and EFI_UNSUPPORTED.
Hi David,
Here are my comments:
1. All of the copyright years need to be updated to 2019.
2. Please remove " Contributed-under: TianoCore Contribution Agreement 1.0"
from your commit message as it is no longer needed.
3. Silicon/Intel/SimicsX58SktPkg/Override/UefiCpuPkg/SecCore/SecMain.c -
Reviewed-by: Sai Chaganty
-Original Message-
From: Kubacki, Michael A
Sent: Wednesday, August 14, 2019 9:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kinney, Michael D
Subject: [edk2-non-osi][PATCH V2 2/2] edk2-non-osi: Add
That's fine. Thanks!
>-Original Message-
>From: Wu, Hao A
>Sent: Thursday, August 15, 2019 3:23 PM
>To: Gao, Liming ; Zhang, Shenglei
>; devel@edk2.groups.io
>Cc: Bi, Dandan
>Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
>PageMapLevel5Entry
>
>> -Original
Hi David,
Please add an .inf file to make it convenient for the platform code to include
this binary. Please see the following for an example:
edk2-non-osi/Platform/Hisilicon/Drivers/Sm750Dxe/UefiSmi.inf
Also, please add the Maintainers.txt entries and change the package name per my
previous
LeafFunction needs to be described in comments.
https://bugzilla.tianocore.org/show_bug.cgi?id=2052
Cc: Eric Dong
Cc: Ray Ni
Cc: Laszlo Ersek
Signed-off-by: Shenglei Zhang
---
UefiCpuPkg/Application/Cpuid/Cpuid.c | 2 ++
1 file changed, 2 insertions(+)
diff --git
Replace the operation to shift logical left with the function
LShiftU64, which has the same functionality.
The original code causes ShellPkg build failure with build
target"-b NOOPT".
Cc: Jaben Carsey
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Shenglei Zhang
---
Acked-by: Jiewen Yao
Reviewed-by: Jiewen Yao
From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly
Cheptosv via Groups.Io
Sent: Thursday, August 15, 2019 10:22 AM
To: Gao, Liming ; devel@edk2.groups.io; Yao, Jiewen
; Kinney, Michael D
Cc: Laszlo Ersek ;
> -Original Message-
> From: Gao, Liming
> Sent: Thursday, August 15, 2019 10:27 AM
> To: Zhang, Shenglei; devel@edk2.groups.io
> Cc: Bi, Dandan; Wu, Hao A
> Subject: RE: [PATCH v2 1/1] MdeModulePkg/DxeIplPeim: Initialize pointer
> PageMapLevel5Entry
>
> Shenglei:
>
> > -Original
Hello,
Thank you for the patch! I reviewed the code and noticed select issues
explained below.
1. The following construction:
if (RegEbx == 0) {
DEBUG ((DEBUG_ERROR, "The CPU is not capble for Core Crystal Clock Frequency
!!\n"));
ASSERT (RegEbx != 0);
}
Does not look good to me, and in my
Reviewed-by: Nate DeSimone
-Original Message-
From: Kubacki, Michael A
Sent: Wednesday, August 14, 2019 9:15 PM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
; Kinney, Michael D
Subject: [edk2-non-osi][PATCH V2 2/2] edk2-non-osi: Add
94 matches
Mail list logo
