From: "Shi, Steven"
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1958
Current build cache does not store and restore all
types file of Hii/vfr, version and dpx. This patch
adds more file types to support them in build cache.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Steven Shi
---
Hello,
Please refer to the below inline comments:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Yao, Jiewen; Wang, Jian J; Gao, Liming
>
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming
> Subject: [edk2-devel] [PATCH v5 3/4]
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming; Wu, Hao A
> Subject: [edk2-devel] [PATCH
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming
> Subject: [edk2-devel] [PATCH v5 4/4]
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zurcher, Christopher J
> Sent: Friday, August 23, 2019 6:02 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D; Yao, Jiewen; Wang, Jian J; Gao, Liming
> Subject: [edk2-devel] [PATCH v5 2/4]
My responses are inline [makubacki]. I will wait for your response before I
send the next patchset.
Thanks,
Michael
> -Original Message-
> From: Chiu, Chasel
> Sent: Monday, August 26, 2019 7:14 PM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Desimone, Nathaniel L ; Gao,
Please see 3 questions below inline. (tagged by [chasel])
Thanks!
Chasel
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, August 27, 2019 2:48 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject: [edk2-platforms][PATCH V3
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Tuesday, August 27, 2019 2:48 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build
> Failures
>
>
Can you follow this process to send this patch again?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
And, the commit message format is
https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format
Thanks
Liming
From: devel@edk2.groups.io
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 5/5] UefiCpuPkg: Remove PcdCpuSmmStaticPageTable
>
> PcdCpuSmmRestrictedMemoryAccess is
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 4/5] UefiCpuPkg: Explain relationship between several SMM
> PCDs
>
> There are three PCDs
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 3/5] UefiCpuPkg/PiSmmCpu: Restrict access per
> PcdCpuSmmRestrictedMemoryAccess
>
> Today's
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 2/5] UefiCpuPkg/PiSmmCpu: Use new PCD
> PcdCpuSmmRestrictedMemoryAccess
>
> The patch changes
Reviewed-by: Eric Dong
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 6:45 AM
> To: devel@edk2.groups.io
> Cc: Dong, Eric ; Yao, Jiewen ;
> Laszlo Ersek
> Subject: [PATCH 1/5] UefiCpuPkg: Add PcdCpuSmmRestrictedMemoryAccess
>
> The patch adds a new X64 only PCD
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2115
Cc: Dandan Bi
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Platform/Intel/UserInterfaceFeaturePkg/UserAuthentication/UserAuthentication2Dxe.c
| 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git
Actually we didn't do that. SmbiosBasic.h is only used by c files in its
directory and not used in other packages.
Thanks,
Shenglei
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Saturday, August 24, 2019 2:12 AM
> To: Zhang, Shenglei ; devel@edk2.groups.io
> Cc: Kubacki,
sorry for the false alarm.
The issue I met before is not like this one. There is no unreachable code issue.
Reviewed-by: Ray Ni
Thanks,
Ray
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 4:52 PM
> To: Kubacki, Michael A ; devel@edk2.groups.io
> Cc: Chaganty,
The consumers are in close source and won't be in open source in near future.
But consumers depend on open source repo.
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, August 26, 2019 5:20 PM
> To: Gao, Liming ; Ni, Ray ;
> devel@edk2.groups.io; Kinney, Michael D
>
> Cc:
Ray,
Are there any components that need these new enum values?
The patch looks very straightforward and is from the
UEFI Spec, so I think the risk is low. But if consumers
will not show up until after the stable tag, perhaps this
should be one of the first patches after the stable tag.
Subject: [PATCH] MdePkg/DxeHstiLib: Added checks to improve error handling.
Added checks for return parameters of LocateHandleBuffer & GetSupportedTypes
function calls in InternalHstiFindAip to improve error handling. An issue was
observed on Dell Poweredge R740, where the Dell PERC H740P
Cc to all Stewards.
>-Original Message-
>From: Ni, Ray
>Sent: Tuesday, August 27, 2019 2:20 AM
>To: devel@edk2.groups.io; Ni, Ray
>Cc: Kinney, Michael D ; Gao, Liming
>
>Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908]
>MdePkg/BluetoothLeConfig.h: Add type
Michael,
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, August 23, 2019 7:54 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/IntelVTdDxe: Fix NULL
> pointer dereference
>
>
Reviewed-by: Sai Chaganty
-Original Message-
From: Kubacki, Michael A
Sent: Monday, August 26, 2019 11:48 AM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Chaganty, Rangasai V
Subject: [edk2-platforms][PATCH V3 1/2] CoffeelakeSiliconPkg: Fix GCC Build
Failures
Thanks David. No more comments for this patch.
> -Original Message-
> From: Wei, David Y
> Sent: Friday, August 23, 2019 10:06 AM
> To: Kubacki, Michael A ;
> devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Desimone, Nathaniel L
> ; Kinney,
Thanks for removing the batch files.
Regarding PcdNetworkEnable and PcdSmbiosEnable, any functionality in an
advanced feature package should not be enabled unless Stage 6 is selected. I
recommend binding these to gMinPlatformPkgTokenSpaceGuid.PcdBootStage now. If
that is a very involved
Thanks David. No more comments for this patch.
> -Original Message-
> From: Wei, David Y
> Sent: Thursday, August 22, 2019 3:31 PM
> To: Kubacki, Michael A ; devel@edk2.groups.io
> Cc: Wu, Hao A ; Gao, Liming ;
> Sinha, Ankit ; Agyeman, Prince
> ; Desimone, Nathaniel L
> ; Kinney, Michael
Mike,
I hit it when I was testing an OVMF build. It looks like the OVMF instructions
reference the generic getting started guide that omits the submodule update
command.
Thanks,
Andrew Fish
> On Aug 26, 2019, at 3:11 PM, Michael D Kinney
> wrote:
>
> Andrew,
>
> I agree the documentation
Andrew,
I agree the documentation for this should be in the same section as the clone
requirements.
This operation is not always required. Right now, if a platform does not use
OpenSSL in CryptoPkg, then the submodule operation can be skipped.
The documentation should let the developer know
pushed @ abc0155b03..30b4abc6e9.
> -Original Message-
> From: af...@apple.com
> Sent: Monday, August 26, 2019 2:10 PM
> To: Kinney, Michael D
> Cc: Ni, Ray ; devel@edk2.groups.io; tim.le...@insyde.com;
> leif.lindh...@linaro.org; Justen, Jordan L
>
> Subject: Re: [edk2-devel]
Liming,
I see the usage of Submodules is documented at the end of the Readme.md. I
would not think of going to a Submodules section to figure out how to get
started or clone the repo.
I did not think of reading the full Readme.md as most of it is about "How to
Contribute to" not how to use
Mike,
I'm OK with it going in.
Thanks,
Andrew Fish
> On Aug 26, 2019, at 2:01 PM, Kinney, Michael D
> wrote:
>
> Ray,
>
> Laszlo and I are OK with this change going into the stable tag.
>
> I would like to a response from Andrew or Leif.
>
> Mike
>
>> -Original Message-
>> From:
Ray,
Laszlo and I are OK with this change going into the stable tag.
I would like to a response from Andrew or Leif.
Mike
> -Original Message-
> From: Ni, Ray
> Sent: Monday, August 26, 2019 1:35 PM
> To: devel@edk2.groups.io; tim.le...@insyde.com; Kinney,
> Michael D
> Cc: Justen,
All,
As the package maintainer of EmulatorPkg, I should push the patches.
But I am not sure if there should be some ack from stewards regarding including
this patch in the coming stable tag.
What's the process?
Thanks,
Ray
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
Tested-by: Tim Lewis
-Original Message-
From: Michael D Kinney
Sent: Wednesday, August 21, 2019 7:36 PM
To: devel@edk2.groups.io
Cc: Jordan Justen ; Ray Ni ;
Andrew Fish ; Tim Lewis
Subject: [Patch][edk2-stable201908 0/2] EmulatorPkg/Win/Host: Fix image
unload regression
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2124
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110
Fixes GCC build failures in WhiskeylakeOpenBoardPkg and CoffeelakeSiliconPkg
(silicon package used by WhiskeylakeOpenBoardPkg).
V3 Changes:
*
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2110
Fixes build failures on GCC7.3.0. Tested on Ubunutu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Signed-off-by: Michael Kubacki
---
Platform/Intel/WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2124
Fixes build failures on GCC7.3.0. Tested on Ubuntu 18.04.1 LTS.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
---
Silicon/Intel/CoffeelakeSiliconPkg/Pch/Include/ConfigBlock/HdAudioConfig.h
| 2 ++
I understand it's now in code freeze phase.
Just make a try to see whether this very clean/simple header file change can be
included in the stable tag.
Any platform that uses BLE stack can get benefit from this definition update.
> -Original Message-
> From: devel@edk2.groups.io On
To support auto-connection, EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs to
add a new data type EfiBluetoothSmpPeerAddressList which associates
with a list of Bluetooth per address connected before.
This new data type was added in UEFI spec 2.7b.
Signed-off-by: Ray Ni
Cc: Michael D Kinney
Cc: Liming
On Fri, 16 Aug 2019 18:43:11 -0400
Boris Ostrovsky wrote:
> On 8/16/19 7:24 AM, Igor Mammedov wrote:
> > for purpose of demo SMRAM (at 0x3) is aliased at a in system
> > address space
> > for easy initialization of SMI entry point.
> > Here is resulting debug output showing that RAM at
On 08/26/19 00:45, Ni, Ray wrote:
> PcdCpuSmmRestrictedMemoryAccess is introduced to replace
> PcdCpuSmmStaticPageTable.
>
> Signed-off-by: Ray Ni
> Cc: Eric Dong
> Cc: Jiewen Yao
> Cc: Laszlo Ersek
> ---
> UefiCpuPkg/UefiCpuPkg.dec | 11 ---
> 1 file changed, 11 deletions(-)
>
>
On 08/26/19 00:45, Ni, Ray wrote:
> There are three PCDs that may impact the behavior of each other in
> SMM environment:
> PcdCpuSmmProfileEnable
> PcdHeapGuardPropertyMask in MdeModulePkg
> PcdCpuSmmRestrictedMemoryAccess
>
> The patch updates the comments in DEC file to document it.
>
>
On 08/26/19 00:45, Ni, Ray wrote:
> Today's behavior is to always restrict access to non-SMRAM regardless
> the value of PcdCpuSmmRestrictedMemoryAccess.
>
> Because RAS components require to access all non-SMRAM memory, the
> patch changes the code logic to honor PcdCpuSmmRestrictedMemoryAccess
On 08/26/19 00:45, Ni, Ray wrote:
> The patch changes PiSmmCpu driver to consume PCD
> PcdCpuSmmRestrictedMemoryAccess.
> Because the behavior controlled by PcdCpuSmmStaticPageTable in
> original code is not changed after switching to
> PcdCpuSmmRestrictedMemoryAccess.
>
> The functionality is
On 08/26/19 00:45, Ni, Ray wrote:
> The patch adds a new X64 only PCD PcdCpuSmmRestrictedMemoryAccess.
> The PCD indicates access to non-SMRAM memory is restricted to
> reserved, runtime and ACPI NVS type after SmmReadyToLock.
> MMIO access is always allowed regardless of the value of this PCD.
>
Marc,
Thanks for addressing the MdeModulePkg dependency in this patch.
Just one minor comment:
In SmmAccessLib.h, change
#ifndef _SMM_ACCESS_H_
To:
#ifndef _SMM_ACCESS_LIB_H_
This change avoids a potential macro conflict.
With that change, Reviewed-by: Ray Ni
> -Original Message-
>
On 08/23/19 17:25, Kinney, Michael D wrote:
> Hi Jiewen,
>
> If a hot add CPU needs to run any code before the
> first SMI, I would recommend is only executes code
> from a write protected FLASH range without a stack
> and then wait for the first SMI.
"without a stack" looks very risky to me.
Pushed 4d3395a9a54d575850fa12ca04326c797b7e1fe9
Re-order the statements as Supreeth's comment.
Best Regards
Eric
-Original Message-
From: Supreeth Venkatesh
Sent: Saturday, August 24, 2019 12:52 AM
To: Jin, Eric ; devel@edk2.groups.io
Subject: Re: [edk2-test][Patch V2 1/1]
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kubacki, Michael A
> Sent: Saturday, August 24, 2019 5:23 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Chaganty, Rangasai V
>
> Subject: [edk2-platforms][PATCH V2 1/2] CoffeelakeSiliconPkg: Fix GCC Build
> Failures
>
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Kubacki, Michael A
> Sent: Saturday, August 24, 2019 7:24 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Gao, Liming
> Subject:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2121
Implement SmmAccess for PEI and DXE phase in IntelSiliconPkg
Signed-off-by: Marc Chen
Cc: Ray Ni
Cc: Rangasai V Chaganty
---
.../Library/PeiSmmAccessLib/PeiSmmAccessLib.c | 343 +
52 matches
Mail list logo
