[edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: SNP ReceiveFilters may be unsupported

2019-09-16 Thread Heinrich Schuchardt
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2197 If EFI_SIMPLE_NETWORK.ReceiveFilters() is not supported, it will return EFI_UNSUPPORTED. In this case do not expect input parameters to be checked for conformance. Signed-off-by: Heinrich Schuchardt ---

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-16 Thread rebecca
On 8/29/19 2:22 PM, Michael D Kinney wrote: The following link is a link to an EDK II WIKI page that contains a summary of the work to date. Please provide feedback in the EDK II mailing lists. The WIKI pages will be updated with input from the entire EDK II community.

Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add check for pointers

2019-09-16 Thread Zhang, Shenglei
Hi Nathaniel, > -Original Message- > From: Desimone, Nathaniel L > Sent: Saturday, September 14, 2019 6:31 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Gao, Liming > Subject: Re: [edk2-devel] [PATCH] MinPlatformPkg/TestPointCheckLib: Add >

Re: [edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere

[edk2-devel] [PATCH v2 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 Inorder to support VS2019, we add VS2019 config process in Setup Batch Files, Because VS2019 and VS2017 could using same vswhere.exe to detect the InstallationPath, So we add the -version as the parameter of vswhere to get the correct

[edk2-devel] [PATCH v2 1/2] Add VS2019 Toolchain def

2019-09-16 Thread Cheng, Ching JenX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2182 In order to support VS2019, the first thing need to do is add 2019 toolchain on tools_def.template v2: add ARM/AARCH64/EBC Definitions, Combine VS2017_HOST and VS2019_HOST to VS_HOST Cc: Amy Chan Cc: Bob Feng Cc: Liming Gao

[edk2-devel] [PATCH v2 0/2] *** Add VS2019 Support ***

2019-09-16 Thread Cheng, Ching JenX
In order to support VS2019 on EDK2, the following patches was modified def and batch files 1. Add VS2019 x86/64 definitions on tools_def.template 2. Add VS2019 support on toolsetup batches, and add version check with command vswhere Because VS2019 and VS2017 using the same vswhere to get

Re: [edk2-devel] [Patch 0/6] Clean up NetworkPkg

2019-09-16 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming > Gao > Sent: 2019年9月17日 10:59 > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin ; > Wang, Jian J ; Wu, Hao A > Subject: [edk2-devel] [Patch 0/6] Clean up NetworkPkg > > Cc: Siyuan Fu

Re: [edk2-devel] [Patch 2/6] MdeModulePkg: Remove network related guid definitions from MdeModulePkg.dec

2019-09-16 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, September 17, 2019 10:59 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A > Subject: [edk2-devel] [Patch 2/6] MdeModulePkg: Remove network related > guid

[edk2-devel] [Patch 6/6] NetworkPkg: Remove unnecessary MdeModulePkg/MdeModulePkg.dec dependency in INF

2019-09-16 Thread Liming Gao
Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Liming Gao --- NetworkPkg/ArpDxe/ArpDxe.inf | 1 - NetworkPkg/Dhcp4Dxe/Dhcp4Dxe.inf | 1 - NetworkPkg/DnsDxe/DnsDxe.inf | 1 - NetworkPkg/HttpDxe/HttpDxe.inf | 1 -

[edk2-devel] [Patch 2/6] MdeModulePkg: Remove network related guid definitions from MdeModulePkg.dec

2019-09-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2196 Network related guid definitions have been moved into NetworkPkg.dec. So, they can be removed from MdeModulePkg.dec. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 10 -- 1 file

[edk2-devel] [Patch 4/6] NetworkPkg UefiPxeBcDxe: Consume PcdTftpBlockSize defined in NetworkPkg.dec

2019-09-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195 Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Liming Gao --- NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/NetworkPkg/UefiPxeBcDxe/UefiPxeBcDxe.inf

[edk2-devel] [Patch 0/6] Clean up NetworkPkg

2019-09-16 Thread Liming Gao
Cc: Siyuan Fu Cc: Jiaxin Wu Cc: Jian J Wang Cc: Hao A Wu Liming Gao (6): NetworkPkg: Move network related header files from MdeModulePkg to NetworkPkg MdeModulePkg: Remove network related guid definitions from MdeModulePkg.dec NetworkPkg: Add PcdTftpBlockSize in NetworkPkg.dec

[edk2-devel] [Patch 5/6] MdeModulePkg: Remove PCD gEfiMdeModulePkgTokenSpaceGuid.PcdTftpBlockSize

2019-09-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195 This PCD has been moved to NetworkPkg.dec file. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Liming Gao --- MdeModulePkg/MdeModulePkg.dec | 6 -- MdeModulePkg/MdeModulePkg.uni | 6 -- 2 files changed, 12 deletions(-) diff --git

[edk2-devel] [Patch 3/6] NetworkPkg: Add PcdTftpBlockSize in NetworkPkg.dec

2019-09-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2195 PcdTftpBlockSize is network related PCD. It should be defined in NetworkPkg.dec. Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Liming Gao --- NetworkPkg/NetworkPkg.dec | 7 +++ NetworkPkg/NetworkPkg.uni | 6 ++ 2 files changed, 13

[edk2-devel] [Patch 1/6] NetworkPkg: Move network related header files from MdeModulePkg to NetworkPkg

2019-09-16 Thread Liming Gao
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2196 Cc: Siyuan Fu Cc: Jiaxin Wu Signed-off-by: Liming Gao --- {MdeModulePkg => NetworkPkg}/Include/Guid/Ip4Config2Hii.h | 0 {MdeModulePkg => NetworkPkg}/Include/Guid/Ip4IScsiConfigHii.h | 0 {MdeModulePkg =>

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-16 Thread Zhang, Shenglei
Hi Nathaniel, Thanks for your comments and below is my response. > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, September 17, 2019 3:25 AM > To: Zhang, Shenglei ; devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Gao, Liming > Subject: RE: [PATCH v2]

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add HiiConfigAccess to IHV SCT binary package

2019-09-16 Thread Eric Jin
Pushed at a89b0fd0a8a0 to a7b07ad68ec3 -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Monday, September 16, 2019 3:25 PM To: devel@edk2.groups.io Cc: shrishail patil ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add

Re: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance

2019-09-16 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Bob Feng >Sent: Tuesday, September 10, 2019 5:37 PM >To: devel@edk2.groups.io >Subject: [edk2-devel] [Patch 0/3] Clean BaseTools code for build performance > >REF: >1

Re: [edk2-devel] [PATCH v5 1/1] MdePkg: UefiLib: Add a function to check if a language is supported

2019-09-16 Thread Liming Gao
Push @ea331a5c21f7d71980fe0ea2e4aa425474f8ffb2 >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Wednesday, September 11, 2019 10:56 PM >To: devel@edk2.groups.io; tz...@solarflare.com >Cc: Kinney, Michael D >Subject: Re:

Re: [edk2-devel] [PATCH v1 0/3] Replace VERIFY_SIZE_OF with STATIC_ASSERT

2019-09-16 Thread Liming Gao
Push @0d85e67714e31e0dbe4241ab2ebb7c423aba174d..d8c4b87ec460233d2c6f3e1343b6638f8b4a1ddf >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Liming Gao >Sent: Monday, September 09, 2019 8:54 AM >To: devel@edk2.groups.io; vit9...@protonmail.com

Re: [edk2-devel] [Patch v2] SecurityPkg Tcg2Config: Move common definitions to new Tcg2Internal.h

2019-09-16 Thread Zhang, Chao B
Reviewed-by : Chao Zhang From: Wang, Jian J Sent: Monday, September 16, 2019 1:57 PM To: Gao, Liming ; devel@edk2.groups.io Cc: Zhang, Chao B Subject: RE: [Patch v2] SecurityPkg Tcg2Config: Move common definitions to new Tcg2Internal.h Reviewed-by: Jian J Wang mailto:jian.j.w...@intel.com>>

Re: [edk2-devel] [PATCH 2/2] SecurityPkg/SecurityPkg.dec: Update TcgPpVendorLib.h to Tcg2PpVendorLib.h

2019-09-16 Thread Zhang, Chao B
Reviewed-by : Chao Zhang From: Wang, Jian J Sent: Monday, September 16, 2019 1:55 PM To: Zhang, Shenglei ; devel@edk2.groups.io Cc: Yao, Jiewen ; Zhang, Chao B Subject: RE: [PATCH 2/2] SecurityPkg/SecurityPkg.dec: Update TcgPpVendorLib.h to Tcg2PpVendorLib.h Reviewed-by: Jian J Wang

Re: [edk2-devel] [PATCH] Change package reviewer of CryptoPkg.

2019-09-16 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ye, Ting > Sent: Tuesday, September 17, 2019 8:44 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Ye, Ting > Subject: [edk2-devel] [PATCH] Change package reviewer of CryptoPkg. > > Remove Ting

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package

2019-09-16 Thread Eric Jin
Pushed at ef7d43a935b3 to fd26c74e0857 -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Monday, September 16, 2019 3:28 PM To: devel@edk2.groups.io Cc: shrishail patil ; Supreeth Venkatesh Subject: Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add

Re: [edk2-devel] [PATCH] Change package reviewer of CryptoPkg.

2019-09-16 Thread Xiaoyu Lu
Reviewed-by: Xiaoyu Lu > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ye, > Ting > Sent: Tuesday, September 17, 2019 8:44 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Ye, Ting > Subject: [edk2-devel] [PATCH] Change package reviewer of

Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib: Use STATIC_ASSERT macro

2019-09-16 Thread Gao, Zhichao
Reviewed-by: Zhichao Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Vitaly Cheptsov via Groups.Io > Sent: Saturday, August 17, 2019 7:58 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib:

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMultipleProtocols, checkpoint 7-9

2019-09-16 Thread Eric Jin
Push at d296b56b6aca94dcbb3fc4dffb4ed36051539084 -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Monday, September 16, 2019 10:31 AM To: devel@edk2.groups.io; xypron.g...@gmx.de Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test]

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo DuplicateDevicePath

2019-09-16 Thread Eric Jin
Pushed at 31a013a99e6db509dfdbe83dd874cc2ac014c4aa -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Monday, September 16, 2019 10:30 AM To: devel@edk2.groups.io; xypron.g...@gmx.de Cc: Supreeth Venkatesh ; Stephano Cetola Subject: Re: [edk2-devel] [edk2-test]

[edk2-devel] [edk2-platforms PATCH v2] SimicsOpenBoardPkg: Always set the boot priority by default

2019-09-16 Thread David Wei
When running networks of multiple machines, Simics assigns different disk IDs to each disk created.this change the boot priority and can't boot from SATA HDD directly. Clear boot priority in NVRAM can fix this issue. Cc: Hao Wu Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki

Re: [edk2-devel] [edk2-platforms] [PATCH v4 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-16 Thread Nate DeSimone
Never mind, I was looking at the wrong patch, sorry about that. Reviewed-by: Nate DeSimone -Original Message- From: devel@edk2.groups.io On Behalf Of Nate DeSimone Sent: Monday, September 16, 2019 1:51 PM To: Sinha, Ankit ; devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu, Chasel ;

Re: [edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services

2019-09-16 Thread Andrew Fish via Groups.Io
> On Sep 16, 2019, at 12:31 PM, Laszlo Ersek wrote: > > On 09/16/19 20:36, Andrew Fish wrote: >> >> >>> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote: >>> >>> On 09/13/19 16:50, Anthony PERARD wrote: This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid using the

Re: [edk2-devel] [edk2-platforms] [PATCH v4 1/1] MinPlatformPkg/Acpi: MADT NMI default flag set to Edge-Triggered

2019-09-16 Thread Nate DeSimone
Hi Ankit, This patch looks identical to PATCH V3 with the exception that you took away the update on the copyright year. May I ask why? Thanks, Nate -Original Message- From: Sinha, Ankit Sent: Monday, September 16, 2019 11:16 AM To: devel@edk2.groups.io Cc: Kubacki, Michael A ; Chiu,

Re: [edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services

2019-09-16 Thread Laszlo Ersek
On 09/16/19 20:36, Andrew Fish wrote: > > >> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote: >> >> On 09/13/19 16:50, Anthony PERARD wrote: >>> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid >>> using the Memory Allocation Services. >>> >>> This comes with a new interface

Re: [edk2-devel] [PATCH v2] MinPlatformPkg/TestPointCheckLib: Add return value when OutTable is NULL

2019-09-16 Thread Nate DeSimone
Hi Shenglei, I don't see how this patch is at all related to the previous version of this patch. Also, you are introducing yet another new bug with this patch. Moreover, this bug is unrelated to the previous bug. Please take a look at the function TestPointGetAcpi(). With your change added,

[edk2-devel] [PATCH] MdeModulePkg: Add missing sourceX for Blt

2019-09-16 Thread Gris87
There is no sourceX offset in case when Configure->PixelFormat == PixelBlueGreenRedReserved8BitPerColor. We are copying most left pixels instead of copying required rectangle. Signed-off-by: Gris87 Cc: Ruiyu Ni --- MdeModulePkg/Library/FrameBufferBltLib/FrameBufferBltLib.c | 2 +- 1 file

Re: [edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services

2019-09-16 Thread Andrew Fish via Groups.Io
> On Sep 16, 2019, at 10:36 AM, Laszlo Ersek wrote: > > On 09/13/19 16:50, Anthony PERARD wrote: >> This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid >> using the Memory Allocation Services. >> >> This comes with a new interface named RegisterExitCallback so that PV >>

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-16 Thread Laszlo Ersek
On 09/16/19 17:06, Yao, Jiewen wrote: > That is correct. > > Current trunk only supports ARM system. > > I have branch to support x86 - > https://github.com/jyao1/edk2/tree/StandaloneSmmX86Poc > But that is not merged into trunk yet. In that case, for this patch: Build-tested-by: Laszlo Ersek

Re: [edk2-devel] [edk2-non-osi PATCHv2 1/1] Platform/RaspberryPi/RPi3: Use official Device Tree binaries

2019-09-16 Thread Leif Lindholm
On Sun, Sep 15, 2019 at 10:49:52PM +0100, Pete Batard wrote: > With commit 5f003136c2bf86620c0caaef0ad146b5e7fd2f6b having been applied to > edk2-platforms, we can use the official Raspberry Pi 3 Device Trees from > https://github.com/raspberrypi/firmware/tree/master/boot, as the FdtDxe > driver

Re: [edk2-devel] [PATCH 09/11] OvmfPkg/XenBusDxe: Fix NotifyExitBoot to avoid Memory Allocation Services

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > This patch fix the EVT_SIGNAL_EXIT_BOOT_SERVICES handler to avoid > using the Memory Allocation Services. > > This comes with a new interface named RegisterExitCallback so that PV > drivers can disconnect from the backend before XenBusDxe is teared >

Re: [edk2-devel] [PATCH 08/11] OvmfPkg/XenBus: Change XENBUS_PROTOCOL to not return allocated memory

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > XsRead and XsBackendRead of the XENBUS_PROTOCOL return allocated > memory but this isn't allowed during the ExitBootServices call. We > need XsRead and XsBackendRead to disconnect from the device so > XENBUS_PROTOCOL is changed to use a buffer supplied by

Re: [edk2-devel] [PATCH 07/11] OvmfPkg/XenBusDxe: Use on stack buffer in internal functions

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > We will use a buffer on the stack instead of allocating memory for > internal functions that are expecting a reply from xenstore. > > The external interface XENBUS_PROTOCOL isn't changed yet, so > allocation are made for XsRead and XsBackendRead. > > Ref:

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package

2019-09-16 Thread Supreeth Venkatesh
Eric, Can you commit it as well? Thanks, Supreeth On Mon, 2019-09-16 at 02:27 -0500, Jin, Eric wrote: > The series is reviewed. > Reviewed-by: Eric Jin > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Eric > Jin > Sent: Wednesday, September 11, 2019 3:51 PM > To:

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add HiiConfigAccess to IHV SCT binary package

2019-09-16 Thread Supreeth Venkatesh
Eric, Can you push this as well? Thanks, Supreeth On Mon, 2019-09-16 at 02:25 -0500, Jin, Eric wrote: > The series is reviewed. > Reviewed-by: Eric Jin > > -Original Message- > From: devel@edk2.groups.io On Behalf Of Eric > Jin > Sent: Thursday, September 12, 2019 11:04 AM > To:

Re: [edk2-devel] [PATCH 2/2] Add VS2019 Support on ToolSetup Batches

2019-09-16 Thread Liming Gao
Jen: I add my comments. > -Original Message- > From: Cheng, Ching JenX > Sent: Wednesday, September 11, 2019 2:08 PM > To: devel@edk2.groups.io > Cc: Chan, Amy ; Feng, Bob C ; Gao, > Liming > Subject: [PATCH 2/2] Add VS2019 Support on ToolSetup Batches > > REF:

Re: [edk2-devel] [PATCH 05/11] OvmfPkg/XenBusDxe: Construct paths without allocation

2019-09-16 Thread Laszlo Ersek
On 09/16/19 17:39, Laszlo Ersek wrote: > On 09/13/19 16:50, Anthony PERARD wrote: >> When doing an action with a path and subpath in the xenstore, >> XenStoreJoin is called to generate "$path/$subpath". But this function >> do an allocation of memory which isn't necessary. Instead we will >>

Re: [edk2-devel] [PATCH 06/11] OvmfPkg/XenBusDxe: Rework XenStoreProcessMessage to avoid allocating memory

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > This patch rework XenStoreProcessMessage in order to avoid memory > allocation when a reply is expected. Instead of allocating a buffer > for this reply, we are going to copy to a buffer passed by the caller. > For messages that aren't fully received,

Re: [edk2-devel] [PATCH 05/11] OvmfPkg/XenBusDxe: Construct paths without allocation

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > When doing an action with a path and subpath in the xenstore, > XenStoreJoin is called to generate "$path/$subpath". But this function > do an allocation of memory which isn't necessary. Instead we will > construct the path with WRITE_REQUEST and data

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-16 Thread Yao, Jiewen
That is correct. Current trunk only supports ARM system. I have branch to support x86 - https://github.com/jyao1/edk2/tree/StandaloneSmmX86Poc But that is not merged into trunk yet. Thank you Yao Jiewen > -Original Message- > From: Ard Biesheuvel > Sent: Monday, September 16, 2019

Re: [edk2-devel] [PATCH 04/11] OvmfPkg/XenBusDxe: Avoid Allocate in XenStoreVSPrint

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > In order to be able to use XenStoreVSPrint during the > ExitBootServices, we remove the allocation done by the function and > use the stack instead. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190 > Signed-off-by: Anthony PERARD > --- >

Re: [edk2-devel] [PATCH 03/11] OvmfPkg/XenBusDxe: Rework watch events reception

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > This patch rework the reception of xenstore watch event to avoid > allocation. > > Instead of queuing watch events, we simply mark a XENSTORE_WATCH as > "triggered". We don't need to know how many time we received the > event, only that it happened. That

Re: [edk2-devel] [PATCH 02/11] OvmfPkg/XenBusDxe: Have XenStoreFindWatch take a pointer

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > Rework XenStoreFindWatch() to be able to search for a registered watch > with a pointer instead of a string. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2190 > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenBusDxe/XenStore.c | 20

Re: [edk2-devel] [PATCH 01/11] OvmfPkg/XenBusDxe: Fix missing \n in DEBUG messages

2019-09-16 Thread Laszlo Ersek
On 09/13/19 16:50, Anthony PERARD wrote: > Fix missing \n in DEBUG messages in XenBusDxe and use DEBUG_*. > > Signed-off-by: Anthony PERARD > --- > OvmfPkg/XenBusDxe/EventChannel.c | 3 ++- > OvmfPkg/XenBusDxe/XenStore.c | 6 +++--- > 2 files changed, 5 insertions(+), 4 deletions(-) > >

Re: [edk2-devel] [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console

2019-09-16 Thread Laszlo Ersek
Hi Zhichao, On 09/16/19 07:15, Gao, Zhichao wrote: > Hi Roy, Ard, Laszlo, > > Do you have any comment if I add the new terminal type to TtyTerm.h? As > PcAnsi.h, the spec mentioned terminal types are put into one header file. I've seen the original posting. I have no particular comments. In

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-16 Thread Ard Biesheuvel
On Mon, 16 Sep 2019 at 12:13, Laszlo Ersek wrote: > > Hi Ard, > > On 09/13/19 21:04, Ard Biesheuvel wrote: > > The StandaloneMmPkg .DSC file went out of sync with the changes > > applied to the package when I enabled this code on the Synquacer > > platform in edk2-platforms. So apply the

Re: [edk2-devel] [PATCH] StandaloneMmPkg: make package .DSC file build again

2019-09-16 Thread Laszlo Ersek
Hi Ard, On 09/13/19 21:04, Ard Biesheuvel wrote: > The StandaloneMmPkg .DSC file went out of sync with the changes > applied to the package when I enabled this code on the Synquacer > platform in edk2-platforms. So apply the necessary changes to make > this package build in isolation. > >

Re: [edk2-devel] [RFC] EDK II Continuous Integration Phase 1

2019-09-16 Thread Laszlo Ersek
Hi Sean, On 09/13/19 23:00, sean.brogan via [] wrote: > These tests require using the "edk2-pytool" stuff but are easy to integrate > with the github PR or CI flow.  Example of it running the code compliance > tests is here: >

Re: [edk2-devel] [PATCH 1/2] Add VS2019 Toolchain def

2019-09-16 Thread Pete Batard
Hi Allen, On 2019.09.16 03:25, Cheng, Ching JenX wrote: Hi Peter, Thanks for your kind comments, For the following comments 1. I will combine VS2017_HOST and VS2019_HOST to VS_HOST to apply both VS2017 and VS2019 plateforms, Great. 2. Sorry I just test x86/64 builds. So if it is ok,

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 03/22]: MdePkg: RISC-V sections in DEC file.

2019-09-16 Thread Leif Lindholm
On Mon, Sep 16, 2019 at 05:16:16AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Thursday, September 5, 2019 3:03 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: BaseTools: BaseTools changes for RISC-V platform.

2019-09-16 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Monday, September 9, 2019 7:37 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: > BaseTools: BaseTools changes

Re: [edk2-devel] [PATCH 0/2] Update lib class header files in DEC files

2019-09-16 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Zhang, Shenglei >Sent: Wednesday, September 04, 2019 4:17 PM >To: devel@edk2.groups.io >Cc: Kinney, Michael D ; Gao, Liming >; Yao, Jiewen ; Wang, Jian J >; Zhang, Chao B >Subject: [PATCH 0/2] Update lib class header files in DEC files

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add FMP test to IHV SCT binary package

2019-09-16 Thread Eric Jin
The series is reviewed. Reviewed-by: Eric Jin -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Wednesday, September 11, 2019 3:51 PM To: devel@edk2.groups.io Cc: shrishail patil ; Supreeth Venkatesh Subject: [edk2-devel] [edk2-test][Patch 3/3]

Re: [edk2-devel] [edk2-test][Patch 3/3] uefi-sct/SctPkg: Add HiiConfigAccess to IHV SCT binary package

2019-09-16 Thread Eric Jin
The series is reviewed. Reviewed-by: Eric Jin -Original Message- From: devel@edk2.groups.io On Behalf Of Eric Jin Sent: Thursday, September 12, 2019 11:04 AM To: devel@edk2.groups.io Cc: shrishail patil ; Supreeth Venkatesh Subject: [edk2-devel] [edk2-test][Patch 3/3]

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 13/22]: MdePkg/Include: Update SmBios header file.

2019-09-16 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Friday, September 6, 2019 12:17 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 13/22]: > MdePkg/Include: Update

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: BaseTools: BaseTools changes for RISC-V platform.

2019-09-16 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Thursday, September 5, 2019 11:45 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v1 11/22]: > BaseTools: BaseTools

Re: [edk2-devel] [edk2-platforms][PATCH V2 1/1] Platform/Intel/Readme.md: Content update

2019-09-16 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Saturday, September 14, 2019 10:09 AM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Bi, Dandan > ; Chaganty, Rangasai V > ; Chiu, Chasel ; Gao, > Liming ;

Re: [edk2-devel] [PATCH 1/2] EmulatorPkg/PeiEmuSerialPortLib: Update the INF file Guid

2019-09-16 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Zhang, > Shenglei > Sent: Thursday, September 5, 2019 3:47 PM > To: devel@edk2.groups.io > Cc: Zhang, Shenglei ; Justen, Jordan L > ; Andrew Fish > ; Ni, Ray > Subject: