Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Bob Feng
Pushed at SHA-1: 61af5f249495b18f45ca164376c871081448c0e4 Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of Bob Feng Sent: Friday, October 4, 2019 11:04 AM To: devel@edk2.groups.io; Kinney, Michael D ; Kubacki, Michael A Cc: Gao, Liming Subject: Re: [edk2-devel]

Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Bob Feng
Thanks for the fix. I agree. Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: Friday, October 4, 2019 5:14 AM To: devel@edk2.groups.io; Kubacki, Michael A ; Kinney, Michael D Cc: Feng, Bob C ; Gao, Liming Subject: Re:

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

2019-10-03 Thread Yao, Jiewen
Good catch! Reviewed by: Jiewen Yao > -Original Message- > From: Laszlo Ersek > Sent: Thursday, October 3, 2019 7:07 PM > To: Zhang, Chao B ; Wang, Jian J > ; Yao, Jiewen > Cc: edk2-devel-groups-io > Subject: Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT > for

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
I agree, I will make the default to enable the runtime cache. > -Original Message- > From: Kinney, Michael D > Sent: Thursday, October 3, 2019 3:01 PM > To: Kubacki, Michael A ; Wu, Hao A > ; devel@edk2.groups.io; Kinney, Michael D > > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ;

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Michael D Kinney
Michael, Perhaps the FeaturePCD for #2 should be enabled by default so the platform DSC only needs to set this PCD for some validation tests. Mike > -Original Message- > From: Kubacki, Michael A > Sent: Thursday, October 3, 2019 2:54 PM > To: Wu, Hao A ; devel@edk2.groups.io > Cc: Bi,

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
#1 - The plan is to remove the polling entirely in V3. #2 - I'd prefer to take a definitive direction and reduce validation and maintenance effort but you and Laszlo both requested this so I'll add a FeaturePCD to control activation of the runtime cache in this patch series.

Re: [edk2-devel] [PATCH V1 1/1] BaseTools: Fix GenMake multi-workspace failure

2019-10-03 Thread Michael D Kinney
Hi Michael, Reviewed-by: Michael D Kinney This look really important. Do you want me to push today? Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Kubacki, Michael A > Sent: Tuesday, October 1, 2019 3:58 PM > To: devel@edk2.groups.io > Cc: Feng, Bob C ; Gao,

[edk2-devel] [edk2-platforms] [PATCH 2/5] KabylakeOpenBoardPkg/KabylakeRvp3: Add BIOS Info PEIM

2019-10-03 Thread Agyeman, Prince
Added BIOS Info PEIM to KabylakeRvp3 to publish the BIOS info HOB. This PEIM currently publishs the board's microcode region info. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../KabylakeRvp3/BiosInfo/BiosInfo.c | 93 +++

[edk2-devel] [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation tool

2019-10-03 Thread Agyeman, Prince
Added fit generation tool to the build process. What was done: Added BIOS_INFO_GUID to the build.cfg Added BIOS_INFO_GUID to GalagoPro3, KabylakeRvp3 and WhiskeylakeURvp build_config.cfg This allows the boards to specify the GUID associated with the its Bios Info PEIM BIOS_INFO_GUID is passed

[edk2-devel] [edk2-platforms] [PATCH 0/5] Add FIT support using FitGen

2019-10-03 Thread Agyeman, Prince
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2210 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2211 This series of patches 1. Add the generation of the FitGen tool to build_bios.py 2. Add Firmware Interface Table (FIT) to the final images of: a.

[edk2-devel] [edk2-platforms] [PATCH 4/5] WhiskeylakeOpenBoardPkg: Add BIOS INFO PEIM

2019-10-03 Thread Agyeman, Prince
Added BIOS info PEIM to publish Bios Info HOB. This PEIM currently publishes the microcode FV info. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../WhiskeylakeURvp/BiosInfo/BiosInfo.c | 93 +++

[edk2-devel] [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB

2019-10-03 Thread Agyeman, Prince
Added gBiosInfoGuid to be used to publish BIOS information HOB which is needed in FIT generation Also added the Bios Info header file BiosInfo.h Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../Intel/BoardModulePkg/BoardModulePkg.dec | 3 +

[edk2-devel] [edk2-platforms] [PATCH 3/5] KabylakeOpenBoardPkg/GalagoPro3: Add BiosInfo PEIM

2019-10-03 Thread Agyeman, Prince
Added BiosInfo PEIM to publish the Bios Info HOB. Currently this PEIM publishes one Bios Info entry which is the microcode region information. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../GalagoPro3/BiosInfo/BiosInfo.c| 92

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

2019-10-03 Thread Michael D Kinney
Leif, Reviewed-by: Michael D Kinney I am covering for Liming and Bob this week, so you do not have to wait for a review from them to push these changes. Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Leif Lindholm > Sent: Tuesday, October 1, 2019 5:49 AM > To:

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Kubacki, Michael A
I understand the concern. I'm aware code is sometimes marked as runtime compatible though it is actually not and meeting all the criteria to work in the runtime environment is non-trivial as you noted. In response to series #2 patch #8, Andrew noted that the UEFI spec defines restrictions on

Re: [edk2-devel] [PATCH V2 8/9] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-10-03 Thread Kubacki, Michael A
Thanks Andrew, I had not seen that before. From: devel@edk2.groups.io On Behalf Of Andrew Fish via Groups.Io Sent: Thursday, October 3, 2019 12:00 PM To: devel@edk2.groups.io; Kubacki, Michael A Cc: Wu, Hao A ; Bi, Dandan ; Ard Biesheuvel ; Dong, Eric ; Laszlo Ersek ; Gao, Liming ; Kinney,

Re: [edk2-devel] [PATCH V2 8/9] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-10-03 Thread Andrew Fish via Groups.Io
> On Oct 3, 2019, at 1:52 PM, Kubacki, Michael A > wrote: > >>> -Done: >>> + mVariableRuntimeCacheReadLock = FALSE; >> >> >> Similar to the previous patch (7/9), >> if timeout occurs when acquiring the read lock, should this flag be set to >> FALSE in such case? >> > > Given that the

Re: [edk2-devel] [PATCH V2 8/9] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-10-03 Thread Kubacki, Michael A
> > -Done: > > + mVariableRuntimeCacheReadLock = FALSE; > > > Similar to the previous patch (7/9), > if timeout occurs when acquiring the read lock, should this flag be set to > FALSE in such case? > Given that the runtime service can be invoked in a multi-threaded OS environment, it is

Re: [edk2-devel] [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable functions

2019-10-03 Thread Kubacki, Michael A
I was debating on keeping this file in the patch series. I don't see a problem moving those other functions. The goal was to break out some of the NV-specific content from many of the other more generic functions in Variable.c Since you mentioned it, I will make that change in V3, unless I hear

Re: [edk2-devel] [PATCH V2 4/9] MdeModulePkg/Variable: Add local auth status in VariableParsing

2019-10-03 Thread Kubacki, Michael A
I will make the following changes in V3: > InitVariableParsing() seems an internal function, the 'EFIAPI' keyword can be > dropped. Please help to update the function definition in .C file as well. I will remove the EFIAPI keyword. > > diff --git

Re: [edk2-devel] [PATCH V2 3/9] MdeModulePkg/Variable: Parameterize VARIABLE_INFO_ENTRY buffer

2019-10-03 Thread Kubacki, Michael A
Your understanding is correct. Thanks, Michael > -Original Message- > From: Wu, Hao A > Sent: Thursday, October 3, 2019 1:04 AM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Laszlo Ersek > ; Gao, Liming ; Kinney, Michael > D ; Ni,

Re: [edk2-devel] [PATCH V2 2/9] MdeModulePkg/Variable: Parameterize GetNextVariableEx() store list

2019-10-03 Thread Kubacki, Michael A
Thanks for the feedback, I'll rename it back to VariableServiceGetNextVariableInternal () and update the comments to refer to FindVariableEx () instead of FindVariable () in V3. Thanks, Michael > -Original Message- > From: Wu, Hao A > Sent: Thursday, October 3, 2019 1:03 AM > To:

Re: [edk2-devel] [platforms/devel-riscv-v2 PATCHv3 00/13] Updates to sync-up with

2019-10-03 Thread Leif Lindholm
On Mon, Sep 23, 2019 at 11:40:24AM +0800, Abner Chang wrote: > This set of patches is updated to incorporate with patches sent for > edk2-staging/RISC-V-V2 PATCH v2. > > Abner Chang (13): > U500Pkg/OpenSbiPlatformLib: Use Fdtlib in EmbeddedPkg > U500Pkg/Sec: Remove unnecessary PCD reference >

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 14/14] Platforms: Readme file updates

2019-10-03 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 11:51:31AM +0800, Gilbert Chen wrote: > Update Readme.md and Maintainers.txt for RISV-V platforms. > > Signed-off-by: Gilbert Chen > --- > Maintainers.txt | 9 + > Readme.md | 11 +++ > 2 files changed, 20 insertions(+) > > diff --git

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 13/14] U500Pkg/PlatformPei: Platform initialization PEIM

2019-10-03 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 11:51:30AM +0800, Gilbert Chen wrote: > This is the platform-implementation specific library which is executed > in early PEI phase for platform initialization. > > Signed-off-by: Gilbert Chen > --- > .../SiFive/U500Pkg/Universal/Pei/PlatformPei/Fv.c | 49 >

Re: [edk2-devel] [PATCH V2 1/9] MdeModulePkg/Variable: Consolidate common parsing functions

2019-10-03 Thread Kubacki, Michael A
The main reason is cohesiveness in the VariableParsing.c file. These are functions that are commonly needed for general variable data structure parsing operations. Most of them just read a member or two in a VARIABLE_STORE_HEADER or VARIABLE_HEADER data structure, perform a simple calculation

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 12/14] U500Pkg/TimerDxe: Platform Timer DXE driver

2019-10-03 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 11:51:29AM +0800, Gilbert Chen wrote: > Timer DXE driver for U500 platform based U500 platform implementation > specifc timer registers. > > Signed-off-by: Gilbert Chen > --- > .../SiFive/U500Pkg/Universal/Dxe/TimerDxe/Timer.c | 311 > + >

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 11/14] U500Pkg/RamFvbServiceruntimeDxe: FVB driver for EFI variable.

2019-10-03 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 11:51:28AM +0800, Gilbert Chen wrote: > Firmware Volume Block driver instance for ram based EFI variable on U500 > platform. > > Signed-off-by: Gilbert Chen > --- > .../Dxe/RamFvbServicesRuntimeDxe/FvbInfo.c | 127 +++ > .../FvbServicesRuntimeDxe.inf

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 10/14] U500Pkg/Library: Library instances of U500 platform library

2019-10-03 Thread Leif Lindholm
On Thu, Sep 19, 2019 at 11:51:27AM +0800, Gilbert Chen wrote: > OpneSbiPlatformLib > - In order to reduce the dependencies with RISC-V OpenSBI project > (https://github.com/riscv/opensbi) and less burdens to EDK2 build > process, the implementation of RISC-V EDK2 platform is leverage > platform

[edk2-devel] Upcoming Event: TianoCore Community Meeting - EMEA/NAMO - Thu, 10/03/2019 9:00am-10:00am #cal-reminder

2019-10-03 Thread devel@edk2.groups.io Calendar
*Reminder:* TianoCore Community Meeting - EMEA/NAMO *When:* Thursday, 3 October 2019, 9:00am to 10:00am, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=484143 ) *Organizer:* Stephano Cetola

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Lendacky, Thomas
On 10/3/19 5:32 AM, Laszlo Ersek wrote: > On 10/03/19 12:12, Laszlo Ersek wrote: > >> UINT32 ApEntryPoint; >> EFI_GUID SevEsFooterGuid; >> UINT16 Size; > > It's probably better to reverse the order of "Size" and > "SevEsFooterGuid", like this: > > UINT32 ApEntryPoint; > UINT16

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

2019-10-03 Thread Achin Gupta
Hi Laszlo, Apologies for not getting back earlier as I was travelling. I will have a look and get back by tomorrow. cheers, Achin On Thu, Oct 03, 2019 at 01:10:53PM +0200, Laszlo Ersek wrote: > Pinging StandaloneMmPkg maintainers again, for reviewing this patch. > > Thanks > Laszlo > > On

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

2019-10-03 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 4:38 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: af...@apple.com; Philippe Mathieu-Daudé ; Mike > Kinney ;

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

2019-10-03 Thread Laszlo Ersek
Pinging StandaloneMmPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:48, Laszlo Ersek wrote: > Achin, Jiewen, Supreeth, > > can one of you guys please review this patch? > > Thanks > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> The FvHasBeenProcessed() and

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

2019-10-03 Thread Laszlo Ersek
Pinging SecurityPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:46, Laszlo Ersek wrote: > Chao, Jian, Jiewen, > > can you please review this patch? > > Thanks, > Laszlo > > > On 09/17/19 21:49, Laszlo Ersek wrote: >> EfiCreateProtocolNotifyEvent() takes a

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

2019-10-03 Thread Laszlo Ersek
Pinging SecurityPkg maintainers again, for reviewing this patch. Thanks Laszlo On 09/26/19 14:45, Laszlo Ersek wrote: > Chao, Jian, Jiewen, > > can you please review this patch? > > Thanks, > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> Unlike the InstallMultipleProtocolInterfaces()

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

2019-10-03 Thread Laszlo Ersek
Pinging NetworkPkg maintainers again. Please? Thanks Laszlo On 09/26/19 14:14, Laszlo Ersek wrote: > Jiaxin, Siyuan, > > can you please review this patch? > > Thanks > Laszlo > > On 09/17/19 21:49, Laszlo Ersek wrote: >> NetLibGetSnpHandle() returns an EFI_HANDLE, not an (EFI_HANDLE*). >>

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-03 Thread Laszlo Ersek
On 10/03/19 10:04, Wu, Hao A wrote: > Before any comment on the patch, since I am not experienced in the Variable > driver, I would like to ask for help from other reviewers to look into this > patch and provide feedbacks as well. Thanks in advance. > > With the above fact, some comments provided

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/03/19 12:12, Laszlo Ersek wrote: > UINT32 ApEntryPoint; > EFI_GUID SevEsFooterGuid; > UINT16 Size; It's probably better to reverse the order of "Size" and "SevEsFooterGuid", like this: UINT32 ApEntryPoint; UINT16 Size; EFI_GUID SevEsFooterGuid; because then even the

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/02/19 20:07, Lendacky, Thomas wrote: > On 10/2/19 10:26 AM, Laszlo Ersek wrote: >> On 10/02/19 17:15, Laszlo Ersek wrote: >>> Adding Phil. >>> >>> I'm looking at this patch only because one thing caught my attention in >>> the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector

Re: [edk2-devel] [RFC PATCH v2 38/44] UefiCpuPkg: Allow AP booting under SEV-ES

2019-10-03 Thread Laszlo Ersek
On 10/02/19 19:58, Lendacky, Thomas wrote: > On 10/2/19 10:15 AM, Laszlo Ersek via Groups.Io wrote: >> Adding Phil. >> >> I'm looking at this patch only because one thing caught my attention in >> the previous one, "OvmfPkg: Add support for SEV-ES AP reset vector >> re-directing": >> >> On

Re: [edk2-devel] [RFC PATCH v2 37/44] OvmfPkg: Add support for SEV-ES AP reset vector re-directing

2019-10-03 Thread Laszlo Ersek
On 10/02/19 19:33, Lendacky, Thomas wrote: > On 10/2/19 9:54 AM, Laszlo Ersek wrote: >> On 09/19/19 21:53, Lendacky, Thomas wrote: >>> From: Tom Lendacky >>> >>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2198 >>> >>> A hypervisor is not allowed to update an SEV-ES guests register state,

Re: [edk2-devel] [RFC PATCH v2 10/44] OvmfPkg: A per-CPU variable area for #VC usage

2019-10-03 Thread Laszlo Ersek
On 10/02/19 18:06, Lendacky, Thomas wrote: > On 10/2/19 6:51 AM, Laszlo Ersek wrote: >> ... Side question: actually, do we support S3 with SEV enabled, at the >> moment? Last week or so I tried to test it, and it didn't work. I don't >> remember if we *intended* to support S3 in SEV guests at

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 09/29] MdePkg/BaseIoLibIntrinsic: RISC-V I/O intrinsic functions.

2019-10-03 Thread Leif Lindholm
On Thu, Oct 03, 2019 at 12:52:57AM +, Abner Chang wrote: > > > So is the plan to just copy IoLibArm.c to IoLibRiskV.c? I kind of > > > agree with Leif that having two copies of the same thing does not make > > > sense. I do see your point about naming, but maybe the issue the > > > IoLibArm.c

Re: [edk2-devel] [PATCH V2 8/9] MdeModulePkg/Variable: Add RT GetNextVariableName() cache support

2019-10-03 Thread Wu, Hao A
> -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen > Subject: [PATCH V2 8/9]

Re: [edk2-devel] [PATCH V2 6/9] MdeModulePkg VariableInfo: Always consider RT DXE and SMM stats

2019-10-03 Thread Wu, Hao A
> -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen > Subject: [PATCH V2 6/9]

Re: [edk2-devel] [PATCH V2 3/9] MdeModulePkg/Variable: Parameterize VARIABLE_INFO_ENTRY buffer

2019-10-03 Thread Wu, Hao A
> -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen > Subject: [PATCH V2 3/9]

Re: [edk2-devel] [PATCH V2 5/9] MdeModulePkg/Variable: Add a file for NV variable functions

2019-10-03 Thread Wu, Hao A
> -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao, Jiewen > Subject: [PATCH V2 5/9]

Re: [edk2-devel] [PATCH V2 4/9] MdeModulePkg/Variable: Add local auth status in VariableParsing

2019-10-03 Thread Wu, Hao A
Inline comments below: > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming;

Re: [edk2-devel] [PATCH V2 2/9] MdeModulePkg/Variable: Parameterize GetNextVariableEx() store list

2019-10-03 Thread Wu, Hao A
A couple of inline comments below: > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao,

Re: [edk2-devel] [PATCH V2 1/9] MdeModulePkg/Variable: Consolidate common parsing functions

2019-10-03 Thread Wu, Hao A
A couple of inline comments below: > -Original Message- > From: Kubacki, Michael A > Sent: Saturday, September 28, 2019 9:47 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney, > Michael D; Ni, Ray; Wang, Jian J; Wu, Hao A; Yao,

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used.

2019-10-03 Thread Nate DeSimone
Good catch, thank you! -Original Message- From: devel@edk2.groups.io On Behalf Of Philippe Mathieu-Daudé Sent: Thursday, October 3, 2019 12:40 AM To: devel@edk2.groups.io; Desimone, Nathaniel L Cc: Chiu, Chasel ; Kubacki, Michael A ; Jeremy Soller Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used.

2019-10-03 Thread Nate DeSimone
Thanks Michael. Another thing we should consider doing a some point in the future is moving the PlatformSecLib implementation that supports dispatch mode from KabylakeOpenBoardPkg to MinPlatformPkg. -Original Message- From: Kubacki, Michael A Sent: Wednesday, October 2, 2019 6:35 PM

Re: [edk2-devel] [edk2-platforms][PATCH V1 0/3] Add FW Boot Media Device Indicator

2019-10-03 Thread Kubacki, Michael A
Thanks for sharing. You articulated well why I also don't think this is required in MdePkg. My description of the reset vector problem was kind of incomplete. While the x86 reset vector is fixed at the top of the address space, that does not mean that a FV has to be mapped to it (or any SPI

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg: Wrong instance of PlatformSecLib is used.

2019-10-03 Thread Philippe Mathieu-Daudé
On 10/2/19 9:40 AM, Nate DeSimone wrote: The GalagoPro3 platform in KabylakeOpenBoardPkg is using the instance of PlatformSecLib in MinPlatformPkg instead of the instance in KabylakeOpenBoardPkg. The version in MinPlatformPkg does not support FSP 2.1 Dispatch Mode, whearas the version in typo: