Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-04 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Desimone, Nathaniel L Sent: Friday, October 04, 2019 1:14 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Kubacki, Michael A ; Chaganty, Rangasai V Subject: [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSER

[edk2-devel] Ice Lake FSP Released

2019-10-04 Thread Nate DeSimone
Hi All, Intel is pleased to announce that Ice Lake FSP is now available on https://github.com/IntelFsp/FSP. With Best Regards, Nate -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#48493): https://edk2.groups.io/g/devel/message/48493 Mu

Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds.

2019-10-04 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, October 4, 2019 1:45 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Jeremy Soller > Subject: [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Resize FSP-T > to acc

Re: [edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-04 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Desimone, Nathaniel L > Sent: Friday, October 4, 2019 1:14 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael A > ; Chaganty, Rangasai V > > Subject: [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in

[edk2-devel] [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Resize FSP-T to accommodate debug FSP builds.

2019-10-04 Thread Nate DeSimone
Resize the flash map for the GalagoPro3 platform to provide enough space to accommodate a debug build of FSP-T. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Jeremy Soller Signed-off-by: Nate DeSimone --- .../GalagoPro3/Include/Fdf/FlashMapInclude.fdf | 6 +++--- 1 file changed, 3 inse

[edk2-devel] [edk2-platforms] [PATCH V2] KabylakeSiliconPkg: Logic Error in EISS bit ASSERT

2019-10-04 Thread Nate DeSimone
Current ASSERT logic checks that the EISS bit is still set after we clear it. This is incorrect, it should be checking that that the EISS bit is clear after we clear it. Cc: Chasel Chiu Cc: Michael Kubacki Cc: Sai Chaganty Signed-off-by: Nate DeSimone --- .../Intel/KabylakeSiliconPkg/Pch/Libr

Re: [edk2-devel] [PATCH 25/35] OvmfPkg/VideoDxe: document EFI_EDID_OVERRIDE_PROTOCOL.GetEdid() call

2019-10-04 Thread Laszlo Ersek
On 09/26/19 14:43, Laszlo Ersek wrote: > On 09/23/19 17:59, Philippe Mathieu-Daudé wrote: >> Hi Laszlo, >> >> On 9/17/19 9:49 PM, Laszlo Ersek wrote: >>> According to the UEFI spec -- and to the edk2 header >>> "MdePkg/Include/Protocol/EdidOverride.h" too --, >>> EFI_EDID_OVERRIDE_PROTOCOL_GET_EDID

Re: [edk2-devel] [edk2-platforms: PATCH 1/1] DisplayLinkPkg: DisplayLinkGop: Added GOP driver for USB docking stations based on DisplayLink chips

2019-10-04 Thread Laszlo Ersek
Hello Andy, I've got a question about your edk2-platforms commit 9df63499ea01 (i.e., this patch): On 08/30/19 17:27, Leif Lindholm wrote: > On Mon, Aug 19, 2019 at 02:32:00PM +0100, Andy Hayes wrote: [...] >> diff --git a/Drivers/DisplayLink/DisplayLinkPkg/DisplayLinkGop/Edid.c >> b/Drivers/Di

Re: [edk2-devel] [PATCH 18/35] NetworkPkg/DxeNetLib: fix type typo in NetLibGetMacAddress()

2019-10-04 Thread Laszlo Ersek
Ping On 10/03/19 13:05, Laszlo Ersek wrote: > Pinging NetworkPkg maintainers again. Please? > > Thanks > Laszlo > > On 09/26/19 14:14, Laszlo Ersek wrote: >> Jiaxin, Siyuan, >> >> can you please review this patch? >> >> Thanks >> Laszlo >> >> On 09/17/19 21:49, Laszlo Ersek wrote: >>> NetLibGetS

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

2019-10-04 Thread Laszlo Ersek
On 10/04/19 15:14, Zhang, Chao B wrote: > Hi Laszlo: >Sorry for late response. The fix is good to me. Thanks! Can you give Reviewed-by or Acked-by? > I am also interested in how you find this issue, can you share it? Sure, please see the explanation in patches #00 and #01 (I CC'd you on the

[edk2-devel] [edk2-platforms][PATCH V2 2/3] BoardModulePkg/FirmwareBootMediaInfoLib: Add library

2019-10-04 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2229 Introduces a new library class FirmwareBootMediaInfoLib that is used to report the firmware boot media device. A default library instance is provided that always returns the firmware boot media is SPI flash. For platforms with other firmware

[edk2-devel] [edk2-platforms][PATCH V2 0/3] Add FW Boot Media Device Indicator

2019-10-04 Thread Kubacki, Michael A
V2 Changes: 1. Add the new libraries in BoardModulePkg and IntelSiliconPkg to the package DSC files so they are included in the package build. This patch series introduces a mechanism for determining the firmware boot media device. This allows the firmware boot media to be discovered through

[edk2-devel] [edk2-platforms][PATCH V2 3/3] BoardModulePkg/FirmwareBootMediaInfoPei: Add module

2019-10-04 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2229 Adds a new module that is responsible for publishing the boot media device information that will be used in the boot flow for system initialization decisions dependent upon firmware boot media. The module depends on a library class to implem

[edk2-devel] [edk2-platforms][PATCH V2 1/3] IntelSiliconPkg/FirmwareBootMediaLib: Add library

2019-10-04 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2229 Adds a new library that is used to make system initialization decisions in the boot flow dependent upon firmware boot media. Note that the firmware boot media is the storage media that the boot firmware is stored on. It is not the OS storage

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Kubacki, Michael A
> On 10/03/19 23:53, Kubacki, Michael A wrote: > > #1 - The plan is to remove the polling entirely in V3. > > > > #2 - I'd prefer to take a definitive direction and reduce validation and > maintenance > > effort but you and Laszlo both requested this so I'll add a > > FeaturePCD > to contr

Re: [edk2-devel] [PATCH V2 7/9] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-04 Thread Kubacki, Michael A
> On 10/04/19 01:31, Kubacki, Michael A wrote: > > I agree, I will make the default to enable the runtime cache. > > I've just made a request for the opposite :) , before reading this part > of the thread. > > Let me revise my request then, seeing the above preference. From the > following three

Re: [edk2-devel] [PATCH 33/35] StandaloneMmPkg/Core: stop abusing EFI_HANDLE for FwVolHeader tracking

2019-10-04 Thread Achin Gupta
Makes sense! Reviewed-by: Achin Gupta On Thu, Oct 03, 2019 at 01:10:53PM +0200, Laszlo Ersek wrote: > Pinging StandaloneMmPkg maintainers again, for reviewing this patch. > > Thanks > Laszlo > > On 09/26/19 14:48, Laszlo Ersek wrote: > > Achin, Jiewen, Supreeth, > > > > can one of you guys pleas

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

2019-10-04 Thread Michael D Kinney
Hi Leif, Do you want to run the same script on the edk2-platforms repo? Thanks, Mike > -Original Message- > From: devel@edk2.groups.io On > Behalf Of Leif Lindholm > Sent: Friday, October 4, 2019 3:20 AM > To: Kinney, Michael D > Cc: devel@edk2.groups.io; Feng, Bob C > ; Gao, Liming >

Re: [edk2-devel] [PATCH v2] MdePkg:Include: Update SmBios header file

2019-10-04 Thread Abner Chang
Just aware that SMBIOS 3.3.0 is published on DMTF, https://www.dmtf.org/standards/smbios The latest version of patch set is PATCH v4, please review it and help to push to mainstream if no further comments. Thanks Abner > -Original Message- > From: Gao, Liming [mailto:liming@intel.com

Re: [edk2-devel] [PATCH wave 1 00/10] support QEMU's "SMRAM at default SMBASE" feature

2019-10-04 Thread Igor Mammedov
On Tue, 1 Oct 2019 17:31:17 +0200 "Laszlo Ersek" wrote: > On 09/27/19 13:35, Igor Mammedov wrote: > > On Tue, 24 Sep 2019 13:34:55 +0200 > > "Laszlo Ersek" wrote: > > >> Going forward, if I understand correctly, the plan is to populate the > >> new SMRAM with the hotplug SMI handler. (This wo

Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify registration

2019-10-04 Thread Zhang, Chao B
Reviewed-by : Chao Zhang -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: 2019年10月3日 19:07 To: Zhang, Chao B ; Wang, Jian J ; Yao, Jiewen Cc: edk2-devel-groups-io Subject: Re: [edk2-devel] [PATCH 27/35] SecurityPkg: stop abusing EFI_EVENT for protocol notify reg

Re: [edk2-devel] [PATCH 26/35] SecurityPkg: fix UninstallMultipleProtocolInterfaces() calls

2019-10-04 Thread Zhang, Chao B
Hi Laszlo: Sorry for late response. The fix is good to me. I am also interested in how you find this issue, can you share it? -Original Message- From: Laszlo Ersek [mailto:ler...@redhat.com] Sent: 2019年10月3日 19:07 To: Zhang, Chao B ; Wang, Jian J ; Yao, Jiewen Cc: edk2-devel-groups

Re: [edk2-devel] [Qemu-devel] [PATCH 1/2] q35: implement 128K SMRAM at default SMBASE address

2019-10-04 Thread Igor Mammedov
On Tue, 1 Oct 2019 20:03:20 +0200 "Laszlo Ersek" wrote: > On 09/30/19 16:22, Yao, Jiewen wrote: > > > >> -Original Message- > >> From: devel@edk2.groups.io On Behalf Of Igor > >> Mammedov > >> Sent: Monday, September 30, 2019 8:37 PM > >> To: Laszlo Ersek > > >>> To me it looks li

Re: [edk2-devel] [PATCH v2 3/7] BaseTools: strip trailing whitespace

2019-10-04 Thread Leif Lindholm
Mike, others, Many thanks - series pushed as 61af5f249495..d19040804afb / Leif On Thu, Oct 03, 2019 at 09:05:05PM +, Kinney, Michael D wrote: > Leif, > > Reviewed-by: Michael D Kinney > > I am covering for Liming and Bob this week, so you do not > have to wait for a review from them t