REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2249
PCDs declared in the SimicsOpenBoardPkg currently use the GUID
gBoardModuleTokenSpaceGuid. The same name is used in other board
packages and a package has been added called BoardModulePkg so
this name is now misleading.
This change assigns
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2247
PCDs declared in the KabylakeOpenBoardPkg currently use the GUID
gBoardModuleTokenSpaceGuid. The same name is used in other board
packages and a package has been added called BoardModulePkg so
this name is now misleading.
This change
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2242
This change refactors OpenBoardPkg.dsc and OpenBoardPkgPcd.dsc to
consolidate redundant sections and better group file content to
improve maintainability and readability.
The same pattern made in this change for KabylakeRvp3 is being
Sets the FSP-T, FSP-M, and FSP-S base address PCDs based on the flash map.
Previously these were hardcoded in the DSC file.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
---
Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.fdf | 3 +++
1 file changed, 3
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2242
The location for PCD configuration is currently inconsistent in
KabylakeOpenBoardPkg. A large set of FeaturePCD definitions are
in OpenBoardPkgConfig.dsc while other PCD definitions (including
FeaturePCD) are located in OpenBoardPkgPcd.dsc.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2243
The location for PCD configuration is currently inconsistent in
WhiskeylakeOpenBoardPkg. A large set of FeaturePCD definitions are
in OpenBoardPkgConfig.dsc while other PCD definitions (including
FeaturePCD) are located in
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2242
The location for PCD configuration is currently inconsistent in
KabylakeOpenBoardPkg. A large set of FeaturePCD definitions are
in OpenBoardPkgConfig.dsc while other PCD definitions (including
FeaturePCD) are located in OpenBoardPkgPcd.dsc.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2244
The location for PCD configuration is currently inconsistent in
SimicsOpenBoardPkg. A large set of FeaturePCD definitions are
in OpenBoardPkgConfig.dsc while other PCD definitions (including
FeaturePCD) are located in OpenBoardPkgPcd.dsc.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2246
The DSC LibraryClass files in CoffeelakeSiliconPkg that are intended
to be included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc,
and SiPkgCommonLib.dsc should have section tags so that they are
not dependent on the top-level DSC file
This change moves the include of OpenBoardPkgPcd.dsc to the top of
OpenBoardPkg.dsc to improve visibility and align the include
location with other board DSC files.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Jeremy Soller
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2242
This change refactors OpenBoardPkg.dsc and OpenBoardPkgPcd.dsc to
consolidate redundant sections and better group file content to
improve maintainability and readability.
The same pattern made in this change for GalagoPro3 is being
applied
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2243
This change refactors OpenBoardPkg.dsc and OpenBoardPkgPcd.dsc to
consolidate redundant sections and better group file content to
improve maintainability and readability.
The same pattern made in this change for WhiskeylakeURvp is being
This change moves the include of OpenBoardPkgPcd.dsc to the top of
OpenBoardPkg.dsc to improve visibility and align the placement with
other board DSC files.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2245
The DSC LibraryClass files in KabylakeSiliconPkg that are intended
to be included elsewhere such as SiPkgPeiLib.dsc, SiPkgDxeLib.dsc,
and SiPkgCommonLib.dsc should have section tags so that they are
not dependent on the top-level DSC file to
This change moves the following DSC file includes to the top of
the OpenBoardPkg.dsc file. This is to improve visibility and
align placement of the include with other board DSC files.
* OpenBoardPkgConfig.dsc
* OpenBoardPkgPcd.dsc
* CorePeiLib.dsc
* CoreDxeLib.dsc
Cc: Agyeman Prince
Cc: Wei
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2244
This change refactors OpenBoardPkg.dsc and OpenBoardPkgPcd.dsc to
consolidate redundant sections and better group file content to
improve maintainability and readability.
The same pattern made in this change for BoardX58Ich10 is being
This patch series affects the following packages/boards.
1. KabylakeOpenBoardPkg/KabylakeRvp3
2. KabylakeOpenBoardPkg/GalagoPro3
3. WhiskeylakeOpenBoardPkg/WhiskeylakeURvp
4. SimicsOpenBoardPkg/BoardX58Ich10
The following high-level changes are done for each board.
1. Remove the file
With this typo correction, Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Thursday, October 3, 2019 3:56 PM
> To: devel@edk2.groups.io; phi...@redhat.com
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Jeremy Soller
> Subject: RE: [edk2-devel]
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Saturday, October 5, 2019 4:45 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Jeremy Soller
> Subject: [edk2-platforms] [PATCH V2] KabylakeOpenBoardPkg: Resize FSP-T to
>
Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Nate
> DeSimone
> Sent: Saturday, October 5, 2019 4:14 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Kubacki, Michael A
> ; Chaganty, Rangasai V
>
> Subject: [edk2-devel] [edk2-platforms]
Inline replies below:
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, October 04, 2019 5:54 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen
> Subject:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Kubacki, Michael A
> Sent: Friday, October 04, 2019 2:06 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni,
> -Original Message-
> From: Kubacki, Michael A
> Sent: Friday, October 04, 2019 1:36 AM
> To: Wu, Hao A; devel@edk2.groups.io
> Cc: Bi, Dandan; Ard Biesheuvel; Dong, Eric; Laszlo Ersek; Gao, Liming; Kinney,
> Michael D; Ni, Ray; Wang, Jian J; Yao, Jiewen
> Subject: RE: [PATCH V2 1/9]
Looking at the commit message in more detail, it should be cleaned up in V2.
Please try to clarify the following specifically:
"boards to specify the GUID associated with the its Bios Info PEIM"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent:
Please also fix the typo in the commit message "publishs".
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kubacki,
> Michael A
> Sent: Monday, October 7, 2019 6:31 PM
> To: Agyeman, Prince ; devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
>
> Subject: Re:
* Please include the version number in the subject.
* Although minor, the commit description unnecessarily varies between commits.
It would be better to keep it consistent.
#2: "Add BIOS Info PEIM", #3: "Add BiosInfo PEIM", #4: "Add BIOS INFO PEIM"
> -Original Message-
> From:
Reviewed-by: Michael Kubacki
> -Original Message-
> From: Agyeman, Prince
> Sent: Thursday, October 3, 2019 2:13 PM
> To: devel@edk2.groups.io
> Cc: Sinha, Ankit ; Desimone, Nathaniel L
> ; Kubacki, Michael A
>
> Subject: [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation
Same feedback as patch #2:
BiosInfo.c:
BiosInfoEntryPoint () function description should be updated. The function
installs the BiosInfo PPI
but also produces the BiosInfo HOB.
It also looks like you can remove the following macros for now:
#define INDEXPORT_TO_ADDRESS(x) (x)
As mentioned in patch #2, the same PEIM can be used for KabylakeRvp3 and
GalagoPro3 for now.
> -Original Message-
> From: Desimone, Nathaniel L
> Sent: Monday, October 7, 2019 3:27 PM
> To: Agyeman, Prince ; devel@edk2.groups.io
> Cc: Sinha, Ankit ; Kubacki, Michael A
>
> Subject: RE:
BiosInfo.c:
BiosInfoEntryPoint () function description should be updated. The function
installs the BiosInfo PPI
but also produces the BiosInfo HOB.
It also looks like you can remove the following macros:
#define INDEXPORT_TO_ADDRESS(x) (x)
#define DATAPORT_TO_ADDRESS(x)
Abner:
Thanks for your notice. I see the public SMBIOS 3.3.0.
For this patch set, I have two minor comments. For other part, Reviewed-by:
Liming Gao
1) Please add BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2202 in the
commit message.
2) The comment for
For now, this is definitely possible.
It may also be viable long term. The table is closely tied to the FV layout
which is
standardized under Minimum Platform. Firmware volumes that may come and go like
those for
a particular advanced feature would end up as child FVs under a FvAdvanced
parent
Library/BiosInfo.h:
1. I think the file description can be more accurate and useful than "Driver
for BIOS Info support."
This header file is not a driver or restricted to any particular driver in
this location. I would
generalize the comment.
2. This file is not related to a
Just return from vacation. Sorry for late response.
Reviewed-by: Siyuan Fu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Philippe
> Mathieu-Daudé
> Sent: 2019年9月24日 19:00
> To: devel@edk2.groups.io; ler...@redhat.com
> Cc: Wu, Jiaxin ; Fu, Siyuan
> Subject: Re:
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c and
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c are
identical files. Can we move this up to the parent KabylakeOpenBoardPkg and use
one PEIM for both platforms?
-Original Message-
From: Agyeman,
Same comment as PATCH 2 & 3, it seems like this PEIM could be used generically
by any Whiskeylake board so I would prefer one copy of it in
WhiskeylakeOpenBoardPkg.
-Original Message-
From: Agyeman, Prince
Sent: Thursday, October 3, 2019 2:13 PM
To: devel@edk2.groups.io
Cc: Sinha,
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Thursday, October 3, 2019 2:13 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Kubacki, Michael A
Subject: [edk2-platforms] [PATCH 5/5] Platform/Intel: Add FIT generation tool
Added fit
Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/BiosInfo/BiosInfo.c and
Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/BiosInfo/BiosInfo.c are
identical files. Can we move this up to the parent KabylakeOpenBoardPkg and use
one PEIM for both platforms?
-Original Message-
From: Agyeman,
Reviewed-by: Nate DeSimone
-Original Message-
From: Agyeman, Prince
Sent: Thursday, October 3, 2019 2:13 PM
To: devel@edk2.groups.io
Cc: Sinha, Ankit ; Desimone, Nathaniel L
; Kubacki, Michael A
Subject: [edk2-platforms] [PATCH 1/5] BoardModulePkg: Add bios info HOB
Added
Laszlo,
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Laszlo Ersek
> Sent: Tuesday, September 17, 2019 12:49 PM
> To: edk2-devel-groups-io
> Cc: Wu, Jiaxin ; Fu, Siyuan
>
> Subject: [edk2-devel] [PATCH 18/35]
>
On 10/05/19 16:28, Zhang, Chao B wrote:
> Reviewed-by : Chao Zhang
Thanks!
Laszlo
>
> -Original Message-
> From: Zhang, Chao B
> Sent: 2019年10月4日 21:14
> To: edk2-devel-groups-io ; 'ler...@redhat.com'
> ; Wang, Jian J ; Yao, Jiewen
>
> Subject: RE: [edk2-devel] [PATCH 26/35]
On 10/04/19 13:31, Igor Mammedov wrote:
> On Tue, 1 Oct 2019 20:03:20 +0200
> "Laszlo Ersek" wrote:
>> (1) What values to use.
> SeaBIOS writes 0x00 into command port, but it seems that's taken by
> EFI_SMM_COMMUNICATION_PROTOCOL. So we can use the next unused value
> (lets say 0x4). We
On 10/04/19 16:09, Igor Mammedov wrote:
> On Tue, 1 Oct 2019 17:31:17 +0200
> "Laszlo Ersek" wrote:
>> (It does not matter if another hotplug CPU starts the relocation in SMM
>> while the earlier one is left with *only* the RSM instruction in SMM,
>> immediately after the swap-back.)
> I don't
43 matches
Mail list logo
