Re: [edk2-devel] BaseTools --hash malfunction after migrate from stable201905 to stable201908

2019-10-20 Thread Steven Shi
Hi Derek, I figure out a new solution for –hash cache as below. Please try it again. https://github.com/shijunjing/edk2/tree/hashcache_v2 It is based on latest edk2 master branch, and what you need porting are below files. Let me know if you need me to create a patch based on edk2-stable201908.

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe string constraint assertions

2019-10-20 Thread Yao, Jiewen
Hi Mike I remember we have discussed it before. The general concern is that: how many additional PCD we need introduce, to control different ASSERT in different modules ? We may want to enable *some* assert in some modules, but disable *some other* assert. E.g. the assert for linkedlist in

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe string constraint assertions

2019-10-20 Thread Liming Gao
Include more people. Basically, to keep the compatible behavior, PcdAssertOnSafeStringConstraints default value should be TRUE. The different platform can configure it. Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Vitaly

Re: [edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference

2019-10-20 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Sunday, October 20, 2019 8:09 PM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiFileHandleLib: Fix potential

Re: [edk2-devel] [PATCH] MdePkg/UefiDebugLibStdErr: Pass the correct buffer size

2019-10-20 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Monday, October 21, 2019 1:28 AM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiDebugLibStdErr: Pass the

Re: [edk2-devel] [PATCH] MdePkg/UefiDebugLibConOut: Pass the correct buffer size

2019-10-20 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Marvin Häuser [mailto:marvin.haeu...@outlook.com] >Sent: Sunday, October 20, 2019 8:09 PM >To: devel@edk2.groups.io >Cc: vit9...@protonmail.com; Kinney, Michael D >; Gao, Liming >Subject: [PATCH] MdePkg/UefiDebugLibConOut: Pass the

Re: [edk2-devel] [PATCH v2 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices event

2019-10-20 Thread Siyuan, Fu
Reviewed-by: Siyuan Fu > -Original Message- > From: Rabeda, Maciej > Sent: 2019年10月14日 20:37 > To: devel@edk2.groups.io > Cc: Fu, Siyuan ; Wu, Jiaxin > Subject: [PATCH v2 1/1] NetworkPkg/SnpDxe: Remove ExitBootServices > event > > Patch addresses Bugzilla #1972. > During

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

2019-10-20 Thread Ni, Ray
It was just pushed. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > H?user > Sent: Sunday, October 20, 2019 5:31 PM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > > Subject: Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

[edk2-devel] [PATCH] MdeModulePkg/Oniguruma: Remove redundant IF statement

2019-10-20 Thread Zhang, Shenglei
The if statement is not necessary, so keep it to edk2 style. And this change has been merged to onigruma. REF:https://github.com/kkos/oniguruma/pull/158 Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- .../Oniguruma/unicode_fold1_key.c | 18 +++---

Re: [edk2-devel] [Patch] PcAtChipsetPkg: Fix spelling errors

2019-10-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Saturday, October 19, 2019 3:35 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Ni, Ray > Subject: [Patch] PcAtChipsetPkg: Fix spelling errors > > From: Sean Brogan > >

Re: [edk2-devel] [Patch] FatPkg: Fix spelling errors

2019-10-20 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: Kinney, Michael D > Sent: Saturday, October 19, 2019 3:15 AM > To: devel@edk2.groups.io > Cc: Sean Brogan ; Ni, Ray > Subject: [Patch] FatPkg: Fix spelling errors > > From: Sean Brogan > >

Re: [edk2-devel] [Patch] MdePkg: Add UefiFileHandleLib to DSC file

2019-10-20 Thread Liming Gao
Reviewed-by: Liming Gao >-Original Message- >From: Kinney, Michael D >Sent: Saturday, October 19, 2019 4:38 AM >To: devel@edk2.groups.io >Cc: Sean Brogan ; Gao, Liming > >Subject: [Patch] MdePkg: Add UefiFileHandleLib to DSC file > >From: Sean Brogan >

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding with python 3

2019-10-20 Thread Bob Feng
Acked-by: Bob Feng -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Vitaly Cheptsov via Groups.Io Sent: Sunday, October 20, 2019 6:26 PM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH v1 1/1] BaseTools: Do not call sys.setdefaultencoding

Re: [edk2-devel] [edk2-platforms] [PATCH v3 2/4] KabylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-20 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Friday, October 18, 2019 8:02 AM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-devel] [edk2-platforms]

Re: [edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI

2019-10-20 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ashish Singhal > Sent: Wednesday, October 16, 2019 1:21 AM > To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; jbra...@nvidia.com > Cc: Ashish Singhal > Subject: [edk2-devel] [PATCH v4 0/2] Fix

[edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Tolerate more Root handle FileNames

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2295 The current implementation of the FileHandleGetFileName() function assumes that the Root directory always has the FileName '\0'. However, the only requirement the UEFI specification defines is that a prepended '\\'

[edk2-devel] [PATCH] ShellPkg/Ls: Return empty content for all empty folders

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2296 Currently, when 'ls' is run on an entirely empty directory (this includes not having '.' and '..'), the output is always 'File not found'. For when not filtering its children, this patch rather displays the usual

[edk2-devel] [PATCH] MdePkg/UefiDebugLibConOut: Pass the correct buffer size

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2302 The second argument of "UnicodeVSPrintAsciiFormat" is "BufferSize", which takes the size of the buffer in bytes. Replace the currently used MAX_DEBUG_MESSAGE_LENGTH usage, which is the buffer's length, with the actual

[edk2-devel] [PATCH] ShellPkg/Ls: Consider UEFI timezone may not be set

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2294 EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, such as when SetTime() has not been called after the RTC was cut off power. Consider this case by not attempting Timezone translations for when it

[edk2-devel] [PATCH] UefiShellCommandLib: Default to first found UC for unsupported PlatformLang

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2300 On some firmwares PlatformLang is set to the local language (e.g. ru-RU), however there is no Unicode Collation protocol instance that supports it. As for missing PlatformLang, fall back to the first found instance.

[edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2293 Move the NULL check in FileHandleGetInfo() to directly after the allocation to prevent potential NULL dereferences. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Marvin Haeuser ---

[edk2-devel] [PATCH v1 0/1] MdePkg: Add PCD to disable safe string constraint assertions

2019-10-20 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Requesting for merge in edk2-stable2019011. Vitaly Cheptsov (1): MdePkg: Add PCD to disable safe string constraint assertions MdePkg/MdePkg.dec | 6 ++ MdePkg/Library/BaseLib/BaseLib.inf | 11 ++-

[edk2-devel] [PATCH v1 1/1] MdePkg: Add PCD to disable safe string constraint assertions

2019-10-20 Thread Vitaly Cheptsov via Groups.Io
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Runtime data checks are not meant to cause debug assertions unless explicitly needed by some debug code (thus the PCD) as this breaks debug builds validating data with BaseLib. Signed-off-by: Vitaly Cheptsov > --- MdePkg/MdePkg.dec

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

2019-10-20 Thread Marvin Häuser
Good day, Thank you for your review. I have not seen this patch pushed yet, could you please update me with the status? Thanks, Marvin > Reviewed-by: Ray Ni > >> -Original Message- >> From: Marvin Häuser >> Sent: Thursday, September 26, 2019 9:38 AM >> To: Ni, Ray ; Marvin Häuser ;