Re: [edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Yao, Jiewen
Welcome Ard and Sami! Reviewed-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Saturday, December 7, 2019 12:07 AM > To: Ard Biesheuvel ; devel@edk2.groups.io > Cc: leif.lindh...@linaro.org; af...@apple.com; ler...@redhat.com;

[edk2-devel] Debugging aarch64 edk2 built with gcc-8.x 64-bit arm compiler

2019-12-06 Thread Vladimir Olovyannikov via Groups.Io
Hi Ard, We are about to switch to the latest Yocto. It is shipped with gcc-8.3 aarch64-linux-gnu compiler. We use DS5 for bare metal debugging. When I build edk2 with gcc-7-x/gcc-8.x, DS5 complains on DWARF format. I tried to explicitly set it to DWARF2, but still cannot even get the stack or

Re: [edk2-devel] [PATCH v2 061/105] .mailmap: Add an entry for Michael Kubacki

2019-12-06 Thread Kubacki, Michael A
Phil, thanks for your effort to put this together. Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daudé > Sent: Friday, December 6, 2019 3:26 AM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Kubacki, Michael A

Re: [EXTERNAL] Re: [edk2-devel] EDK2 Host-Based Unit Test RFC (Now with docs!)

2019-12-06 Thread Bret Barkelew via Groups.Io
1. I see that MdePkg adds a dependency on UnitTestPkg. This makes UnitTestPkg the root package when building and running host based unit tests. This makes sense, but good to highlight that all packages that use host based tests will introduce a new package dependency on UnitTestPkg. *

Re: [edk2-devel] [PATCH v2 025/105] .mailmap: Add an entry for Erik Bjorge

2019-12-06 Thread Bjorge, Erik C
Looks good to me. Reviewed-by: Erik Bjorge -Original Message- From: Philippe Mathieu-Daude Sent: Friday, December 6, 2019 3:25 AM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Bjorge, Erik C Subject: [PATCH v2 025/105] .mailmap: Add an entry for Erik Bjorge We use .mailmap

Re: [edk2-devel] [PATCH v2 007/105] .mailmap: Add an entry for Ashley DeSimone

2019-12-06 Thread Philippe Mathieu-Daudé
On Fri, Dec 6, 2019 at 6:24 PM Desimone, Ashley E wrote: > > Technically in this case it is her name. Oops I apologize, I'll update (in think about this in my future contributions). > Reviewed-by: Ashley DeSimone Thanks! > -Original Message- > From: Philippe Mathieu-Daude

Re: [edk2-devel] Public-Service-Announcement: send-email issues with Git 2.22.0+

2019-12-06 Thread Nate DeSimone
Hi Leif, On 12/4/2019 4:13 AM, Leif Lindholm wrote: > Hi Nate, > > On Wed, Dec 04, 2019 at 04:31:04 +, Nate DeSimone wrote: >> I have been dealing with a very frustrating issue recently where all >> of my "CR LF" line endings get erroneously converted into "LF LF" >> once I send my patch to

[edk2-devel] [PATCH] BaseTools/Scripts: Add sendemail.transferEncoding to SetupGit.py

2019-12-06 Thread Nate DeSimone
If git finds a '\r' character in the message, then it converts the entire message content into Quoted-Printable encoding. It appears that when groups.io converts the QP encoding back to text format, the '\r' characters somehow become '\n'. To workaround this, the SetupGit.py script will now

[edk2-devel] [PATCH] SimicsOpenBoardPkg: Replace CMOS Hardcoded Addresses

2019-12-06 Thread Agyeman, Prince
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2330 Changes: * Added CmosMap.h that defines CMOS addresses used in SimicsOpenBoardPkg as macros * Replaced hardcoded CMOS addresses with the macros defined in CmosMap.h Cc: Nate DeSimone Cc: Michael Kubacki Signed-off-by: Prince

Re: [edk2-devel] [PATCH v2 007/105] .mailmap: Add an entry for Ashley DeSimone

2019-12-06 Thread Desimone, Ashley E
Technically in this case it is her name. Reviewed-by: Ashley DeSimone -Original Message- From: Philippe Mathieu-Daude [mailto:phi...@redhat.com] Sent: Friday, December 6, 2019 3:25 AM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Desimone, Ashley E Subject: [PATCH v2

Re: [edk2-devel] [PATCH v2 093/105] .mailmap: Add an entry for Vladimir Olovyannikov

2019-12-06 Thread Vladimir Olovyannikov via Groups.Io
Reviewed-by: Vladimir Olovyannikov Thanks! > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, December 6, 2019 3:26 AM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Vladimir Olovyannikov > > Subject: [PATCH v2 093/105] .mailmap: Add an entry for Vladimir >

Re: [edk2-devel] [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/6/19 5:09 PM, Rabeda, Maciej wrote: Philippe, I was so keen to give you the green light but typo in Callback.c has not been fixed here. ususlly -> ususally Nice catch! If you could address this, that would be great :) Certainly, will do. Thanks! Maciej -Original Message-

[edk2-devel] [PATCH] Maintainers.txt: Update reviewer email address

2019-12-06 Thread Maciej Rabeda
Created new email account that will not append legal disclaimers to my responses/patches. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda --- Maintainers.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Maintainers.txt b/Maintainers.txt index

Re: [edk2-devel] [PATCH v2 055/105] .mailmap: Add an entry for Marvin Häuser

2019-12-06 Thread Marvin Häuser
Good day, Please excuse me, I didn't see the patch the first time. Reviewed-by: Marvin Häuser Best regards, Marvin We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Marvin Häuser to have his name and email address displayed properly in the git

Re: [edk2-devel] [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Philippe, I was so keen to give you the green light but typo in Callback.c has not been fixed here. ususlly -> ususally If you could address this, that would be great :) Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To:

Re: [edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Sami Mujawar
Hi Ard, Sincere Apologies. I just realised I should have replied with a Reviewed by. Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Sami Mujawar Sent: 06 December 2019 03:56 PM To: Ard Biesheuvel ; devel@edk2.groups.io Cc: leif.lindh...@linaro.org;

Re: [edk2-devel] [PATCH 47/79] NetworkPkg/Mtftp6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 47/79]

Re: [edk2-devel] [PATCH 45/79] NetworkPkg/MnpDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 45/79] NetworkPkg/MnpDxe:

Re: [edk2-devel] [PATCH 40/79] NetworkPkg/HttpDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 40/79] NetworkPkg/HttpDxe:

Re: [edk2-devel] [PATCH 49/79] NetworkPkg/TcpDxe/Sock: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 49/79]

Re: [edk2-devel] [PATCH 41/79] NetworkPkg/Ip4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 41/79] NetworkPkg/Ip4Dxe:

Re: [edk2-devel] [PATCH 44/79] NetworkPkg/Library: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 44/79] NetworkPkg/Library:

Re: [edk2-devel] [PATCH 42/79] NetworkPkg/Ip6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 42/79] NetworkPkg/Ip6Dxe:

Re: [edk2-devel] [PATCH 53/79] NetworkPkg/Udp6Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 53/79] NetworkPkg/Udp6Dxe:

Re: [edk2-devel] [PATCH 52/79] NetworkPkg/Udp4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 52/79] NetworkPkg/Udp4Dxe:

Re: [edk2-devel] [PATCH 46/79] NetworkPkg/Mtftp4Dxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:15 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 46/79]

Re: [edk2-devel] [PATCH 50/79] NetworkPkg/TcpDxe/Tcp: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 50/79]

Re: [edk2-devel] [PATCH 51/79] NetworkPkg/Tls: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 51/79] NetworkPkg/Tls: Fix

Re: [edk2-devel] [PATCH 2/7] MdeModulePkg/SmmIpl: expose MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
On Fri, 6 Dec 2019 at 15:29, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > The MM communicate 2 protocol was introduced to factor out the mismatch > between traditional MM, which requires the physical address of the MM > buffer to be passed, and standalone MM, which copies the MM

Re: [edk2-devel] [PATCH 54/79] NetworkPkg/UefiPxeBcDxe: Fix various typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 54/79]

Re: [edk2-devel] [PATCH 55/79] NetworkPkg/VlanConfigDxe: Fix few typos

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda Thanks! Maciej -Original Message- From: Philippe Mathieu-Daude Sent: Tuesday, December 3, 2019 17:16 To: devel@edk2.groups.io Cc: Antoine Coeur ; Wu, Jiaxin ; Fu, Siyuan ; Rabeda, Maciej ; Philippe Mathieu-Daude Subject: [PATCH 55/79]

Re: [edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Leif Lindholm
On Fri, Dec 06, 2019 at 15:54:52 +, Ard Biesheuvel wrote: > On Fri, 6 Dec 2019 at 15:44, Laszlo Ersek wrote: > > > > On 12/06/19 16:28, Ard Biesheuvel wrote: > > > From: Ard Biesheuvel > > > > > > Achin has indicated that he no longer has the bandwidth available to > > > co-maintain

Re: [edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Sami Mujawar
Signed-off-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 06 December 2019 03:29 PM To: devel@edk2.groups.io Cc: leif.lindh...@linaro.org; af...@apple.com; ler...@redhat.com; michael.d.kin...@intel.com; Ard Biesheuvel ; Achin Gupta ; Sami

[edk2-devel] [PATCH 2/7] MdeModulePkg/SmmIpl: expose MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel The MM communicate 2 protocol was introduced to factor out the mismatch between traditional MM, which requires the physical address of the MM buffer to be passed, and standalone MM, which copies the MM communicate buffer data into a separate buffer, requiring the virtual

[edk2-devel] [PATCH 3/7] ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Implement the new MmCommunication2 protocol which supports the use of standalone MM at runtime inside an address space that has been virtually remapped by the OS. Note that the implementation of the old MM Communicate protocol is removed: it never worked correctly so there

[edk2-devel] [PATCH 4/7] MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Application/VariableInfo/VariableInfo.c | 19 +++ MdeModulePkg/Application/VariableInfo/VariableInfo.inf | 2 +-

[edk2-devel] [PATCH 7/7] StandaloneMmPkg: switch to MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Update the reference to MM communicate to refer to the MM communicate 2 protocol instead. This makes no difference for the MM side of the implementation, but is more accurate nonetheless, since the original MM protocol does not work in combination with standalone MM.

[edk2-devel] [PATCH 1/7] MdePkg: introduce MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Add the protocol definition of the MM communicate 2 protocol, which is introduced in version 1.7 errata A of the PI spec. Signed-off-by: Ard Biesheuvel --- MdePkg/Include/Protocol/MmCommunication2.h | 69 MdePkg/MdePkg.dec |

[edk2-devel] [PATCH 0/7] New implementation of MM communicate for standalone MM

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel This series implements the changes proposed by Mantis ticket 1993, which describes how we need to modify the MM communicate protocol to make it compatible with standalone MM based DXE_RUNTIME_DRIVER MM client using virtually remapped memory. These changes have been accepted

[edk2-devel] [PATCH 6/7] MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Include/Guid/SmmVariableCommon.h| 6 +--

[edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Achin has indicated that he no longer has the bandwidth available to co-maintain StandaloneMmPkg, and has asked Sami and me to step in. Cc: Achin Gupta Cc: Sami Mujawar Cc: Jiewen Yao Signed-off-by: Ard Biesheuvel --- Maintainers.txt | 3 ++- 1 file changed, 2

[edk2-devel] [PATCH 5/7] MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2 protocol

2019-12-06 Thread Ard Biesheuvel
From: Ard Biesheuvel Switch to the new MM communicate 2 protocol which supports both traditional and standalone MM. Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteSmmCommon.h | 2 +-

Re: [edk2-devel] [PATCH 1/1] Maintainers: assume co-maintainership of StandaloneMmPkg

2019-12-06 Thread Laszlo Ersek
On 12/06/19 16:28, Ard Biesheuvel wrote: > From: Ard Biesheuvel > > Achin has indicated that he no longer has the bandwidth available to > co-maintain StandaloneMmPkg, and has asked Sami and me to step in. > > Cc: Achin Gupta > Cc: Sami Mujawar > Cc: Jiewen Yao > Signed-off-by: Ard

Re: [edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2019-12-06 Thread Laszlo Ersek
On 12/06/19 15:31, Ard Biesheuvel wrote: > Currently, we dispatch drivers specified via Driver entries after > calling PlatformBootManagerBeforeConsole(), which prevents us from > loading drivers that provide consoles via Driver entries. I'd put this as: ... which prevents

[edk2-devel] [Patch 3/4 V6] BaseTools: Update build_rule.txt to generate dependent files.

2019-12-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311 Enable the dependent files generation function for compilers and Trim tool. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Conf/build_rule.template | 96 +- 1 file changed, 54

[edk2-devel] [Patch 0/4 V6] Enhance Incremental Build

2019-12-06 Thread Bob Feng
V6: Add notes for RVCT tool chain that it is not enabled incremental build feature V5: Document how to enable or disable dependency file list generation for a tool chain. V4: Move .deps files to where corresponding .obj file locate V3: Change CLANG9 to CLANGPDB according to commit 14672c34bd V2:

[edk2-devel] [Patch 1/4 V6] BaseTools: Add build option for dependency file generation

2019-12-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311 Add /showIncludes for msvc and -MMD -MF $@.deps for GCC and CLANG Remove /MP for msvc since /MP does not work with /showIncludes Cc: Liming Gao Cc: Steven Shi Cc: Michael D Kinney Signed-off-by: Bob Feng --- V6: Add notes for RVCT tool

[edk2-devel] [Patch 4/4 V6] BaseTools: Enhance Basetool for incremental build

2019-12-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311 Include dependency file in Makefile to enhance incremental build Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/AutoGen/GenMake.py| 83 ++--- .../Source/Python/AutoGen/IncludesAutoGen.py | 284

[edk2-devel] [Patch 2/4 V6] BaseTools: Generate dependent files for ASL and ASM files

2019-12-06 Thread Bob Feng
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2311 Implement the function in Trim tool to get the included file list for ASL and ASM file. Cc: Liming Gao Cc: Steven Shi Signed-off-by: Bob Feng --- BaseTools/Source/Python/Trim/Trim.py | 115 ++- 1 file changed, 95

Re: [edk2-devel] [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

2019-12-06 Thread Laszlo Ersek
On 12/06/19 15:09, Philippe Mathieu-Daudé wrote: > On 12/6/19 1:43 PM, Laszlo Ersek wrote: >> On 12/06/19 13:13, Philippe Mathieu-Daudé wrote: >>> On 12/6/19 12:24 PM, Philippe Mathieu-Daude wrote: >>> [...] - Another note regarding groups.io 40 posts per 30min limit - My previous

Re: [edk2-devel] [PATCH v2 057/105] .mailmap: Add an entry for Maurice Ma

2019-12-06 Thread Ma, Maurice
Reviewed-by: Maurice Ma Thanks, -Maurice > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Philippe Mathieu-Daudé > Sent: Friday, December 6, 2019 3:26 > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Ma, Maurice > > Subject:

Re: [edk2-devel] [BUG] building multiple versions of a single platform is broken again

2019-12-06 Thread Ard Biesheuvel
On Fri, 6 Dec 2019 at 14:40, Leif Lindholm wrote: > > On Fri, Dec 06, 2019 at 14:29:28 +, Ard Biesheuvel wrote: > > When I build DEBUG and RELEASE versions of the same platform in one go, like > > > > build -b DEBUG -b RELEASE -a X64 -p OvmfPkg/OvmfPkgX64.dsc -t GCC5 > > > > the first build

Re: [edk2-devel] [BUG] building multiple versions of a single platform is broken again

2019-12-06 Thread Leif Lindholm
On Fri, Dec 06, 2019 at 14:29:28 +, Ard Biesheuvel wrote: > When I build DEBUG and RELEASE versions of the same platform in one go, like > > build -b DEBUG -b RELEASE -a X64 -p OvmfPkg/OvmfPkgX64.dsc -t GCC5 > > the first build completes, but the second one fails immediately like below. > >

[edk2-devel] [RFC PATCH 0/2] MdeModulePkg: reorder Driver#### handling for console drivers

2019-12-06 Thread Ard Biesheuvel
Change the order in which the BDS handles Driver entries and invokes the PlatformBmLib hooks so that we can load GOP drivers via Driver entries in time for them to be used as the console. Cc: Leif Lindholm Cc: Laszlo Ersek Cc: Zhichao Gao Cc: Ray Ni Cc: Maurice Ma Cc: Guo Dong Cc:

[edk2-devel] [RFC PATCH 2/2] MdeModulePkg/BdsDxe: allow consoles on drivers loaded via Driver####

2019-12-06 Thread Ard Biesheuvel
Currently, we dispatch drivers specified via Driver entries after calling PlatformBootManagerBeforeConsole(), which prevents us from loading drivers that provide consoles via Driver entries. This is particularly annoying on AArch64 systems, given that it prevents us from loading AArch64

[edk2-devel] [RFC PATCH 1/2] MdeModulePkg/PlatformBootManagerLib: document change of Driver#### handling

2019-12-06 Thread Ard Biesheuvel
A future patch will change the order in which Driver options are processed, removing the possibility to create such options in PlatformBootManagerBeforeConsole(). Update the code comments duplicated across the tree to reflect this upcoming change, and replace Driver with SysPrep, which

[edk2-devel] [BUG] building multiple versions of a single platform is broken again

2019-12-06 Thread Ard Biesheuvel
When I build DEBUG and RELEASE versions of the same platform in one go, like build -b DEBUG -b RELEASE -a X64 -p OvmfPkg/OvmfPkgX64.dsc -t GCC5 the first build completes, but the second one fails immediately like below. This appears to have gotten broken between edk2-stable201905 and

Re: [edk2-devel] [PATCH v2 100/105] .mailmap: Add an entry for Yao Jiewen

2019-12-06 Thread Yao, Jiewen
No worry. That is always confusing. For Intel, the email address usually is ".@intel.com" Some people may have a number in the middle, but you can ignore that. Appreciate your work to fix so many people's name. > -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe >

Re: [edk2-devel] [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/6/19 1:23 PM, Laszlo Ersek wrote: On 12/06/19 12:24, Philippe Mathieu-Daude wrote: The .mailmap git feature helps fixing commit mistakes (in name/email). The easiest way to use it is with the --use-mailmap flag: $ git log --use-mailmap See documentation [1] and [2], and interesting

Re: [edk2-devel] [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

2019-12-06 Thread Philippe Mathieu-Daudé
On 12/6/19 1:43 PM, Laszlo Ersek wrote: On 12/06/19 13:13, Philippe Mathieu-Daudé wrote: On 12/6/19 12:24 PM, Philippe Mathieu-Daude wrote: [...] - Another note regarding groups.io 40 posts per 30min limit - My previous big series [5] involved 79 patches, and groups.io banned me for some time

Re: [edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin

2019-12-06 Thread yuchenlin via Groups.Io
Oops, please ignore my last mail... I mistakenly think this patch is about qemu mailmap. In edk2, I am ok for this patch. Reviewed-by: Yu-Chen Lin -- Best Regards, Yu-Chen Lin yuchenlin 於 2019-12-06 21:59 寫道: > > Hi, > > > > Cool, it is a good idea for mapping this. > > However, I have two

Re: [edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin

2019-12-06 Thread yuchenlin via Groups.Io
Hi, Cool, it is a good idea for mapping this. However, I have two mail address, named npes87...@gmail.com and yuchen...@synology.com (mailto:yuchen...@synology.com) IMO, the entry should be diff --git a/.mailmap b/.mailmap index 3816e4effe..3fbf3902a3 100644 --- a/.mailmap +++ b/.mailmap @@

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Platform/ARM/Juno: remove explicit PCIe enumeration

2019-12-06 Thread Ard Biesheuvel
On Fri, 6 Dec 2019 at 11:41, Sami Mujawar wrote: > > Tested on Juno R2, the MAC address for Marvel Yukon NIC is programmed > correctly. > > Tested-by: Sami Mujawar > Thanks all Pushed as 8b72f720d53e..1e4952d63b63 (with two instances of EFI_EVENT converted to VOID*) -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v2 100/105] .mailmap: Add an entry for Yao Jiewen

2019-12-06 Thread Philippe Mathieu-Daudé
Hi Jiewen, On 12/6/19 2:31 PM, Yao, Jiewen wrote: HI Philippe "Yao" is my family name. "Jiewen" is my given name. I am very sorry for inverting your names, I'll fix this in the next version. Thanks for correcting me! Thank you Yao Jiewen -Original Message- From: Philippe

Re: [edk2-devel] [PATCH v2 100/105] .mailmap: Add an entry for Yao Jiewen

2019-12-06 Thread Yao, Jiewen
HI Philippe "Yao" is my family name. "Jiewen" is my given name. Thank you Yao Jiewen > -Original Message- > From: Philippe Mathieu-Daude > Sent: Friday, December 6, 2019 7:27 PM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Yao, Jiewen > > Subject: [PATCH v2 100/105]

[edk2-devel] [PATCH v2 105/105] .mailmap: Add an entry for Zailiang Sun

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Zailiang Sun to have his name and email address displayed properly in the git history. Cc: Zailiang Sun Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I

[edk2-devel] [PATCH v2 103/105] .mailmap: Add an entry for Yonghong Zhu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Yonghong Zhu to have his name and email address displayed properly in the git history. Cc: Yonghong Zhu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I

[edk2-devel] [PATCH v2 100/105] .mailmap: Add an entry for Yao Jiewen

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Yao Jiewen to have his name and email address displayed properly in the git history. Cc: Yao Jiewen Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

[edk2-devel] [PATCH v2 101/105] .mailmap: Add an entry for Yeh Greg

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Yeh Greg to have his name and email address displayed properly in the git history. Cc: Yeh Greg Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not

[edk2-devel] [PATCH v2 099/105] .mailmap: Add an entry for Xue Shengfeng

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Xue Shengfeng to have his name and email address displayed properly in the git history. Cc: Xue Shengfeng Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100,

[edk2-devel] [PATCH v2 104/105] .mailmap: Add an entry for Yu-Chen Lin

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Yu-Chen Lin to have his name and email address displayed properly in the git history. Cc: Yu-Chen Lin Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I

[edk2-devel] [PATCH v2 102/105] .mailmap: Add an entry for Yingke Liu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Yingke Liu to have his name and email address displayed properly in the git history. Cc: Yingke Liu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

Re: [edk2-devel] [PATCH v2 092/105] .mailmap: Add an entry for Vitaly Cheptsov

2019-12-06 Thread Vitaly Cheptsov via Groups.Io
Reviewed-by: Vitaly Cheptsov В пт, дек. 6, 2019 в 14:26, Philippe Mathieu-Daude пишет: > We use .mailmap to display contributors email addresses in an > uniform format. > > Add an entry for Vitaly Cheptsov to have his name and email address > displayed properly in the git history. > > Cc:

Re: [edk2-devel] [PATCH v2 051/105] .mailmap: Add an entry for Maciej Rabeda

2019-12-06 Thread Rabeda, Maciej
Reviewed-by: Maciej Rabeda PS. Disregard the legal note at the end of the email. -Original Message- From: Philippe Mathieu-Daude Sent: Friday, December 6, 2019 12:26 To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude ; Rabeda, Maciej Subject: [PATCH v2 051/105] .mailmap: Add an

Re: [edk2-devel] [PATCH v2 065/105] .mailmap: Add an entry for Nikolai Saoukh

2019-12-06 Thread Николай Саух
Reviewed-by: Nikolai Saoukh On Fri, Dec 6, 2019 at 3:00 PM Philippe Mathieu-Daude wrote: > > We use .mailmap to display contributors email addresses in an > uniform format. > > Add an entry for Nikolai Saoukh to have his name and email address > displayed properly in the git history. > > Cc:

Re: [edk2-devel] [PATCH v2 043/105] .mailmap: Add an entry for Laszlo Ersek

2019-12-06 Thread Laszlo Ersek
On 12/06/19 12:25, Philippe Mathieu-Daude wrote: > We use .mailmap to display contributors email addresses in an > uniform format. > > Add an entry for Laszlo Ersek to have his name and email address > displayed properly in the git history. > > Cc: Laszlo Ersek > Signed-off-by: Philippe

Re: [edk2-devel] [PATCH v2 000/105] .mailmap: Add mailmap file to have a cleaner git history

2019-12-06 Thread Laszlo Ersek
On 12/06/19 13:13, Philippe Mathieu-Daudé wrote: > On 12/6/19 12:24 PM, Philippe Mathieu-Daude wrote: > [...] >> - Another note regarding groups.io 40 posts per 30min limit - >> >> My previous big series [5] involved 79 patches, and groups.io banned >> me for some time after the 40th post. On [5]

Re: [edk2-devel] [PATCH v2 005/105] .mailmap: Add an entry for Antoine Cœur

2019-12-06 Thread Cœur
Reviewed-by: Antoine Cœur Le 06/12/2019 à 19:24, Philippe Mathieu-Daude a écrit : We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Antoine Cœur to have his name and email address displayed properly in the git history. Cc: Antoine Cœur

Re: [edk2-devel] [PATCH v2 040/105] .mailmap: Add an entry for Jim Dailey

2019-12-06 Thread Jim Dailey
Reviewed-by: Jim Dailey -Original Message- From: devel@edk2.groups.io On Behalf Of Philippe Mathieu-Daudé Sent: Friday, December 6, 2019 5:26 AM To: devel@edk2.groups.io Cc: Philippe Mathieu-Daude; Dailey, Jim Subject: [edk2-devel] [PATCH v2 040/105] .mailmap: Add an entry for Jim

[edk2-devel] [PATCH v2 095/105] .mailmap: Add an entry for Wang Yu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Wang Yu to have his name and email address displayed properly in the git history. Cc: Wang Yu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not Cc

[edk2-devel] [PATCH v2 097/105] .mailmap: Add an entry for Xiaofeng Wang

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Xiaofeng Wang to have his name and email address displayed properly in the git history. Cc: Xiaofeng Wang Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100,

[edk2-devel] [PATCH v2 098/105] .mailmap: Add an entry for Xiaoyu Lu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Xiaoyu Lu to have his name and email address displayed properly in the git history. Cc: Xiaoyu Lu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

[edk2-devel] [PATCH v2 096/105] .mailmap: Add an entry for Wei Xu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Wei Xu to have his name and email address displayed properly in the git history. Cc: Wei Xu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not Cc

[edk2-devel] [PATCH v2 080/105] .mailmap: Add an entry for Samer El-Haj-Mahmoud

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Samer El-Haj-Mahmoud to have his name and email address displayed properly in the git history. Cc: Samer El-Haj-Mahmoud Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient

[edk2-devel] [PATCH v2 092/105] .mailmap: Add an entry for Vitaly Cheptsov

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Vitaly Cheptsov to have his name and email address displayed properly in the git history. Cc: Vitaly Cheptsov Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to

[edk2-devel] [PATCH v2 091/105] .mailmap: Add an entry for Vanguput Narendra

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Vanguput Narendra to have his name and email address displayed properly in the git history. Cc: Vanguput Narendra Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list

[edk2-devel] [PATCH v2 093/105] .mailmap: Add an entry for Vladimir Olovyannikov

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Vladimir Olovyannikov to have his name and email address displayed properly in the git history. Cc: Vladimir Olovyannikov Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the

[edk2-devel] [PATCH v2 094/105] .mailmap: Add an entry for Wang Fan

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Wang Fan to have his name and email address displayed properly in the git history, in particular commit cde5a72d36. Cc: Wang Fan Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the

[edk2-devel] [PATCH v2 078/105] .mailmap: Add an entry for Rui Sun

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Rui Sun to have his name and email address displayed properly in the git history. Cc: Rui Sun Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not Cc

[edk2-devel] [PATCH v2 069/105] .mailmap: Add an entry for Philippe Mathieu-Daudé

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Philippe Mathieu-Daudé to have his name and email address displayed properly in the git history. Signed-off-by: Philippe Mathieu-Daude --- .mailmap | 1 + 1 file changed, 1 insertion(+) diff --git

[edk2-devel] [PATCH v2 070/105] .mailmap: Add an entry for Qian Ouyang

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Qian Ouyang to have his name and email address displayed properly in the git history. Cc: Qian Ouyang Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I

[edk2-devel] [PATCH v2 074/105] .mailmap: Add an entry for Rebecca Cran

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Rebecca Cran to have his name and email address displayed properly in the git history. Cc: Rebecca Cran Cc: Rebecca Cran Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the

[edk2-devel] [PATCH v2 085/105] .mailmap: Add an entry for Songpeng Li

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Songpeng Li to have his name and email address displayed properly in the git history. Cc: Songpeng Li Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I

[edk2-devel] [PATCH v2 079/105] .mailmap: Add an entry for Sachin Agrawal

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Sachin Agrawal to have his name and email address displayed properly in the git history. Cc: Sachin Agrawal Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to

[edk2-devel] [PATCH v2 071/105] .mailmap: Add an entry for Qing Huang

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Qing Huang to have his name and email address displayed properly in the git history. Cc: Qing Huang Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

[edk2-devel] [PATCH v2 076/105] .mailmap: Add an entry for Rodrigo Gonzalez del Cueto

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Rodrigo Gonzalez del Cueto to have his name and email address displayed properly in the git history. Cc: Rodrigo Gonzalez del Cueto Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting

[edk2-devel] [PATCH v2 089/105] .mailmap: Add an entry for Ting Ye

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Ting Ye to have his name and email address displayed properly in the git history. Cc: Ting Ye Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can not Cc

[edk2-devel] [PATCH v2 068/105] .mailmap: Add an entry for Penny Gao

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Penny Gao to have his name and email address displayed properly in the git history. Cc: Penny Gao Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

[edk2-devel] [PATCH v2 084/105] .mailmap: Add an entry for Siyuan Fu

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Siyuan Fu to have his name and email address displayed properly in the git history. Cc: Siyuan Fu Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100, I can

[edk2-devel] [PATCH v2 082/105] .mailmap: Add an entry for Sergey Isakov

2019-12-06 Thread Philippe Mathieu-Daudé
We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Sergey Isakov to have his name and email address displayed properly in the git history. Cc: Sergey Isakov Signed-off-by: Philippe Mathieu-Daude --- [Due to MTA restricting the recipient list to 100,

  1   2   >