Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

Mike, The hardcoded vs paths are not a safe assumption. I would rather see agreement of how the environment should be configured prior to calling edk2 build and if being capable of building host os specific binaries is the requirement then that should be clarified and the scripts can be

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

Reviewed-by: Nate DeSimone -Original Message- From: Kubacki, Michael A Sent: Thursday, January 30, 2020 8:41 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/1]

[edk2-devel] [PATCH 0/1] Use _MSC_VER to determine MSVC compiler

Patch details are explained in https://bugzilla.tianocore.org/show_bug.cgi?id=2397. We request this to be merged in edk2-stable202002. Vitaly Cheptsov (1): MdePkg: Use _MSC_VER to determine MSVC compiler MdePkg/Include/AArch64/ProcessorBind.h | 2 +- MdePkg/Include/Arm/ProcessorBind.h |

[edk2-devel] [PATCH 1/1] MdePkg: Use _MSC_VER to determine MSVC compiler

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2397 CLANGPDB toolchain, implemented by clang compiler, will also define currently used _MSC_EXTENSIONS macro, which does not behave correctly in many situations as explained in the report. Signed-off-by: Vitaly Cheptsov ---

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 18:28, Kinney, Michael D wrote: > Hi Laszlo, > > It can be done with the WebUI. There is a picture on > this page that shows setting the 'push' label before > selecting 'Create Pull Request' > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Aha,

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

On 2020.01.31 17:53, Ard Biesheuvel wrote: On Fri, 31 Jan 2020 at 18:48, Pete Batard wrote: Hi Ard, On 2020.01.31 17:05, Ard Biesheuvel wrote: On Fri, 24 Jan 2020 at 12:54, Pete Batard wrote: The Genet driver stub used by the Raspberry Pi 4 platform is designed to set the MAC address

[edk2-devel] [PATCH v8 0/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash

Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to modify each driver that calls into hash calculating API.

[edk2-devel] [PATCH v8 1/2] CryptoPkg: Add CryptoPkg Token Space GUID

Added CryptoPkg Token Space GUID to be able to define PCDs. Cc: Jiewen Yao Cc: Jian J Wang Cc: Michael D Kinney Signed-off-by: Amol N Sukerkar --- Notes: v6 - removed file CryptoPkgTokenSpace.h v7 - fixed typo v8 - Fixed Author and signed-off-by name

[edk2-devel] [PATCH v8 2/2] CryptoPkg/BaseHashApiLib: Implement Unified Hash Calculation API

This commit introduces a Unified Hash API to calculate hash using a hashing algorithm specified by the PCD, PcdHashApiLibPolicy. This library interfaces with the various hashing API, such as, MD4, MD5, SHA1, SHA256, SHA512 and SM3_256 implemented in BaseCryptLib. The user can calculate the desired

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

On Fri, 31 Jan 2020 at 18:48, Pete Batard wrote: > > Hi Ard, > > On 2020.01.31 17:05, Ard Biesheuvel wrote: > > On Fri, 24 Jan 2020 at 12:54, Pete Batard wrote: > >> > >> The Genet driver stub used by the Raspberry Pi 4 platform is > >> designed to set the MAC address according to a PCD. > >> >

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

On 2020.01.31 17:48, Pete Batard via Groups.Io wrote: Hi Ard, On 2020.01.31 17:05, Ard Biesheuvel wrote: On Fri, 24 Jan 2020 at 12:54, Pete Batard wrote: The Genet driver stub used by the Raspberry Pi 4 platform is designed to set the MAC address according to a PCD. To be able to set that

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

Hi Ard, On 2020.01.31 17:05, Ard Biesheuvel wrote: On Fri, 24 Jan 2020 at 12:54, Pete Batard wrote: The Genet driver stub used by the Raspberry Pi 4 platform is designed to set the MAC address according to a PCD. To be able to set that PCD at runtime, by using the Raspberry Pi firmware

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

Hi Laszlo, It can be done with the WebUI. There is a picture on this page that shows setting the 'push' label before selecting 'Create Pull Request' https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process I can also be done with the 'hub' command. The following Command

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 18:00, Laszlo Ersek wrote: > On 01/31/20 17:31, Kinney, Michael D wrote: >> Laszlo, >> >> I think a new BZ is a good idea. I am sure there is more >> history here and more discussion required on this invalid >> policy PCD setting case. >> >> I would also like to see a DEBUG() message

Re: [edk2-devel] [edk2-platforms][PATCH v2 2/3] Platform/RPi: Add PlatformPcdLib to set the Genet MAC address

On Fri, 24 Jan 2020 at 12:54, Pete Batard wrote: > > The Genet driver stub used by the Raspberry Pi 4 platform is > designed to set the MAC address according to a PCD. > > To be able to set that PCD at runtime, by using the Raspberry > Pi firmware interface, that has a dedicated call to retrieve

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 17:31, Kinney, Michael D wrote: > Laszlo, > > I think a new BZ is a good idea. I am sure there is more > history here and more discussion required on this invalid > policy PCD setting case. > > I would also like to see a DEBUG() message or even better > a REPORT_STATUS_CODE() for

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 17:52, Kinney, Michael D wrote: > 2) Open PR with the 'push' label set. If all checks >pass, then it is merged. If any checks fail, then >the maintainer can address and do a forced push to >their branch to retry. Yes, this would be ideal, but I don't know how I can

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

Hi Laszlo, I suspect the behavior you observed was due to the PR being opened, which triggers the CI actions immediately. Then you set the 'push' label, which was not seen when the PR was opened. This required a second pass which you did by re-opening. There are 2 approaches a maintainer can

Re: [edk2-devel] [PATCH v2] BaseTools/Conf/gitattributes: fix "--function-context" for C source code

On 01/31/20 09:35, Liming Gao wrote: > Laszlo: > I am back. This change is good. Reviewed-by: Liming Gao > Thank you, Liming! Merged via : commit eafd990f2606. Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

Liming, That script does not set everything up to build host apps for all VS20xx tool chains. It works for VS2017, VS2019, but not any of the others. It sets env vars for those other tool chains but Does not run the VS environment setup script that updates PATH and sets LIBS and INC to support

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

Laszlo, I think a new BZ is a good idea. I am sure there is more history here and more discussion required on this invalid policy PCD setting case. I would also like to see a DEBUG() message or even better a REPORT_STATUS_CODE() for an invalid policy PCD setting and I would like platform

Re: [edk2-devel] [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime Services test.

> -Original Message- > From: Ard Biesheuvel > Sent: Thursday, January 30, 2020 2:52 PM > To: Gaurav Jain > Cc: devel@edk2.groups.io; Leif Lindholm ; Pankaj Bansal > > Subject: [EXT] Re: [PATCH 1/1] EmbeddedPkg: Fixed Asserts in SCT Runtime > Services test. > > Caution: EXT Email > >

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Thursday, January 30, 2020 8:41 PM To: devel@edk2.groups.io Cc: Agyeman, Prince ; Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Gao, Liming Subject: [edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 10:28, Laszlo Ersek wrote: > Hi Mike, > > On 01/31/20 09:12, Laszlo Ersek wrote: > >> So let me push this series as-is for TianoCore#2129, with your R-b >> applied. > > My pull request (with the "push" label set) seems to have stalled. The > checks have passed (twice -- I closed and

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 10:28, Laszlo Ersek wrote: > Hi Mike, > > On 01/31/20 09:12, Laszlo Ersek wrote: > >> So let me push this series as-is for TianoCore#2129, with your R-b >> applied. > > My pull request (with the "push" label set) seems to have stalled. The > checks have passed (twice -- I closed and

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

Hi Mike, On 01/31/20 09:12, Laszlo Ersek wrote: > So let me push this series as-is for TianoCore#2129, with your R-b > applied. My pull request (with the "push" label set) seems to have stalled. The checks have passed (twice -- I closed and reopened the PR once, to re-trigger mergify), but the

Re: [edk2-devel] [PATCH v2] BaseTools/Conf/gitattributes: fix "--function-context" for C source code

Laszlo: I am back. This change is good. Reviewed-by: Liming Gao Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo Ersek > Sent: Friday, January 31, 2020 4:34 PM > To: Kinney, Michael D > Cc: edk2-devel-groups-io ; Feng, Bob C > ; Leif Lindholm ; >

Re: [edk2-devel] [PATCH v2] BaseTools/Conf/gitattributes: fix "--function-context" for C source code

Hi Mike, On 01/23/20 13:13, Laszlo Ersek wrote: > Mike, > > can you please ACK this patch while Liming and Bob are away? It's very > simple. I intended to write "ping" here... But then I realized I failed to add you to the "To:" list in the first place, when I asked you to review! :( Sigh.

Re: [edk2-devel] [Patch] BaseTools/Build: Fix Structured PCD app host env issues

Mike: I suggest to call BaseTools\set_vsprefix_envs.bat to setup VS environment. Its input parameter is VS2012, VS2013, VS2015, VS2017, VS2019. If so, we don't need to add VS installation path in Build python script. Thanks Liming > -Original Message- > From: Kinney, Michael D >

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Friday, January 31, 2020 12:41 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Chaganty, Rangasai V > ; Chiu, Chasel ; > Desimone, Nathaniel L ; Gao, Liming > >

Re: [edk2-devel] [PATCH 00/11] SecurityPkg/DxeImageVerificationHandler: fix retval for "deny" policy

On 01/31/20 03:59, Kinney, Michael D wrote: > Hi Laszlo, > > I have reviewed this patch series. All the patches look good. The > detailed description of each change made it easy to review. > > Series Reviewed-by: Michael D Kinney Thank you very much! (more below) > > I have one question

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] Maintainers.txt: Remove Intel maintainer

Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Kubacki, > Michael A > Sent: Friday, January 31, 2020 12:41 PM > To: devel@edk2.groups.io > Cc: Agyeman, Prince ; Chaganty, Rangasai V > ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Gao, Liming >