> -Original Message-
> From: Albecki, Mateusz
> Sent: Monday, February 03, 2020 10:19 PM
> To: devel@edk2.groups.io
> Cc: Albecki, Mateusz; Wu, Hao A; Marcin Wojtas; Gao, Zhichao; Gao, Liming
> Subject: [PATCH 0/4] MdeModulePkg/SdMmcPciHcDxe: Refactor command
> processing
Hello Mateusz,
Yes, I did. This patch also enables the Emulator X64 stack unwind as well.
Thanks
Steven Shi
Intel\SSG\SFE\FIE Firmware Infrastructure
> -Original Message-
> From: Gao, Liming
> Sent: Tuesday, February 4, 2020 3:22 PM
> To: Shi, Steven ; devel@edk2.groups.io
> Cc: Feng, Bob C
>
Reviewed-by: Jian J Wang
Regards,
Jian
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, January 30, 2020 3:01 PM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J ; Lu, XiaoyuX
> Subject: [Patch 1/5] CryptoPkg/BaseCryptLib: Add
> X509ConstructCertificateStackV().
>
>
Steven:
Have you verified this change in Emulator X64?
Thanks
Liming
> -Original Message-
> From: Shi, Steven
> Sent: Monday, February 3, 2020 10:02 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Feng, Bob C ;
> Shi, Steven
> Subject: [PATCH] BaseTools: Enhance call stack
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 9:23 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> On 02/03/20 10:09, Zeng, Star wrote:
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 2:57 PM
> To:
Sorry, the title is incorrect. Please see the thread with title " [PATCH V2]
UefiCpuPkg RegisterCpuFeaturesLib: Match data type and format specifier"
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zeng,
> Star
> Sent: Tuesday, February 4, 2020 3:00 PM
> To:
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Match data type and format specifier for printing.
1. Type cast ProcessorNumber and FeatureIndex to UINT32
as %d only expects a UINT32.
2. Use %08x instead of %08lx for CacheControl to print Index
as it is UINT32 type.
3. Use %016lx instead of %08lx for MemoryMapped to print
(Index |
Vitaly:
Yes. I think we should have better solution in OpenSSL to support EDK2 usage.
But, this is a long term solution. For now, I will try the solution to remove
-fms-compatibility option in CLANGPDB tool chain.
Thanks
Liming
From: vit9696
Sent: Monday, February 3, 2020 7:29 PM
To: Gao,
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, February 4, 2020 10:21 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [Patch V2 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in
> CLANGPDB tool chain
>
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Tuesday, February 4, 2020 10:21 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [Patch V2 2/2] MdePkg: Avoid using __clang__ to specify CLANGPDB
>
>
Thanks for your data. Seemly, those data is acceptable on OvmfXen. For this
patch, Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Anthony PERARD
> Sent: Tuesday, February 4, 2020 1:26 AM
> To: Gao, Liming
> Cc: Laszlo Ersek ;
Mike:
If we document this assumption in build specification, I agree this patch.
Can you enter one BZ for build spec update?
For this patch, Reviewed-by: Liming Gao
Thanks
Liming
> -Original Message-
> From: Kinney, Michael D
> Sent: Tuesday, February 4, 2020 1:52 AM
> To: Gao,
Comply with gEfiSecurityPkgTokenSpaceGuid.PcdTpm2HashMask is better.
We can append new definition after existing one.
#define HASH_ALG_SHA10x0001
#define HASH_ALG_SHA256 0x0002
#define HASH_ALG_SHA384 0x0004
#define HASH_ALG_SHA512 0x0008
#define HASH_ALG_SM3_256 0x0010
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2502
This option is required to make GCC49 tool chain work with the high
version GCC compiler.
Cc: Bob Feng
Signed-off-by: Liming Gao
---
BaseTools/Conf/tools_def.template | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
*Reminder:* TianoCore Community Meeting - APAC/NAMO
*When:* Thursday, 6 February 2020, 7:30pm to 8:30pm, (GMT-08:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=621370 )
*Organizer:* Brian Richardson
Thanks Mike, to cover us during Chinese New Year holiday.
I am just back from vocation. A minor comment:
The PcdHashApiLibPolicy is UINT8, but the value is shown as 32bit 0x0004.
There are couple of ways to enhance:
1) Define UINT8, and use 8bit style 0x04.
2) Define UINT32, and use 32bit
Current UpdateCapsule service will reject all non-reset capsule images and
return EFI_OUT_OF_RESOURCE if the system is at runtime. This will block a
platform CapsuleLib from implementing ProcessCapsuleImage() with runtime
capsule processing capability. This patch removes this restriction.
BZ:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
Avoid using __clang__ to specify CLANGPDB because this macro is also defined
in CLANG38 and this causes CLANG38 build failure.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
MdePkg/Include/Base.h | 2 +-
1 file
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
Define NO_MSABI_VA_FUNCS to use GCC built-in macros for variable argument
lists for CLANGPDB tool chain.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Conf/tools_def.template | 2 +-
1 file changed, 1
From: Amol N Sukerkar
https://bugzilla.tianocore.org/show_bug.cgi?id=2151
This commit introduces a Unified Hash API to calculate hash using a
hashing algorithm specified by the PCD, PcdHashApiLibPolicy. This library
interfaces with the various hashing API, such as, MD4, MD5, SHA1, SHA256,
https://bugzilla.tianocore.org/show_bug.cgi?id=2151
Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded
API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or
SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to
From: Amol N Sukerkar
https://bugzilla.tianocore.org/show_bug.cgi?id=2151
Added CryptoPkg Token Space GUID to be able to define PCDs.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael D Kinney
Signed-off-by: Amol N Sukerkar
Reviewed-by: Michael D Kinney
---
CryptoPkg/CryptoPkg.dec | 6 +-
1
Amol,
One additional issue was found by the Linux/GCC build.
The lib class .h file was correct, but I missed that
the context parameter updates were not propagated to the
BaseHashApiLib instance. So there were function
prototype mismatches between the class and the instance.
I have corrected
Thanks, Mike! Sorry, I seemed to have missed that. I reviewed and accept the
change.
~ Amol
-Original Message-
From: Kinney, Michael D
Sent: Monday, February 03, 2020 3:19 PM
To: Sukerkar, Amol N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Yao, Jiewen ; Wang, Jian J ;
Agrawal,
Hi Mike,
I have no issue with generating new GUIDs.
Thanks,
Amol
-Original Message-
From: Kinney, Michael D
Sent: Monday, February 03, 2020 2:50 PM
To: Sukerkar, Amol N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Yao, Jiewen ; Wang, Jian J ;
Agrawal, Sachin ; Musti, Srinivas
;
Hi Amol,
I prepared a branch an GitHub PR with this content.
The EDK II CI checks found duplicate GUID issues:
PROGRESS - --Running CryptoPkg: Guid Check Test NO-TARGET --
ERROR - Error Duplicate guid: DDCBCFBA-8EEB-488A-96D6-097831A6E50B (2)
GUID: DDCBCFBA-8EEB-488A-96D6-097831A6E50B
Thanks for the review, Mike!
~ Amol
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Monday, February 03, 2020 11:36 AM
To: devel@edk2.groups.io; Sukerkar, Amol N ; Kinney,
Michael D
Cc: Yao, Jiewen ; Wang, Jian J ;
Agrawal, Sachin ; Musti, Srinivas
Hi Amol,
Thanks for the updates. They all look great.
Series Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On
> Behalf Of Sukerkar, Amol N
> Sent: Monday, February 3, 2020 10:19 AM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ;
> Yao,
Added CryptoPkg Token Space GUID to be able to define PCDs.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Michael D Kinney
Signed-off-by: Amol N Sukerkar
---
Notes:
v6
- removed file CryptoPkgTokenSpace.h
v7
- fixed typo
v8
- Fixed Author and signed-off-by name
Currently, the UEFI drivers using the SHA/SM3 hashing algorithms use hard-coded
API to calculate the hash, for instance, sha_256(...), etc. Since SHA384 and/or
SM3_256 are being increasingly adopted for robustness, it becomes cumbersome to
modify each driver that calls into hash calculating API.
This commit introduces a Unified Hash API to calculate hash using a
hashing algorithm specified by the PCD, PcdHashApiLibPolicy. This library
interfaces with the various hashing API, such as, MD4, MD5, SHA1, SHA256,
SHA512 and SM3_256 implemented in BaseCryptLib. The user can calculate
the desired
Liming,
Yes. I think that is a reasonable assumption.
We can document that restriction in the EDK II Build Specification
that standard POSIX include files (e.g. ) must never be
placed in the same directory with other include files that are
required for Structured PCD data types or
On Mon, Feb 03, 2020 at 03:34:07PM +, Anthony PERARD wrote:
> On Mon, Feb 03, 2020 at 01:34:55AM +, Gao, Liming wrote:
> > Anthony:
> > This change is OK to me. But if this PCD is configured as Dynamic, its
> > value will be got from PCD service. This operation will take some time and
*Reminder:* TianoCore Community Meeting - EMEA/NAMO
*When:* Thursday, 6 February 2020, 9:00am to 10:00am, (GMT-08:00) America/Los
Angeles
*Where:* https://bluejeans.com/889357567?src=join_info
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=621369 )
*Organizer:* Brian Richardson
Sorry for the misunderstanding before. The patch set is good to me.
Series: Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Krzysztof Koch [mailto:krzysztof.k...@arm.com]
> Sent: Monday, January 20, 2020 7:14 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao,
On Mon, Feb 03, 2020 at 01:34:55AM +, Gao, Liming wrote:
> Anthony:
> This change is OK to me. But if this PCD is configured as Dynamic, its
> value will be got from PCD service. This operation will take some time and
> cause the inaccurate time delay. Have you measured its impact?
No, I
SdMmcPciHcDxe driver used to read response only after
command and data transfer completed. According to SDHCI
specification response data is ready after the command
complete status is set by the host controller. Getting
the response data early will help debugging the cases
when command completed
Current driver does not support PIO transfer mode for
commands other then tuning. This change adds the code
to transfer PIO data.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 3 +
This patch refactors the way in which the driver will check
the data transfer completion. Data transfer related
functionalities have been moved to separate function.
Cc: Hao A Wu
Cc: Marcin Wojtas
Cc: Zhichao Gao
Cc: Liming Gao
Signed-off-by: Mateusz Albecki
---
To allow for easier debug of failing commands we
have added a capability to print TRB and command
packet when we start execution of the TRB(on
DEBUG_VERBOSE level) and when the TRB failed to
execute correctly(on DEBUG_ERROR level). Additionally
we will also print error interrupt status and
This patch series aims to refactor command processing to achieve following
1. Trace the failing TRB packets to see what commands are failing and for what
reasons
2. Get the response data even if data transfer timed out to allow easier
debugging
3. Fix the PIO mode which is currently completely
From: Steven
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2487
The call stack unwindability of the COFF X64 binary requires
the binary to remain the pdata and xdata sections.
Details see the MSVC X64 calling convertion doc in below link:
The Raspberry Pi 4 platforms uses a Broadcom Genet network interface, for
which we need ACPI entries in order to make it usable under Linux.
This patch adds these entries, including a max-dma-burst-size DSD attribute
aimed at simplifying support for Genet on distros that use older kernels,
such
Pierre:
If so, this is not the error for other ACPI table. I suggest to print INFO
message and directly return with success return value.
Thanks
Liming
> -Original Message-
> From: Pierre Gondois
> Sent: Monday, February 3, 2020 9:20 PM
> To: devel@edk2.groups.io; Gao, Liming
> Cc:
On 02/03/20 10:09, Zeng, Star wrote:
>> -Original Message-
>> From: Laszlo Ersek
>> Sent: Monday, February 3, 2020 4:47 PM
>> To: Zeng, Star ; devel@edk2.groups.io
>> Cc: Dong, Eric ; Ni, Ray
>> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
>> CacheControl
Hello Liming,
Currently, the only ACPI tables which contain AML bytecode are the DSDT and
SSDT tables. We don't need to generate a ".hex" file for other ACPI tables or
any other file since we would like to parse AML bytecode.
However this is only a safety check and this can be removed if
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Monday, February 3, 2020 4:15 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
>
> Subject: [PATCH 2/2] MdePkg: Use the same VA function for both CLANGPDB and
> CLANG38
>
>
Reviewed-by: Liming Gao
> -Original Message-
> From: Liu, Zhiguang
> Sent: Monday, February 3, 2020 4:15 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [PATCH 1/2] BaseTools: append -DNO_MSABI_VA_FUNCS option in CLANGPDB
> tool chain
>
>
Changes from v2:
* Remove #if (FixedPcdGet64 (PcdBcmGenetRegistersAddress) != 0) check
Jeremy Linton (2):
Silicon/Broadcom/Net: Add Genet stub driver to setup MAC
Platform/RPi4: Enable Broadcom Genet stub driver
Pete Batard (1):
Platform/RPi: Add PlatformPcdLib to set the Genet MAC address
From: Jeremy Linton
Add a stub for the Broadcom Genet network interface, that is used
by the Raspberry Pi 4 (and that may be used by other platforms).
For the time being, the stub only performs UMAC init, using a MAC
address PCD, as, even without a working network interface in UEFI
environment,
The Genet driver stub used by the Raspberry Pi 4 platform is
designed to set the MAC address according to a PCD.
To be able to set that PCD at runtime, by using the Raspberry
Pi firmware interface, that has a dedicated call to retrieve
the MAC address, and satisfy driver dependencies in a generic
Pierre:
Thanks for your contribution. Do you verify below configurations? And, how do
you verify Windows host + GCC make?
1. Windows Host + VS nmake
2. Windows Host + GCC make
3. Linux Host + GCC make.
Thanks
Liming
> -Original Message-
> From: Pierre Gondois
> Sent: Thursday, January
Pierre:
Sorry for late response. I have one comment. Why only allows "DSDT" or "SSDT"
in Signature?
Thanks
Liming
> -Original Message-
> From: Pierre Gondois
> Sent: Thursday, January 23, 2020 1:32 AM
> To: Pierre Gondois ; devel@edk2.groups.io
> Cc: ard.biesheu...@linaro.org; Feng,
Liming,
I believe it is reasonable to fix OpenSSL, but most likely it is faster to
address EDK II code at first. In future we should still stick to _MSC_VER, but
for now just ensuring that any toolchain by MSVC does not define
_MSC_EXTENSIONS should work too.
I believe that -fms-compatibility
Hello Hao,
On 02/03/20 01:34, Hao A Wu wrote:
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2498
>
> Commit fd30b00707 updated the logic in function MicrocodeDetect() that
> will directly use the CPUID and PlatformID information from the 'CpuData'
> field in the CPU_MP_DATA structure,
> -Original Message-
> From: Laszlo Ersek
> Sent: Monday, February 3, 2020 4:47 PM
> To: Zeng, Star ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: Re: [PATCH] UefiCpuPkg RegisterCpuFeaturesLib: Use %08x to print
> CacheControl Index
>
> Hello Star,
>
> On 02/03/20 08:06,
Hi,
Is there any chance this patch series will get reviewed soon?
The v1 series has already been reviewed a few months ago and the patches which
were not ok were re-submitted as v2.
The v3 series is basically a rebase of v1 on latest master with the v2 changes
included.
Kind regards,
Krzysztof
Hello Star,
On 02/03/20 08:06, Star Zeng wrote:
> Instead of %08lx, use %08x to print CacheControl Index
> as it is UINT32 type.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Laszlo Ersek
> Signed-off-by: Star Zeng
> ---
> .../Library/RegisterCpuFeaturesLib/CpuFeaturesInitialize.c | 2 +-
> 1
Signed-off-by: Zhiguang Liu
Reviewed-by: Liming Gao
---
MdePkg/Include/Base.h | 2 +-
MdePkg/Include/Ia32/ProcessorBind.h | 2 +-
MdePkg/Include/X64/ProcessorBind.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/MdePkg/Include/Base.h
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
For CLANGPDB tool chain and X64, use MS ABI version of GCC built-in macros for
variable argument lists to be align with CLANG38 tool chain.
Cc: Michael D Kinney
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
MdePkg/Include/Base.h | 2
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2415
For CLANGPDB tool chain and X64, use MS ABI version of GCC built-in macros for
variable argument lists to be align with CLANG38 tool chain.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Zhiguang Liu
---
BaseTools/Conf/tools_def.template |
Vitaly:
This change will cause CryptoPkg openssl build failure, because
OpensslLib.inf undefines _MSC_VER macro to make sure openssl source code be
built in edk2 project without using MS VS functions.
Now, I have no good solution to fix this issue. One way is to use
65 matches
Mail list logo
