Re: [edk2-devel] [patch 2/2] MdeModulePkg/DisplayEngine: Zero memory before free (CVE-2019-14558)

2020-02-12 Thread Wang, Jian J
Please update copyright year for patch 1 and 2. With it addressed, Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Thursday, February 13, 2020 12:03 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Wang, Jian J > Subject: [patch

Re: [edk2-devel] [patch 1/2] MdeModulePkg/String.c: Zero memory before free (CVE-2019-14558)

2020-02-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Thursday, February 13, 2020 12:03 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Wang, Jian J > Subject: [patch 1/2] MdeModulePkg/String.c: Zero memory before free (CVE- >

Re: [edk2-devel] [patch] MdeModulePkg/HiiDB: Remove configuration table when it's freed (CVE-2019-14586)

2020-02-12 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Bi, Dandan > Sent: Thursday, February 13, 2020 12:03 PM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Dong, Eric ; > Wang, Jian J > Subject: [patch] MdeModulePkg/HiiDB: Remove configuration table when it's > freed

[edk2-devel] [patch 1/2] MdeModulePkg/String.c: Zero memory before free (CVE-2019-14558)

2020-02-12 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1611 Cc: Liming Gao Cc: Eric Dong Cc: Jian J Wang Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/HiiDatabaseDxe/String.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MdeModulePkg/Universal/HiiDatabaseDxe/String.c

[edk2-devel] [patch 2/2] MdeModulePkg/DisplayEngine: Zero memory before free (CVE-2019-14558)

2020-02-12 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1611 Cc: Liming Gao Cc: Eric Dong Cc: Jian J Wang Signed-off-by: Dandan Bi --- MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[edk2-devel] [patch] MdeModulePkg/HiiDB: Remove configuration table when it's freed (CVE-2019-14586)

2020-02-12 Thread Dandan Bi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1995 Fix the corner case issue that the original configuration runtime memory is freed, but it is still exposed to the OS runtime. So this patch is to remove the configuration table to avoid being used in OS runtime when the configuration

[edk2-devel] [PATCH v2 0/1] Remove "no-autoalginit" flag from OpenSSL build

2020-02-12 Thread Zurcher, Christopher J
In order to implement the EVP interface, the EVP_get_digestbyname function requires the desired digest to be already initialized. Removing the "no-autoalginit" build option will allow algorithms to be retrieved by name. Cc: Jian J Wang Cc: Xiaoyu Lu Christopher J Zurcher (1):

[edk2-devel] [PATCH v2 1/1] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build

2020-02-12 Thread Zurcher, Christopher J
This is required for interfaces such as EVP to retrieve algorithms by name. This commit also adds the "sort" keyword to the header file parsing loop so the .inf files aren't randomized after every run of process_files.pl. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Christopher J Zurcher ---

Re: [edk2-devel] [Patch 1/1] BaseTools:build failure in CLANGPDB tool chain

2020-02-12 Thread Bob Feng
Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of Fan, ZhijuX Sent: Wednesday, February 12, 2020 5:59 PM To: devel@edk2.groups.io Cc: Fan, ZhijuX ; Gao, Liming ; Feng, Bob C Subject: [edk2-devel] [Patch 1/1] BaseTools:build failure in CLANGPDB tool chain

[edk2-devel] [PATCH v3 0/2] Move FIT based microcode shadow to platform PEIM

2020-02-12 Thread Siyuan, Fu
V2 Changes: Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID. Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform microcode shadow PPI/Protocol is found. Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni V3 Changes Add comments to DXE version

[edk2-devel] [PATCH v3 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

2020-02-12 Thread Siyuan, Fu
V2 Changes: Rename EDKII_PEI_CPU_MICROCODE_ID to EDKII_PEI_MICROCODE_CPU_ID. Return EFI_UNSUPPORTED instead of EFI_NOT_FOUND if no platform microcode shadow PPI/Protocol is found. Remove PcdCpuShadowMicrocodeByFit related tokens from UefiCpuPkg.uni V3 Changes Add comments to DXE version

[edk2-devel] [PATCH v3 2/2] MdePkg: Remove FIT table industry standard header file.

2020-02-12 Thread Siyuan, Fu
Commit c7c964b and dd01704 add header file for FIT table and update MpInitLib to support FIT based microcode shadow operation. There are comments that FIT is Intel specific specification instead of industry standard, which should not be placed in EDK2 MdePkg and UefiCpuPkg. This patch removes the

Re: [edk2-devel] [PATCH 0/9] Fix false negative issue in DxeImageVerificationHandler

2020-02-12 Thread Liming Gao
Jian, Jiewen and Chao: Does this patch catch to edk2 Q1 stable tag? If yes, can this patch be reviewed this week, because Q1 stable tag soft feature freeze is 2020-02-14. Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian J > Sent: Thursday,

Re: [edk2-devel] [staging/RISC-V-V2]: Need to bump opensbi submodule to get sbi_hfence.S etc.

2020-02-12 Thread Abner Chang
Hi Rebecca, We fixed the build errors in order to incorporate with latest OpenSBI lib. Both changes were on RISC-V-V2 and devel-riscvplatorms branches which are same as before. However, we rebased and force updated it in order to keep the commits clear. We may keep doing this until we get those

[edk2-devel] [edk2-platforms] [PATCH 4/4] WhiskeylakeOpenBoardPkg/UpXtreme: Add DSC and build files

2020-02-12 Thread Agyeman, Prince
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191 Adds the DSC and build files necessary to build the UpXtreme board instance. Key files = * build_config.cfg - Board-specific build configuration file. * OpenBoardPkg.dsc - The UpXtreme board description file. * OpenBoardPkgPcd.dsc -

[edk2-devel] [edk2-platforms] [PATCH 2/4] WhiskeylakeOpenBoardPkg: Add UpXtreme board ID

2020-02-12 Thread Agyeman, Prince
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2191 Co-authored-by: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Intel/WhiskeylakeOpenBoardPkg/Include/PlatformBoardId.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git

[edk2-devel] [edk2-platforms] [PATCH 1/4] WhiskeylakeOpenBoardPkg/WhiskeylakeURvp: Remove BoardFuncInit

2020-02-12 Thread Agyeman, Prince
Removes BoardFuncInit related functionality in WhiskeylakeURvp. Co-authored-by: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Library/BoardInitLib/BoardFunc.c | 19 .../Library/BoardInitLib/BoardFunc.h | 20

Re: [edk2-devel] [PATCH v2 2/2] MdePkg: Remove FIT table industry standard header file.

2020-02-12 Thread Michael D Kinney
Reviewed-by: Michael D Kinney > -Original Message- > From: Fu, Siyuan > Sent: Tuesday, February 11, 2020 5:37 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, > Liming > Subject: [PATCH v2 2/2] MdePkg: Remove FIT table industry > standard header file. > > Commit c7c964b

Re: [edk2-devel] [PATCH v3] IntelSiliconPkg: FIT based shadow microcode PPI support.

2020-02-12 Thread Michael D Kinney
Siyuan, IntelSiliconPkg/Feature/ShadowMicrocode: For simple modules that only have a single .c file, there Is not need to split out a .h file. Please merge the .h File content into the .c file and delete the .h file. More comments inline below. Mike > -Original Message- > From:

Re: [edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Krzysztof Koch > Sent: Thursday, February 13, 2020 1:28 AM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; Gao, Liming > ; matteo.carl...@arm.com; > sami.muja...@arm.com; n...@arm.com > Subject: [PATCH v2 1/1] MdePkg: Add PCCT

Re: [edk2-devel] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: Kinney, Michael D > Sent: Thursday, February 13, 2020 6:45 AM > To: devel@edk2.groups.io > Cc: Gao, Liming ; Sean Brogan > ; Bret Barkelew > Subject: [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures > >

[edk2-devel] [PATCH 1/1] CryptoPkg/OpensslLib: Remove "no-autoalginit" flag from OpenSSL build

2020-02-12 Thread Zurcher, Christopher J
This is required for interfaces such as EVP to retrieve algorithms by name. This commit also adds the "sort" keyword to the header file parsing loop so the .inf files aren't randomized after every run of process_files.pl. --- CryptoPkg/Library/OpensslLib/OpensslLib.inf | 64

[edk2-devel] [PATCH 0/1] Remove "no-autoalginit" flag from OpenSSL build

2020-02-12 Thread Zurcher, Christopher J
In order to implement the EVP interface, the EVP_get_digestbyname function requires the desired digest to be already initialized. Removing the "no-autoalginit" build option will allow algorithms to be retrieved by name. Cc: Jian J Wang Cc: Xiaoyu Lu Christopher J Zurcher (1):

Re: [edk2-devel] [PATCH 04/19] Silicon/NXP: Remove DuartLib and use BaseSerialPortLib16550

2020-02-12 Thread Leif Lindholm
On Mon, Feb 10, 2020 at 05:48:47 +, Pankaj Bansal wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Saturday, February 8, 2020 11:16 PM > > To: Pankaj Bansal > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; Varun Sethi ; > > devel@edk2.groups.io > > Subject:

Re: [edk2-devel] [PATCH 14/19] Silicon/NXP/LS1043A: Replce SocLib

2020-02-12 Thread Leif Lindholm
On Wed, Feb 12, 2020 at 09:37:30 +, Pankaj Bansal wrote: > > > > -Original Message- > > From: Leif Lindholm > > Sent: Tuesday, February 11, 2020 7:05 PM > > To: Pankaj Bansal > > Cc: Meenakshi Aggarwal ; Michael D Kinney > > ; Varun Sethi ; > > devel@edk2.groups.io > > Subject: Re:

Re: [edk2-devel] [EXTERNAL] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Bret Barkelew via Groups.Io
Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney Sent: Wednesday, February 12, 2020 2:45:11 PM To: devel@edk2.groups.io Cc: Liming Gao ; Sean Brogan ; Bret Barkelew Subject: [EXTERNAL] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

[edk2-devel] [Patch] MdePkg/BaseSafeIntLib: Fix VS20xx IA32 link failures

2020-02-12 Thread Michael D Kinney
https://bugzilla.tianocore.org/show_bug.cgi?id=2525 SafeUint64Mult() looks for 64-bit overflows and performs several 32-bit multiples with 64-bit results to check for all possible overflow conditions. IA32 builds using VS20xx with optimizations enabled are producing a reference to the _allmull

Re: [edk2-devel] [PATCH 18/19] Silicon/NXP: Add LX2160A SocLib

2020-02-12 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:27 +0530, Pankaj Bansal wrote: > Add LX2160A SocLib Same soclib question as elsewhere. Also, please add some more info to commit message. > Signed-off-by: Pankaj Bansal > --- > Silicon/NXP/Chassis3V2/LX2160A/Include/Soc.h | 39 + >

Re: [edk2-devel] [PATCH 19/19] Platform/NXP: Add LX2160ARDBPKG

2020-02-12 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:28 +0530, Pankaj Bansal wrote: > Add LX2160ARDBPKG > > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/Include/Qixis.h | 40 > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dec | 23 +++ > Platform/NXP/LX2160aRdbPkg/LX2160aRdbPkg.dsc | 54

Re: [edk2-devel] [PATCH 17/19] Silicon/NXP: Add Chassis3V2

2020-02-12 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:26 +0530, Pankaj Bansal wrote: > Add Chassis3V2 Insufficient as a commit message. > Signed-off-by: Pankaj Bansal > --- > Silicon/NXP/Chassis3V2/Chassis3V2.dec | 23 +++ > Silicon/NXP/Chassis3V2/Chassis3V2.dsc.inc | 10 + >

Re: [edk2-devel] [PATCH 16/19] Silicon/NXP: Add Pl011 Serial port lib

2020-02-12 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:25 +0530, Pankaj Bansal wrote: > Use ArmPlatformPkg/PL011SerialPortLib with some changes: > 1. add Get clock API to get the UART clock from ArmPlatformLib > 2. remove SerialPortInitalize functionality > > This is same as being done in

Re: [edk2-devel] [PATCH 15/19] Platform/NXP/LS1043ARDB: introduce PEI Phase

2020-02-12 Thread Leif Lindholm
On Fri, Feb 07, 2020 at 18:13:24 +0530, Pankaj Bansal wrote: > Added PEI phase to LS1043ARDB. Needs more detail. > Signed-off-by: Pankaj Bansal > --- > Platform/NXP/FVRules.fdf.inc | 60 --- > Platform/NXP/LS1043aRdbPkg/LS1043aRdbPkg.dsc | 13 -- >

[edk2-devel] [PATCH v2 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Krzysztof Koch
The Platform Communications Channel Table (PCCT) was defined in: ACPI Specification Version 5.0, Errata A - Published Nov. 13, 2013. Starting from the Acpi50.h header file, there are definitions describing the table but a macro with the table's signature is missing. This patch adds the

Re: [edk2-devel] [PATCH v3 00/78] Fix a bunch of typos (part 1)

2020-02-12 Thread Cœur
Le 11/02/2020 à 06:54, Laszlo Ersek a écrit : Thank you Antoine and Phil for this large work! Laszlo No problem for the work. Sorry for the EFI_D_INFO: it was changed with the typo in October 2019, while my commit predates. For the little story, I made most corrections in February 2018, and

Re: [edk2-devel] [RFC PATCH 1/1] OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path

2020-02-12 Thread Ni, Ray
> (3) However: I think this should be added as a Dynamic Command instead. > I'm basing this on the message of commit 0961002352e9 ("ShellPkg/tftp: > Convert from NULL class library to Dynamic Command", 2017-11-28), which > is the first commit in edk2 ever to introduce a Dynamic Command. > > And

Re: [edk2-devel] PCD Migration issue

2020-02-12 Thread Liming Gao
Andrew: For the work model with old PEI and new DXE, besides Dynamic PCD, there may be Hob or Variable issue. This is a complex topic to make sure the mismatch PEI and DXE work together. Thanks Liming > -Original Message- > From: af...@apple.com > Sent: Wednesday, February 12, 2020

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Vitaly Cheptsov via Groups.Io
Liming, Yes, perhaps that was unclear from my message. From what I understand __builtin_va_start behaves the same way as __builtin_ms_va__start for EFIAPI functions, and these are currently the only functions where variadic arguments are allowed. For non-EFIAPI functions the calling

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Liming Gao
Vitaly: With this change, X64 GCC and CLANG tool chain will use below VA_START definition. #define VA_START(Marker, Parameter) __builtin_ms_va_start (Marker, Parameter) Thanks Liming From: devel@edk2.groups.io On Behalf Of Vitaly Cheptsov via Groups.Io Sent: Wednesday, February 12, 2020

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Krzysztof Koch
Hi Liming, No problem, I will resubmit the patch updating the relevant ACPI spec header files. Thanks, Krzysztof -Original Message- From: Gao, Liming Sent: Wednesday, February 12, 2020 13:59 To: Krzysztof Koch ; devel@edk2.groups.io Cc: Kinney, Michael D ; Matteo Carlini ; nd ;

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Liming Gao
Krzysztof: Sorry to miss this patch. I see PCCT table is added since ACPI 5.0. So, I think its table signature definition should also be added into Acpi50.h, Acpi51.h, Acpi60.h, Acpi61.h and Acpi62.h. Thanks Liming > -Original Message- > From: Krzysztof Koch > Sent: Wednesday,

[edk2-devel] [edk2-platforms] [PATCH v2 2/5] Platform/ARM/SgiPkg: Use lookup table to install ACPI table

2020-02-12 Thread Vijayenthiran Subramaniam
Use lookup table to identify the platform and install corresponding ACPI tables. As the number of supported platforms grow, the existing platform identification using if..else does not scale well. Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c

[edk2-devel] [edk2-platforms] [PATCH v2 5/5] Platform/ARM/Sgi: Add initial support for RD-N1-Edge-Dual platform

2020-02-12 Thread Vijayenthiran Subramaniam
For RD-N1-Edge platforms, use multi-chip-mode information from the SGI platform descriptor HOB to pick the correct ACPI table to be installed. Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 1 +

[edk2-devel] [edk2-platforms] [PATCH v2 3/5] Platform/ARM/SgiPkg: Add MultiChipMode to Platform Descriptor

2020-02-12 Thread Vijayenthiran Subramaniam
The 'system-id' node of HW_CONFIG device tree has been updated to have a new property 'multi-chip-mode' which holds the information about the multi-chip-mode support. To adapt to this change, add 'MultiChipMode' member to SGI_PLATFORM_DESCRIPTOR structure to get 'multi-chip-mode' property from

[edk2-devel] [edk2-platforms] [PATCH v2 4/5] Platform/ARM/Sgi: Add ACPI tables for dual-chip RD-N1-Edge platform

2020-02-12 Thread Vijayenthiran Subramaniam
RD-N1-Edge supports a dual-chip configuration in which two RD-N1-Edge platforms are connected through high speed CCIX link. In this dual-chip configuration, the CPU and core GIC Redistributors count are doubled. Add ACPI tables for dual-chip RD-N1-Edge platform. Signed-off-by: Vijayenthiran

[edk2-devel] [edk2-platforms] [PATCH v2 1/5] Platform/ARM/SgiPkg: Disable use of deprecated APIs

2020-02-12 Thread Vijayenthiran Subramaniam
Add the `DISABLE_NEW_DEPRECATED_INTERFACES` build option in DSC file to make sure that the deprecated APIs are not used SgiPkg. Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/PlatformStandaloneMm.dsc | 3 +++ Platform/ARM/SgiPkg/SgiPlatform.dsc | 3 +++ 2 files

[edk2-devel] [edk2-platforms] [PATCH v2 0/5] Platform/ARM/SgiPkg: Add support for RD-N1-Edge-Dual platform

2020-02-12 Thread Vijayenthiran Subramaniam
Changes since v1: - Fix typo which caused build error This patch series adds support for RD-N1-Edge platform with multi-chip capability. The first patch in this series is an improvement to SgiPkg to avoid any usage of deprecated APIs. The second patch refactors the existing code to use lookup

[edk2-devel] [PATCH] [edk2-staging/FceFmmt]BaseTools: Support no UI section FFS

2020-02-12 Thread Feng, YunhuaX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2521 1. If FFS file has no UI section, its FILE_GUID will be used as its name. FMMT tool -d/-a/-r option can be updated to support such FFS file. 2. -v option will print FILE_GUID if no UI section Cc: Bob Feng Cc: Liming Gao Signed-off-by:

Re: [edk2-devel] [PATCH v3 00/78] Fix a bunch of typos (part 1)

2020-02-12 Thread Laszlo Ersek
On 02/11/20 13:12, Philippe Mathieu-Daudé wrote: > I think I probably messed this when rebasing (Antoine work was 1 year > old...). Not a big deal, thank you for salvaging Antoine's work! Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply

Re: [edk2-devel] [RFC PATCH 1/1] OvmfPkg: add 'initrd' shell command to expose Linux initrd via device path

2020-02-12 Thread Laszlo Ersek
Adding Ray and Zhichao; comments below On 02/11/20 19:03, Ard Biesheuvel wrote: > Add a new 'initrd' command to the UEFI Shell that allows any file that is > accessible to the shell to be registered as the initrd that is returned > when Linux's EFI stub loader invokes the LoadFile2 protocol on

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Add PCCT table signature definition

2020-02-12 Thread Krzysztof Koch
Hi All, Is there something I can do to help get this patch merged? Kind regards, Krzysztof -Original Message- From: Sami Mujawar Sent: Thursday, January 30, 2020 11:40 To: Krzysztof Koch ; devel@edk2.groups.io Cc: michael.d.kin...@intel.com; liming@intel.com; Matteo Carlini ; nd

Re: [edk2-devel] [edk2-platforms] [PATCH v2 6/7] CometlakeOpenBoardPkg/CometlakeURvp: Add DSC and build files

2020-02-12 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Esakkithevar, Kathappan Sent: Tuesday, February 11, 2020 11:13 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Kethi Reddy, Deepika ; Agyeman, Prince Subject: [edk2-platforms] [PATCH v2

Re: [edk2-devel] [edk2-platforms] [PATCH v2 2/7] CometlakeOpenBoardPkg/CometlakeURvp: Add headers

2020-02-12 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Esakkithevar, Kathappan Sent: Tuesday, February 11, 2020 11:13 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Kethi Reddy, Deepika ; Agyeman, Prince Subject: [edk2-platforms] [PATCH v2

[edk2-devel] [Patch 1/1] BaseTools:build failure in CLANGPDB tool chain

2020-02-12 Thread Fan, ZhijuX
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2520 Incremental build failure in CLANGPDB tool chain on Windows host The build failure is like below when do incremental build. The root cause is in generated deps_target file. It has one line ":". Signed-off-by: Zhiju.Fan Cc: Liming Gao Cc:

Re: [edk2-devel] [PATCH v2 1/2] UefiCpuPkg: Remove FIT based microcode shadow logic from MpInitLib.

2020-02-12 Thread Laszlo Ersek
On 02/12/20 03:52, Ni, Ray wrote: > >> +EFI_STATUS >> +PlatformShadowMicrocode ( >> + IN OUT CPU_MP_DATA *CpuMpData >> + ) >> +{ >> + return EFI_UNSUPPORTED; >> +} > > Siyuan, > Better to have comments above "return EFI_UNSUPPORTED" to clarify the > existing supporting scope. > >

Re: [edk2-devel] [PATCH 14/19] Silicon/NXP/LS1043A: Replce SocLib

2020-02-12 Thread Pankaj Bansal
> -Original Message- > From: Leif Lindholm > Sent: Tuesday, February 11, 2020 7:05 PM > To: Pankaj Bansal > Cc: Meenakshi Aggarwal ; Michael D Kinney > ; Varun Sethi ; > devel@edk2.groups.io > Subject: Re: [PATCH 14/19] Silicon/NXP/LS1043A: Replce SocLib > > On Fri, Feb 07, 2020 at

Re: [edk2-devel] [PATCH V2] BaseTools:fix Ecc tool issue for check StructPcd

2020-02-12 Thread Bob Feng
Reviewed-by: Bob Feng < bob.c.f...@intel.com > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#54274): https://edk2.groups.io/g/devel/message/54274 Mute This Topic: https://groups.io/mt/69769091/21656 Group Owner:

Re: [edk2-devel] [Patch] BaseTools: Fixed build failure when using python38

2020-02-12 Thread Bob Feng
Reviewed-by: Bob C Feng -Original Message- From: Fan, ZhijuX Sent: Wednesday, February 12, 2020 3:14 PM To: devel@edk2.groups.io Cc: Gao, Liming ; Feng, Bob C Subject: [Patch] BaseTools: Fixed build failure when using python38 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2304

Re: [edk2-devel] [PATCH 1/1] BaseTools: Switch to GNU mode for CLANGPDB

2020-02-12 Thread Vitaly Cheptsov via Groups.Io
Liu, Thanks for explanation, it does make sense now. As for no need to -DNO_MSABI_VA_FUNCS I agree, but it will not make much difference, because from what I understand the VA_ARG implementation is chosen based on EFIAPI presence when generic __builtin’s are used. Best, Vitaly > 12 февр.