"Stuart" gives the system a lot of structure and flexibility. It lets us
maintain the build process consistently in a cross platform way and allows
platforms to use python instead of shell scripting. This takes advantage of
our investments in dependency management, optimized submodule
On 3/27/20 8:29 PM, Sean via Groups.Io wrote:
Feedback wanted. Happy to add more if there is some agreement that
you like this direction.
I see the OVMF build is running for example:
/opt/hostedtoolcache/Python/3.8.2/x64/bin/stuart_build -c
OvmfPkg/PlatformBuild.py TOOL_CHAIN_TAG=GCC5
There are two parts of this I think should be discussed.
1. Core-Ci for emulator, ovmf, armvirt packages.
a. I think there is some value here for those package maintainers. The core ci
does spell checks, char encoding checks, lib class declaration, etc. Those
seem valuable to help keep the
Thanks Mike.
I understand the *private protocol* now. I think it is OK to put CryptoProtocol
into Private dir to sever that purpose.
And for private API, I don’t have concern on the data structure, since it is
invisible.
Siyuan provided below usage and concern:
"The goal to provide a driver
Hello Per,
unfortunately, due to the spectacularly broken threading in this
discussion, I have to reconstruct the history manually first:
On Mar 27, 2020, at 8:51 AM, per_sundstrom via Groups.Io
wrote:
> I want to exclusively use PXE/IPv6 when deploying a set of physical
> machines with some
Reviewed-by: Ashley DeSimone
-Original Message-
From: Desimone, Nathaniel L
Sent: Friday, March 27, 2020 1:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Ashley E ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Philippe Mathieu-Daudé
Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo:
On 28/03/2020 1:04, Liran Alon wrote:
On 28/03/2020 0:05, Laszlo Ersek wrote:
On 03/27/20 14:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+ Packet->HostAdapterStatus =
+ EFI_EXT_SCSI_STATUS_HOST_ADAPTER_DATA_OVERRUN_UNDERRUN;
+
On 28/03/2020 0:05, Laszlo Ersek wrote:
On 03/27/20 14:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+ Packet->HostAdapterStatus =
+ EFI_EXT_SCSI_STATUS_HOST_ADAPTER_DATA_OVERRUN_UNDERRUN;
+ return
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
The UEFI specification v2.8 Errata A Section 8.2 "GetVariable()"
"Attributes" parameter description states:
"If not NULL, a pointer to the memory location to return the
attributes bitmask for the variable. See
From: Michael Kubacki
This reverts commit 6896efdec2709e530b23c688cf0f31706709a0c5.
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
GetVariable() now returns attributes when it fails with
EFI_BUFFER_TOO_SMALL. Therefore, commit 6896efdec270 is
reverted since it is no longer relevant.
From: Michael Kubacki
This patch series updates the GetVariable() implementation
to return Attributes in the case EFI_BUFFER_TOO_SMALL is returned.
* [PATCH v3 1/3] Makes the functional change in the DXE/MM variable driver.
* [PATCH v3 2/3] Makes the functional change in the PEI variable
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2062
This commit makes the behavior for PeiGetVariable() match the following
specification-defined behavior. It is now consistent with the DXE/SMM
variable driver implementation.
The UEFI specification v2.8 Errata A
On 27/03/2020 16:35, Laszlo Ersek wrote:
On 03/27/20 01:05, Liran Alon wrote:
On 27/03/2020 0:17, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
PvScsiRestorePciAttributes (Dev);
diff --git a/OvmfPkg/PvScsiDxe/PvScsi.h b/OvmfPkg/PvScsiDxe/PvScsi.h
index
On 03/27/20 14:04, Liran Alon wrote:
>
> On 27/03/2020 14:26, Laszlo Ersek wrote:
>> On 03/25/20 17:10, Liran Alon wrote:
>>> +/**
>>> + Returns if PVSCSI request ring is full
>>> +**/
>>> +STATIC
>>> +BOOLEAN
>>> +PvScsiIsReqRingFull (
>>> + IN CONST PVSCSI_DEV *Dev
>>> + )
>>> +{
>>> +
Reviewed-by: Nate DeSimone
On 3/26/20, 2:26 PM, "Desimone, Ashley E" wrote:
Add the definition of PIN_FILE_HELP to
checkout_pin_args.py to fix import error.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret
Currently edkrepo --help shows a listing of commands
that is not in alphabetical order. This is confusing.
This change makes the list shown in alphabetical order.
Cc: Ashley DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Philippe Mathieu-Daudé
Signed-off-by: Nate DeSimone
Hi Rebecca,
On 03/25/20 21:16, Rebecca Cran wrote:
> Signed-off-by: Rebecca Cran
> ---
> OvmfPkg/Include/OvmfPlatforms.h| 7 +++
> OvmfPkg/Library/AcpiTimerLib/BaseAcpiTimerLib.c| 3 +++
> OvmfPkg/Library/AcpiTimerLib/BaseRomAcpiTimerLib.c | 4
>
Thanks for the quick reply.
I sort of suspected that it was compiled in :-(
How hard would it be to have it configured through fw_cfg ?
We are on a supported distro and are not allowed homebrewed binaries.
And, [more importantly] are there any other ways of persuading OVMF to boot
from IPv6
Hi All,
On 03/27/20 03:51, Wang, Jian J wrote:
> Zhichao,
>
> You can just use the PCD in C code "if (PcdGet...){}" instead of macro
> #if.
I do not have the capacity to contribute useful thoughts to this
discussion right now; I just want to provide three links here, to
previous comments that
/Per,
PCD's are a Platform Configuration Database that is used in the edk2. Values
can be compiled in, patched in binaries, or looked up dynamically in a
database. The idea is the consuming code, like the UefiPxeBcDxe driver, codes
stays the same and the platform sets the mechanism that is
That's a good point. I will send a v3 with the change added to VariablePei.
Thanks,
Michael
On 3/27/2020 7:39 AM, Wang, Jian J wrote:
Michael,
I know this is related to UEFI spec. But I think the PEI variable driver should
be
consistent with RT driver's behavior. Otherwise it will cause
Jiewen,
The purpose of private includes is to keep modules/lib
in *other* packages from using interfaces that are the
package with the private interface does not want other
packages to use and does not want to have to coordinate
with other packages if that package owner decides to
make changes to
Hi,
I want to exclusively use PXE/IPv6 when deploying a set of physical machines
with some QEMU/KVM virtual machines on top.
So far, the only [hacky] way I have managed to do this is to:
1) Bring up a VM with OVMF
2) Set the wanted boot-order with PXE over IPv6 at the top
3) Save this to the
Michael,
I know this is related to UEFI spec. But I think the PEI variable driver should
be
consistent with RT driver's behavior. Otherwise it will cause confusion. I
suggest
to make similar change to PEI variable driver.
Regards,
Jian
> -Original Message-
> From: devel@edk2.groups.io
On 03/27/20 15:36, Laszlo Ersek wrote:
> (+Phil, +Anthony)
>
> On 03/26/20 09:43, Ard Biesheuvel wrote:
>> (+ Laszlo)
>>
>> On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei
>> wrote:
>>>
>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570
>>> OvmfPkg and EmulatorPkg are mostly used by the
(+Phil, +Anthony)
On 03/26/20 09:43, Ard Biesheuvel wrote:
> (+ Laszlo)
>
> On Thu, 26 Mar 2020 at 08:04, Zhang, Shenglei
> wrote:
>>
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2570
>> OvmfPkg and EmulatorPkg are mostly used by the developers, so add
>> them to target list.
>>
>>
On 03/26/20 11:24, Ard Biesheuvel wrote:
> The UEFI properties table and the associated memory protection feature was
> severely broken from the start, and has been deprecated for a while. Let's
> drop all references to it from OVMF so we can safely remove it from the
> DXE core as well.
>
>
On 03/27/20 01:05, Liran Alon wrote:
>
> On 27/03/2020 0:17, Laszlo Ersek wrote:
>> On 03/25/20 17:10, Liran Alon wrote:
>>> PvScsiRestorePciAttributes (Dev);
>>> diff --git a/OvmfPkg/PvScsiDxe/PvScsi.h b/OvmfPkg/PvScsiDxe/PvScsi.h
>>> index 6d23b6e1eccf..7f91d70fec79 100644
>>> ---
On 27/03/2020 16:04, Liran Alon wrote:
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+
+ //
+ // Report target status
+ //
+ Packet->TargetStatus = Response->ScsiStatus;
+
+ //
+ // Host adapter status and function return value depend on
+ // device
Incidentally, this is not an [edk2-platform] patch, as the subject line
from previous mail seemed to indicate, but an [edk2] patch.
/Pete
On 2020.03.27 13:01, Pete Batard wrote:
ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing
2 of the 3 reserved bytes that are defined at the
On 27/03/2020 14:26, Laszlo Ersek wrote:
On 03/25/20 17:10, Liran Alon wrote:
+/**
+ Returns if PVSCSI request ring is full
+**/
+STATIC
+BOOLEAN
+PvScsiIsReqRingFull (
+ IN CONST PVSCSI_DEV *Dev
+ )
+{
+ PVSCSI_RINGS_STATE *RingsState;
+ UINT32 ReqNumEntries;
+
+
ACPI 6.3 added a 16-bit SPE overflow Interrupt field, replacing
2 of the 3 reserved bytes that are defined at the end of the
GICC structure for 6.0.
Add a new macro to initialise the new field.
Signed-off-by: Pete Batard
---
EmbeddedPkg/Include/Library/AcpiLib.h | 8
1 file changed, 8
On 03/25/20 19:18, Bret Barkelew wrote:
> Should it though? It seems like it should go the opposite way.
> ArmVirt->Ovmf and ArmVirt->Bhyve. Which one is the more core package?
> By naming it would *seem* that ArmVirt is more core, but maybe I’m
> wrong.
OvmfPkg is the more core package.
Thanks
On 03/25/20 18:13, Liran Alon wrote:
>
> On 25/03/2020 18:40, Liran Alon wrote:
>>
>> On 25/03/2020 18:31, Laszlo Ersek wrote:
>>> On 03/25/20 02:11, Liran Alon wrote:
To avoid further style comments, what is the coding convention in EDK2
to align the "PVSCSI_CMD_DESC_SETUP_RINGS Cmd;"
Do you need to change (c) date to 2020?
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56488): https://edk2.groups.io/g/devel/message/56488
Mute This Topic: https://groups.io/mt/61916653/21656
Group Owner: devel+ow...@edk2.groups.io
Reviewed by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56487): https://edk2.groups.io/g/devel/message/56487
Mute This Topic: https://groups.io/mt/32999780/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56486): https://edk2.groups.io/g/devel/message/56486
Mute This Topic: https://groups.io/mt/32999793/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Reviewed by: Alexei Fedorov
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#56485): https://edk2.groups.io/g/devel/message/56485
Mute This Topic: https://groups.io/mt/32999782/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
On 03/25/20 17:10, Liran Alon wrote:
> Implement EXT_SCSI_PASS_THRU.PassThru().
>
> Machines should be able to boot after this commit.
> Tested with Ubuntu 16.04 guest.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2567
> Signed-off-by: Liran Alon
> ---
> OvmfPkg/OvmfPkg.dec
Hello,
Requesting to merge this into edk2-stable202005 for the reasons explained in
BZ[1]. I assume there is no real objection for this, only the approach we make
such changes in the future, but this can be postponed as we encounter more of
such problems.
Best regards,
Vitaly
[1]
From: Vitaly Cheptsov
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628
Requesting for merge in edk2-stable202005.
CC: Liming Gao
CC: Marvin Häuser
CC: Zhiguang Liu
Vitaly Cheptsov (1):
BaseTools: Use SEH exceptions in CLANGPDB for IA32
BaseTools/Conf/tools_def.template | 14
From: Vitaly Cheptsov
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2628
This patch reduces the size of IA32 binaries by ensuring that
no .debug_frame / .eh_frame sections are generated through forcing
SEH exception model, which is already the default in clang for X64.
EDK II does not
There's no real reason to have the PPTT constants factorized in
AcpiTables.h, and hiding them away with the interrupts is only
going to end up being counter-productive for folks trying to
understand or maintain the code.
Move these sections to Pptt.aslc where they belong.
Signed-off-by: Pete
Reviewed-by: Xiaoyu Lu
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> GuoMinJ
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Wang, Jian J
> ; Lu, XiaoyuX
> Subject: [edk2-devel] [PATCH v2 1/2]
Reviewed-by: Xiaoyu Lu
> -Original Message-
> From: GuoMinJ [mailto:newexplor...@gmail.com]
> Sent: Thursday, March 5, 2020 2:41 PM
> To: devel@edk2.groups.io
> Cc: GuoMinJ ; Wang, Jian J
> ; Lu, XiaoyuX
> Subject: [PATCH v2 2/2] CryptoPkg/BaseHashApiLib: Rename BaseHashApiLib
> by
Jiewen,
comments below.
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yao, Jiewen
> Sent: Friday, March 27, 2020 2:16 PM
> To: Fu, Siyuan ; devel@edk2.groups.io; Gao, Zhichao
>
> Cc: Wang, Jian J ; Lu, XiaoyuX ;
> Maciej Rabeda
> ; Wu, Jiaxin
> Subject: Re:
On Fri, 27 Mar 2020 at 02:02, Bret Barkelew wrote:
>
> Reviewed-by: Bret Barkelew
>
Thanks Bret
Does this apply only to this 3rd patch? Or to the whole series?
>
>
>
> From: Ard Biesheuvel
> Sent: Thursday, March 26, 2020 3:24:42 AM
> To:
Library is static interface. Protocol is dynamic interface. That is key
difference.
My understanding for a *private protocol* is that: one module in the package to
produce. The other module in the same packet to consume. Both are at runtime.
That brings zero impact to other module.
It is not
Jiewen,
In my opinion it's NOT a provide protocol, although it's placed in the private
include folder.
The intention of this protocol, the crypto DXE driver who produces it, and the
set of PEI/Runtime/SMM BaseCryptoLib instances who consume it, is to
support the modulization update of crypto
49 matches
Mail list logo
