Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Friday, April 17, 2020 10:18 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v2 2/6] EdkRepo:
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Friday, April 17, 2020 10:18 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v2 5/6] EdkRepo:
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Friday, April 17, 2020 10:18 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v2 6/6] EdkRepo:
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Friday, April 17, 2020 10:18 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v2 4/6] EdkRepo:
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Friday, April 17, 2020 10:18 AM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH v2 3/6] EdkRepo:
On 4/17/20 2:55 AM, Laszlo Ersek wrote:
However, this library has hugely bit-rotted, and it needs some serious
scrubbing before we can do that. Let me look into a patch series for
that. I'll continue to review of this series after that. I hope that
works for you.
Yes, that works - especially
Reviewed-by: Sean Brogan
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#57545): https://edk2.groups.io/g/devel/message/57545
Mute This Topic: https://groups.io/mt/72907803/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe:
Zhichao,
This is correct. I did not notice the message previously, but otherwise
everything outlined here is accurate. Let me know if further input can be
performed from my side for this to land.
Best regards,
Vitaly
> 2 апр. 2020 г., в 11:28, Gao, Zhichao написал(а):
>
> Summarize the
This version amends patch 4/6 to use Erik's feeback
regardling list comprehensions. All other patches are
unchanged.
This patch set adds the initial support for consuming
multiple manifest repositories to the BaseConfig, GlobalConfig
and GlobalUserConfig classes defined in
Move the edkrepo_global_data_directory from the
GlobalConfig class to the base config class.
Updated the assignments of self.filename in both
the GlobalConfig and the GlobalUserConfig classes
as well as the initializaion of the BaseConfig
class to use get_edkrepo_global_data_directory()
Add support for the following cfg format to the
BaseConfig class enabling it to be consumed by
both the Global and User configuration file
classes. CfgProps for each listed manifest repository
will be dynamically added to the classes prop_list.
Configuration Example:
[Manifest_A]
...
Added functions to get the URL, LocalPath, Branch
and the absolute path for individual manifest
repositories to the BaseConfig class.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo/config/config_factory.py
Add manifest-repos and edk2-staging sections
to the edkrepo.cfg to enable support of multiple
manifest repositories.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo_installer/Vendor/edkrepo.cfg | 8
Add the manifest_repo_list property to the BaseConfig class
to return a list of manfiest repo sections in the config file.
Signed-off-by: Ashley E Desimone
Cc: Nate DeSimone
Cc: Puja Pandya
Cc: Erik Bjorge
Cc: Bret Barkelew
Cc: Prince Agyeman
---
edkrepo/config/config_factory.py | 6 ++
I am going to go with it was a long day. I will send out an updated patch set
for review taking your feedback into account.
Thanks,
Ashley
-Original Message-
From: Bjorge, Erik C
Sent: Friday, April 17, 2020 8:09 AM
To: Desimone, Ashley E ; devel@edk2.groups.io
Cc: Desimone, Nathaniel
On 04/16/20 01:09, Rebecca Cran wrote:
> Add a null implementation of QemuFwCfgS3Lib, for bhyve.
>
> Signed-off-by: Rebecca Cran
> ---
> .../PeiQemuFwCfgS3LibFwCfgNull.inf| 39
> .../QemuFwCfgS3BasePeiNull.c | 221 ++
>
On 04/16/20 01:09, Rebecca Cran wrote:
> Add a null PEI implementation of QemuFwCfgLib for bhyve.
>
> Signed-off-by: Rebecca Cran
> ---
> .../QemuFwCfgLibNull/QemuFwCfgPeiLibNull.inf | 36 ++
> .../QemuFwCfgLibNull/QemuFwCfgPeiNull.c | 107 ++
> 2 files changed, 143
On 04/16/20 01:09, Rebecca Cran wrote:
> bhyve uses the older VESA BIOS Extensions 2.0, so add the mode info
> structure to IndustryStandard/LegacyVgaBios.h
>
> Signed-off-by: Rebecca Cran
> ---
> .../Include/IndustryStandard/LegacyVgaBios.h | 39 +++
> 1 file changed, 39
Hi,
On 04/16/20 01:09, Rebecca Cran wrote:
> Add a null implementation library fof QemuFwCfgS3Lib, to support bhyve.
>
> Signed-off-by: Rebecca Cran
> ---
> .../DxeQemuFwCfgS3LibFwCfgNull.inf| 32 ++
> .../QemuFwCfgS3LibNull/QemuFwCfgS3DxeNull.c | 307 ++
>
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
The BaseResetSystemLib instance is not suitable for OS runtime, because
its ResetShutdown() implementation calls PciRead16 (OVMF_HOSTBRIDGE_DID).
On q35, this boils down to a memory-mapped config space access -- but we
never ask the OS to map MMCONFIG for
On 4/17/20 5:59 PM, Ard Biesheuvel wrote:
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Repo: https://pagure.io/lersek/edk2.git
Branch: rsl_cleanup
Rebecca's
[PATCH 02/13] OvmfPkg: support powering off bhyve guests
at
Hi Chang,
For any and all of your future patches, "Signed-off" should contain your
name + email and maintainer should be in Cc :)
Reviewed-by: Maciej Rabeda
Thanks,
Maciej
On 17-Apr-20 04:38, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: Keysound Chang
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Move the ResetShutdown() definition to its own file. This will help us
introduce:
- a new library instance that is not broken in runtime modules (the
current library instance is broken in runtime modules),
- another new library instance for bhyve
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
The cases under ResetSystem() currently mix "break"s with "return"s for no
good reason. Use "break" consistently.
(The inconsistency was introduced in commit 84c0b80de716,
"OvmfPkg/ResetSystemLib: Add new API ResetSystem", 2019-04-28.)
Cc: Ard Biesheuvel
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Annotate the #include directives with the interfaces that this lib
instance needs from the included lib class headers. This will help us keep
the #include set minimal, when we move code around later.
While at it, synchronize the [LibraryClasses] section
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Wrap the source code and the INF file at 79 characters.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
On 4/17/20 5:37 PM, Laszlo Ersek wrote:
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Repo: https://pagure.io/lersek/edk2.git
Branch: rsl_cleanup
Rebecca's
[PATCH 02/13] OvmfPkg: support powering off bhyve guests
at
https://edk2.groups.io/g/devel/message/57450
Reviewed-by: Maciej Rabeda
On 17-Apr-20 04:51, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: 2020年4月9日 11:02
To: devel@edk2.groups.io
Cc: Fu, Siyuan ; Maciej Rabeda
; Wu, Jiaxin
Subject: [edk2-devel]
Reviewed-by: Maciej Rabeda
On 09-Apr-20 10:22, Siyuan, Fu wrote:
Reviewed-by: Siyuan Fu
-Original Message-
From: michael.kuba...@outlook.com
Sent: 2020年4月8日 13:47
To: devel@edk2.groups.io
Cc: Fu, Siyuan ; Maciej Rabeda
; Wu, Jiaxin
Subject: [PATCH v1 1/1] NetworkPkg/Ip6Dxe:
Wrap the source code and the INF file at 79 characters.
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe Mathieu-Daudé
Cc: Rebecca Cran
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Signed-off-by: Laszlo Ersek
---
OvmfPkg/Library/ResetSystemLib/ResetSystemLib.inf | 3 ++-
The cases under ResetSystem() currently mix "break"s with "return"s for no
good reason. Use "break" consistently.
(The inconsistency was introduced in commit 84c0b80de716,
"OvmfPkg/ResetSystemLib: Add new API ResetSystem", 2019-04-28.)
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: Philippe
In preparation for introducing DxeResetSystemLib, rename the current
(only) ResetSystemLib instance to BaseResetSystemLib.
In the DSC files, keep the ResetSystemLib resolution in the same
[LibraryClasses] section, but move it near the TimerLib resolution, as the
differences between the
The BaseResetSystemLib instance is not suitable for OS runtime, because
its ResetShutdown() implementation calls PciRead16 (OVMF_HOSTBRIDGE_DID).
On q35, this boils down to a memory-mapped config space access -- but we
never ask the OS to map MMCONFIG for runtime.
There are at least three
Move the ResetShutdown() definition to its own file. This will help us
introduce:
- a new library instance that is not broken in runtime modules (the
current library instance is broken in runtime modules),
- another new library instance for bhyve support.
While at it, squash AcpiPmControl()
Ref:https://bugzilla.tianocore.org/show_bug.cgi?id=2675
Repo: https://pagure.io/lersek/edk2.git
Branch: rsl_cleanup
Rebecca's
[PATCH 02/13] OvmfPkg: support powering off bhyve guests
at
https://edk2.groups.io/g/devel/message/57450
Annotate the #include directives with the interfaces that this lib
instance needs from the included lib class headers. This will help us keep
the #include set minimal, when we move code around later.
While at it, synchronize the [LibraryClasses] section with the #include
directives -- list
On 4/17/20 1:55 AM, Laszlo Ersek wrote:
Indeed I can't apply these patches with git-am, without some manual
hacking. Lines in the patches are terminated with .
Please run "BaseTools/Scripts/SetupGit.py" in your edk2 clone.
Ugh, sorry I thought I'd fixed that. I'll fix my editors and send
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH 6/6] EdkRepo: Add
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH 3/6] EdkRepo: Add
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH 1/6] EdkRepo:
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH 5/6] EdkRepo: Move
Why is this not a list comprehension?
return [x for x in self.prop_list if manifest_repo in x.name]
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ;
Reviewed-by: Erik Bjorge
-Original Message-
From: Desimone, Ashley E
Sent: Thursday, April 16, 2020 8:31 PM
To: devel@edk2.groups.io
Cc: Desimone, Nathaniel L ; Pandya, Puja
; Bjorge, Erik C ; Bret
Barkelew ; Agyeman, Prince
Subject: [edk2-staging/EdkRepo] [PATCH 2/6] EdkRepo: Add
Gaurav,
You sent to the old list. Adding the new edk2-devel list
>
> > -Original Message-
> > From: Gaurav Jain
> > Sent: Friday, April 17, 2020 2:55 AM
> > To: edk2-de...@lists.01.org
> > Cc: Eric Jin ; Supreeth Venkatesh
> > ; Samer El-Haj-Mahmoud > mahm...@arm.com>; Prasanth Pulla
Pushed: 944af47a8c83115dcd5dae581e5c3770a12a2ed2
Thanks,
Chasel
> -Original Message-
> From: Chaganty, Rangasai V
> Sent: Friday, April 17, 2020 4:11 PM
> To: Kumar, Chandana C ;
> devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
>
> Subject: RE: [edk2-platforms:
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Lendacky, Thomas
> Sent: Thursday, April 16, 2020 9:47 PM
> To: devel@edk2.groups.io; Dong, Eric
> Cc: Justen, Jordan L ; Laszlo Ersek
> ; Ard Biesheuvel ; Kinney,
> Michael D ; Gao, Liming
>
On 04/16/20 01:09, Rebecca Cran wrote:
> Update ResetSystemLib to support powering off bhyve guests instead of
> having them enter the CpuDeadLoop.
>
> On bhyve, the Power Management 1 Control Register is located at 0x404;
> a write with SLP_TYP set to 5 will power off the guest.
>
>
Hi, Experts:
There is a TimeLib implementation in
UefiCpuPkg\Library\SecPeiDxeTimerLibUefiCpu .
It uses cpu's local apic timer.
I wonder whether it could be used in smm drivers?
If using MicroSecondDelay function (which provided in this timerlib), maybe we
should save OS's CPU local apic timer
On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556
>
> This patch uses CPUID signature check to skip reading the PlatformId MSR,
> which is not implemented on AMD processors.
>
> The PlatformId is used for loading microcode
On Tue, 14 Apr 2020 at 09:01, Jiang, Guomin wrote:
>
> Summarize current status:
>
> Problem Statement:
> Openssl require _fltused to be defined as a constant anywhere floating point
> is used.
> It may use float out of edk2 tree and need _fltused, for example, Microsoft’s
> OnScreenKeyboard
Reviewed-by: Sai Chaganty
-Original Message-
From: Kumar, Chandana C
Sent: Wednesday, April 15, 2020 1:31 AM
To: devel@edk2.groups.io
Cc: Chaganty, Rangasai V ; Chiu, Chasel
; Desimone, Nathaniel L
Subject: [edk2-platforms: PATCH] MinPlatformPkg/PlatformInitPei: Create Library
On 04/16/20 01:09, Rebecca Cran wrote:
> On bhyve, the ACPI timer is located at a fixed IO address; it need
> not be programmed into, nor fetched from, the PMBA -- power
> management base address -- register of the PCI host bridge.
>
> Signed-off-by: Rebecca Cran
> ---
>
On 04/16/20 22:47, Laszlo Ersek wrote:
> (5) Please make sure that the new files use CRLF line terminators
> consistently.
Indeed I can't apply these patches with git-am, without some manual
hacking. Lines in the patches are terminated with .
Please run "BaseTools/Scripts/SetupGit.py" in your
Correct the extract function help message
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yunhua Feng
---
BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
Reviewed-by: Shenglei Zhang
> -Original Message-
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael Kubacki
> Sent: Thursday, April 9, 2020 2:13 AM
> To: devel@edk2.groups.io
> Cc: Andrew Fish ; Ard Biesheuvel
> ; Bret Barkelew
> ; Justen, Jordan L
> ;
For the patch set:
Reviewed-by: Zhichao Gao
Thanks,
Zhichao
> -Original Message-
> From: Krzysztof Koch
> Sent: Tuesday, April 14, 2020 4:50 PM
> To: devel@edk2.groups.io; Ni, Ray ; Gao, Zhichao
>
> Cc: Sami Mujawar ; Matteo Carlini
> ; Laura Moretta ; nd
>
> Subject: RE:
On 4/17/20 12:46 AM, Rebecca Cran wrote:
I'm running into a problem with Ecc against any code: I'm using Ubuntu
19.10, and have copied the output of running it against MdePkg at the
end of this email. Does Ecc work with Python 3, or does it still need
Python 2?
Of course, this was the
Hi Laszlo,
I've removed comments from you that I won't have any difficulty with
implementing.
(1) Please try to run the BhyvePkg code through the ECC tool, and see if
ECC is OK with the coding style. (In some cases ECC is *way* too strict
in my opinion, so please use common sense, and/or
58 matches
Mail list logo
