Re: 回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

2021-02-17 Thread Sami Mujawar
Hi Liming, We are working to get EDK2 Open CI enabled for ArmPkg and ArmPlatformPkg. We are doing some initial cleanup before the CI is enabled. Regards, Sami Mujawar From: devel@edk2.groups.io on behalf of Rebecca Cran via groups.io Sent: Thursday, 18

回复: [edk2-devel] 回复: [edk2-devel] 回复: [PATCH v1 1/1] BaseTools: Align include guards policy

2021-02-17 Thread gaoliming
Pierre: I agree to add this checker in ECC tool first. Then, we can start to discuss the topic about the code clean up on the early phase of next stable tag. Thanks Liming 发件人: bounce+27952+71690+4905953+8761...@groups.io 代表 PierreGondois 发送时间: 2021年2月16日 6:03 收件人: gaoliming ;

回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread gaoliming
I am OK to add this checker in ECC. Reviewed-by: Liming Gao > -邮件原件- > 发件人: bounce+27952+71693+4905953+8761...@groups.io > 代表 PierreGondois > 发送时间: 2021年2月16日 17:29 > 收件人: devel@edk2.groups.io; bob.c.f...@intel.com; > gaolim...@byosoft.com.cn; rebe...@nuviainc.com; >

回复: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread gaoliming
Yuwei: There are some discussion in https://edk2.groups.io/g/devel/message/70772 Thanks Liming > -邮件原件- > 发件人: bounce+27952+71757+4905953+8761...@groups.io > 代表 Yuwei Chen > 发送时间: 2021年2月18日 8:39 > 收件人: devel@edk2.groups.io; pierre.gond...@arm.com; Feng, Bob C > ;

Re: [edk2-devel] [PATCH v1 01/10] Silicon/Phytium: Added PlatformLib to FT2000/4

2021-02-17 Thread 贾玲
Hi Leif, Thank you for your reply. I'm glad to hear from you! I received a total of ten replies, and the contents of the reply seems to be quoted from the original. Is there any problems with our code submission? Please advise us what to do next. Thank you very much! Best Regards, Ling >

Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency

2021-02-17 Thread Bret Barkelew
I'm not opposed to moving to 2.15.03 for consistency, but we'll have to publish a new package. This one is already pushed to Nuget. On Wed, Feb 17, 2021 at 7:39 PM gaoliming wrote: > Laszlo: > > > -邮件原件- > > 发件人: bounce+27952+71686+4905953+8761...@groups.io > > 代表 Laszlo Ersek > >

[edk2-devel] [PATCH v2] RedfishPkg/JsonLib: Add JsonLoadString function

2021-02-17 Thread Abner Chang
Add JsonLoadString function to load a NULL terminated-string JSON Signed-off-by: Abner Chang Cc: Leif Lindholm Cc: Nickle Wang Cc: Michael D Kinney --- RedfishPkg/Include/Library/JsonLib.h | 21 + RedfishPkg/Library/JsonLib/JsonLib.c | 26 ++ 2

Re: 回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

2021-02-17 Thread Rebecca Cran
Liming, It was found via Linaro's CI environment, but not EDK2's. I'm planning to set up my own Jenkins server to run CI to catch problems like this before they're committed. It'll also let me test OvmfPkg/Bhyve builds too. -- Rebecca Cran On 2/17/21 8:33 PM, gaoliming wrote: Rebecca:

回复: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM dependency

2021-02-17 Thread gaoliming
Laszlo: > -邮件原件- > 发件人: bounce+27952+71686+4905953+8761...@groups.io > 代表 Laszlo Ersek > 发送时间: 2021年2月16日 5:00 > 收件人: devel@edk2.groups.io; b...@corthon.com > 主题: Re: [edk2-devel] [PATCH v1 1/1] BaseTools: Update the NASM > dependency > > Hi Bret, > > On 02/12/21 21:49, Bret Barkelew

回复: [edk2-devel] [PATCH v3 00/13] Add support for using FF-A calls

2021-02-17 Thread gaoliming
Sughosh: This is a new feature. Can you submit one BZ (https://bugzilla.tianocore.org/) to record it? Thanks Liming > -邮件原件- > 发件人: bounce+27952+70357+4905953+8761...@groups.io > 代表 Sughosh Ganu > 发送时间: 2021年1月15日 14:14 > 收件人: devel@edk2.groups.io > 抄送: Sami Mujawar ; Ard Biesheuvel >

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Ignore the build error of assignment within conditional expression

2021-02-17 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 12:20 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nickle (HPS SW) > ; Michael D Kinney > Subject: [PATCH] RedfishPkg/JsonLib:

回复: [edk2-devel] [PATCH 1/1] ArmPkg: Fix ARM ProcessorSubClassDxe build

2021-02-17 Thread gaoliming
Rebecca: Is this issue detected in open CI environment? Thanks Liming > -邮件原件- > 发件人: bounce+27952+71573+4905953+8761...@groups.io > 代表 Rebecca Cran > 发送时间: 2021年2月10日 23:05 > 收件人: devel@edk2.groups.io > 抄送: Rebecca Cran ; Leif Lindholm > ; Ard Biesheuvel > 主题: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident

2021-02-17 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 12:20 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nickle (HPS SW) > ; Michael D Kinney > Subject: [PATCH] RedfishPkg/JsonLib: Fix

回复: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

2021-02-17 Thread gaoliming
Patrick: I am OK for this extension to meet with Microsoft recommendation. This change is a new feature. Can you submit one BZ (https://bugzilla.tianocore.org/) for it? Thanks Liming > -邮件原件- > 发件人: bounce+27952+71716+4905953+8761...@groups.io > 代表 Patrick > Rudolph > 发送时间: 2021年2月17日

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-17 Thread Nickle Wang
Hi Abner, You many want to update the function description. It mentioned "UTF8 encoded string" but the input string type is CHAR8, not CHAR16. Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Monday, January 25, 2021 12:32 PM > To:

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-17 Thread Abner Chang
Hi Leif, Would you like to recheck the new patches I sent? Thanks Abner > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 1:11 PM > To: Leif Lindholm > Cc: devel@edk2.groups.io; Wang, Nickle (HPS SW) ; > Michael D Kinney > Subject: RE:

[edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

2021-02-17 Thread Li, Walon
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3135 When Boot Menu does not exist in the BootOrder, BmRegisterBootManagerMenu will create one into list. However, it should be put at the "end" of BootOrder instead of "start" of BootOrder. Replace 0 by -1 to adjust order of load options.

[edk2-devel] 回复: [PATCH v3 2/4] MdePkg/Nasm.inc: add macros for C types used in structure definition

2021-02-17 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Ray Ni > 发送时间: 2021年2月9日 22:17 > 收件人: devel@edk2.groups.io > 抄送: Michael D Kinney ; Liming Gao > ; Zhiguang Liu > 主题: [PATCH v3 2/4] MdePkg/Nasm.inc: add macros for C types used in > structure definition > > Signed-off-by: Ray Ni > Cc: Michael

回复: [edk2-devel] [Patch 1/1] BaseTools/ECC: Add antlr version check

2021-02-17 Thread gaoliming
Bob: Can you mention python version in the error message? So, the developer can know to install antlr for python 3 or python 2. Besides, this change is also required in BaseTools\BinPipWrappers scripts. Thanks Liming > -邮件原件- > 发件人: bounce+27952+71401+4905953+8761...@groups.io > 代表

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: Add more CRT functions

2021-02-17 Thread Abner Chang
Hi Leif, Have time to review the v2 which was revised according to your comments on v1. Thanks Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Abner Chang > Sent: Thursday, January 28, 2021 10:58 AM > To: devel@edk2.groups.io > Cc:

回复: [edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-17 Thread gaoliming
I suggest to directly change [FixedPcd] to [Pcd] section. All Pcds can support FixedAtBuild and PatchableInModule. With this change, Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: bounce+27952+71734+4905953+8761...@groups.io > 代表 Sughosh Ganu > 发送时间: 2021年2月17日 19:27 > 收件人:

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] TigerlakeOpenBoardPkg/TigerlakeURvp: Fix build errors with GCC5

2021-02-17 Thread Heng Luo
Hi Naito, Thank you for your patch to resolve the problem. Basically this patch looks good to me, some suggestions: 1. I have submitted a Bugzilla https://bugzilla.tianocore.org/show_bug.cgi?id=3224 for this issue, could you add it in your commit message?

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

2021-02-17 Thread Wu, Hao A
> -Original Message- > From: Laszlo Ersek > Sent: Wednesday, February 17, 2021 10:11 PM > To: Wang, Jian J ; Wu, Hao A ; > Ni, Ray > Cc: devel@edk2.groups.io; Bandaru, Purna Chandra Rao > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve > Error handling of Ufs

回复: [edk2-devel] 回复: [PATCH] BaseTools: Fix BrotliCompress run issue on Linux

2021-02-17 Thread gaoliming
Yunhua: Please also fix it in edk2\BaseTools\BinPipWrappers\PosixLike\BrotliCompress. Thanks Liming > -邮件原件- > 发件人: bounce+27952+71273+4905953+8761...@groups.io > 代表 gaoliming > 发送时间: 2021年2月5日 9:13 > 收件人: 'Yunhua Feng' ; > devel@edk2.groups.io > 抄送: 'Bob Feng' ; 'Yuwei Chen' > > 主题:

回复: [edk2-devel] [Wiki V2] Add update notes for incomaptible patches that fix typos in SmBios.h

2021-02-17 Thread gaoliming
Reviewed-by: Liming Gao The change has been merged into edk2 wiki. Thanks Liming > -邮件原件- > 发件人: bounce+27952+71098+4905953+8761...@groups.io > 代表 Zhiguang Liu > 发送时间: 2021年2月3日 16:18 > 收件人: devel@edk2.groups.io > 抄送: Liming Gao > 主题: [edk2-devel] [Wiki V2] Add update notes for

Re: [edk2-devel] [PATCH v2 1/1] BaseTools: Align include guards policy

2021-02-17 Thread Yuwei Chen
Hi Pierre, There seems already have a Bugzilla link for this issue: https://bugzilla.tianocore.org/show_bug.cgi?id=3094 And a personally concern: Some of the current codes still use "_***_H_", such as " __PEI_APRIORI_FILE_NAME_H__ ". If the ECC check only support the coding standard you

[edk2-devel] [PATCH v3 5/5] UefiCpuPkg/SmmCpuFeaturesLib: Add Standalone MM support

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3218 Adds an INF for StandaloneMmCpuFeaturesLib, which supports building the SmmCpuFeaturesLib code for Standalone MM. Minimal code changes are made to allow reuse of existing code for Standalone MM. The original INF file

[edk2-devel] [PATCH v3 4/5] UefiCpuPkg/SmmCpuFeaturesLib: Abstract PcdCpuMaxLogicalProcessorNumber

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3218 Adds a new function called GetCpuMaxLogicalProcessorNumber() to return the number of maximum CPU logical processors (currently gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber). This allows the the mechanism

[edk2-devel] [PATCH v3 3/5] UefiCpuPkg/SmmCpuFeaturesLib: Cleanup library constructors

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki There's currently two library instances: 1. SmmCpuFeaturesLib 2. SmmCpuFeaturesLibStm There's two constructor functions: 1. SmmCpuFeaturesLibConstructor() 2. SmmCpuFeaturesLibStmConstructor() SmmCpuFeaturesLibConstructor() is called by

[edk2-devel] [PATCH v3 2/5] UefiCpuPkg/SmmCpuFeaturesLib: Rename SmmCpuFeaturesLib.c

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki This change renames SmmCpuFeaturesLib.c to SmmCpuFeaturesLibCommon.c to better convey that this file contains library implementation common to all library instances. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Cc: Rahul Kumar Signed-off-by: Michael Kubacki ---

[edk2-devel] [PATCH v3 1/5] UefiCpuPkg/SmmCpuFeaturesLib: Move multi-instance function decl to header

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki FinishSmmCpuFeaturesInitializeProcessor() is a multi-instance internal library function that is currently not declared in a header file but embedded in "SmmCpuFeaturesLib.c". This change cleans up the declaration moving it to a new header file "CpuFeaturesLib.h" and

[edk2-devel] [PATCH v3 0/5] UefiCpuPkg/StandaloneMmCpuFeaturesLib: Add Standalone MM support

2021-02-17 Thread Michael Kubacki
From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3218 The present SmmCpuFeaturesLib implementation in UefiCpuPkg can be useful for IA32/X64 platforms that need a library instance for a Standalone MM environment. Much of the logic can be reused and a new INF can isolate

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-17 Thread Ard Biesheuvel
On Wed, 17 Feb 2021 at 18:16, Jeremy Linton wrote: > > Hi, > > On 2/17/21 1:55 AM, Ard Biesheuvel via groups.io wrote: > > On Wed, 17 Feb 2021 at 08:30, Jeremy Linton wrote: > >> > >> Hi, > >> > >> On 2/17/21 12:56 AM, Ard Biesheuvel wrote: > >>> On Wed, 17 Feb 2021 at 07:18, jlinton wrote: >

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-17 Thread Jeremy Linton
Hi, On 2/17/21 1:55 AM, Ard Biesheuvel via groups.io wrote: On Wed, 17 Feb 2021 at 08:30, Jeremy Linton wrote: Hi, On 2/17/21 12:56 AM, Ard Biesheuvel wrote: On Wed, 17 Feb 2021 at 07:18, jlinton wrote: From: Jeremy Linton The existing RPi3 ACPI entries for the Arasan and SDHCI

Re: [edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters

2021-02-17 Thread Thomas Abraham
Reviewed-by: Thomas Abraham -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71748): https://edk2.groups.io/g/devel/message/71748 Mute This Topic: https://groups.io/mt/80706889/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe:

[edk2-devel] [PATCH edk2-platforms v1 1/1] Platform/ARM/VExpressPkg: Remove non-ASCII characters

2021-02-17 Thread Sami Mujawar
The patch at "4be8625ab1b008057ae9a500aa8978be2a02d6e2 Platform/ARM/VExpressPkg: Add support for FVP RevC model" introduced a new file SsdtPci.asl. The file SsdtPci.asl had a few non-ASCII characters in the code comments. These resulted in the Trim utility generating a warning that caused the

Re: [EXTERNAL] Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2021-02-17 Thread Laszlo Ersek
On 02/17/21 13:18, Pete Batard wrote: > Hi Leif, > > Thanks for trying to resurrect this issue. > > At this stage, and despite some initial pushback in the bugzilla ticket, > I believe we can all agree with the consensus that UefiBootManagerLib is > not in fact specs-compliant and therefore

Re: [edk2-devel] [PATCH v2 4/4] UefiCpuPkg/SmmCpuFeaturesLib: Add Standalone MM support

2021-02-17 Thread Laszlo Ersek
On 02/16/21 21:11, Michael Kubacki wrote: > On 2/15/2021 12:33 PM, Laszlo Ersek wrote: >> On 02/13/21 01:58, mikub...@linux.microsoft.com wrote: >>> From: Michael Kubacki >>> >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3218 >>> >>> Adds an INF for StandaloneMmCpuFeaturesLib, which

Re: [edk2-devel] [PATCH] MdeModulePkg/UfsPassThruDxe: Improve Error handling of Ufs Pass Thru driver

2021-02-17 Thread Laszlo Ersek
Jian, Hao, Ray -- any feedback on this? Thanks Laszlo On 02/11/21 13:59, Purna Chandra Rao Bandaru wrote: > From: Bandaru > > https://bugzilla.tianocore.org/show_bug.cgi?id=3217 > > Following is the brief description of the changes > 1) There are cards that can take upto 600ms for Init and

[edk2-devel] [PATCH v3 1/4] Platform/RaspberryPi: Add Negative table check

2021-02-17 Thread jlinton
From: Jeremy Linton Turns out its helpful to have a !PcdToken flag that enables a DSDT/SSDT. That simplifies both the emmc2 SSDT (it only installs when !SdIsArasan) and later for the XHCI/PCIe switch where we want to install one of two tables depending on whether a single Pcd is set.

[edk2-devel] [PATCH v2] Platform/RaspberryPi: Only enable IORT when 3G limit is disabled.

2021-02-17 Thread jlinton
From: Jeremy Linton The 3G limit, and the 2G IORT are intended to solve the same linux problem. They limit PCI DMA operations to the first 3G of RAM. Older linux kernels, as used with RHEL/Centos, trigger an assertion* when a DMA operation starts at a range that doesn't fit within the 2G range

[edk2-devel] [PATCH v3 3/4] Platform/RaspberryPi: User control of eMMC2 DMA

2021-02-17 Thread jlinton
From: Jeremy Linton DMA translation on the eMMC2 vary based on SoC, and this is made worse by the poor _DMA support in Linux. For now the "safe" option is to simply run the eMMC2 controller in PIO mode. More advanced users or !Linux operating systems may choose to enable this to gain a perf

[edk2-devel] [PATCH v3 4/4] Platform/RaspberryPi: Invert default Arasan, eMMC2 routing

2021-02-17 Thread jlinton
From: Jeremy Linton In order for the WiFi to work, and the SD to run at full speed we need to bind the SD slot to the eMMC2 controller. Since we now have a driver for the eMMC2 controller there isn't any reason to leave the SD card bound to the older Arasan controller. Signed-off-by: Jeremy

[edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-17 Thread jlinton
From: Jeremy Linton The existing RPi3 ACPI entries for the Arasan and SDHCI controllers need updating to work with the RPi4. This is done by adding a caps override for the legacy Arasan controller and then adding an entirely new entry for the newer eMMC2 controller. Then we flip the default

[edk2-devel] [PATCH v3 2/4] Platform/RaspberryPi/Acpitables: Add eMMC2 device and tweak Arasan

2021-02-17 Thread jlinton
From: Jeremy Linton The primary problem with the RPi's Arasan controller is the lack of a meaningful capabilities register. With just a sdhci-caps _DSD entry we can provide that information. It can then be bound to the Linux sdhci_iproc driver which already hardcodes the remaining controller

Re: [EXTERNAL] Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2021-02-17 Thread Pete Batard
Hi Leif, Thanks for trying to resurrect this issue. At this stage, and despite some initial pushback in the bugzilla ticket, I believe we can all agree with the consensus that UefiBootManagerLib is not in fact specs-compliant and therefore needs to be fixed, one way or another, to make it

Re: [EXTERNAL] Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

2021-02-17 Thread Leif Lindholm
Hi Pete, +various Resurrecting this old thread since Ard pointed out an issue I ran into myself had already been encountered by Pete. And the bugzilla ticket (directly below this reply) has had no relevant progress since August. Executive summary: The current UefiBootManagerLib implementation of

[edk2-devel] [PATCH v4 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm

2021-02-17 Thread Sughosh Ganu
From: Ilias Apalodimas Allow passing of a request to StandaloneMm Core through the Firmware Framework(FF-A) using FFA_MSG_SEND_DIRECT_REQ method. This method is used as a mechanism for requesting some service from StandaloneMm. Signed-off-by: Ilias Apalodimas Signed-off-by: Sughosh Ganu

[edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-17 Thread Sughosh Ganu
From: Ilias Apalodimas Instead of running StMM in SPM, OP-TEE creates a new secure partition, which emulates SPM and isolates StMM from the rest of the Trusted Applications (TAs). We can then compile StMM as an FD image and run it in OP-TEE. With the addition of a new RPMB driver, we can

[edk2-devel] [PATCH v4 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add the FF-A header for invoking the mmu functions using FF-A calls as the transport mechanism. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V3: None

[edk2-devel] [PATCH v4 12/14] ArmPkg: Allow FF-A calls to set memory region's attributes

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Allow setting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V3: * Change the patch header to

[edk2-devel] [PATCH v4 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add support for reporting completion of a MM request using either the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V3: None

[edk2-devel] [PATCH v4 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Allow getting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu --- Changes since V3: * Change the patch header to have the ArmPkg prefix

[edk2-devel] [PATCH v4 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version

2021-02-17 Thread Sughosh Ganu
With the introduction of Firmware Framework(FF-A), a Secure Partition can get the SPM version either using FF-A calls or through the existing svc calls. Use a runtime check to use either of the two methods based on the Pcd feature flag value. Signed-off-by: Sughosh Ganu Co-developed-by: Achin

[edk2-devel] [PATCH v4 05/14] ArmPkg: Add macros for SPM version

2021-02-17 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros which can be used in the module for checking the SPM version compatibility. Signed-off-by: Sughosh Ganu --- Changes since V3: * Put the macro definitions for the SPM major and minor versions in a separate patch, as suggested by

[edk2-devel] [PATCH v4 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled

2021-02-17 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros with FF-A enabled, which can be used in the module for checking the SPM version compatibility. These SPM major and minor version numbers are mandated for having support for the Firmware Framework(FF-A) feature enabled. Signed-off-by:

[edk2-devel] [PATCH v4 06/14] StandaloneMmPkg: Use macros for SPM version check

2021-02-17 Thread Sughosh Ganu
Declare module wide variables for SPM major and minor versions to be used in checking the SPM version compatibility. Use the SPM major and minor version macros declared in the previous patch for the version check. Signed-off-by: Sughosh Ganu --- Changes since V3: * Separate out the declaration

[edk2-devel] [PATCH v4 04/14] ArmPkg: Introduce support for PcdFfaEnable

2021-02-17 Thread Sughosh Ganu
The Secure Partition(SP) can request services from the Secure Partition Manager Core(SPMC) either through FF-A calls or through the existing SVC calls. Add a feature flag Pcd for enabling the FF-A method -- when this is set to FALSE, the SP uses the existing SVC calls for making the requests.

[edk2-devel] [PATCH v4 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta Add the Firmware Framework(FF-A) header in the StandaloneMm entry point driver. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V3: None

[edk2-devel] [PATCH v4 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta The Arm SMC calling convention standard v1.2 allows 8 input and output parameter registers. The FF-A specification relies on this communication. This patch extends the number of output registers returned by ArmCallSvc() to match this convention. Signed-off-by: Achin Gupta

[edk2-devel] [PATCH v4 00/14] Add support for using FF-A calls

2021-02-17 Thread Sughosh Ganu
The following patch series adds support for using the Firmware Framework(FF-A) as a transport mechanism for requesting services from the Secure Partition Manager(SPM). This is done through a Pcd which can be used to enable the FF-A mechanism or to use the earlier used SVC calls. The patches have

[edk2-devel] [PATCH v4 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header

2021-02-17 Thread Sughosh Ganu
From: Achin Gupta This patch adds a rudimentary header file with defines for FF-A ABIs that will be used as the transport between S-EL0 and the SPM Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- Changes since V3: None

[edk2-devel] [edk2-platforms] [PATCH v3 3/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RD-V1-MC

2021-02-17 Thread Vijayenthiran Subramaniam
Add HMAT ACPI tables that is specific for RD-V1-MC quad-chip platform. The latencies mentioned in the table are hypothetical values and represents typical latency between four chips. These values are applicable only for RD-V1-MC quad-chip fixed virtual and should not be reused for other platforms.

[edk2-devel] [edk2-platforms] [PATCH v3 2/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RdN1EdgeX2

2021-02-17 Thread Vijayenthiran Subramaniam
Add HMAT table support for RD-N1-Edge dual-chip platform. The latencies mentioned in the table are hypothetical values and represents typical latency between two chips. These values are applicable only for RD-N1-Edge dual-chip fixed virtual and should not be reused for other platforms.

[edk2-devel] [edk2-platforms] [PATCH v3 1/3] Platform/ARM/SgiPkg: Add helper macros for HMAT table

2021-02-17 Thread Vijayenthiran Subramaniam
Add helper macros to create Memory Proximity Domain, System Locality Latency and Bandwidth Information, Memory Side Cache Information structures in the HMAT table. Signed-off-by: Vijayenthiran Subramaniam --- Platform/ARM/SgiPkg/Include/SgiAcpiHeader.h | 113 +++- 1 file

[edk2-devel] [edk2-platforms] [PATCH v3 0/3] Add HMAT tables for RD multi-chip platforms

2021-02-17 Thread Vijayenthiran Subramaniam
This patch series adds HMAT tables for Arm's Neoverse reference design multi-chip fixed virtual platforms. The first patch in the series adds helper macros to create HMAT table within SgiPkg and the rest two patches adds HMAT table for RD-N1-Edge-X2 and RD-V1-MC platforms respectively. Changes

[edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

2021-02-17 Thread Patrick Rudolph
From: Tim Crawford Use Microsoft's recommended positioning [1] for the boot logo. > We recommend that the logo is placed with its center at 38.2% from the > screen's top edge. This positioning is based on the golden ratio's > visual aesthetics and matches the Windows 10 design proportions.

Re: [edk2-devel] reg: RNG functions Usage in NetworkPkg

2021-02-17 Thread Sivaraman Nainar
Hello Maciej: We haven't met any issue with the current implementation. RNG Library functions are using Process Based Random Number generation. Some OEM's asking about the plan for the same support in NetworkPkg. -Siva From: Rabeda, Maciej [mailto:maciej.rab...@linux.intel.com] Sent: Tuesday,

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/3] Platform/ARM/SgiPkg: Add helper macros for HMAT table

2021-02-17 Thread Sami Mujawar
Hi Vijay, Please find my response inline marked [SAMI] Regards, Sami Mujawar From: Vijayenthiran Subramanian Sent: Wednesday, 17 February 2021, 9:15 am To: devel@edk2.groups.io; Sami Mujawar Cc: Vijayenthiran Subramaniam; jonathan.came...@huawei.com;

Re: [edk2-devel] [edk2-platforms] [PATCH v2 3/3] Platform/ARM/SgiPkg: Add HMAT ACPI table for RD-V1-MC

2021-02-17 Thread Vijayenthiran Subramaniam
Hi Sami, On Fri, Feb 12, 2021 at 5:28 PM Sami Mujawar wrote: > > Hi Vijay, > > This patch needs similar changes as patch 2/3. Ack. > > Regards, > > Sami Mujawar > > -Original Message- > From: Vijayenthiran Subramaniam > Sent: 03 February 2021 09:07 AM > To: devel@edk2.groups.io;

Re: [edk2-devel] [edk2-platforms] [PATCH v2 1/3] Platform/ARM/SgiPkg: Add helper macros for HMAT table

2021-02-17 Thread Vijayenthiran Subramaniam
Hi Sami, On Fri, Feb 12, 2021 at 5:28 PM Sami Mujawar wrote: > > Hi Vijay, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > -Original Message- > From: Vijayenthiran Subramaniam > Sent: 03 February 2021 09:07 AM > To: devel@edk2.groups.io;

[edk2-devel] [PATCH v3 2/2] Platform/NXP: Add OEM specific DSDT generator

2021-02-17 Thread Vikas Singh via groups.io
These changes add platform specific DSDT generator and Clk dsdt properties for LX2160ARDB. Signed-off-by: Vikas Singh --- Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c | 9 ++

[edk2-devel] [PATCH v3 1/2] Platform/NXP: Add Dynamic Acpi for layerscape platforms

2021-02-17 Thread Vikas Singh via groups.io
These changes intend to add Common Configuration Manager (CM) for all fsl platforms and Platform headers consumed by CM for LX2160ARDB. Signed-off-by: Vikas Singh --- Platform/NXP/ConfigurationManagerPkg/ConfigurationManagerDxe/ConfigurationManager.c | 834

[edk2-devel] [PATCH v3 0/2] Dynamic ACPI framework for fsl layerscape platforms

2021-02-17 Thread Vikas Singh via groups.io
This patch series sets the foundation of Dynamic ACPI framework for all fsl layerscape platforms. In order to achieve: - Configurable firmware builds. - Unify firmware build for similar platforms. - Minimize/eliminate human induced errors. - Validate and generate firmware that complies

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-17 Thread Ard Biesheuvel
On Wed, 17 Feb 2021 at 08:59, Andrei Warkentin wrote: > > I'm not sure I truly follow the conversation you're having (sorry), but I'll > raise my hand as a _DMA user. I'm not that married to it, but I haven't added > support for the alternate IORT-based DMA range clamping. If long term we want