Hi Sean,
Here is the proposed fix to PatchCheck.py to not flag a Mergify merge commit as
an error:
https://github.com/tianocore/edk2-codereview/commit/1b264739387ae940b42d70b5cd25b7c68ed21318
I have re-enabled PatchCheck in GitHub branch protection rules, and I did 2 PRs
at same time and
On 6/16/21 10:10 PM, Ard Biesheuvel wrote:
> On Wed, 16 Jun 2021 at 07:30, Omkar Kulkarni wrote:
>>
>>
>> On 6/10/21 6:44 AM, Ming Huang via groups.io wrote:
>>> On 6/9/21 3:10 PM, Ard Biesheuvel wrote:
On Tue, 8 Jun 2021 at 16:21, Ming Huang
>>> wrote:
>
> TF-A:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates the code to identify flash regions by GUID and internally
map the GUID entries to values specific to KabylakeSiliconPkg.
Cc: Chasel Chiu
Cc: Rangasai V Chaganty
Cc: Nate DeSimone
Signed-off-by: Michael
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates the SPI protocol to identify flash regions by GUID instead
of fixed values defined in an enum. Packages consuming
IntelSiliconPkg are able to associate a given GUID with their chosen
values based on their SPI
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
This change identifies flash regions by GUID instead of fixed values
since the flash region identifiers are now defined in IntelSiliconPkg
and different boards may want to associate a flash region identifier
with a
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates the library to identify flash regions by GUID and internally
map the GUID entries to values specific to CoffeelakeSiliconPkg.
Cc: Chasel Chiu
Cc: Rangasai V Chaganty
Cc: Nate DeSimone
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
gEfiSmmSpiProtocolGuid is now declared in IntelSiliconPkg.dec. This
change updates Ich10Pkg to remove the protocol declaration in the
package and update libraries and modules to use the protocol from
IntelSiliconPkg.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The following PPI and Protocols have moved to IntelSiliconPkg. The
remaining definitions in KabylakeSiliconPkg are removed and libs
modules that need to reference IntelSiliconPkg are updated.
1. gPchSpiProtocolGuid
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The following PPI and Protocols have moved to IntelSiliconPkg. The
remaining definitions in CoffeelakeSiliconPkg are removed and libs/
modules that need to reference IntelSiliconPkg are updated.
1.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The following PPI and Protocols have moved to IntelSiliconPkg. The
remaining definitions in TigerlakeSiliconPkg are removed and libs/
modules that need to reference IntelSiliconPkg are updated.
1. gPchSpiProtocolGuid
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
This library now uses gPchSpiPpiGuid from IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
Reviewed-by: Chasel Chiu
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The library has been consolidated with instances in other Intel
silicon packages as a single instance in IntelSiliconPkg
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The library instance has moved to IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
Reviewed-by: Chasel Chiu
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The library has been consolidated with instances in other Intel
silicon packages as a single instance in IntelSiliconPkg
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The library has been consolidated with instances in other Intel
silicon packages as a single instance in IntelSiliconPkg
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Michael Kubacki
Reviewed-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates WhiskeylakeOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
The library has been consolidated with instances in other Intel
silicon packages as a single instance in IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Chasel Chiu
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
SpiFvbServiceSmm and SpiFvbServiceStandaloneMm have moved to
IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates SimicsOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
Reviewed-by: Nate
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates TigerlakeOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Michael
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates KabylakeOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Jeremy Soller
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates CometlakeOpenBoardPkg to use the SmmSpiFlashCommonLib
instance in IntelSiliconPkg and the SpiFvbServiceSmm driver in
IntelSiliconPkg.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Removes the PCDs from SiPkg.dec since they are defined in
IntelSiliconPkg.dec.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Chasel Chiu
Cc: Sai Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
The previous PCDs are removed from CoffeelakeSiliconPkg.dec.
Cc: Chasel Chiu
Cc: Sai Chaganty
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
The previous PCDs are removed from Ich10Pkg.dec.
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Chasel Chiu
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Sai Chaganty
Cc: Nate DeSimone
Cc: Heng Luo
Signed-off-by: Michael Kubacki
Reviewed-by: Nate
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Agyeman Prince
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Updates PCDs to use the IntelSiliconPkg PCD tokenspace now that the
PCDs are declared in IntelSiliconPkg.dec.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Jeremy Soller
Signed-off-by: Michael Kubacki
Reviewed-by: Nate
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Adds a Traditional MM and Standalone MM SPI FVB Service driver to
IntelSiliconPkg. These drivers produce the firmware volume block
protocol for SPI flash devices compliant with the Intel Serial
Flash Interface
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Adds the SpiFlashCommonLib interface to IntelSiliconPkg. The initial
library instance added in this change is the NULL instance.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Nate
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
These SPI Protocol definitions are intended to serve as the single
definitions for Intel platform and silicon packages.
1. gPchSpiProtocolGuid
2. gPchSmmSpiProtocolGuid
Cc: Ray Ni
Cc: Rangasai V Chaganty
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Adds the SMM instance of SpiFlashCommonLib. The code is based on
refactoring existing library instances into a consolidated version
with no functional impact.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
This SPI PPI definition is intended to serve as the single
definition for Intel platform and silicon packages.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Adds the following PCDs to IntelSiliconPkg.dec to consolidate the
PCD to a single silicon declaration file. This allows libraries
modules in IntelSiliconPkg to be able to use this PCD.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Adds the following PCDs to IntelSiliconPkg.dec to consolidate the
PCD to a single silicon declaration file. This allows libraries
and modules in IntelSiliconPkg to be able to use this PCD.
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Removes extra IntelSiliconPkg.dec entry in PeiPolicyUpdateLib.inf.
Cc: Ray Ni
Cc: Rangasai V Chaganty
Signed-off-by: Michael Kubacki
Reviewed-by: Nate DeSimone
---
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
gEfiMemoryTypeInformationGuid is used in PeiSaPolicyUpdatePreMem.c
but not in the [Guids] section in PeiPolicyUpdateLib.inf.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
Removes extra IntelSiliconPkg.dec entry in PeiPolicyUpdateLib.inf.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Rangasai V Chaganty
Cc: Deepika Kethi Reddy
Cc: Kathappan Esakkithevar
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3307
SpiFlashCommonLib is duplicated in multiple places across the MinPlatform
design in edk2-platforms. I'm planning to build some additional
functionality on top of SpiFlashCommonLib and, ideally, this duplication
will
Manic:
The patch content is good. But, the commit message misses Signed-off-by:
Contributor Name
And, please run BaseTools\Scripts\PatchCheck.py to check the commit message
format.
Thanks
Liming
> -邮件原件-
> 发件人: Manickavasakam Karpagavinayagam
> 发送时间: 2021年6月18日 1:42
> 收件人:
Ken:
This version looks good to me. If no other comment is got, I will merge
it.
Thanks
Liming
> -邮件原件-
> 发件人: kenlautn...@gmail.com
> 发送时间: 2021年6月18日 0:07
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang ; Hao A Wu
> ; Zhichao Gao ; Ray Ni
> ; Liming Gao
> 主题: [PATCH v1 1/1]
Sami:
I agree this change. With this patch, will you update the existing
platform to use the matched version macro EFI_ACPI_IO_REMAPPING_TABLE_REV0?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Sami
> Mujawar
> 发送时间: 2021年6月17日 17:55
> 收件人: devel@edk2.groups.io
> 抄送: Sami
MinPlatformPkg maintainers, can we please get this in soon if there are
no concerns?
Thanks,
Michael
On 6/7/2021 10:30 AM, Michael Kubacki wrote:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3033
Adds several libraries and modules to the MinPlatformPkg build
MinPlatformPkg maintainers, can we please get this in soon if there's no
concern?
Thanks,
Michael
On 6/15/2021 8:41 PM, Yao, Jiewen wrote:
Thank you, Michael.
Acked-by: Jiewen Yao
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael
Kubacki
Sent: Wednesday, June
Thanks
Reviewed-by: Sean Brogan
On 6/14/2021 11:34 AM, Kun Qin wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3445
Per update from Cspell tool, the minimal requirement of Cspell 5.x
regarding Node is 12 and above. This has caused multple Cspell failures
during CI build
Link to Mergify queue feature documentation
https://docs.mergify.io/actions/queue/#merge-queue-problem
Mike
> -Original Message-
> From: Kinney, Michael D
> Sent: Thursday, June 17, 2021 2:53 PM
> To: devel@edk2.groups.io; spbro...@outlook.com; a...@kernel.org; Kinney,
> Michael D
Hi Sean,
Mergify had added a queue feature to handle the rebases automatically and make
sure
CI passes in the order that the PRs are being applied to the base branch.
I have setup the edk2-codereview repo with a smaller set of CI tests to skip the
compiles to provide a way to experiment with
I wonder, should we add a .vscode directory in the edk2 repo and add the
recommended extensions to an extensions.json file (See Workspace
Recommended Extensions in
https://code.visualstudio.com/docs/editor/extension-marketplace)?
--
Rebecca Cran
On 6/17/21 12:39 AM, Nate DeSimone wrote:
Hi Sami,
The include guard pattern is present everywhere. No sure it makes sense to
start fixing these one at a time.
The #pragma once may be a better long term solution and may improve build times
slightly.
https://en.wikipedia.org/wiki/Pragma_once
Best regards,
Mike
>
Liming :
Thank you for the review comments. Created [edk2] [PATCH V2] MdePkg : Add IPMI
Macro and Structure Defintions to resolve build errors and sent for review.
-Manic
-Original Message-
From: gaoliming
Sent: Wednesday, June 16, 2021 10:51 PM
To: Manickavasakam Karpagavinayagam ;
MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors
Build error reported for missing structures IPMI_SET_BOOT_OPTIONS_RESPONSE,
EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
On 6/8/21 3:06 PM, Laszlo Ersek wrote:
> Introduce the NETWORK_ISCSI_MD5_ENABLE feature test macro for NetworkPkg.
> When explicitly set to FALSE, remove MD5 from IScsiDxe's CHAP algorithm
> list.
>
> Set NETWORK_ISCSI_MD5_ENABLE to TRUE by default, for compatibility
> reasons. Not just to
Mike :
During PCI Bus enumeration, we need to skip SPI Controller (because of a
silicon sighting) or else any SET variable asserts.
Also, need to skip a specific MLX card UEFI OPROM or else will see CPU
exception.
We checked the PCIBUS driver code flow and there is no generic hooks to skip
I agree that this is unlikely to be a consequence of the current patch.
I logged new BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3459
Regards,
/Pete
On 2021.06.17 05:44, Sunil V L wrote:
Hi Pete,
Thank you very much!.
On Wed, Jun 16, 2021 at 01:35:27PM +0100, Pete Batard wrote:
From: Ken Lautner
Changed BdsEntry.c to use Variable Policy instead of Variable Lock
as Variable Lock will be Deprecated eventually
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Zhichao Gao
Cc: Ray Ni
Cc: Liming Gao
Signed-off-by: Kenneth Lautner
Reviewed-by: Liming Gao
---
Has the reason for the PciBusDxe override been discussed with the PciBusDxe
maintainer?
What feature would need to be added to PciBusDxe to accommodate the use case?
Mike
From: devel@edk2.groups.io On Behalf Of manickavasakam
karpagavinayagam
Sent: Thursday, June 17, 2021 7:56 AM
To:
Hi, Patrick,
The V2 patch addressed all previous comments.
However, when I try to test your patch and build with VS2019, it gave me
compiling error as below:
w:\edk2\UefiPayloadPkg\UefiPayloadEntry\UefiPayloadEntry.c(140): warning C4244:
'=': conversion from 'UINT64' to 'UINT32', possible
Hi, Patrick,
Thank you, I will take a look on the new patch!
Regards
Maurice
> -Original Message-
> From: Patrick Rudolph
> Sent: Thursday, June 17, 2021 6:21
> To: Ma, Maurice
> Cc: devel@edk2.groups.io; Dong, Guo ; You,
> Benjamin
> Subject: Re: [PATCH]
On 06/17/2021, Grzegorz Bernacki wrote:
> Hi Min M,
>
> Sure, I will send the test result after I make changes for the v4 version. Can
> you please point me to a few mails with the test result table so I can copy
> the
> format?
>
Please refer to https://edk2.groups.io/g/devel/message/74239
Just
Hi Maurice,
I've implemented the requested changes. It now also accepts ACPI_NVS
as usable DRAM.
Thanks,
Patrick
On Thu, Jun 17, 2021 at 2:33 AM Ma, Maurice wrote:
>
> Hi, Rudolph,
>
> Thank you for submitting the patch. In general the approach looks good to
> me.
> Here I have several minor
Hi Min M,
Sure, I will send the test result after I make changes for the v4
version. Can you please point me to a few mails with the test result
table so I can copy the format?
thanks,
greg
czw., 17 cze 2021 o 03:30 Xu, Min M napisał(a):
>
> On 06/14/2021 5:48 PM, Grzegorz Bernacki Wrote:
> >
Currently several DXE crash due to invalid memory resource settings.
The PciHostBridgeDxe which expects the MMCONF and PCI Aperature
to be EfiMemoryMappedIO, but currently those regions are (partly)
mapped as EfiReservedMemoryType.
coreboot and slimbootloader provide an e820 compatible memory
On 17/06/2021 15:01, Ard Biesheuvel wrote:
> On Thu, 17 Jun 2021 at 11:12, Dov Murik wrote:
>>
>> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
>>
>> In order to support measured SEV boot with kernel/initrd/cmdline, we'd
>> like to have one place that reads those blobs; in the future
Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
ground to add a warning about the incompatibility with boot verification
process.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: James Bottomley
Cc: Tobin Feldman-Fitzthum
Signed-off-by: Dov Murik
---
Remove the QemuFwCfgLib interface used to read the QEMU cmdline
(-append argument) and the initrd size. Instead, use the synthetic
filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd",
and "cmdline".
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: James Bottomley
This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441.
Manually fixed conflicts in:
OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c
Note that besides re-exposing the kernel command line as a file in the
synthetic filesystem, we also revert back to AllocatePool instead of
[resending due to missing recipients]
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
In order to support measured SEV boot with kernel/initrd/cmdline, we'd
like to have one place that reads those blobs; in the future we'll add
the measurement and verification in that place.
We already
On Thu, 17 Jun 2021 at 11:12, Dov Murik wrote:
>
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
>
> In order to support measured SEV boot with kernel/initrd/cmdline, we'd
> like to have one place that reads those blobs; in the future we'll add
> the measurement and verification in that
The IORT generator is populating the reference field for Context and
PMU interrupts even if their count is zero.
Update the IORT generator to set the references only if the interrupt
count is not 0. Also add checks to ensure a valid reference token has
been provided.
Signed-off-by: Sami Mujawar
Bugzilla: 3458 - Add support IORT Rev E.b specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.b,
Feb 2021 (https://developer.arm.com/documentation/den0049/)
introduces the following updates,
According to section 5.3.5, EDK II C Coding Standards Specification
(https://edk2-docs.gitbook.io/edk-ii-c-coding-standards-specification)
the header file guard names must not be prefixed with underscores as
they are reserved for compiler implementation.
Therefore, fix the header file include
Bugzilla: 3458 - Add support IORT Rev E.b specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.b,
Feb 2021 (https://developer.arm.com/documentation/den0049/)
introduces the following updates,
Bugzilla: 3458 - Add support IORT Rev E.b specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.b,
Feb 2021 (https://developer.arm.com/documentation/den0049/)
introduces the following updates,
Bugzilla: 3458 - Add support IORT Rev E.b specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table (IORT) specification has been updated to
rev E.b. The following updates are introduced including the errata
to rev E and E.a:
- increments the
Some field names in the IORT table parser were longer than the
OUTPUT_FIELD_COLUMN_WIDTH plus indentation, resulting in loss of
the output print alignment. Therefore, abbreviate the field names.
Signed-off-by: Sami Mujawar
---
Notes:
v2:
- No code change since v1. Re-sending with v2
Bugzilla: 3458 - Add support IORT Rev E.b specification updates
(https://bugzilla.tianocore.org/show_bug.cgi?id=3458)
The IO Remapping Table, Platform Design Document, Revision E.b,
Feb 2021 (https://developer.arm.com/documentation/den0049/)
introduces the following updates,
The IORT table generator is setting up a reference to ID array for
nodes even when the ID Mapping count is zero. This is not an issue as an
OS would only access the ID Reference if the ID mapping count is not zero.
However, it would be good to set the reference to ID array to zero when
the ID
Remove the QemuFwCfgLib interface used to read the QEMU cmdline
(-append argument) and the initrd size. Instead, use the synthetic
filesystem QemuKernelLoaderFs which has three files: "kernel", "initrd",
and "cmdline".
Signed-off-by: Dov Murik
---
Make it clear that X86QemuLoadImageLib relies on fw_cfg; prepare the
ground to add a warning about the incompatibility with boot verification
process.
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Cc: Jordan Justen
Cc: James Bottomley
Cc: Tobin Feldman-Fitzthum
Signed-off-by: Dov Murik
---
This reverts commit efc52d67e1573ce174d301b52fa1577d552c8441.
Manually fixed conflicts in:
OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c
Note that besides re-exposing the kernel command line as a file in the
synthetic filesystem, we also revert back to AllocatePool instead of
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457
In order to support measured SEV boot with kernel/initrd/cmdline, we'd
like to have one place that reads those blobs; in the future we'll add
the measurement and verification in that place.
We already have a synthetic filesystem
Hi Everyone,
I have compiled a list of recommended extensions and settings for using Visual
Studio Code to develop EDK II code. I have posted them on the wiki:
https://github.com/tianocore/tianocore.github.io/wiki/Nate's-Recommended-VSCode-Extensions-and-Settings
Feel free to add to the list
85 matches
Mail list logo
