[edk2-devel] [RFC PATCH] OvmfPkg/OvmfXen: set PcdAcpiS3Enable at initialization

There are several functions in OvmfPkg/Library using QemuFwCfgS3Enabled() to detect the S3 support status. However, in MdeModulePkg, PcdAcpiS3Enable is used to check S3 support. Since InitializeXenPlatform() didn't set PcdAcpiS3Enable as InitializePlatform() did, this made the inconsistency

Re: [edk2-devel] [EXTERNAL] [Patch 2/3] .mergify: Simplify Mergify rules using GitHub status checks

Acked-by: Bret Barkelew - Bret From: Michael D Kinney Sent: Wednesday, July 7, 2021 8:49 PM To: devel@edk2.groups.io Cc: Liming Gao; Sean Brogan; Bret

Re: [EXTERNAL] [edk2-devel] [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py

Reviewed-by: Bret Barkelew - Bret From: devel@edk2.groups.io on behalf of Michael D Kinney via groups.io Sent: Wednesday, July 7, 2021 8:49:00 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao ; Chen, Yuwei Subject: [EXTERNAL] [edk2-devel] [Patch

Re: [edk2-devel] [EXTERNAL] [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states

Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney Sent: Wednesday, July 7, 2021 8:49 PM To: devel@edk2.groups.io Cc: Sean Brogan; Bret Barkelew; Liming

[edk2-devel] [Patch 3/3] .azurepipelines: Remove FINISHED and FAILED states

Remove 10 second delay workarounds for issues observed when Mergify was originally enabled. These issues are no longer present when GitHub branch protections are used for status checks. Cc: Sean Brogan Cc: Bret Barkelew Cc: Liming Gao Signed-off-by: Michael D Kinney ---

[edk2-devel] [Patch 2/3] .mergify: Simplify Mergify rules using GitHub status checks

* Enable Mergify queue feature to support auto rebase when 'push' label is set and gauarntee that all EDK II CI checks are run before merging in changes with linear history. * Use status checks configured in GitHub branch protections * Allow non EDK II Maintainers to create a PR Requires an

[edk2-devel] [Patch 1/3] BaseTools/Scripts: Ignore Mergify merge commits in PatchCheck.py

Mergify adds merge commits to a PR when processing PRs using the queue feature with auto rebase. Update PatchCheck.py to ignore commit message issues with these merge commits. These merge commits are not added to the base branch when the PR is merged by Mergify. Cc: Bob Feng Cc: Liming Gao Cc:

[edk2-devel] [Patch 0/3] Mergify Enhancements

* Removed FINISHED and FAILED states with 10 second delays * Update PatchCheck.py to ignore commit message format issues in merge commeits added by Merfigy. * Enable Mergify queue feature to support auto rebase when 'push' label is set and gauarntee that all EDK II CI checks are run before

[edk2-devel] [Patch 1/3] BaseTools/Scripts: Fix GetMaintainer.py line endings

Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 380 ++--- 1 file changed, 190 insertions(+), 190 deletions(-) diff --git a/BaseTools/Scripts/GetMaintainer.py b/BaseTools/Scripts/GetMaintainer.py

[edk2-devel] [Patch 3/3] Maintainers.txt: Add GitHub IDs

Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Signed-off-by: Michael D Kinney --- Maintainers.txt | 286 1 file changed, 143 insertions(+), 143 deletions(-) diff --git a/Maintainers.txt b/Maintainers.txt index f4e4c72d0628..86926df13be3

[edk2-devel] [Patch 2/3] BaseTools/Scripts: Allow GitHub ID at end Maintainers.txt lines

Update GetMaintainer.py to support an optional GitHub ID at the end of maitainer lines. Cc: Bob Feng Cc: Liming Gao Cc: Yuwei Chen Signed-off-by: Michael D Kinney --- BaseTools/Scripts/GetMaintainer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [Patch 0/3] Add GitHub ID to Maintainer.txt

Update GetMaintainer.py to allow a GitHub ID after the email address for maintainers and reviewers and update Maitainers.txt with GitHub IDs. The GitHub ID will be used to help autotate the PR reviewer assignments. Cc: Andrew Fish Cc: Laszlo Ersek Cc: Leif Lindholm Cc: Bob Feng Cc: Liming

Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

The extra spaces are in purpose to align the == It looks correct with a fixed size font. Mike From: Kinney, Michael D Sent: Wednesday, July 7, 2021 7:20 PM To: Bret Barkelew ; devel@edk2.groups.io; Kinney, Michael D Cc: Liming Gao ; Liu, Zhiguang Subject: RE: [EXTERNAL] [edk2-devel] [Patch

Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

Hi Bret, I will fix the extra spaces. Thanks, Mike From: Bret Barkelew Sent: Wednesday, July 7, 2021 4:00 PM To: devel@edk2.groups.io; Kinney, Michael D Cc: Liming Gao ; Liu, Zhiguang Subject: RE: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L""

Re: [edk2-devel] [PATCH v2 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc

Reviewed-by: Bob Feng -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois Sent: Wednesday, July 7, 2021 4:56 AM To: devel@edk2.groups.io; Sean Brogan ; Bret Barkelew ; Kinney, Michael D ; Liming Gao ; Sami Mujawar Subject: [edk2-devel] [PATCH v2 4/4]

Re: [edk2-devel] [PATCH 1/1] BaseTools: Remove non-ascii character of StructurePcd comment

Reviewed-by: Bob Feng -Original Message- From: Chen, Christine Sent: Monday, June 28, 2021 4:47 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Liming Gao Subject: [PATCH 1/1] BaseTools: Remove non-ascii character of StructurePcd comment Currently, the ConvertFceToStructurePcd.py tool

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, July 9, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST

Re: [EXTERNAL] [edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

I like it. Do you have an extra space after the (L’A’) and (L”A”)? Reviewed-by: Bret Barkelew - Bret From: Michael D Kinney via groups.io Sent: Wednesday, July 7, 2021 3:43 PM To: devel@edk2.groups.io Cc: Liming

Re: [edk2-devel] [PATCH] IntelSiliconPkg/PcieSecurity: don't measure the device when TPM disabled

Pushed: https://github.com/tianocore/edk2-platforms/commit/31a4bb942aefd90b465953be772ee7b41a9dd279 Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chaganty, > Rangasai V > Sent: Wednesday, July 7, 2021 11:40 AM > To: Zhang, Qi1 ; devel@edk2.groups.io > Cc: Yao,

[edk2-devel] [Patch 1/1] MdePkg/Include: Add STATIC_ASSERT for L'' and L"" strings

Add STATIC_ASSERT() macros to verify that the compiler is configured correctly for the use of L'' and L"" strings. Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Michael D Kinney --- MdePkg/Include/Base.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [EXTERNAL] Re: [edk2-devel] Do the edk2 CI unit tests work in Linux?

Steven, Yes, Pytools is cross platform and is used regularly on Linux. Generally mono has been the problem on Linux. Ideally we could move to a native Linux package manager to make this have fewer dependencies but for now can you try following the directions here on getting mono setup.

Re: [edk2-devel] [PATCH] IntelSiliconPkg/PcieSecurity: don't measure the device when TPM disabled

Reviewed-by: Sai Chaganty -Original Message- From: Zhang, Qi1 Sent: Wednesday, June 30, 2021 11:23 PM To: devel@edk2.groups.io Cc: Zhang, Qi1 ; Yao, Jiewen ; Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH] IntelSiliconPkg/PcieSecurity: don't measure the device when TPM disabled

Re: [edk2-devel] [PATCH v2] OvmfPkg: Remove unused print service driver (PrintDxe)

On 7/7/21 8:01 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf

[edk2-devel] [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe)

From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

[edk2-devel] [PATCH v2] OvmfPkg: Remove unused print service driver (PrintDxe)

From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Remove unused print service driver (PrintDxe)

On 7/6/21 6:02 PM, Laszlo Ersek wrote: > On 07/06/21 11:53, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude >> >> The Print service driver is not used by OVMF, remove it. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc: Jordan Justen >> Cc: Brijesh Singh >> Cc: Erdem Aktas

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: introduce EMBED_GRUB=FALSE to skip including Grub image

On 07/07/2021 13:51, James Bottomley wrote: > On Wed, 2021-07-07 at 10:42 +, Dov Murik wrote: >> The AmdSevX64 target includes an embedded Grub image to support >> secure >> (measured) boot of confidential guests with encrypted root images. >> >> However, it is sometimes convenient to build

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg: Remove meaningless comment

On 7/6/21 5:57 PM, Laszlo Ersek wrote: > On 07/06/21 11:49, Philippe Mathieu-Daudé wrote: >> From: Philippe Mathieu-Daude >> >> The "Shell Embedded Boot Loader" description (added in >> commit 6f5872b1f401) does not add any value, remove it. >> >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Cc:

Re: [edk2-devel] Ajays NET20DC Cable's alternative

Hello, As far as I know, you can use a USB 3.0 debug cable as an alternative. Also, I think there other methods to connect between host and target in Intel(r) UEFI Development Kit (Intel(r) UDK) Debugger Tool (version 1.5) Configuration and Setup Guide.

Re: [edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: introduce EMBED_GRUB=FALSE to skip including Grub image

On Wed, 2021-07-07 at 10:42 +, Dov Murik wrote: > The AmdSevX64 target includes an embedded Grub image to support > secure > (measured) boot of confidential guests with encrypted root images. > > However, it is sometimes convenient to build this target without an > embedded Grub. We

[edk2-devel] [PATCH 1/1] OvmfPkg/AmdSev: introduce EMBED_GRUB=FALSE to skip including Grub image

The AmdSevX64 target includes an embedded Grub image to support secure (measured) boot of confidential guests with encrypted root images. However, it is sometimes convenient to build this target without an embedded Grub. We introduce the EMBED_GRUB setting (defaults to TRUE), which conditions

[edk2-devel] Ajays NET20DC Cable's alternative

Hi, All: If users want to debug UDK BIOS source code, they could use COM port or USB port as communication channel. Usually, UDK suggests using Ajays NET20DC device as the usb port inter-connection cables between Host and Target board. But, I found: Ajays is bankcrupt so their product line is

[edk2-devel] [PATCH] IntelFsp2Pkg: Add search function for Config Editor

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3482 This patch adds a search function in the Config Editor GUI at the top right corner. Once users key in the words to search, it will look for the option containing the string in the same page and display it. Cc: Maurice Ma Cc: Nate DeSimone

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

On 07/07/21 08:00, Kinney, Michael D wrote: > Hi Laszlo, > > I did many experiments and could not get the exact behavior I proposed. > > Here is the best I can do with the behavior of GitHub and Mergify: > > 1) I further simplified Mergify configuration so personal builds ('push' >label not

Re: [edk2-devel] [PATCH v5 00/10] Secure Boot default keys

Hi, I created BZ #3481 (https://bugzilla.tianocore.org/show_bug.cgi?id=3481). Please let me know if I filled it correctly thanks, greg śr., 7 lip 2021 o 03:18 gaoliming napisał(a): > > Grzegorz Bernacki: > This is a new feature. Can you submit one BZ > (https://bugzilla.tianocore.org/) for

Re: [edk2-devel] QemuVideo: BochsID mismatch (got 0x0)

Hi all: After testing, I found that once the QXL device shared a PciRoot slot with other devices, the following log would appear: QemuVideo: BochsID mismatch (got 0x0) Connect: PciRoot(0x0)... : Not Found Is this a feature of QXL devices? Best regards, Lange At 2021-07-07

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: clean up TPM_ENABLE remnants

Hi Laszlo, I did many experiments and could not get the exact behavior I proposed. Here is the best I can do with the behavior of GitHub and Mergify: 1) I further simplified Mergify configuration so personal builds ('push' label not set) are no longer auto closed. Any developer doing a