Re: [edk2-devel] [PATCH v2] MinPlatformPkg/PciHostBridgeLibSimple: Fix Mem.Limit assignment

Thanks for fixing this issue! Reviewed-by: Chasel Chiu > -Original Message- > From: Benjamin Doron > Sent: Friday, July 23, 2021 10:27 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Liming Gao > ; Dong, Eric > Subject: [PATCH v2]

Re: [edk2-devel] RFC: EXT4 filesystem driver

> On Jul 22, 2021, at 7:07 PM, Desimone, Nathaniel L > wrote: > > Hi Pedro, > >> -Original Message- >> From: devel@edk2.groups.io >> mailto:devel@edk2.groups.io>> On Behalf Of Pedro >> Falcato >> Sent: Thursday, July 22, 2021 9:54 AM >> To: Andrew Fish

[edk2-devel] Adding HTTP boot IO timeout programmability from PcdHttpIoTimeout

Hello, Please review the attached filed EDK2 tracker for feature enablement of programmable timeout of the HTTP boot IO timer. NetworkPkg-HttpBoot: Making the HTTP IO timeout value programmable with PCD. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3507 HTTP boot has a default set

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

Ashraf, Thanks for the summary. Can you send a V2 patch which only take cares the 1G page table assembly logic? Thanks, Ray > -Original Message- > From: S, Ashraf Ali > Sent: Friday, July 23, 2021 12:58 AM > To: Ni, Ray ; Dov Murik ; Ard > Biesheuvel ; Brijesh Singh > ; James

Re: [edk2-devel] [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in Main.asm

Reviewed-by: Ray Ni > -Original Message- > From: Xu, Min M > Sent: Thursday, July 22, 2021 1:52 PM > To: devel@edk2.groups.io > Cc: Xu, Min M ; Dong, Eric ; Ni, Ray > ; Yao, Jiewen > > Subject: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in > Main.asm > > RFC:

Re: [edk2-devel] [PATCH] UefiCpuPkg: ResetVector Tool Support for Python 3

Ashraf, I assume that your previous ResetVector patch can be dropped, and we just review this one that supports python3 first, right? Since this patch is for the feedbacks of patch separation, can you help to do it further? 1. only do minimal update to the python script to make it python3

[edk2-devel] [PATCH v2] MinPlatformPkg/PciHostBridgeLibSimple: Fix Mem.Limit assignment

In the case where the root bridge's Mem.Limit is the base address of PCIe MMIO, subtract one to make a valid end address. This fixes an issue where CpuDxe returns "Length(0x5001) is not aligned!" when PciHostBridgeDxe attempts to make this range uncacheable. Cc: Chasel Chiu Cc: Nate

Re: [edk2-devel] RFC: EXT4 filesystem driver

Hi Pedro, > -Original Message- > From: devel@edk2.groups.io On Behalf Of Pedro > Falcato > Sent: Thursday, July 22, 2021 9:54 AM > To: Andrew Fish > Cc: edk2-devel-groups-io ; mhaeu...@posteo.de; > r...@edk2.groups.io > Subject: Re: [edk2-devel] RFC: EXT4 filesystem driver > > Hi

[edk2-devel] [RFC] MemoryProtectionLib for Dynamic Memory Guard Settings

Current memory protection settings rely on FixedAtBuild PCD values (minus PcdSetNxForStack). Because of this, the memory protection configuration interface is fixed in nature. Cases arise in which memory protections might need to be adjusted between boots (if platform design allows) to avoid

[edk2-devel] [PATCH v1] MinPlatformPkg/PciHostBridgeLibSimple: Fix Mem.Limit assignment

In the case where the root bridge's Mem.Limit is the base address of PCIe MMIO, subtract one to make a valid end address. This fixes an issue where CpuDxe returns "Length(0x5001) is not aligned!" when PciHostBridgeDxe attempts to make this range uncacheable. Signed-off-by: Benjamin Doron

Re: [edk2-devel] [PATCH V2 4/4] OvmfPkg/ResetVector: Update ResetVector to support Tdx

On July 23, 2021 1:08 AM, Tom Lendacky wrote: > On 7/22/21 12:52 AM, Min Xu wrote: > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > diff --git a/OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm > > b/OvmfPkg/ResetVector/Ia32/Flat32ToFlat64.asm > > index c6d0d898bcd1..2206ca719593

Re: [edk2-devel] [PATCH] UefiCpuPkg: ResetVector Tool Support for Python 3

According to the logs, the .raw file binaries were committed 10 years ago. This commit in 2014 make a change to how the build defines are processed. It also switches from using ASM to NASM for the assembler.

Re: [edk2-devel] [PATCH] UefiCpuPkg: ResetVector Tool Support for Python 3

Hi., Michael Even If we generate the binaries using the Python2 also, it's getting changed. Can you confirm from your end by generating the binaries using the build.py in Python2 Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From: Kinney, Michael D

Re: [edk2-devel] [edk2-rfc] RFC: EXT4 filesystem driver

> -Original Message- > From: r...@edk2.groups.io On Behalf Of gaoliming > Sent: Wednesday, July 21, 2021 6:21 PM > To: r...@edk2.groups.io; pedro.falc...@gmail.com; devel@edk2.groups.io > Subject: 回复: [edk2-rfc] RFC: EXT4 filesystem driver > > > > > -邮件原件- > > 发件人:

Re: [edk2-devel] [PATCH V2 4/4] OvmfPkg/ResetVector: Update ResetVector to support Tdx

On 7/22/21 12:52 AM, Min Xu wrote: > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > In Tdx all CPUs "reset" to run on 32-bit protected mode with flat > descriptor (paging disabled). But in Non-Td guest the initial state of > CPUs is 16-bit real mode. To resolve this conflict, BITS

Re: [edk2-devel] [PATCH] UefiCpuPkg VTF0 X64: Build page tables using 1-GByte Page Granularity

Hi. Ray Based on Dov Murik Comments to take the python script changes separately, I have filed the Bugzilla for that separately. https://bugzilla.tianocore.org/show_bug.cgi?id=3506 verified the binary. More details are in Bugzilla. Regards, Ashraf Ali S Intel Technology India Pvt. Ltd. 

Re: [edk2-devel] RFC: EXT4 filesystem driver

Hi Andrew, Marvin, RE: The package name: It doesn't sound like a bad idea to have something like a FileSystemPkg and have a bunch of different filesystems inside of it, but I'll defer to you and my mentors' judgement; we could also drop that issue for now and take care of it afterwards, since it

Re: [edk2-devel] [PATCH] UefiCpuPkg: ResetVector Tool Support for Python 3

Hi Ashraf, Why would an update to the Python script to Python3 cause any changes to the binary images the script produces. If they are different, then that would seem to imply that the change was not compatible from a behavior perspective. Mike > -Original Message- > From:

[edk2-devel] [PATCH] UefiCpuPkg: ResetVector Tool Support for Python 3

[edk2-devel] [PATCH] REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3506 Build Scrips for Reset Vector currently based on Python 2 which is already EOL, needs to modify the build script based on Python 3, update the Binary accordingly. Change-Id: I2cfef08177951f2f29ee168ac4a9de9b10769ea1 Cc:

Re: [edk2-devel] RFC: EXT4 filesystem driver

On 22.07.21 17:58, Andrew Fish wrote: On Jul 22, 2021, at 3:24 AM, Marvin Häuser > wrote: On 22.07.21 01:12, Pedro Falcato wrote: EXT4 (fourth extended filesystem) is a filesystem developed for Linux that has been in wide use (desktops, servers, smartphones) since

Re: [edk2-devel] RFC: EXT4 filesystem driver

> On Jul 22, 2021, at 3:24 AM, Marvin Häuser wrote: > > On 22.07.21 01:12, Pedro Falcato wrote: >> EXT4 (fourth extended filesystem) is a filesystem developed for Linux >> that has been in wide use (desktops, servers, smartphones) since 2008. >> >> The Ext4Pkg implements the Simple File

Re: [edk2-devel] ArmVirt and Self-Updating Code

On Thu, 22 Jul 2021 at 16:54, Bret Barkelew wrote: > > Expanding audience to the full dev list… > > See below… > > > > - Bret > > > > From: Thomas Abraham > Sent: Wednesday, July 7, 2021 11:07 PM > To: Bret Barkelew; Ard Biesheuvel (TianoCore); Lindholm, Leif; Laszlo Ersek; > Marvin Häuser; Sami

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 6/6] RedfishClientPkg/Redfish-Profile-Simulator: Add requirements

Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 6/6]

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 5/6] RedfishClientPkg/Redfish-Profile-Simulator: Add ETAG on memory resource

Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 5/6]

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 4/6] RedfishClientPkg/Redfish-Profile-Simulator: HTTP methods on Memory Collection

Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 4/6]

Re: [edk2-devel] ArmVirt and Self-Updating Code

Expanding audience to the full dev list… See below… - Bret From: Thomas Abraham Sent: Wednesday, July 7, 2021 11:07 PM To: Bret Barkelew; Ard Biesheuvel (TianoCore); Lindholm,

Re: [edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

Here is the documentation: https://github.com/osresearch/kexec-load/blob/main/README.md On Thu, Jul 22, 2021 at 1:09 AM Marvin Häuser wrote: > > > On 21.07.21 15:23, Cheng-Chieh Huang via groups.io wrote: > > From: Trammell Hudson > > > > This adds a text command line for the UefiPayloadPkg

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, July 23, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOCATION:Asia/Shanghai BEGIN:STANDARD TZNAME:CST

[edk2-devel] [PATCH 3/3] IntelSiliconPkg: Add IgdOpRegion30.h to support IGD OpRegion v3.0

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3426 - There are many OpRegion fields obsoleted in MBOX1 - MBOX2 is re-purposed for Backlight related fields for dual LFP. - Backlight related fields moved to MBOX2 from MBOX3 and some fields are obsoleted in MBOX3. Signed-off-by: Digant H

Re: [edk2-devel] [edk2-platform][PATCH v1 1/1] Platform/RaspberryPi/RPi4: Fix non-standard ACPI HIDs

On Wed, 21 Jul 2021 at 22:39, Andrei Warkentin wrote: > > Reviewed-by: Andrei Warkentin Pushed as d549e39ca1a9..194269223294 Thanks all, > > From: Ard Biesheuvel > Sent: Tuesday, July 20, 2021 10:37 AM > To: Samer El-Haj-Mahmoud > Cc: edk2-devel-groups-io ;

Re: [edk2-devel] RFC: EXT4 filesystem driver

On 22.07.21 01:12, Pedro Falcato wrote: EXT4 (fourth extended filesystem) is a filesystem developed for Linux that has been in wide use (desktops, servers, smartphones) since 2008. The Ext4Pkg implements the Simple File System Protocol for a partition that is formatted with the EXT4 file

Re: [edk2-devel] [PATCH 1/1] MdePkg: add definition of LINUX_EFI_INITRD_MEDIA_GUID

On Wed, 21 Jul 2021 at 20:04, Kinney, Michael D wrote: > Hi Jeff, > > > > I see. I missed the file rename line in the git patch. > > > > I think the description needs to be expanded to clearly describe the > production and consumption of this device path with this GUID. > > > >1. What

Re: [edk2-devel] [PATCH v4 10/11] OvmfPkg: add BlobVerifierLibSevHashes

Here's the diff from the v3 of this patch. It's supposed to catch more cases of bad length fields overflowing the reserved MEMFD space or the declared length of the table. diff --git a/OvmfPkg/Library/BlobVerifierLib/BlobVerifierSevHashes.c

[edk2-devel] [PATCH v4 02/11] OvmfPkg/AmdSev: use GenericQemuLoadImageLib in AmdSev builds

Newer kernels support efistub and therefore don't need all the legacy stuff in X86QemuLoadImageLib, which are harder to secure. Specifically the verification of kernel/initrd/cmdline blobs will be added only to the GenericQemuLoadImageLib implementation, so use that for SEV builds. Cc: Ard

[edk2-devel] [PATCH v4 10/11] OvmfPkg: add BlobVerifierLibSevHashes

Add an implementation for BlobVerifierLib that locates the SEV hashes table and verifies that the calculated hashes of the kernel, initrd, and cmdline blobs indeed match the expected hashes stated in the hashes table. If there's a missing hash or a hash mismatch then EFI_ACCESS_DENIED is returned

[edk2-devel] [PATCH v4 04/11] OvmfPkg: add library class BlobVerifierLib with null implementation

BlobVerifierLib will be used to verify blobs fetching them from QEMU's firmware config (fw_cfg) in platforms that enable such verification. The null implementation BlobVerifierLibNull treats all blobs as valid. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem

[edk2-devel] [PATCH v4 11/11] OvmfPkg/AmdSev: Enforce hash verification of kernel blobs

In the AmdSevX64 build, use BlobVerifierLibSevHashes to enforce verification of hashes of the kernel/initrd/cmdline blobs fetched from firmware config. This allows for secure (measured) boot of SEV guests with QEMU's -kernel/-initrd/-append switches (with the corresponding QEMU support for

[edk2-devel] [PATCH v4 03/11] OvmfPkg: PlatformBootManagerLibGrub: Allow executing kernel via fw_cfg

From: James Bottomley Support QEMU's -kernel option. Create a QemuKernel.c for PlatformBootManagerLibGrub which is an exact copy of the file PlatformBootManagerLib/QemuKernel.c . Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley

[edk2-devel] [PATCH v4 06/11] ArmVirtPkg: add BlobVerifierLibNull to DSC

This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Ref:

[edk2-devel] [PATCH v4 09/11] OvmfPkg/AmdSev: reserve MEMFD space for for firmware config hashes

From: James Bottomley Split the existing 4KB page reserved for SEV launch secrets into two parts: first 3KB for SEV launch secrets and last 1KB for firmware config hashes. The area of the firmware config hashes will be attested (measured) by the PSP and thus the untrusted VMM can't pass in

[edk2-devel] [PATCH v4 08/11] OvmfPkg/AmdSev/SecretPei: build hob for full page

Round up the size of the SEV launch secret area to a whole page, as required by BuildMemoryAllocationHob. This will allow the secret area defined in the MEMFD to take less than a whole 4KB page. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc:

[edk2-devel] [PATCH v4 07/11] OvmfPkg/QemuKernelLoaderFsDxe: call VerifyBlob after fetch from fw_cfg

In QemuKernelLoaderFsDxeEntrypoint we use FetchBlob to read the content of the kernel/initrd/cmdline from the QEMU fw_cfg interface. Insert a call to VerifyBlob after fetching to allow BlobVerifierLib implementations to add a verification step for these blobs. This will allow confidential

[edk2-devel] [PATCH v4 05/11] OvmfPkg: add BlobVerifierLibNull to DSC

This prepares the ground for calling VerifyBlob() in QemuKernelLoaderFsDxe. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Ashish Kalra Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao Cc: Min Xu Cc: Tom Lendacky Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3457

[edk2-devel] [PATCH v4 00/11] Measured SEV boot with kernel/initrd/cmdline

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3457 Booting with SEV prevented the loading of kernel, initrd, and kernel command-line via QEMU fw_cfg interface because they arrive from the VMM which is untrusted in SEV. However, in some cases the kernel, initrd, and cmdline are not secret

[edk2-devel] [PATCH v4 01/11] OvmfPkg/AmdSev/SecretDxe: fix header comment to generic naming

From: James Bottomley Commit 96201ae7bf97 ("OvmfPkg/AmdSev/SecretDxe: make secret location naming generic", 2020-12-15) replaced references to SEV with the generic term Confidential Computing, but missed the file header comment. Fix the naming in that header. Cc: Ard Biesheuvel Cc: Jordan

[edk2-devel] [edk2-platforms PATCH v4 2/2] Revert "Platform/RaspberryPi: Setup option for disabling Fast Boot"

This reverts commit efdc159ef7c9f15581a0f63d755a1530ff475156. This commit is not longer required as Boot Discovery Policy has been implemented for RPi. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RaspberryPi.dec

[edk2-devel] [edk2-platforms PATCH v4 1/2] Platform/RaspberryPi: Enable Boot Discovery Policy.

This commit modify platform boot to check the value of BootDiscoveryPolicy variable and use BootPolicyManager Protocol to connect devices specified by the variable. Signed-off-by: Grzegorz Bernacki Reviewed-by: Sunny Wang --- Platform/RaspberryPi/RPi4/RPi4.dsc

[edk2-devel] [PATCH v4 1/1] MdeModulePkg: Add BootDiscoveryPolicyUiLib.

This library extends Boot Maintenance Menu and allows to select Boot Discovery Policy. When choice is made BootDiscoveryPolicy variable is set. Platform code can use this variable to decide which class of device shall be connected. Signed-off-by: Grzegorz Bernacki Reviewed-by: Zhichao Gao ---

[edk2-devel] [edk2-platforms PATCH v4 0/2]Add BootDiscoveryPolicyUiLib

This patchset extends Boot Maintenance Menu and allows to select Boot Discovery Policy. Raspberry Pi platforms uses the variable to connect specified class of devices on boot. This patchset also removes efdc159e which has similar functionality. Discussion on design can be found at:

[edk2-devel] [Patch V2] NetworkPkg: Add HTTP Additional Event Notifications

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3496 Add new EDKII_HTTP_CALLBACK_PROTOCOL in NetworkPkg, Send HTTP Events via EDKII_HTTP_CALLBACK_PROTOCOL when Dns/ConnectTcp/TlsConnectSession/InitSession occurs. Signed-off-by: Heng Luo Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu ---

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 5/6] RedfishClientPkg/Redfish-Profile-Simulator: Add ETAG on memory resource

Add ETAG support on Memory resource. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../Redfish-Profile-Simulator/v1sim/systems.py | 13 + 1 file changed, 13 insertions(+) diff --git a/RedfishClientPkg/Tools/Redfish-Profile-Simulator/v1sim/systems.py

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 6/6] RedfishClientPkg/Redfish-Profile-Simulator: Add requirements

add requirements.txt for the required python module Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../Tools/Redfish-Profile-Simulator/requirements.txt| 2 ++ 1 file changed, 2 insertions(+) create mode 100644

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 0/6] Initial commit of Redfish Profile Simulator

This is an open source project on DMTF GitHub. (https://github.com/DMTF/Redfish-Profile-Simulator) We clone this project under RedfishClientPkg and maintain it by edk2 because this project has currently been using and updating rarely. That is easier for edk2 to add features to the simulator or

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 3/6] RedfishClientPkg/Redfish-Profile-Simulator: Add more features

- Add HTTPs support - Add ETAG support - Change default credential to admin/pwd123456 - Add HTTP methods on BIOS managed resource. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../redfishProfileSimulator.py| 92 -- .../v1sim/redfishURIs.py

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 4/6] RedfishClientPkg/Redfish-Profile-Simulator: HTTP methods on Memory Collection

Add POST and PATCH methods on Memory collection and resource. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../v1sim/redfishURIs.py | 25 +++ .../v1sim/systems.py | 43 +++ 2 files changed, 68 insertions(+)

[edk2-devel] [staging/edk2-redfish-client Tools PATCH 2/6] RedfishClientPkg/Tools: Add more Redfish resource

Add more Redfish resource for EDK2 Redfish development. - Add two more systems to profile. - Add BIOS, Memory and Log service to profile. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../redfish/v1/$metadata/index.xml| 6 +- .../index.json

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Add Jiewen Yao as OvmfPkg Maintainer

On Wed, 21 Jul 2021 at 04:22, Yao, Jiewen wrote: > > Reviewed-by: Jiewen Yao > Reviewed-by: Ard Biesheuvel Thanks Jiewen! > > -Original Message- > > From: Kinney, Michael D > > Sent: Wednesday, July 21, 2021 8:44 AM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Ard Biesheuvel >