This patch set is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Cole
Sent: Saturday, July 24, 2021 4:02 AM
To: devel@edk2.groups.io
Cc: Cole Robinson
Subject: [edk2-devel] [PATCH 0/3] BaseTools: fix some python DeprecationWarnings
This
+ NetworkPkg Maitainer/Reviewer
Hi Zachary,
I notice you pushed the patch to https://github.com/tianocore/edk2/pull/1834
But according to "The developer process for the EDK II project" In
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
Normally we send the patch
Hi James
"However, this ran into problems when it was decided AmdSev shouldn't have it's
own Library."
I am not clear on the history. Would you please clarify why AmdSev should not
have its own library?
It looks not reasonable to me. AmdSev is just a feature. A feature may have its
own
On Sun, 2021-07-25 at 10:52 +0300, Dov Murik wrote:
> And I do have one question:
> > May I know what is criteria to put a SEV module to OvmfPkg\AmdSev
> > or OvmfPkg directly?
> >
> > My original understanding is:
> > If a module is required by OvmfPkg{Ia32,Ia32X64,X64}.{dsc,fdf},
> > then it
Thanks for the explanations. Comments below:
On 25/07/2021 11:17, Yao, Jiewen wrote:
> Thank you Dov.
> Comment below:
>
>> -Original Message-
>> From: Dov Murik
>> Sent: Sunday, July 25, 2021 3:53 PM
>> To: Yao, Jiewen ; devel@edk2.groups.io
>> Cc: Tobin Feldman-Fitzthum ; Tobin
Thank you Dov.
Comment below:
> -Original Message-
> From: Dov Murik
> Sent: Sunday, July 25, 2021 3:53 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Tobin Feldman-Fitzthum ; Tobin Feldman-Fitzthum
> ; Jim Cadden ; James Bottomley
> ; Hubertus Franke ; Ard Biesheuvel
> ; Justen,
Hi Jiewen,
On 25/07/2021 5:43, Yao, Jiewen wrote:
> Hi
> I am reviewing this patch series. I am OK with most parts.
Thank you.
>
> And I do have one question:
> May I know what is criteria to put a SEV module to OvmfPkg\AmdSev or OvmfPkg
> directly?
>
> My original understanding is:
> If a
Agree. I will update the patch set based upon your suggestions.
Thanks!
Xu, Min
> -Original Message-
> From: Yao, Jiewen
> Sent: Sunday, July 25, 2021 2:01 PM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Brijesh Singh
> ; Erdem Aktas ; James
> Bottomley ; Tom Lendacky
>
I see. I will update it in the next version.
Thanks!
> -Original Message-
> From: Yao, Jiewen
> Sent: Sunday, July 25, 2021 3:44 PM
> To: Xu, Min M ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: RE: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point
> in
Yes, if that can avoid the UefiCpuPkg change.
> -Original Message-
> From: Xu, Min M
> Sent: Sunday, July 25, 2021 3:42 PM
> To: Yao, Jiewen ; devel@edk2.groups.io
> Cc: Dong, Eric ; Ni, Ray
> Subject: RE: [PATCH V2 3/4] UefiCpuPkg/ResetVector: Add Main32 entry point in
> Main.asm
>
>
On July 25, 2021 2:08 PM, Yao, Jiewen wrote:
> Current OvmfPkg Reser vector is a mess (see my previous email).
> I also compared the ResetVector code in UefiCpuPkg and OvmfPkg. There
> are already duplication/override.
>
> I suggest we just drop UefiCpuPkg change, and focus on improving OvmfPkg.
Current OvmfPkg Reser vector is a mess (see my previous email).
I also compared the ResetVector code in UefiCpuPkg and OvmfPkg. There are
already duplication/override.
I suggest we just drop UefiCpuPkg change, and focus on improving OvmfPkg.
If we need add something in UefiCpuPkg, let's copy the
Hi Min, Brijesh, James
I feel very frustrated when I review the existing OVMF reset vector.
A big problem is that this code mixed too many SEV stuff, and we are trying to
add more TDX stuff in *one* file, without clear isolation.
Take PageTables64.asm as example, here are the symbols. (* means
13 matches
Mail list logo
