Re: [edk2-devel] [PATCH v3 6/7] OvmfPkg/PlatformCI: dummy grub.efi for AmdSev

Thanks for this addition to CI! On 03/11/2021 11:11, Gerd Hoffmann wrote: > Building grub.efi for AmdSev is difficult because it depends on patches > not yet merged to upstream grub. So shortcut the grub build by simply > creating an empty grub.efi file. That allows to at least build-test the

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

Hey all, Thanks for the effort! 1. If virtually everyone will need Uncrustify, why cannot it be built along with BaseTools from a submodule? Especially with the fork that makes sense, after that it depends on the upstream (it does not look too nice to me). 2. Does this cover CRLF->LF? 3.

Re: [edk2-devel] [PATCH v2 0/5] [RfC] OvmfPkg/Microvm: second batch of microvm patches

On Wed, Nov 03, 2021 at 04:06:22PM +0100, Gerd Hoffmann wrote: > Adds support for virtio-mmio devices to microvm. > > While being at it also add the README, the > patch somehow disappeared from the first batch. > > v2: > - qemu changes needed for this are merged and will be >in the 6.2

Re: [edk2-devel] [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724 > > Add typecast to fix build error with VS2019 X64 NOOPT converting> a UINT64 value to UINT32 value.> > Cc: Rebecca Cran > Cc: Peter Grehan > Signed-off-by: Michael D Kinney Acked-by: Peter Grehan -=-=-=-=-=-=-=-=-=-=-=- Groups.io

Re: [edk2-devel] [PATCH v3 0/7] OvmfPkg/PlatformCI: hook up AmdSev, Bhyve and Microvm

On Wed, Nov 03, 2021 at 10:11:16AM +0100, Gerd Hoffmann wrote: > v3: > - pick up Acked-by: > - use __file__ to extend path > v2: > - hook up OvmfXen too. > - add CI maintainers to Cc. > > Gerd Hoffmann (7): > OvmfPkg/PlatformCI: factor out PlatformBuildLib.py > OvmfPkg/PlatformCI: add

Re: [edk2-devel] [PATCH v3 0/5] OvmfPkg: rework TPM configuration.

On Thu, Oct 28, 2021 at 01:09:16PM +0200, Gerd Hoffmann wrote: > Allows to enable/disable TPM 1.2 support in OVMF. > Allows to enable SHA-1 support for TPM hashing. > > v3: > - drop config menu for tpm 1.2 (needs other fixes first) > - update some places missed. > - add microvm cleanup. > -

Re: [edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe

Reviewed-by: Jiewen Yao > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, November 9, 2021 3:00 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Justen, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > ; Dong, Eric ;

Re: [edk2-devel] [Patch 1/1] OvmfPkg/Xen: Fix VS2019 build issues

On Mon, Nov 08, 2021 at 08:22:08AM -0800, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3722 > > Fix VS2019 NOOPT build issues related to converting > a larger integer value to a smaller integer value. > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Ard

Re: [edk2-devel] [PATCH V3 0/3] Rename XenTimerDxe to LocalApicTimerDxe

On Mon, Nov 08, 2021 at 02:07:57PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > XenTimerDxe is a local Apic timer driver and it has nothing to do > with Xen. So rename it to LocalApicTimerDxe. > > After renaming, LocalApicTimerDxe is used in OvmfPkg if

Re: [edk2-devel] [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with 'ParseFlags'

See below > -Original Message- > From: Joey Gouly > Sent: Thursday, September 16, 2021 10:46 PM > To: devel@edk2.groups.io > Cc: joey.go...@arm.com; sami.muja...@arm.com; Ni, Ray > ; Gao, Zhichao ; n...@arm.com > Subject: [PATCH v2 1/5] ShellPkg: Replace 'Trace' parameter with

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, November 9, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/09/2021 #cal-reminder

Few issues are submitted this week. Let’s cancel this week meeting. 3723 EDK2 Code unassig...@tianocore.org UNCO Fix EmbeddedPkg VS2019 X64 NOOPT build issues 11:57:04

[edk2-devel] [Patch 1/1] OvmfPkg/Bhyve/PlatformPei: Fix VS2019 X64 NOOPT build issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3724 Add typecast to fix build error with VS2019 X64 NOOPT converting a UINT64 value to UINT32 value. Cc: Rebecca Cran Cc: Peter Grehan Signed-off-by: Michael D Kinney --- OvmfPkg/Bhyve/PlatformPei/Platform.c | 2 +- 1 file changed, 1

Re: [edk2-devel] [edk2-platforms][PATCH 00/30] EDK2 RISC-V port with opensbi v0.9

Reviewed-by: Daniel Schaefer From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, October 19, 2021 16:09 To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Sunil V L ; Schaefer, Daniel Subject: [edk2-platforms][PATCH 00/30] EDK2 RISC-V

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

> On Nov 8, 2021, at 5:13 PM, Kinney, Michael D > wrote: > > HI Andrew, > > Great feedback. > > What your preferred way to install a tool like this? If we collect that data > from the community, we can make sure the pipeline generates the right type of > installers. > I could not

Re: [edk2-devel] [PATCH V3 14/29] UefiCpuPkg: Enable Tdx support in MpInitLib

On November 5, 2021 2:46 PM, Gerd Hoffmann wrote: > > > Can't you create something in MdePkg/Library/Baselib and then use it > > > everywhere it's needed? > > > > > Do you mean put the basic Tdx functions in MdePkg/Library/BaseLib? If that > > is > the case, then I would add below basic Tdx

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 11/09/2021 #cal-reminder

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [PATCH v2 1/2] ArmPkg: Add SMC helper functions

Could I have some reviews on this please? -- Rebecca Cran On 11/1/21 4:11 PM, Rebecca Cran wrote: Add functions ArmCallSmc0/1/2/3 to do SMC calls with 0, 1, 2 or 3 arguments. The functions return up to 3 values. Signed-off-by: Rebecca Cran --- ArmPkg/Include/Library/ArmSmcLib.h

Re: [edk2-devel] [PATCH v2 4/7] ShellPkg: Add Cache ID to PPTT parser

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chris > Jones > Sent: Wednesday, November 3, 2021 11:41 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > gaolim...@byosoft.com.cn; Liu, Zhiguang ; Ni, Ray > ; Gao, Zhichao ;

Re: [edk2-devel] [PATCH v2 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: Chris Jones > Sent: Wednesday, November 3, 2021 11:41 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > gaolim...@byosoft.com.cn; Liu, Zhiguang ; Ni, Ray > ; Gao, Zhichao ; > alexei.fedo...@arm.com;

Re: [edk2-devel] [PATCH v2 1/7] MdePkg: Add missing Cache ID (in)valid define

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chris > Jones > Sent: Wednesday, November 3, 2021 11:41 PM > To: devel@edk2.groups.io > Cc: Kinney, Michael D ; > gaolim...@byosoft.com.cn; Liu, Zhiguang ; Ni, Ray > ; Gao, Zhichao ;

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

HI Andrew, Great feedback. What your preferred way to install a tool like this? If we collect that data from the community, we can make sure the pipeline generates the right type of installers. Thanks, Mike From: Andrew Fish Sent: Monday, November 8, 2021 5:09 PM To: devel@edk2.groups.io;

回复: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory aggregator/device type mismatch

Yes. I will create PR for this patch. Thanks Liming 发件人: Christopher Jones 发送时间: 2021年11月8日 19:12 收件人: gaoliming ; Samer El-Haj-Mahmoud ; devel@edk2.groups.io 抄送: michael.d.kin...@intel.com; zhiguang@intel.com; Sami Mujawar ; Ben Adderson ; Akanksha Jain ; Matteo Carlini ; nd 主题: Re:

回复: [edk2-devel] Progress on getting Uncrustify working for EDK2?

Mike： I add my comments below. 发件人: devel@edk2.groups.io 代表 Michael D Kinney 发送时间: 2021年11月9日 8:24 收件人: Andrew Fish ; Marvin Häuser ; Kinney, Michael D ; Michael Kubacki 抄送: edk2-devel-groups-io ; Leif Lindholm ; mikub...@linux.microsoft.com; rebe...@nuviainc.com; Bret Barkelew 主题:

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

MIke, I could not figure out how to download uncrustify tool from the provided link. 99% of the people are just going to want to install the tool, not be a developer of the fork. We should have some simple instructions on how to download the tool. The link points to something git web view

回复: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Pierre: Got it. I will remove it. Thanks Liming > -邮件原件- > 发件人: Pierre Gondois > 发送时间: 2021年11月8日 21:55 > 收件人: devel@edk2.groups.io; gaolim...@byosoft.com.cn > 抄送: 'Kinney, Michael D' ; 'Teng, Lynn L' > ; af...@apple.com; l...@nuviainc.com > 主题: Re: [edk2-devel] Soft Feature Freeze

Re: [edk2-devel] [PATCH V5 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

Hi, Sami Please see my comments inline. From: Sami Mujawar Sent: Monday, November 8, 2021 10:18 PM To: Xu, Min M ; devel@edk2.groups.io Cc: Kinney, Michael D ; Liming Gao ; Liu, Zhiguang ; Yao, Jiewen ; Wang, Jian J ; Gerd Hoffmann ; nd Subject: Re: [PATCH V5 2/3] SecurityPkg: Support

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

Hello, Good information in this thread on code style. Some of the topics apply to uncrustify and some are out of scope for what uncrustify can fix on its own. I would like to focus on a date to convert all source code in edk2 repo using the uncrustify tool and to capture the other code style

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Folks, We are able to resolve the __ModuleEntryPoint error and was able to run below build configurations locally. * Windows_VS2019 - Passed * EmulatorPkg_Win_VS2019 - Passed * OvmfPkg_Win_VS2019 - Passed * Ubuntu_GCC5 - Passed * ArmVirtPkg_Ubuntu_GCC5 - Passed * EmulatorPkg_Ubuntu_GCC5 -

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

On 11/8/21 09:43, Stefan Berger wrote: On 11/8/21 07:13, Yao, Jiewen wrote: The PPFlag variable MUST to be locked to prevent malicious modification. Otherwise, anyone can change the PP configuration without confirmation from end user. That change by an attacker could presumably only  be

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

Marvin, Thanks for the question! You’re right, I need to squash this patch into the applicable patches in the series so that the build fixes are present when the initial changes are added (to maintain bisectability). Surprised no one had mentioned it yet.  I would actually be happy to keep

Re: [edk2-devel] [Patch V2 5/7] NetworkPkg: Reproduce builds across source format changes

Hey Mike, Reviewed-by: Maciej Rabeda Thanks, Maciej On 01-Nov-21 22:37, Michael D Kinney wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3688 Use DEBUG_LINE_NUMBER instead of __LINE__. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Cc: Michael Kubacki Signed-off-by: Michael D

Re: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

Hi Liming, I have checked with Team member , Totally We need support 50+ Driver GUID in DevicePath PCD value ，So the length need to increase again, I will change the Patch and re-send again. Thanks! -Original Message- From: Jiang, Xiaolu Sent: Monday, November 8, 2021 9:24 AM To:

Re: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

1. Currently the PCD value length is More than 1024, less than 2048, 2. Now we have 14 members, Also need to add 4~6 part to the PCD. So we Increase the length to 4096. -Original Message- From: gaoliming Sent: Monday, November 8, 2021 9:15 AM To: Jiang, Xiaolu ; devel@edk2.groups.io

Re: [edk2-devel][PATCH] BaseTools: Increase the DevicePath length for support more PCD value.

Hi Liming, It's a good suggestion, I will try it first, Thanks ! -Original Message- From: gaoliming Sent: Monday, November 8, 2021 11:18 AM To: Jiang, Xiaolu ; devel@edk2.groups.io Cc: Feng, Bob C ; Chen, Christine ; Fu, Siyuan Subject: 回复: [edk2-devel][PATCH] BaseTools: Increase the

[edk2-devel] [Patch 1/1] OvmfPkg/Xen: Fix VS2019 build issues

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3722 Fix VS2019 NOOPT build issues related to converting a larger integer value to a smaller integer value. Cc: Anthony Perard Cc: Julien Grall Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Michael D

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

On 11/8/21 07:13, Yao, Jiewen wrote: The PPFlag variable MUST to be locked to prevent malicious modification. Otherwise, anyone can change the PP configuration without confirmation from end user. That change by an attacker could presumably only  be done via UEFI shell/command line? How do I

Re: [edk2-devel] [PATCH V5 3/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpmMeasurementLib

Hi Min, Thank you for the updated patch. I have a minor suggestion marked inline as [SAMI]. Otherwise, these changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 07/11/2021 12:35 PM, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625

Re: [edk2-devel] [PATCH V5 2/3] SecurityPkg: Support CcMeasurementProtocol in DxeTpm2MeasureBootLib

Hi Min, Thank you for the updated patch. I have a minor suggestion marked inline as [SAMI]. Otherwise, this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 07/11/2021 12:35 PM, Min Xu wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3625

Re: [edk2-devel] [PATCH] UefiCpuPkg: Fix CPU stack guard support by aligning GDT buffer

On Fri, Nov 5, 2021 at 7:37 PM Vitaly Cheptsov wrote: > > Hi Leif, > > I assume you mean the commit description, because the commit message is in the topic. A topic is not a commit message. The commit message is what comes after the topic. > I believe something like that would do: > >

Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Hi Liming, The "Add SSDT PCI generator in DynamicTablesPkg" feature at https://bugzilla.tianocore.org/show_bug.cgi?id=3682 won't be merged before hard feature freeze, so I think it should be removed from the list of proposed features, Regards, Pierre On 11/5/21 05:53, gaoliming via groups.io

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

The PPFlag variable MUST to be locked to prevent malicious modification. Otherwise, anyone can change the PP configuration without confirmation from end user. Thank you Yao Jiewen > -Original Message- > From: Gerd Hoffmann > Sent: Monday, November 8, 2021 7:58 PM > To: Stefan Berger

Re: [edk2-devel] [PATCH v2 3/4] OvmfPkg: Enable physical presence interface for TPM 1.2

On Sat, Nov 06, 2021 at 09:19:33PM -0400, Stefan Berger wrote: > > On 11/5/21 08:17, Gerd Hoffmann wrote: > > On Tue, Nov 02, 2021 at 11:49:09AM -0400, Stefan Berger wrote: > > > Enable the physical presence interface for TPM 1.2. It is required for the > > > TPM 1.2 menu to work. > > > > > >

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

Hi, > From the above point of view, your speculation is right. excellent! > In this way, if a QXL device wants to work on ARM, the io window of the > bridge it is mounted on must be allocated as -0fff [size=4K]. That doesn't solve the cache attribute issues though ... > In my

Re: [edk2-devel] [PATCH v1 1/1] MdePkg: Fix ACPI memory aggregator/device type mismatch

Hi, It looks like this patch has received the relevant approvals and is ready for merge. Could this patch please be merged in time for the edk2-stable202111 release. Thanks, Chris From: gaoliming Sent: Friday, October 8, 2021 3:09 AM To: Samer El-Haj-Mahmoud ;

Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Add comment that ItemPtr is set after validation

Hi, It looks like this patch has recieved the relevant approvals and is ready for merge. Could this patch please be merged in time for the edk2-stable202111 release. Thanks, Chris From: Gao, Zhichao Sent: Thursday, October 28, 2021 4:15 AM To: Sami Mujawar ;

Re: [edk2-devel] [PATCH v4 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation

On Wed, Oct 27, 2021 at 08:28 AM, PierreGondois wrote: > > Hi Khasim, > > + Sami > > Thanks for the new patch-set, everything looks good to me: > > Reviewed-by: Pierre Gondois Hi all, As we have entered the soft freeze phase, I would like to provide additional info to the edk2 community

Re: [edk2-devel] [PATCH v5 4/7] Platform/ARM/N1Sdp: Enable N1Sdp platform specific configurations

Hi Khasim, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/11/2021 02:21 PM, Khasim Mohammed via groups.io wrote: This patch adds PCDs and updates the fdf file for N1Sdp platform specific configurations. Signed-off-by: Deepak Pandey Signed-off-by: Khasim

Re: [edk2-devel] [PATCH v5 3/7] Platform/ARM/N1Sdp: Introduce platform DXE driver

Hi Khasim, Other than a few minor code alignment issues (which I will fix before pushing), this patch looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/11/2021 02:21 PM, Khasim Mohammed via groups.io wrote: Add an initial platform DXE driver and support for ramdisk

Re: [edk2-devel] [PATCH v5 2/7] Silicon/ARM/NeoverseN1Soc: Define new PCDs and configure memory map

Hi Khasim, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/11/2021 02:21 PM, Khasim Mohammed via groups.io wrote: This patch introduces new PCDs required to enable chip to chip interface and corresponding memory map is updated. Signed-off-by: Chandni

Re: [edk2-devel] [PATCH v5 1/7] Silicon/ARM/NeoverseN1Soc: Fix missing function documentation

Hi Khasim, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 05/11/2021 02:21 PM, Khasim Mohammed via groups.io wrote: This patch adds missing documentation for few of the functions and fixes few formatting changes. Signed-off-by: Khasim Syed Mohammed ---

Re: [edk2-devel] The arm virtual machine displays problems in QXL during the UEFI phase

Hi Gerd: Thanks for your reply. >1. I wonder why the device display be normal when it hung on >bus=pci.8,addr=0x0, but it is abnormal when bus=pci.9,addr=0x1 or >bus=pci.7,addr=0x0. > Placing qxl behind a pci bridge is problematic too (even on x86). > I'm surprised it works at all. qxl needs

Re: [edk2-devel] [PATCH v2] MdeModulePkg\UfsBlockIoPei: UFS MMIO address size support both 32/64 bits

> -Original Message- > From: devel@edk2.groups.io On Behalf Of > ian.c...@intel.com > Sent: Friday, November 5, 2021 5:46 PM > To: devel@edk2.groups.io > Cc: Chiu, Ian ; Chiu, Ian ; Chu, > Maggie ; Ni, Ray ; Wu, Hao A > > Subject: [edk2-devel] [PATCH v2] MdeModulePkg\UfsBlockIoPei: UFS