Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.dsc:Add BootManagerLib for BootManagerMenuApp

Reviewed-by: Zhiguang Liu From: devel@edk2.groups.io on behalf of Ning Feng Sent: Thursday, November 18, 2021 18:09 To: devel@edk2.groups.io Cc: Feng, Ning ; Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [edk2-devel] [PATCH]

Re: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

Acked-by: Michael D Kinney michael.d.kin...@intel.com From: devel@edk2.groups.io On Behalf Of Pedro Falcato Sent: Thursday, November 18, 2021 12:31 PM To: edk2-devel-groups-io ; Pedro Falcato Cc: Leif Lindholm ; Kinney, Michael D Subject: Re: [edk2-devel]

Re: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

Hi Liming, Thanks for the RB :) I'll be pushing this soon. Ext4Dxe at the moment only supports ext4 due to a lack of need for ext2/3 (since ext4 itself is already decently old), but with a bit of work it can support all the previous ext's. If you have a need for it, feel free to let me know and

回复: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

Pedro： I review this patch. This change looks good. Reviewed-by: Liming Gao Besides, I want to confirm whether Ext4Dxe support Ext2/Ext3/Ext4 file system or only Ext4 file system. Thanks Liming 发件人: devel@edk2.groups.io 代表 Pedro Falcato 发送时间: 2021年11月19日 4:31 收件人:

[edk2-devel] [PATCH v4] OvmfPkg: Remove unused print service driver (PrintDxe)

From: Philippe Mathieu-Daude PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, and those are consumed by the following PrintLib instance: MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf However, none of the OVMF DSC files contain such a PrintLib

Re: [edk2-devel] [edk2-platforms PATCH] Ext4Pkg: Add uninitialized extents support

It's been over two weeks and a quick Rb would be great, since this patch is relatively trivial and it would fix a bug. Again, if I'm doing anything wrong, please let me know. Thanks, Pedro On Mon, Nov 1, 2021 at 9:29 PM Pedro Falcato wrote: > Quick PS: I CC'd the edk2-platforms stewards on

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi Folks, Sorry for the delay in my response. Thanks for the inputs. My bad for not understanding what Jiewen was referring to, I think he is suggesting to remove the unused algorithms with in the ECC cipher. Not removing already available ciphers. Totally makes sense but it would involve more

[edk2-devel] [PATCH v2 14/15] DynamicTablesPkg: Add FdtHwInfoParser library

From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. FdtHwInfoParser library is an

[edk2-devel] [PATCH v2 15/15] DynamicTablesPkg: Handle 16550_WITH_GAS id

From: Pierre Gondois Handle the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_16550_WITH_GAS id when generating an AML description of a serial port. The same _HID/_CID as the EFI_ACPI_DBG2_PORT_SUBTYPE_SERIAL_FULL_16550 are generated. Signed-off-by: Pierre Gondois --- Notes: v2: - New patch.

[edk2-devel] [PATCH v2 13/15] DynamicTablesPkg: FdtHwInfoParser: Add PCI config parser

From: Pierre Gondois On platforms that implement PCIe, the PCIe configuration space information must be described to a standards-based operating system in the Memory mapped configuration space base address Description (MCFG) table. The PCIe information is described in the platform Device Tree,

[edk2-devel] [PATCH v2 12/15] DynamicTablesPkg: FdtHwInfoParser: Add GIC dispatcher

From: Pierre Gondois The GIC Dispatcher is the top-level component that is responsible for invoking the respective parsers for GICC, GICD, GIC MSI Frame, GIC ITS and the GICR. Signed-off-by: Pierre Gondois --- .../FdtHwInfoParserLib/Gic/ArmGicDispatcher.c | 212 ++

[edk2-devel] [PATCH v2 10/15] DynamicTablesPkg: FdtHwInfoParser: Add ITS parser

From: Pierre Gondois Arm GIC v3/v4 optionally includes support for GIC Interrupt Translation Service (ITS). The GIC ITS Structure is part of the Multiple APIC Description Table (MADT) that describes the GIC Interrupt Translation service to the OS. The GIC Interrupt Translation Service

[edk2-devel] [PATCH v2 11/15] DynamicTablesPkg: FdtHwInfoParser: Add GICR parser

From: Pierre Gondois The GIC Redistributor (GICR) structure is part of the Multiple APIC Description Table (MADT) that enables the discovery of GIC Redistributor base addresses by providing the Physical Base Address of a page range containing the GIC Redistributors. More than one GICR Structure

[edk2-devel] [PATCH v2 09/15] DynamicTablesPkg: FdtHwInfoParser: Add MSI Frame parser

From: Pierre Gondois Arm GIC version 2 systems that support Message Signalled Interrupts implement GICv2m MSI frame(s). Each GICv2m MSI frame consists of a 4k page which includes registers to generate message signalled interrupts to an associated GIC distributor. The frame also includes

[edk2-devel] [PATCH v2 08/15] DynamicTablesPkg: FdtHwInfoParser: Add GICD parser

From: Pierre Gondois On ARM-based systems the Generic Interrupt Controller (GIC) manages interrupts on the system. Each interrupt is identified in the GIC by an interrupt identifier (INTID). ACPI GSIVs map one to one to GIC INTIDs for peripheral interrupts, whether shared (SPI) or private (PPI).

[edk2-devel] [PATCH v2 07/15] DynamicTablesPkg: FdtHwInfoParser: Add GICC parser

From: Pierre Gondois The GIC CPU Interface (GICC) structure is part of the Multiple APIC Description Table (MADT) that describes the interrupt model for the platform. The MADT table is a mandatory table required for booting a standards-based operating system. Arm requires the GIC interrupt

[edk2-devel] [PATCH v2 06/15] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

From: Pierre Gondois The Microsoft Debug Port Table 2 (DBG2), the Serial Port Console Redirector (SPCR) table are mandatory tables required for booting a standards-based operating system. The DBG2 table is used by the OS debugger while the SPCR table is used to configure the serial terminal.

[edk2-devel] [PATCH v2 05/15] DynamicTablesPkg: FdtHwInfoParser: Generic Timer Parser

From: Pierre Gondois The Generic Timer Description Table (GTDT) is a mandatory table required for booting a standards-based operating system. It provides an OSPM with information about a system's Generic Timer configuration. The Generic Timer (GT) is a standard timer interface implemented on ARM

[edk2-devel] [PATCH v2 04/15] DynamicTablesPkg: FdtHwInfoParser: Add Boot Arch parser

From: Pierre Gondois The Fixed ACPI Description Table (FADT) is a mandatory table required for booting a standards-based operating system. The FADT table has an 'ARM Boot Architecture Flags' field that is used by an OS at boot time to determine the code path during boot. This field is used to

[edk2-devel] [PATCH v2 03/15] DynamicTablesPkg: FdtHwInfoParser: Add FDT utility functions

From: Pierre Gondois The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects. Therefore, add a set of helper functions to simplify parsing of the platform Device Tree. Signed-off-by: Pierre Gondois ---

[edk2-devel] [PATCH v2 02/15] DynamicTablesPkg: FdtHwInfoParser: CM Object descriptor helper

From: Pierre Gondois FdtHwInfoParserLib is an instance of the HwInfoParser. The FdtHwInfoParser parses a platform Device Tree and populates the Platform Information repository with Configuration Manager objects that describe the platform hardware. These Configuration Manager objects are

[edk2-devel] [PATCH v2 01/15] DynamicTablesPkg: Definition for HwInfoParser interface

From: Pierre Gondois Hardware information parser is an optional module defined by the Dynamic Tables Framework. It can either parse an XML, a Device Tree or a Json file containing the platform hardware information to populate the platform information repository. The Configuration Manager can

[edk2-devel] [PATCH v2 00/15] Implement a FdtHwInfoParserLib

From: Pierre Gondois v2: - Handle absence of Pci legacy interrupts in Pci parser. [Pierre] - Handle Affinity3 field in GicC parser. [Sami] - Add pl011 compatible string in serial port parser. [Sami] - Use 16550_with_GAS ID when 16550 is detected in serial port parser. [Sami] - Use

[edk2-devel] [PATCH v3 8/8] DynamicTablesPkg: Fix multiple objects parsing

From: Pierre Gondois When a CmObjDesc contains multiple objects, only the first one is parsed as the buffer doesn't progress. Fix this. Also check that the whole buffer has been parsed with an asset. Signed-off-by: Pierre Gondois --- .../ConfigurationManagerObjectParser.c | 13

[edk2-devel] [PATCH v3 7/8] DynamicTablesPkg: SSDT Pci express generator

From: Pierre Gondois This generator allows to generate a SSDT table describing a Pci express Bus. It uses the following CmObj: - EArmObjCmRef - EArmObjPciConfigSpaceInfo - EArmObjPciAddressMapInfo - EArmObjPciInterruptMapInfo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682 To: Sami

[edk2-devel] [PATCH v3 6/8] DynamicTablesPkg: Add Pci related objects

From: Pierre Gondois Introduce the following CmObj in the ArmNameSpaceObjects: - CM_ARM_PCI_ADDRESS_MAP_INFO - CM_ARM_PCI_INTERRUPT_MAP_INFO These objects allow to describe address range mapping of Pci busses and interrupt mapping of Pci devices. To: Sami Mujawar To: Alexei Fedorov

[edk2-devel] [PATCH v3 4/8] DynamicTablesPkg: AML Code generation to add _PRT entries

From: Pierre Gondois _PRT entries can describe interrupt mapping for Pci devices. The object is described in ACPI 6.4 s6.2.13 "_PRT (PCI Routing Table)". Add AmlCodeGenPrtEntry() helper function to add _PRT entries to an existing _PRT object. To: Sami Mujawar To: Alexei Fedorov Reviewed-by:

[edk2-devel] [PATCH v3 5/8] DynamicTablesPkg: Add AmlAttachNode()

From: Pierre Gondois This function allows to add a node as the last node of a parent node in an AML tree. For instance, ASL code corresponding to NewNode: Name (_UID, 0) ASL code corresponding to ParentNode: Device (PCI0) { Name(_HID, EISAID("PNP0A08")) } "AmlAttachNode (ParentNode,

[edk2-devel] [PATCH v3 1/8] DynamicTablesPkg: AML Code generation for memory ranges

From: Pierre Gondois Add helper functions to generate AML Resource Data describing memory ranges. Memory ranges can be one, double or four words long. They can be of 'normal', IO or bus number memory type. The following APIs are exposed: - AmlCodeGenRdDWordIo () - AmlCodeGenRdDWordMemory () -

[edk2-devel] [PATCH v3 3/8] DynamicTablesPkg: AML Code generation to create a named ResourceTemplate()

From: Pierre Gondois Add AmlCodeGenNameResourceTemplate() to generate code for a ResourceTemplate(). AmlCodeGenNameResourceTemplate ("REST", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(REST, ResourceTemplate () {}) To: Sami Mujawar To: Alexei Fedorov

[edk2-devel] [PATCH v3 2/8] DynamicTablesPkg: AML Code generation to create a named Package()

From: Pierre Gondois Add AmlCodeGenNamePackage() to generate code for a Package(). AmlCodeGenNamePackage ("PACK", ParentNode, NewObjectNode) is equivalent of the following ASL code: Name(PACK, Package () {}) To: Sami Mujawar To: Alexei Fedorov Reviewed-by: Sami Mujawar Signed-off-by:

[edk2-devel] [PATCH v3 0/8] Create a SSDT PCIe generator

From: Pierre Gondois REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3682 As part of the DynamicTablesPkg, add a generator creating a SSDT table describing a PCIe bus. This patch-set also adds new functions to generate AML bytecode in the AmlLib. The changes can be seen at:

[edk2-devel] [PATCH v3] IntelSiliconPkg/BaseConfigBlockLib: Add function to iterate over Config Blocks

In BaseConfigBlockLib add function to get next config block from config blocks table in order to iterate over blocks of the same type. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3700 Signed-off-by: Jakub Fedorowicz mailto:jakub.fedorow...@intel.com Cc: Ray Ni mailto:ray...@intel.com

Re: [edk2-devel] [edk2-platforms][PATCH v6 11/30] AmpereAltraPkg: Add Ac01PcieLib library instance

On Thu, Nov 18, 2021 at 20:41:15 +0700, Nhi Pham via groups.io wrote: > From: Vu Nguyen > > Provides essential functions to initialize the PCIe Root Complex on > Ampere Altra processor. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc:

[edk2-devel] [edk2platforms][PATCH v3 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

Added IntelDieInfo header into IntelSiliconPkg tree. The purpose is to have generic and unified interface for getting information about dies installed in the system. It will be implemented by silicon code. Cc: Ray Ni Cc: Rangasai V Chaganty Signed-off-by: Maciej Czajkowski --- Notes: v3:

[edk2-devel] [edk2platforms][PATCH v3 0/1] IntelSiliconPkg: Add IntelDieInfoProtocol

This commit will add a protocol/PPI definition which will provide a generic and unified way to get information about dies installed in the system(PCH, SoC, CPU). It will be implemented per generation in silicon packages. v3 changes: - added EDKII_ prefix to interface - removed GUID definitons

Re: [edk2-devel] [edk2-platforms][PATCH v5 00/30] Add new Ampere Mt. Jade platform

On Thu, Nov 18, 2021 at 20:45:15 +0700, Nhi Pham wrote: > On 18/11/2021 20:02, Leif Lindholm wrote: > > Hi Nhi, > > > > 9/10 cannot be merged at this point, because that one is dependent on > > "EmbeddedPkg/AcpiLib: Add more helper functions" to be merged into > > edk2, which is currently in hard

Re: [edk2-devel] [edk2-platforms][PATCH v5 00/30] Add new Ampere Mt. Jade platform

On 18/11/2021 20:02, Leif Lindholm wrote: Hi Nhi, 9/10 cannot be merged at this point, because that one is dependent on "EmbeddedPkg/AcpiLib: Add more helper functions" to be merged into edk2, which is currently in hard freeze. But if you'd like, I'm happy for 1-8/30 to be merged at this

[edk2-devel] [edk2-platforms][PATCH v6 11/30] AmpereAltraPkg: Add Ac01PcieLib library instance

From: Vu Nguyen Provides essential functions to initialize the PCIe Root Complex on Ampere Altra processor. Cc: Thang Nguyen Cc: Chuong Tran Cc: Phong Vo Cc: Leif Lindholm Cc: Michael D Kinney Cc: Ard Biesheuvel Cc: Nate DeSimone Signed-off-by: Nhi Pham --- Changes since v5: * Fixed

Re: [edk2-devel] [edk2-platforms][PATCH v5 11/30] AmpereAltraPkg: Add Ac01PcieLib library instance

On 18/11/2021 19:33, Leif Lindholm wrote: Hi Nhi, On Wed, Nov 17, 2021 at 23:47:08 +0700, Nhi Pham wrote: From: Vu Nguyen Provides essential functions to initialize the PCIe Root Complex on Ampere Altra processor. The NOOPT build fails for me with

Re: [edk2-devel] [edk2-platforms][PATCH v5 15/30] AmpereAltraPkg: Add PciSegmentLib library instance

On Wed, Nov 17, 2021 at 23:47:12 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provides functions to handle the PCIe configuration requests. The target > Root Complex is selected based on the segment number parsed from the input > address. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo

Re: [edk2-devel] [edk2-platforms][PATCH v5 00/30] Add new Ampere Mt. Jade platform

Hi Nhi, 9/10 cannot be merged at this point, because that one is dependent on "EmbeddedPkg/AcpiLib: Add more helper functions" to be merged into edk2, which is currently in hard freeze. But if you'd like, I'm happy for 1-8/30 to be merged at this point. Best Regards, Leif On Wed, Nov 17, 2021

Re: [edk2-devel] [edk2-platforms][PATCH v5 02/30] AmpereAltraPkg: Add FlashLib library instance

On Wed, Nov 17, 2021 at 23:46:59 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provides functions to access the NVRAM, NVRAM2 and FailSafe region on the > Flash over MM communication. > > Cc: Thang Nguyen > Cc: Chuong Tran > Cc: Phong Vo > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Ard

Re: [edk2-devel] [edk2-platforms][PATCH v5 11/30] AmpereAltraPkg: Add Ac01PcieLib library instance

Hi Nhi, On Wed, Nov 17, 2021 at 23:47:08 +0700, Nhi Pham wrote: > From: Vu Nguyen > > Provides essential functions to initialize the PCIe Root Complex on > Ampere Altra processor. The NOOPT build fails for me with

Re: [edk2-devel] [PATCH] OvmfPkg/AmdSev: Erase secret area content on ExitBootServices

Please don't merge this. We're going in a different direction, see https://edk2.groups.io/g/devel/message/83853 . Instead of letting the guest kernel copy the secret content and OVMF will erase the original (the patch below), we mark the area as "reserved" (in OVMF) and then the OS doesn't

[edk2-devel] [PATCH] OvmfPkg/AmdSev/SecretPei: Mark SEV launch secret area as reserved

Mark the SEV launch secret MEMFD area as reserved, which will allow the guest OS to use it during the lifetime of the OS, without creating copies of the sensitive content. Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Brijesh Singh Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen

Re: [edk2-devel] [PATCH v2 1/1] ShellPkg/AcpiView: PrintFormatter for FADT Flags field

Hi Abdul, Thank you for implementing the suggestion. Pleas find my feedback inline marked [SAMI]. Regards, Sami Mujawar On 17/11/2021 12:29 PM, Abdul Lateef Attar wrote: Adds PrintFormatter function to the FADT flags field. Prints indivisual flag name along with flag value. Adds new parser

Re: [edk2-devel] [PATCH v1 06/14] DynamicTablesPkg: FdtHwInfoParser: Add Serial port parser

Hi Sami, Please find my answer inlined: On 11/5/21 14:27, Sami Mujawar wrote: > > Hi Pierre, > > Please find my response inline marked [SAMI]. > > Regards, > > Sami Mujawar > > > On 23/06/2021 01:38 PM, pierre.gond...@arm.com wrote: >> From: Pierre Gondois >> >> The Microsoft Debug Port Table 2

[edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.dsc:Add BootManagerLib for BootManagerMenuApp

Add PlatformBootManagerLibconstructor for BootManagerMenuApp, to get the value PcdBootManagefile overrided by platform side. Signed-off-by: Ning Feng Cc: Guo Dong Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You --- UefiPayloadPkg/UefiPayloadPkg.dsc | 6 -- 1 file changed, 4 insertions(+), 2

Re: [edk2-devel] [PATCH V3 15/29] OvmfPkg: Update SecEntry.nasm to support Tdx

Comment on config-B. > -Original Message- > From: Gerd Hoffmann > Sent: Wednesday, November 17, 2021 11:20 PM > To: Xu, Min M > Cc: devel@edk2.groups.io; Ard Biesheuvel ; Justen, > Jordan L ; Brijesh Singh ; > Erdem Aktas ; James Bottomley > ; Yao, Jiewen ; Tom Lendacky > > Subject:

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.dsc:Add BootManagerLib for BootManagerMenuApp

We only need the constructor of this Lib to override the value patchable PcdBootManagefile. Null Lib will only link the constructor. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83848): https://edk2.groups.io/g/devel/message/83848

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.dsc:Add BootManagerLib for BootManagerMenuApp

+ MdeModulePkg/Application/BootManagerMenuApp/BootManagerMenuApp.inf { + + NUll|UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf 1. NULL? -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#83847):