Re: [edk2-devel] [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs that depend on UefiCpuLib.

2022-04-05 Thread Chiu, Chasel
Thanks Yu! Reviewed-by: Chasel Chiu > -Original Message- > From: Pu, Yu > Sent: Friday, April 1, 2022 1:22 PM > To: devel@edk2.groups.io > Cc: Pu, Yu ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v1 2/6] IntelFsp2WrapperPkg: Add CpuLib to module INFs >

Re: [edk2-devel] [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that depend on UefiCpuLib

2022-04-05 Thread Chiu, Chasel
Thanks Yu! Reviewed-by: Chasel Chiu > -Original Message- > From: Pu, Yu > Sent: Friday, April 1, 2022 1:22 PM > To: devel@edk2.groups.io > Cc: Pu, Yu ; Chiu, Chasel ; > Desimone, Nathaniel L ; Zeng, Star > > Subject: [PATCH v1 1/6] IntelFsp2Pkg: Add CpuLib to module INFs that >

Re: [edk2-devel] [Patch V4] NetworkPkg: Add PCDs for HTTP DNS RetryCount and RetryInterval

2022-04-05 Thread Heng Luo
Dear Maintainers, Could you review the patch? All checks have passed the EDK2 CI build. https://github.com/tianocore/edk2/pull/2717 Thanks, Heng > -Original Message- > From: devel@edk2.groups.io On Behalf Of Heng Luo > Sent: Sunday, April 3, 2022 2:14 PM > To: devel@edk2.groups.io > Cc:

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 04/05/2022 #cal-reminder

2022-04-05 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20220317T223602Z

[edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove MU_CHANGE comment markers

2022-04-05 Thread Michael Kubacki
From: Michael Kubacki MU_CHANGE tags are used in a different project (Project Mu) to highlight deviations from Tianocore. Therefore, the comments are not needed when the changes are present in a Tianocore repository. Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang

Re: [edk2-devel] need help - edk2 build issue

2022-04-05 Thread Pedro Falcato
Hi, It looks like the assembler is failing. Do you have an up-to-date NASM? I remember that some distros' NASMs aren't supported by edk2, which requires a fairly recent one (2.15.05) Best regards, Pedro On Tue, Apr 5, 2022 at 10:25 PM Ghorai, Sukumar wrote: > Hi, > > would you pl help me to

Re: [edk2-devel] need help - edk2 build issue

2022-04-05 Thread Andrew Fish via groups.io
Sukumar, The LongJump.iii is just the nasm file after it has been post processed you should be able to look at it. If I look at mine I see. 44: rdsspq rax ... 49:incsspq rax Those are some funky x86 instructions maybe your nasm is too old? This should be the required version I

[edk2-devel] [PATCH] BaseTools: Add python version of GenCrc32

2022-04-05 Thread artem . khakimov
From: Artem Khakimov Add GenCrc32 python tool, add tests, switch BinWrappers and BinPipWrappers to GenCrc32.py Cc: Bob Feng Cc: Olga Artemeva Cc: Vadim Mikheev Cc: Alexander Larionov Signed-off-by: Artem Khakimov --- BaseTools/BinPipWrappers/PosixLike/GenCrc32 | 41 ++--

Re: [edk2-devel] need help - edk2 build issue

2022-04-05 Thread Ghorai, Sukumar
Hi, would you pl help me to resolve this edk2 build issue (TOT codebase)? sghorai@sghorai-desk3:~/work/edk2-tianocore/edk2-april05/edk2$ build -p UefiPayloadPkg/UefiPayloadPkg.dsc -a IA32 -a X64 -t GCC5 -D BOOTLOADER=COREBOOT Build environment: Linux-5.13.0-35-generic-x86_64-with-glibc2.29

Re: [edk2-devel] GSoC 2022: Add S3 resume support to MinPlatform

2022-04-05 Thread Benjamin Doron
Hi, I'm looking for feedback on a proposal for a large project. I intend to implement S3 resume for MinPlatform (medium project) and develop closed chassis debug over an HDMI cable as an additional project to assist the bringup work. Commonly, serial ports in laptops are either difficult to access

[edk2-devel] [PATCH v8 6/6] OvmfPkg/AmdSevDxe: Add support for SEV live migration.

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Check for SEV live migration feature support, if detected setup a new UEFI enviroment variable to indicate OVMF support for SEV live migration. This environment variable is created by UEFI but consumed by the (guest) linux kernel. This is actually part of a 3-way negotiation

[edk2-devel] [PATCH v8 5/6] OvmfPkg/PlatformPei: Mark SEC GHCB page as unencrypted via hypercall

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Mark the SEC GHCB page (that is mapped as unencrypted in ResetVector code) in the hypervisor's guest page encryption state tracking. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- OvmfPkg/PlatformPei/AmdSev.c | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v8 4/6] OvmfPkg/VmgExitLib: Encryption state change hypercall support in VC handler

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Make the #VC handler aware of the page encryption state change hypercall by adding support to check KVM_HC_MAP_GPA_RANGE hypercall and add the additional register values used by hypercall in the GHCB. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra ---

[edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Invoke the hypercall API to notify hypervisor when the page's encryption state changes. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Brijesh Singh Signed-off-by: Ashish Kalra --- .../X64/PeiDxeVirtualMemory.c| 16 1 file

[edk2-devel] [PATCH v8 2/6] OvmfPkg/BaseMemEncryptLib: Hypercall API for page encryption state change

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Add API to issue hypercall on page encryption state change. By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the

[edk2-devel] [PATCH v8 1/6] OvmfPkg/BaseMemEncryptLib: Detect SEV live migration feature.

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra Add support to check if we are running inside KVM HVM and KVM HVM supports SEV Live Migration feature. Cc: Jordan Justen Cc: Ard Biesheuvel Signed-off-by: Ashish Kalra --- OvmfPkg/Include/Library/MemEncryptSevLib.h| 12 .../DxeMemEncryptSevLibInternal.c

[edk2-devel] [PATCH v8 0/6] SEV Live Migration support for OVMF.

2022-04-05 Thread Ashish Kalra via groups.io
From: Ashish Kalra BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3467 By default all the SEV guest memory regions are considered encrypted, if a guest changes the encryption attribute of the page (e.g mark a page as decrypted) then notify hypervisor. Hypervisor will need to track the

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 02/33] FmpDevicePkg: Add LOONGARCH64 architecture for EDK2 CI.

2022-04-05 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:52 PM > To: devel@edk2.groups.io > Cc: Liming Gao ; Michael D Kinney > ; Guomin Jiang ; Wei6 > Xu > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH

Re: [edk2-devel] [staging/LoongArch RESEND PATCH v1 01/33] FatPkg: Add LOONGARCH64 architecture for EDK2 CI.

2022-04-05 Thread Abner Chang
Acked-by: Abner Chang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chao Li > Sent: Wednesday, February 9, 2022 2:52 PM > To: devel@edk2.groups.io > Cc: Ray Ni > Subject: [edk2-devel] [staging/LoongArch RESEND PATCH v1 01/33] FatPkg: Add > LOONGARCH64 architecture for

Re: [edk2-devel] [edk2-platforms PATCH v1 0/1] BoardModulePkg: Copy device path

2022-04-05 Thread Attar, AbdulLateef (Abdul Lateef) via groups.io
[Public] Hi, Could you please review the patch? Thanks AbduL -Original Message- From: devel@edk2.groups.io On Behalf Of Abdul Lateef Attar via groups.io Sent: 15 March 2022 10:16 To: devel@edk2.groups.io Cc: Eric Dong ; Liming Gao Subject: [edk2-devel] [edk2-platforms PATCH v1 0/1]

Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

2022-04-05 Thread Michael D Kinney
Hi Rebecca, I agree this is a good way to run from command line. With the addition of the ignore files feature in the YAML files, you have to make sure the filenames added to files are not in the ignored set and not in BaseTools and not from submodules. If you are working on a specific

Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

2022-04-05 Thread Rebecca Cran
I have the following script for running Uncrustify locally on Linux: ../edk2/.pytool/Plugin/UncrustifyCheck/mu-uncrustify-release_extdep/Linux-x86/uncrustify -c ../edk2/.pytool/Plugin/UncrustifyCheck/uncrustify.cfg -F files --replace --no-backup --if-changed Then I just echo the paths of

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

2022-04-05 Thread Rebecca Cran
Thanks. I hadn't come across that view before. -- Rebecca Cran On 4/5/22 08:46, Michael Kubacki wrote: It is printed in the error log. For your current PR: https://github.com/tianocore/edk2/pull/2744 The results are printed in "Standard_Error_Output.log":

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

2022-04-05 Thread Michael Kubacki
It is printed in the error log. For your current PR: https://github.com/tianocore/edk2/pull/2744 The results are printed in "Standard_Error_Output.log": https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=47584=ms.vss-test-web.build-test-results-tab=346168=100012=attachments These

Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

2022-04-05 Thread Michael Kubacki
In my previous mail, I showed how to see the Uncrustify diff from your server build. This mail is about local execution. I'll start by saying that the easiest way I've found to run Uncrustify locally is as a VS Code plugin. It works on both Linux and Windows and it allows you to easily format

Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

2022-04-05 Thread Michael Kubacki
Before discussing how to see the issues locally, here's how to see them in the pipelines. I will send a separate reply with local details. 1. Go to the build that is failing Uncrustify. I am using this PR for your case: https://github.com/tianocore/edk2/pull/2742 2. Click "Details" I am

Re: [edk2-devel] [PATCH v1 1/1] .pytool/Plugin/UncrustifyCheck: Output file diffs by default

2022-04-05 Thread Rebecca Cran
So your change in 56530dec1105f17455752675e4c90fb859c64836 didn't fix anything, because we don't output TestSuites.xml to the console: if I introduce a code style issue into a branch, CI still only prints the following: PROGRESS - --Running ArmPkg: Uncrustify Coding Standard Test NO-TARGET --

Re: [edk2-devel] [PATCH] OvmfPkg: reserve igd memory by E820

2022-04-05 Thread Corvin Köhne
Hi, > > I don't know if it's possible to extract it from host firmware within > > OS context easily. > > Extracting from firmware updates is probably easier. Good idea but I'll focus on the rest first because I have access to the GOP driver for my systems. > > According to Intel you should ask

Re: [edk2-devel] [PATCH] OvmfPkg: reserve igd memory by E820

2022-04-05 Thread Gerd Hoffmann
On Tue, Apr 05, 2022 at 07:47:38AM +, Corvin Köhne wrote: > Hi, > > > Where does the intel gop driver come from? Extracted from host > > firmware? > > https://projectacrn.github.io/latest/tutorials/gpu-passthru.html#enable-the-gvt-d-gop-driver > > I don't know if it's possible to extract

Re: [edk2-devel] [PATCH] OvmfPkg: reserve igd memory by E820

2022-04-05 Thread Corvin Köhne
Hi, > Where does the intel gop driver come from? Extracted from host > firmware? https://projectacrn.github.io/latest/tutorials/gpu-passthru.html#enable-the-gvt-d-gop-driver I don't know if it's possible to extract it from host firmware within OS context easily. According to Intel you should

Re: [edk2-devel] [PATCH] OvmfPkg: reserve igd memory by E820

2022-04-05 Thread Gerd Hoffmann
Hi, > > First, there is no need to communicate memory regions from the > > hypervisor to the guest. The IGD hardware has registers pointing > > to the opregion and to stolen memory, so the guest can simply > > allocate and initialize memory, then program the registers > > accordingly. Same

[edk2-devel] [edk2-platforms][PATCH V1 1/1] Platform/Sgi: Replace EfiResetSystemLib with ResetSystemLib

2022-04-05 Thread Pranav Madhu
Replace EfiResetSystemLib library with ResetSystemLib library. UEFI ResetSystem() API is implemented in both these libraries, and the implementation is also similar. The code for EfiResetSystemLib will be removed from edk2. Update the platform build description files by replacing EfiResetSystemLib

[edk2-devel] [edk2][PATCH V3 1/1] ArmPkg: Handle warm reboot request correctly

2022-04-05 Thread Pranav Madhu
The warm reboot requests were mapped to cold reboot as the power control module was not capable of handling the warm reboot requests. That has changed now and power control module supports warm reboot. Accordingly, update ArmSmcPsciResetSystemLib and to invoke the PSCI call with parameters for

Re: [edk2-devel] EDK2 CI build error "Uncrustify Coding Standard"

2022-04-05 Thread Ashish Kalra via groups.io
Hi Mike, I am following up on Brijesh's email, i am running the CI tests related to my SEV live migration patches, which i am in process of posting. I am running the CI tests locally and getting errors while building OvmfPkg, my patches include two new header files, error log is copied below.