Hi Liming,
Below is the detail why need this change. If you only care usage. Please jump
to "How to use it" directly.
Why need:
1. Replication build is not new, you can refer https://reproducible-builds.org
for detail
2. The benefit is that 1) make sure the same commit generate same binary so
Thanks Ted for updating patch!
For this patch series, Reviewed-by: Chasel Chiu
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Kuo,
> Ted
> Sent: Wednesday, April 13, 2022 10:43 AM
> To: devel@edk2.groups.io
> Subject: [edk2-devel][PATCH v4 0/8] Support PEI 64bit in
Hi Ted,
Please see my comments below inline.
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Wednesday, April 13, 2022 10:43 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [edk2-devel][PATCH v4 1/8]
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Tuesday, April 12, 2022 5:04 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
>
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Jordan Justen ;
> Jian J Wang ; Ray Ni ; Hao A Wu
> ;
> -Original Message-
> From: Gerd Hoffmann
> Sent: Thursday, April 7, 2022 5:33 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Jordan Justen ;
> Jian J Wang ; Ray Ni ; Hao A Wu
> ; Gerd Hoffmann ; Jiewen Yao
> ; Liming Gao ; Pawel
> Polawski ; Chang, Abner (HPS
On April 13, 2022 5:22 AM, James Bottom wrote:
>
> I'm using a SEC phase which has a TPM driver to experiment with sorting out
> measured boot, which is how I noticed (usually SEC doesn't do MMIO) .
> What I'm seeing is after commit b6b2de884864 ("MdePkg: Support mmio for
> Tdx guest in
Hi Abner,
You pointed out that you attached a patch to your last email, but I didn't find
it, do you forgot to put it? In the current EDK II code repo, I can not find
the patch which you mentioned.
--
Thanks,
Chao
On 4月 8 2022, at 7:26 晚上, "Chang, Abner (HPS SW/FW
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
update smbiosview type 9 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Zhiguang Liu
Cc: Zhichao Gao
Cc: Dandan Bi
Cc: Star Zeng
---
MdePkg/Include/IndustryStandard/SmBios.h | 49 +++-
1 file changed, 48
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3896
update smbiosview type 9 related fileds.
Signed-off-by: Bo Chang Ke
Cc: Ray Ni
Cc: Zhichao Gao
---
.../SmbiosView/PrintInfo.c| 7 +-
.../SmbiosView/QueryTable.c | 237 ++
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added SecFspWrapperPlatformSecLibSample support for X64.
2.Adopted FSPT_ARCH2_UPD in SecFspWrapperPlatformSecLibSample.
3.Moved Fsp.h up one level to be shared across IA32 and X64.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc:
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Add Execute64BitCode to execute 64bit code from long mode directly
in PEI 64bit.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
.../BaseFspWrapperApiLib/FspWrapperApiLib.c| 42
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added SecFspSecPlatformLibNull support for X64.
2.Added X64 support to IntelFsp2Pkg.dsc.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
IntelFsp2Pkg/IntelFsp2Pkg.dsc |
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added FspSecCore support for X64.
2.Bumped FSP header revision to 7 to indicate FSP 64bit is supported.
3.Corrected few typos.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Updated FSP_GLOBAL_DATA and FSP_PLAT_DATA structures to support
both IA32 and X64.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
IntelFsp2Pkg/FspSecCore/SecFsp.c | 2 +-
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added EFIAPI to FspNotifyPhasePeimEntryPoint, SwapStack and
PEI_CORE_ENTRY.
2.Cast FspData from pointer to UINTN and then from UINTN to UINT32.
3.Changed AsmReadEsp to AsmReadStackPointer.
4.Changed the type of the return value of
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
Currently PEI drivers/libraries only support 32bit in IntelFsp2Pkg and
IntelFsp2WrapperPkg. The patches below are needed to support these
drivers/libraries in 64bit.
V2 changes:
1.Change FSPM_UPD_COMMON2 to FSPM_UPD_COMMON_FSP24 in
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3893
1.Added FSPx_ARCH2_UPD structures which support both IA32 and X64.
2.Added FSPx_UPD_COMMON_FSP24 structures.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Cc: Ashraf Ali S
Signed-off-by: Ted Kuo
---
Zhihao:
I remember CI has the check for the package dependency. If this patch passes
CI, seemly this checker doesn't do. You can see DependencyCheck in
MdeModulePkg\MdeModulePkg.ci.yaml.
And, this patch introduces new dependency in VariableStandaloneMm. It has
been used in edk2 platform
Guomin:
Can you introduce DEBUG_FILE_PATH usage? If the developer wants to enable
this feature, how configure DEBUG_FILE_PATH?
Thanks
Liming
> -邮件原件-
> 发件人: Guomin Jiang
> 发送时间: 2022年4月12日 18:25
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney ; Liming Gao
> ; Zhiguang Liu
> 主题:
Michael:
Thanks for your update. Reviewed-by: Liming Gao
for this patch set.
Thanks
Liming
> -邮件原件-
> 发件人: Michael Kubacki
> 发送时间: 2022年4月13日 0:32
> 收件人: gaoliming ; devel@edk2.groups.io
> 抄送: 'Abner Chang' ; 'Andrew Fish'
> ; 'Anthony Perard' ; 'Ard
> Biesheuvel' ; 'Benjamin You'
>
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by: Yu Pu
---
UefiPayloadPkg/UefiPayloadEntry/UefiPayloadEntry.h| 1 -
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c | 1 -
UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c |
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib and all modules
are updated to not depend on this library, remove it completely.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
UefiCpuPkg/Library/BaseUefiCpuLib/BaseUefiCpuLibNull.c | 16 -
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Hao A Wu
Signed-off-by: Yu Pu
---
SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Signed-off-by: Yu Pu
---
OvmfPkg/Sec/SecMain.c | 1 -
OvmfPkg/AmdSev/AmdSevX64.dsc | 1 -
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Ray Ni
Signed-off-by: Yu Pu
---
PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 -
1 file changed, 1 deletion(-)
diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc
b/PcAtChipsetPkg/PcAtChipsetPkg.dsc
index
Because UefiCpuPkg/UefiCpuLib is merged to MdePkg/CpuLib, remove the
dependency of UefiCpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
IntelFsp2Pkg/FspSecCore/FspSecCoreM.inf | 1 -
IntelFsp2Pkg/FspSecCore/SecMain.h | 1 -
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib. This
patch merges UefiCpuPkg/UefiCpuLib to MdePkg/CpuLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Signed-off-by: Yu Pu
---
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Yu Pu
---
There are two libraries: MdePkg/CpuLib and UefiCpuPkg/UefiCpuLib and
UefiCpuPkg/UefiCpuLib will be merged to MdePkg/CpuLib. To avoid build
failure, add CpuLib dependency to all modules that depend on UefiCpuLib.
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Signed-off-by: Yu Pu
---
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3394
Today lots of duplicated code call CPUID and calculates the address
mask. Adding an API named GetPhysicalAddressBits in UefiCpuLib can
solve this problem, but at the same time cause MdeModulePkg depend
on UefiCpuPkg which does not meet
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:CANCELLED
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220317T223602Z
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 08/14] IntelFsp2Pkg: Remove UefiCpuLib from
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 03/14] IntelFsp2WrapperPkg: Add CpuLib to module
Reviewed-by: Chasel Chiu
Thanks,
Chasel
> -Original Message-
> From: Pu, Yu
> Sent: Tuesday, April 12, 2022 10:52 PM
> To: devel@edk2.groups.io
> Cc: Pu, Yu ; Chiu, Chasel ;
> Desimone, Nathaniel L ; Zeng, Star
>
> Subject: [PATCH v2 02/14] IntelFsp2Pkg: Add CpuLib to module INFs
Thank you Mike, I created a PR https://github.com/tianocore/edk2/pull/2770.
Thanks,
Bob
-Original Message-
From: Kinney, Michael D
Sent: Wednesday, April 13, 2022 7:54 AM
To: Feng, Bob C ; devel@edk2.groups.io; Kinney, Michael D
Cc: Sean Brogan ; Bret Barkelew
; Gao, Liming
Reviewed-by: Michael D Kinney
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, April 12, 2022 7:23 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Sean Brogan
> ; Bret Barkelew ;
> Kinney, Michael D ; Gao, Liming
>
> Subject: [Patch] pip-requirements.txt: Update basetools
I'm using a SEC phase which has a TPM driver to experiment with sorting
out measured boot, which is how I noticed (usually SEC doesn't do MMIO)
. What I'm seeing is after commit b6b2de884864 ("MdePkg: Support mmio
for Tdx guest in BaseIoLibIntrinsic") we get a massive slowdown of
about 100x in
I've identified a serious performance regression in recent edk2, so
I've been trying to identify it by bisection, but it seems that the TDX
patches have broken bisection in edk2. You can see this by trying to
checkout b6b2de884864 and build it. It will give you
Active Platform =
Laszlo :
Checked internally and came to know that Aptio BIOS for this platform doesn't
support the serial redirection support during POST.
Thank you
-Manic
-Original Message-
From: Laszlo Ersek
Sent: Friday, April 8, 2022 5:20 AM
To: Manickavasakam Karpagavinayagam ; Gerd Hoffmann
1. Although SmmCpuRendezvousLib in UefiCpuPkg, add SmmRendezvousLib.h into
MdeModulePkg/Include/Library folder bypass the check.
2. The SmmRendezvousLib is a standalone MM library and doesn’t have any DXE
service dependency. It can be used by SMM variable module and MM variable
module.
As the
Hi Liming,
To help move reviews along, I went ahead and sent a v4 patch series with
the following information:
1. More details about when the HOB is required.
2. More details about when the HOB should be installed in the boot flow.
3. A 4 byte reserved field after the "Version" field.
The
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Guo Dong
Cc: Ray Ni
Cc: Maurice Ma
Cc: Benjamin You
Cc: Sean Rhodes
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Anthony Perard
Cc: Ard Biesheuvel
Cc: Brijesh Singh
Cc: Erdem Aktas
Cc: Gerd Hoffmann
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Andrew Fish
Cc: Ray Ni
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Michael Kubacki
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds an instance of VariableFlashInfoLib to the platform build as
it is a new library class introduced in MdeModulePkg.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Sami Mujawar
Cc: Gerd Hoffmann
Cc: Julien Grall
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds support to the UEFI variable fault tolerant write (FTW) drivers
to receive FTW base and size information dynamically via the Variable
Flash Information library.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Updates VariableRuntimeDxe, VariableSmm, and VariableStandaloneMm
to acquire variable flash information from the Variable Flash
Information library.
Cc: Jian J Wang
Cc: Hao A Wu
Cc: Liming Gao
Signed-off-by:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new library class VariableFlashInfoLib that abstracts access
to variable flash information. The instance provided first attempts
to retrieve information from the Variable Flash Info HOB. If that
HOB is not
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
Adds a new GUID that is used to identify a HOB that passes variable
flash information to UEFI variable drivers in HOB consumption phases
such as DXE, Traditional MM, and Standalone MM.
This information was previously
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479
The UEFI variable drivers such as VariableRuntimeDxe, VariableSmm,
VariableStandaloneMm, etc. (and their dependent protocol/library
stack), typically acquire UEFI variable store flash information
with PCDs declared in
I've been working on cleaning up some of the code in ArmPlatformPkg and
have been trying to understand the differences between PrePi and PrePeiCore.
It looks like PrePi was added to save space over PrePeiCore, but I'm
wondering if we still need it? I'm guessing most of the platforms below
could
Thanks for the contribution.
Merged https://github.com/tianocore/edk2/pull/2766
> -Original Message-
> From: Gerd Hoffmann
> Sent: Monday, April 11, 2022 7:25 PM
> To: devel@edk2.groups.io
> Cc: Oliver Steffen ; Pawel Polawski
> ; Wang, Jian J ; Xiaoyu Lu
> ; Yao, Jiewen ; Jiang, Guomin
Synced the basetools patch from edk2 repo to
edk2-basetools repo. Update the basetools pip module version
to the latest.
Signed-off-by: Bob Feng
Cc: Sean Brogan
Cc: Bret Barkelew
Cc: Michael D Kinney
Cc: Liming Gao
---
pip-requirements.txt | 2 +-
1 file changed, 1 insertion(+), 1
Signed-off-by: Gerd Hoffmann
---
.../CompilerIntrinsicsLib.inf | 20 +++
1 file changed, 20 insertions(+)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
b/MdePkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf
index
Implementations for those functions already exist,
so remove them to avoid duplicate symbols.
Signed-off-by: Gerd Hoffmann
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 47 ---
1 file changed, 47 deletions(-)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
Signed-off-by: Gerd Hoffmann
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 22 ---
1 file changed, 22 deletions(-)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
b/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
index d0996d6276bc..3c47bef63c4d 100644
---
Does not exist and is not needed.
Signed-off-by: Gerd Hoffmann
---
MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
b/MdePkg/Library/CompilerIntrinsicsLib/Ia32/Gcc.c
index
Update #if conditions so the 64bit version is picked for X64 too.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by: Ard Biesheuvel
---
MdePkg/Library/CompilerIntrinsicsLib/memcmp_ms.c | 2 +-
MdePkg/Library/CompilerIntrinsicsLib/memcpy_ms.c | 2 +-
It's not an exact match, edk2 expects "BSD-2-Clause-Patent" but
http://opensource.org/licenses/bsd-license.php references in comments
is "BSD-2-Clause".
Guess I need an explicit Intel explicitly agreeing to this even though
that is a rather minor change ...
Signed-off-by: Gerd Hoffmann
---
First step in creating a single, common compiler intrinsics library for
everybody who needs it. Move the ArmPkg library to MdePkg, update all
references. No code changes.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by: Ard Biesheuvel
---
ArmVirtPkg/ArmVirt.dsc.inc
Signed-off-by: Gerd Hoffmann
---
.../{memset_ms.c => types_ms.h} | 29 +--
.../Library/CompilerIntrinsicsLib/memcpy_ms.c | 6 +---
.../CompilerIntrinsicsLib/memmove_ms.c| 6 +---
.../Library/CompilerIntrinsicsLib/memset_ms.c | 6 +---
4 files changed, 4
Copy over unmodified (except for running through uncrustify), from
https://github.com/tianocore/edk2-libc/tree/master/StdLib/LibC/CRT
Signed-off-by: Gerd Hoffmann
---
.../Library/CompilerIntrinsicsLib/Ia32/Gcc.c | 283 ++
.../CompilerIntrinsicsLib/Ia32/lldiv.c| 98
Move intrinsics for ia32 from CryptoPkg/Library/IntrinsicLib
to MdePkg/Library/CompilerIntrinsicsLib. Also move strcmp.
Remove CryptoPkg/Library/IntrinsicLib.
Use MdePkg/Library/CompilerIntrinsicsLib instead.
Update all references.
Signed-off-by: Gerd Hoffmann
Acked-by: Jiewen Yao
Acked-by:
This is an attept to start cleaning up the messy compiler intrinsics
situation. Today we don't have a core intrinsics library, resulting
in everybody creating their own. ArmPkg has one, CryptoPkg has one.
I'm sure there are many more.
This doesn't make sense. Given we can't avoid compiler
Hi Mike,
This patch is yet to be merged. Could you look into this?
Regards,
JP
-Original Message-
From: Kinney, Michael D
Sent: 08 April 2022 23:30
To: Jayaprakash, N ; devel@edk2.groups.io; Kinney,
Michael D
Cc: Frinzell, Aaron
Subject: RE: [edk2-devel] [edk2-libc Patch 1/1]
Hi Abner,
Yes, I think it might be a coincidence, in fact, we have been using the UDK2018
since 2018, and this code are not been modified after adding it.
I think maybe be our are all refer to the ARM architecture. Looking at this
code, the function HandOffToDxeCore just switches from the PEI
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3840
Use DEBUG_FILE_PATH to control ASSERT path
Motivation and Goal:
1. Make replication build more easy and less toolchain dependency
2. Consume the ASSERT string easy for downstream
3. Make code more clear
Cc: Michael D Kinney
Cc: Liming
Hi Abner,
All of the feedback that you pointed out I will fix it in the next version,
thank you!
--
Thanks,
Chao
On 4月 8 2022, at 7:02 晚上, "Chang, Abner (HPS SW/FW Technologist)"
wrote:
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of
--
Thanks,
Chao
On 4月 8 2022, at 5:38 下午, "Chang, Abner (HPS SW/FW Technologist)"
wrote:
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chao Li
> > Sent: Wednesday, February 9, 2022 2:56 PM
> > To: devel@edk2.groups.io
> > Cc: Michael
Hi Anber,
Please check my reply in the mail.
--
Thanks,
Chao
On 4月 8 2022, at 2:25 下午, "Chang, Abner (HPS SW/FW Technologist)"
wrote:
>
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Chao Li
> > Sent: Wednesday, February 9, 2022 2:55 PM
Hi Abner,
Yes, the PE/COFF has been adapted to LoongArch32 and LoongArch64, please refer
to: https://docs.microsoft.com/en-us/windows/win32/debug/pe-format
Hi Abner,
Do I have to remove a "_" at the head and tail? All I found in MdePkg is that
*.h files have two "_" at the head and tail. If you are sure that EDK II coding
style must contain only one "_" at the head and tail, I will modify it.
--
Thanks,
Chao
On 4月 7
Hi,
> > - Io.Base = IoBase;
> > - Io.Limit = IoBase + IoSize - 1;
> > + if (IoSize) {
> > +Io.Base = IoBase;
> > +Io.Limit = IoBase + IoSize - 1;
> > + } else {
> > +Io.Base = MAX_UINT64;
> > +Io.Limit = 0;
> HI Gerd,
> Does the consumer of Io (in PCI_ROOT_BRIDGE
> -Original Message-
> From: Gerd Hoffmann
> Sent: Thursday, April 7, 2022 5:33 PM
> To: devel@edk2.groups.io
> Cc: Leif Lindholm ; Ard Biesheuvel
> ; Jordan Justen ;
> Jian J Wang ; Ray Ni ; Hao A Wu
> ; Gerd Hoffmann ; Jiewen Yao
> ; Liming Gao ; Pawel
> Polawski ; Chang, Abner (HPS
Please correct the commit message which confused me.
It should be "Update the PcdCpuStackGuard to support PcdsPatchableInModule,
PcdsDynamci and PcdsDynamciEx ... ..."
Thanks!
Jeff
fanjianf...@byosoft.com.cn
From: Chen, Gang C
Date: 2022-04-11 18:13
To: devel
CC: guomin.jiang; dandan.bi;
On 32bit protectd mode, is there any impact if PcdCpuStackGuard is set to TRUE?
Even thers is no page table enabling at that time.
Best Regards,
Jeff
fanjianf...@byosoft.com.cn
From: Chen, Gang C
Date: 2022-04-11 22:51
To: Ni, Ray; devel@edk2.groups.io; Liu, Shuo
CC: Jiang, Guomin; Bi,
81 matches
Mail list logo
