Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI *

2022-06-16 Thread Ayush Singh
> The C we have is free standing so there is nothing that is set up for the C language, other than libs the user asked for. It is possible to have freestanding Rust as well, but the current goal of the project is to make it possible to use the standard library for UEFI applications. So, some

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread Kilian Kegel
git clone --recursive https://github.com/tianocore/edk2.git That works! You forgot “—recursive” From: M.T. Sent: Thursday, June 16, 2022 10:19 PM To: devel@edk2.groups.io; Maciej T. Cc: Kinney, Michael

Re: [edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Mike Gerow via groups.io
On Thu, Jun 16, 2022, 17:06 Pedro Falcato wrote: > Hi Mike, > > What's the point of upstreaming firmware for crosvm? Isn't crosvm supposed > to be a "thin" hypervisor that runs the kernel directly? > Yes, the initial goal was for crosvm to be a thin hypervisor, just running the kernel directly,

Re: [edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Pedro Falcato
Hi Mike, What's the point of upstreaming firmware for crosvm? Isn't crosvm supposed to be a "thin" hypervisor that runs the kernel directly? Thanks, Pedro On Fri, Jun 17, 2022 at 12:40 AM Mike Gerow via groups.io wrote: > Hi Folks, > > For the last few months I've been using OVMF with crosvm

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-16 Thread Dionna Glaze via groups.io
> Are you possibly including the memory pinning time (that happens in the > hypervisor before the guest is started) in your measurement? > I might be, sorry. I'd go with your numbers. > This is for 2GB (0x8000) of RAM. If I've done my calculations > correctly for a 1600MHz TSC, that comes

Re: [edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Andrew Fish via groups.io
Mike, FYI you are not subscribed to the mailing list so all your posts require a humans approval, so that is the delay in them showing up.. > On Jun 16, 2022, at 4:29 PM, Mike Gerow via groups.io > wrote: > > Hi Folks, > > For the last few months I've been using OVMF with crosvm >

[edk2-devel] Running OVMF on crosvm

2022-06-16 Thread Mike Gerow via groups.io
Hi Folks, For the last few months I've been using OVMF with crosvm ( https://chromium.googlesource.com/chromiumos/platform/crosvm/+/HEAD/README.md#:~:text=crosvm%20is%20a%20virtual%20machine,on%20the%20Chrome%20OS%20platform. ) to give it the ability to boot a UEFI OS image in a UEFI

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI *

2022-06-16 Thread Andrew Fish via groups.io
> On Jun 16, 2022, at 1:17 PM, Ayush Singh wrote: > > Thanks for the great answer. After some discussion in the zulip [1], I > have some approaches that I will try first. > > As for calling C, EFIABI from Rust, yes, it is quite well supported. > Rust also has a specific EFIABI now, since some

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread M.T.
I spun up a windows 10 pro VM and started from scratch, now I'm consistently hitting a redefinition error. EmulatorPkg built, so it is something with this Brotoli Library Building ... c:\users\user\uefi\edk2\MdeModulePkg\Library\BrotliCustomDecompressLib\BrotliCustomDecompressLib.inf [X64]

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI

2022-06-16 Thread Ayush Singh
Thanks for the great answer. After some discussion in the zulip [1], I have some approaches that I will try first. As for calling C, EFIABI from Rust, yes, it is quite well supported. Rust also has a specific EFIABI now, since some EFI platforms don't use C calling conventions. As for the entry

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread Michael D Kinney
A couple things to get a clean log 1. Try removing your Build dir so we know it is a clean build 2. Use -n 1 option to disable mp build so the log is easier to follow 3. Use -j logfile.txt option to generate a complete log file Mike From: devel@edk2.groups.io On Behalf Of M.T. Sent:

Re: [edk2-devel] [PATCH v3 17/28] SecurityPkg: Add Protected Variable Services

2022-06-16 Thread Judah Vang
Min, I prefer not to do this since there is already 28 patches. The line changes are mostly from the .h and .c files, I do not think there is much benefit from moving the the .inf files to a different patch.  Doing something like that will still leave 5800 lines changes in this patch. Judah

Re: [edk2-devel] [Patch v2 00/28] UEFI variable protection

2022-06-16 Thread Michael Kubacki
Do you have the data below? This is important for platform adoption and would be useful to include in the following section. https://github.com/judahvang/edk2/tree/rpmc-update#platform-integration-considerations Thanks, Michael On 5/16/2022 10:48 PM, Michael Kubacki wrote: Hi Judah, Do

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread M.T.
I get NASM version 2.15 compiled on Jun 27 2020 I bumped it up to the same version you have just in case, several attempts in build and recompiling results in the original error where BrotliCustomDecompressLib fails, but I also now see these two: Building ...

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread Michael D Kinney
Which version of NASM do you have installed? When I run nasm -v, I get the following: NASM version 2.15.05 compiled on Aug 28 2020 Mike From: M.T. Sent: Thursday, June 16, 2022 11:44 AM To: devel@edk2.groups.io; Kinney, Michael D Subject: Re: [edk2-devel] Windows 10 build failing Thanks

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread M.T.
Thanks Michael I did run git submodule update --init when I checked out the repo. I ran it again, and now I'm bouncing between two errors, the original I posted, and when I run build again, I get this, which I thought was addressed with nasm 2.15, what am I missing here? Appreciate the help xp

Re: [edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI

2022-06-16 Thread Andrew Fish via groups.io
> On Jun 16, 2022, at 7:20 AM, Ayush Singh wrote: > > Hello everyone, I wanted to ask if the edk2 build system also links to > crt0-efi, like GNU-EFI? > > If yes, I would also like to see how that is actually implemented. If > not, how does edk2 support custom entry functions? It is possible

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-16 Thread Lendacky, Thomas via groups.io
On 6/16/22 11:44, Dionna Amalie Glaze wrote: A question: is there some performance impact when accepting all memory under 4GB? On SEV-SNP, we accept the HOBs 0-0xA000 and 0x10_-0xC00_, which takes a couple seconds, which is non-negligible. Are you possibly including the memory

Re: [edk2-devel] Windows 10 build failing

2022-06-16 Thread Michael D Kinney
Looks like Brotli submodule code is missing. https://github.com/tianocore/edk2#submodules Mike From: devel@edk2.groups.io On Behalf Of M.T. Sent: Thursday, June 16, 2022 11:09 AM To: devel@edk2.groups.io Subject: [edk2-devel] Windows 10 build failing Hello I am trying to setup a windows

[edk2-devel] Windows 10 build failing

2022-06-16 Thread M.T.
Hello I am trying to setup a windows build system with MSVS2017 or MSVS2022, but I keep running into the same issue over and over, and I can't seem to figure it out. I followed several guides on how to get everything working, but also, I can't build MdeModulePkg, which on linux was nowhere near

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-16 Thread Dionna Glaze via groups.io
> A question: is there some performance impact when accepting all memory under > 4GB? On SEV-SNP, we accept the HOBs 0-0xA000 and 0x10_-0xC00_, which takes a couple seconds, which is non-negligible. For VMs that want to boot very fast and still have access to a lot of memory in the long

[edk2-devel] Does edk2 also link to crt0-efi like GNU-EFI

2022-06-16 Thread Ayush Singh
Hello everyone, I wanted to ask if the edk2 build system also links to crt0-efi, like GNU-EFI? If yes, I would also like to see how that is actually implemented. If not, how does edk2 support custom entry functions? It is possible with llvm backend but I am not sure how it is done in GCC and am

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-16 Thread Lendacky, Thomas via groups.io
On 6/16/22 00:51, Gerd Hoffmann wrote: Hi, Tom Lendacky's suggestion for SEV-SNP is to pre-accept all memory under 4GB to make all that complexity go away. Only this approach worked in my own testing. With the MMIO hole it's just validating 3GB of memory. Accepting all memory under 4GB

[edk2-devel] [PATCH 1/1] OvmfPkg: reduce the number of dsc include files for tpm libs

2022-06-16 Thread Gerd Hoffmann
We can have multiple [LibraryClasses] sections, so we can place all TPM-related library configuration to a single include file. Signed-off-by: Gerd Hoffmann --- OvmfPkg/OvmfTpmLibs.dsc.inc | 18 ++ OvmfPkg/OvmfTpmLibsDxe.dsc.inc | 10 --

Re: [edk2-devel] [PATCH 2/2] SecurityPkg/HashLibTdx: Return EFI_UNSUPPORTED if it is not Tdx guest

2022-06-16 Thread Yao, Jiewen
Both are merged. https://github.com/tianocore/edk2/pull/2981 > -Original Message- > From: Yao, Jiewen > Sent: Sunday, June 12, 2022 9:34 PM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Gerd Hoffmann ; Wang, Jian J > Subject: RE: [PATCH 2/2] SecurityPkg/HashLibTdx: Return EFI_UNSUPPORTED

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-16 Thread Min Xu
On June 16, 2022 1:51 PM, Gerd Hoffmann wrote: > > > Tom Lendacky's suggestion for SEV-SNP is to pre-accept all memory > > > under 4GB to make all that complexity go away. Only this approach > > > worked in my own testing. With the MMIO hole it's just validating 3GB of > memory. > > Accepting all