Reviewed-by: Bob Feng
-Original Message-
From: devel@edk2.groups.io On Behalf Of Michael D Kinney
Sent: Tuesday, August 16, 2022 9:49 AM
To: devel@edk2.groups.io
Cc: Konstantin Aladyshev ; Feng, Bob C
; Gao, Liming ; Chen, Christine
Subject: [edk2-devel] [Patch edk2-stable202208 1/2]
This patch is good to me.
Reviewed-by: Bob Feng
-Original Message-
From: Kinney, Michael D
Sent: Tuesday, August 16, 2022 9:49 AM
To: devel@edk2.groups.io
Cc: Konstantin Aladyshev ; Feng, Bob C
; Gao, Liming ; Chen, Christine
Subject: [Patch edk2-stable202208 2/2]
Tom,
Yes. I expect caller sets/clears the appropriate bits in the
PageTableBaseAddress bit-field.
With this way, the PageTableLib can be stable enough and doesn't need to change
for
different (Intel/AMD/...) x86 features today (or future) that repurpose some
bits in
the page table entry.
To
If no GUID value is provided with EFI_SECTION_FREEFORM_SUBTYPE_GUID
then preserve the prior behavior until all downstream platforms
are updated to pass in a GUID value.
When the size of a EFI_SECTION_FREEFORM_SUBTYPE_GUID section required
the use of EFI_FREEFORM_SUBTYPE_GUID_SECTION2 header, set
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4021
When the size of a EFI_SECTION_FREEFORM_SUBTYPE_GUID section required
the use of EFI_FREEFORM_SUBTYPE_GUID_SECTION2 header, set the section
type to EFI_SECTION_FREEFORM_SUBTYPE_GUID.
Cc: Konstantin Aladyshev
Cc: Bob Feng
Cc: Liming Gao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4022
If no GUID value is provided with EFI_SECTION_FREEFORM_SUBTYPE_GUID
then preserve the prior behavior until all downstream platforms
are updated to pass in a GUID value.
Cc: Konstantin Aladyshev
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
> --- a/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> +++ b/MdeModulePkg/Core/PiSmmCore/PiSmmCore.c
> @@ -621,6 +621,9 @@ InternalIsBufferOverlapped (
>IN UINTN Size2
>)
> {
> + if (((UINTN)Buff1 > MAX_UINTN - Size1) || ((UINTN)Buff2 > MAX_UINTN -
> Size2)) {
> +return TRUE;
> + }
1.
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
08/16/2022
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
There is no function to send POST request with the Content type
which is different from "application/json".
There is no function to send DELETE request with the body.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
RedfishPkg/Include/Library/RedfishLib.h| 80
Definitions of the required functiuons to send requests to BMC
are in the PrivateInclude folder.
So they cannot be used by the other Redfish packages.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
RedfishPkg/Include/Library/RedfishLib.h| 616
Host Interface details are describer by the SMBIOS Type 42 table.
The table is published by the RedfishHostInterfaceDxe driver.
That driver supports USB and PCI-E host interface types.
The table is consumed by the RedfishGetHostInterfaceProtocolData
function in the RedfishDiscoverDxe driver.
The
Those patches allow the third party modules to use the functionality
implemented in the RedfishPkg to support the features defined
by Redfish specification.
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Igor Kulchytskyy
---
Igor Kulchytskyy (3):
RedfishPkg: RedfishDiscoverDxe: USB Redfish
*Tools, CI, Code base construction meeting series*
*When:*
08/15/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608786 )
*Description:*
TianoCore community,
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
08/15/2022
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1608786 )
*Description:*
TianoCore
FvbDev->LbaCache must be freed on error path before deallocating FvbDev.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Mike Maslenkin
---
MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#92452): https://edk2.groups.io/g/devel/message/92452
Mute This Topic: https://groups.io/mt/93047943/21656
Group Owner:
From: Aryeh Chen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4020
Add PcdAcpiGpe1BlockLength of FADT Gpe1BlkLen register on
MinPlatformPkg for PlatformBoardpkg to update platform setting.
Signed-off-by: Aryeh Chen
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Isaac Oram
Cc: Liming Gao
Cc:
FwVolHeader must be deallocated on error path.
Cc: Liming Gao
Cc: Dandan Bi
Signed-off-by: Mike Maslenkin
---
MdeModulePkg/Core/Dxe/FwVol/FwVol.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
b/MdeModulePkg/Core/Dxe/FwVol/FwVol.c
index
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Chen, Aryeh
> Sent: Monday, August 15, 2022 1:36 AM
> To: devel@edk2.groups.io
> Cc: Chen, Aryeh ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; Oram, Isaac W ;
> Gao, Liming ; Dong, Eric
> Subject: [PATCH v1] MinPlatformPkg: Add
This v5 series is a follow up of previously submitted patches:
https://edk2.groups.io/g/devel/message/92128
The v5 patches include a new `Reviewed-by` tag collected during the v4
round and skipped 2 patches merged during the last review cycle.
Patch v5
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
U5SeriesPkg platforms build.
Cc: Abner Chang
Cc: Gilbert Chen
Cc: Daniel Schaefer
Signed-off-by: Kun Qin
Reviewed-by:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
AmpereAltraPkg platforms build.
Cc: Nhi Pham
Cc: Vu Nguyen
Cc: Thang Nguyen
Cc: Chuong Tran
Cc: Leif Lindholm
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
RaspberryPi platforms build.
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Cc: Jeremy Linton
Signed-off-by: Kun Qin
Reviewed-by:
The new changes in SecureBootVariableLib brought in a new dependency
of PlatformPKProtectionLib.
This change added the new library instance from SecurityPkg to resolve
PhytiumCommonPkg platforms build.
Cc: Leif Lindholm
Cc: Peng Xie
Cc: Ling Jia
Cc: Yiqi Shu
Signed-off-by: Kun Qin
On Mon, 15 Aug 2022 at 18:31, Dimitrije Pavlov wrote:
>
> Some functions across OVMF don't check pointer arguments for
> validity, which causes null pointer dereferences and crashes
> in the SCT test suite.
>
> This series adds checks to return EFI_INVALID_PARAMETER if a
> pointer argument is
The current implementation does not check if Language or DriverName
are NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Liming Gao
Cc: Sunny Wang
Cc: Jeff Booher-Kaeding
Cc:
Some functions across OVMF don't check pointer arguments for
validity, which causes null pointer dereferences and crashes
in the SCT test suite.
This series adds checks to return EFI_INVALID_PARAMETER if a
pointer argument is NULL.
v2:
- Add Liming Gao to Cc [Ard]
- Turn individual patches into
The current implementation does not check if Progress or Results
pointers in ExtractConfig are NULL, or if Progress pointer in
RouteConfig is NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.
Cc: Ard Biesheuvel
Cc:
The current implementation does not check if Info or SizeInfo
pointers are NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these
pointers are NULL.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Liming Gao
Cc: Sunny Wang
Cc: Jeff Booher-Kaeding
On 7/18/22 08:18, Ni, Ray via groups.io wrote:
The lib includes two APIs:
* PageTableMap
It creates/updates mapping from LA to PA.
The implementation only supports paging structures used in 64bit
mode now. PAE paging structure support will be added in future.
* PageTableParse
It
On Mon, 15 Aug 2022 at 16:59, Dimitrije Pavlov wrote:
>
> The current implementation does not check if Language or DriverName
> are NULL. This causes the SCT test suite to crash.
>
> Add a check to return EFI_INVALID_PARAMETER if any of these pointers
> are NULL.
>
> Cc: Ard Biesheuvel
> Cc:
The current implementation does not check if Progress or Results
pointers in ExtractConfig are NULL, or if Progress pointer in
RouteConfig is NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.
Cc: Ard Biesheuvel
Cc:
The current implementation does not check if Info or SizeInfo
pointers are NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these
pointers are NULL.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Sunny Wang
Cc: Jeff Booher-Kaeding
Cc: Samer
On Tue, Jul 26, 2022 at 12:46:38PM -0700, Michael D Kinney wrote:
> The email addresses for the reviewers of the MptScsi and
> PvScsi in the OvmfPkg are no longer valid. Remove the
> reviewers for the MptScsi and PvScsi drivers until new
> maintainers/reviewers can be identified.
>
> Cc: Andrew
The current implementation does not check if Language or DriverName
are NULL. This causes the SCT test suite to crash.
Add a check to return EFI_INVALID_PARAMETER if any of these pointers
are NULL.
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Sunny Wang
Cc: Jeff Booher-Kaeding
Cc: Samer
On Wed, Aug 10, 2022 at 10:11:40AM +0200, Oliver Steffen wrote:
> From: Laszlo Ersek
>
> Increase the maximum line length for debug messages.
> While log messages should be short, they can still
> get quite long, for example when printing device paths
> or config strings in HII routing.
> 512
On Fri, 5 Aug 2022 at 18:56, Jeff Brasen via groups.io
wrote:
>
>
>
> > -Original Message-
> > From: Ard Biesheuvel
> > Sent: Tuesday, August 2, 2022 10:51 AM
> > To: Jeff Brasen
> > Cc: devel@edk2.groups.io; hao.a...@intel.com; ray...@intel.com;
> > quic_llind...@quicinc.com;
On Thu, 11 Aug 2022 at 00:54, Kun Qin wrote:
>
> Hi Ard,
>
> Could you please help review this patch? Any feedback in appreciated.
>
Thanks for the fix
Reviewed-by: Ard Biesheuvel
Pushed as 01e3a8877180..9675047d7245
>
> On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
> > The new changes
On Mon, 15 Aug 2022 at 16:10, Sami Mujawar wrote:
>
> The edk2 patch at:
> "6eb407947592 SecurityPkg: SecureBootVariableLib: Added
> newly supported interfaces" introduced a new dependency
> of PlatformPKProtectionLib to SecureBootVariableLib.
>
> This causes the FVP model platform builds to fail
The edk2 patch at:
"6eb407947592 SecurityPkg: SecureBootVariableLib: Added
newly supported interfaces" introduced a new dependency
of PlatformPKProtectionLib to SecureBootVariableLib.
This causes the FVP model platform builds to fail when
Secure Boot is enabled (i.e. SECURE_BOOT_ENABLE = TRUE).
On Mon, Aug 15, 2022 at 11:40:30AM +0200, Ard Biesheuvel wrote:
> Wire up the newly added DriverLoadInhibitorLib in a way that ties
> dispatch of the Ip4Dxe and Ip6Dxe drivers to QEMU fw_cfg variables
> 'opt/org.tianocore/IPv4Support' and 'opt/org.tianocore/IPv6Support'
> respectively.
>
>
On Thu, Aug 11, 2022 at 02:40:57PM +0200, Boeuf, Sebastien wrote:
> From: Sebastien Boeuf
>
> Both ACPI shutdown and ACPI PM timer devices has been moved to different
> port addresses in the latest version of Cloud Hypervisor. These changes
> need to be reflected on the OVMF firmware.
Can this
Hello everyone. I wanted to ask if there was a device/parameter to have
`EFI_TIMESTAMP_PROTOCOL` in OVMF.
I would like to use this protocol to provide monotonic time in Rust (and
fall back to platform-specific registers in case the protocol is absent).
However, in the default qemu configuration,
As the CommunicationBuffer plus BufferSize may overflow, check the
value first before using.
Cc: Jian J Wang
Cc: Liming Gao
Cc: Eric Dong
Cc: Ray Ni
Signed-off-by: Wenyi Xie
---
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 5 -
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 files
Main Changes since v1 :
1.treate overflow as overlap
Wenyi Xie (1):
MdeModulePkg/PiSmmCore:Avoid overflow risk
MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 5 -
MdeModulePkg/Core/PiSmmCore/PiSmmIpl.c | 4
2 files changed, 8 insertions(+), 1 deletion(-)
--
2.20.1.windows.1
Hi Jeff, Pierre,
Please findmy response inline marked [SAMI].
Regards,
Sami Mujawar
On 12/08/2022 02:36 pm, Pierre Gondois wrote:
Hi Jeff,
Please find some inline comments below:
On 8/5/22 17:14, Jeff Brasen via groups.io wrote:
Add APIs needed to build _DSD with different UUIDs.
This is
Wire up the newly added DriverLoadInhibitorLib in a way that ties
dispatch of the Ip4Dxe and Ip6Dxe drivers to QEMU fw_cfg variables
'opt/org.tianocore/IPv4Support' and 'opt/org.tianocore/IPv6Support'
respectively.
Setting both variables to 'n' disables IP based networking entirely,
without the
Add a new library that can be incorporated into any driver built from
source, and which permits loading of the driver to be inhibited based on
the value of a QEMU fw_cfg boolean variable. This will be used in a
subsequent patch to allow dispatch of the IPv6 and IPv6 network protocol
driver to be
Add some generic plumbing and wire it up for OvmfPkgX64 so that IPv4
and/or IPv6 networking can be turned off from the QEMU command line.
This is a follow-up to Yuan's patch '[PATCH v1 0/2] Add support to
disable VirtIo net at runtime' which only targeted the virtio network
driver specifically.
Reviewed-by: Star Zeng
-Original Message-
From: Chiu, Chasel
Sent: Monday, August 15, 2022 2:23 PM
To: devel@edk2.groups.io
Cc: Chiu, Chasel ; Desimone, Nathaniel L
; Zeng, Star
Subject: [PATCH v2] IntelFsp2Pkg: FSPM_ARCH2_UPD mismatching bug.
REF:
Thanks for testing!
-Oliver
On Mon, Aug 15, 2022 at 5:52 AM Daniel Schaefer
wrote:
> Thanks!
> ghcr.io/tianocore/containers/fedora-35-test:cea91ec is the container it
> uses, right?
> I used this to build the RISC-V U540 platform in edk2-platforms and can
> confirm it can still build and boot
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4019
FSPM_ARCH2_UPD in FspApiEntryM.nasm was not up-to-date and
should be fixed for both IA32 and X64 builds.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/Ia32/FspApiEntryM.nasm | 3 ++-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4019
FSPM_ARCH2_UPD in FspApiEntryM.nasm was not up-to-date and
should be fixed.
Cc: Nate DeSimone
Cc: Star Zeng
Signed-off-by: Chasel Chiu
---
IntelFsp2Pkg/FspSecCore/X64/FspApiEntryM.nasm | 3 ++-
1 file changed, 2 insertions(+), 1
+cc: isaac.w.ora, nathaniel.l.desimone, star.zeng, zhichao.gao, maciej.rabeda,
jiaxin.wu, siyuan.fu, zhiguang.liu, dandan.bi, gaoliming, rfc
Hi,
I would like to propose to add Alert standard format support which is based
on ASF2.0 specification(DSP0136).
54 matches
Mail list logo
