From: Abner Chang
Add maintainer and reviewer of ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Abdul Lateef Attar
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nickle Wang
Reviewed-by: Michael D Kinney
Reviewed-by: Nickle Wang
---
Maintainers.txt | 11
From: Abner Chang
Add Ipmi Protocol/Ppi/SMM modules to ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
From: Abner Chang
Add Ipmi Protocol/Ppi/SMM implementations.
The underlying implementation of transport
interface depends on the binded
ManageabilityTransportLib.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor
From: Abner Chang
This is the KCS manageability transport library
instance follows the design guidance described
in Readme file under ManageabilityPkg.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
From: Abner Chang
The helper functions library facilitates reducing
duplicated code in the manageability transport
library instances.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Abdul Lateef Attar
---
From: Abner Chang
The NULL instance of ManageabilityTransportLib
library.
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Abdul Lateef Attar
Reviewed-by: Nickle Wang
---
.../ManageabilityPkg/ManageabilityPkg.dec |
From: Abner Chang
Initial commit of ManageabilityPkg
Signed-off-by: Abner Chang
Cc: Liming Gao
Cc: Isaac Oram
Cc: Nate DeSimone
Cc: Abdul Lateef Attar
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Abdul Lateef Attar
Reviewed-by: Nickle Wang
---
From: Abner Chang
edk2 ManageabilityPkg is introduced to provide edk2 drivers
and libraries for industry platform management standards,
such as PLDM (Platform Level Data Model), MCTP (Management
Component Transfer Protocol),
IPMI (Intelligent Platform Management Interface) and others.
The
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
Sounds good. Thanks.
Reviewed-by: Jiewen Yao
> -Original Message-
> From: kra...@redhat.com
> Sent: Monday, March 20, 2023 11:00 PM
> To: devel@edk2.groups.io; Yao, Jiewen
> Cc: Pawel Polawski ; Wang, Jian J
> ; Oliver Steffen ; Xu, Min M
> ; Marvin Häuser ;
> jma...@redhat.com
>
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 3, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Wang, Jian J ; Yao, Jiewen
> ; Marvin Häuser ; James
> Bottomley ; Michael Roth ;
> Wu, Hao A
[AMD Official Use Only - General]
Hi Nickle, see my feedbacks below,
> -Original Message-
> From: Nickle Wang
> Sent: Monday, March 20, 2023 9:40 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ; Nate DeSimone
> ; Attar, AbdulLateef (Abdul Lateef)
> ; Igor
Reviewed-by: Hao A Wu
Best Regards,
Hao Wu
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 3, 2023 2:51 PM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel ; Gerd Hoffmann
> ; Wang, Jian J ; Yao, Jiewen
> ; Marvin Häuser ; James
> Bottomley ; Michael Roth ;
> Wu, Hao A
[AMD Official Use Only - General]
Hi Nickle,
Thanks for catching those issue. I am fixing it now.
There is few feedbacks below,
> -Original Message-
> From: Nickle Wang
> Sent: Monday, March 20, 2023 9:32 PM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Liming Gao ; Isaac Oram
> ;
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, March 21, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
*Tools, CI, Code base construction meeting series*
*When:*
Monday, March 20, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753770 )
*Description:*
TianoCore
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, March 20, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://github.com/tianocore/edk2/discussions/2614
View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=1753770 )
*Description:*
Hi Abdul,
On Mon, Mar 20, 2023 at 14:09:11 +, Attar, AbdulLateef (Abdul Lateef) wrote:
> AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg
> framework.
>BoardPkg will be generic across all AMD boards which are based on
> MinPlatformPkg framework.
>It's like
Hi,
> It seems that Page1GSupport is already TRUE in my case, so
> unfortunately, the suggested changes don't help.
>
> Before commit bbda386d25, PhysMemAddressWidth is 36, after the commit,
> it's 47. I tried with hardcoding different values:
> 45 - My VM boots fine.
> 46 - I run into a "KVM
[AMD Official Use Only - General]
Thanks for reviewing, will submit V3 patch.
-Original Message-
From: Leif Lindholm
Sent: 17 March 2023 21:30
To: Attar, AbdulLateef (Abdul Lateef)
Cc: devel@edk2.groups.io; Ard Biesheuvel ; Chang,
Abner ; Michael D Kinney
Subject: Re: [PATCH v2
[AMD Official Use Only - General]
Hi Leif,
Please see inline my reply [Abdul]
I'll address the remaining review comments and submit V3 version.
Thanks
AbduL
-Original Message-
From: Leif Lindholm
Sent: 17 March 2023 21:25
To: devel@edk2.groups.io; Attar, AbdulLateef (Abdul
[Public]
Hi Leif,
AMD/BoardPkg will contains the modules/drivers to support MinPlatformPkg
framework.
BoardPkg will be generic across all AMD boards which are based on
MinPlatformPkg framework.
It's like "edk2-platforms/Platform/Qemu/QemuOpenBoardPkg".
We will gradually add modules
[AMD Official Use Only - General]
Hi Leif,
How about adding a separate entry?
Currently its generic to adapt the MinPlatformPkg, later will add more specific
platforms.
AMD board and platform
F: Platform/AMD/BoardPkg
F: Platform/AMD/PlatformPkg
M: maintainer1
M: maintainer2
AMD Seattle
F:
On Mon, Mar 20, 2023 at 01:20:29PM +, Yao, Jiewen wrote:
> Would you please share with us what test has been done for this patch?
Usual regression testing, including booting images with and without
secure boot. Additionally checked images with the wrong signature
are rejected (try boot
Can anyone help to review this? Thanks :)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101451): https://edk2.groups.io/g/devel/message/101451
Mute This Topic: https://groups.io/mt/97727097/21656
Group Owner: devel+ow...@edk2.groups.io
Can anyone help to review this? Thanks :)
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#101450): https://edk2.groups.io/g/devel/message/101450
Mute This Topic: https://groups.io/mt/97727098/21656
Group Owner: devel+ow...@edk2.groups.io
Am 17.03.23 um 15:01 schrieb Gerd Hoffmann:
> Hi,
>
>> With edk2-stable202205 or when reverting the commit, my VM boots with
>> only 512 MiB of assigned memory. With the commit, with 512 MiB it cannot
>> even initialize the display, with 750 MiB it runs into a different error
>> during Linux
The Rtc library for the kvmtool guest firmware configures the
RTC controller address range as runtime memory by calling the
gDS->SetMemorySpaceAttributes().
The SetMemorySpaceAttributes() function has a dependency on
the CPU Arch Protocol. If the CPU Arch Protocol is not
installed the call to set
When scanning for the Serial Port in the device
tree, the length and value parameters to ScanMem8()
are not in the right order. This results in the
serial port not being detected if the chosen node
in the device tree has additional elements.
Therefore, pass the parameters to ScanMem8() in the
This patch series has the following fixes for DynamicTablesPkg and
ArmVirtPkg/Kvmtool:
1. Reduces the log output from TableHelperLib in DynamicTablesPkg.
2. Fixes issue with parsing of the serial port node in
ArmSerialPortParser in DynamicTablesPkg and
EarlyFdt16550SerialPortHookLib
When scanning for the Serial Port in the device
tree, the length and value parameters to ScanMem8()
are not in the right order. This results in the
serial port not being detected if the chosen node
in the device tree has additional elements.
Therefore, pass the parameters to ScanMem8() in the
Reduce the log output from Configuration Manager Object Parser
in TableHelperLib by enabling the logs only if DEBUG_INFO is
enabled.
Signed-off-by: Sami Mujawar
---
DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c
| 28 ++--
1 file changed, 14
Gred,
Thanks for the test. I found the root cause and will fix the issue in next
version patch.
Thanks,
Dun
-Original Message-
From: Gerd Hoffmann
Sent: Monday, March 20, 2023 7:43 PM
To: Tan, Dun
Cc: devel@edk2.groups.io; Dong, Eric ; Ni, Ray
; Kumar, Rahul R
Subject: Re: [Patch
Please find my comment inline below.
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Abdul Lateef Attar
; Nickle Wang ; Igor Kulchytskyy
Subject:
Please see my comments inline below.
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Abdul Lateef Attar
; Nickle Wang ; Igor Kulchytskyy
Subject:
On 3/20/23 2:33 AM, Tinh Nguyen wrote:
-/**
- Fetches the firmware ('BIOS') version from the
- FirmwareVersionInfo HOB.
+/** Fetches the Firmware version string for SMBIOS type 0
- @return The version as a UTF-16 string
+ This function get the Firmware version string from OemMiscLib
Would you please share with us what test has been done for this patch?
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Gerd
> Hoffmann
> Sent: Monday, March 20, 2023 6:02 PM
> To: devel@edk2.groups.io
> Cc: Pawel Polawski ; Wang, Jian J
> ; Oliver
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Abdul Lateef Attar
; Nickle Wang ; Igor Kulchytskyy
Subject: [edk2-platforms][PATCH
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Abdul Lateef Attar ; Leif Lindholm
; Michael D Kinney ;
Liming Gao ; Isaac Oram ;
Nickle Wang
Subject: [edk2-platforms][PATCH
Sorry, I don't think I saw a suggestion from you to not set CC - though
I may have missed emails since this patch series was sent from the email
of my former employer.
Marvin did suggest that though, so I can certainly add another patch to
the series to do that.
--
Rebecca Cran
On
Hi Abner,
On Sat, Mar 18, 2023 at 09:16:17 +, Chang, Abner via groups.io wrote:
> I don't see any modules under OverdriveBoard, is this package still
The code is split between Platform/AMD and Silicon/AMD/Styx, the
latter also being used by SoftIron/Overdrive1000 and LeMaker Cello
(although
Hi Abner,
On Sat, Mar 18, 2023 at 09:03:50 +, Chang, Abner via groups.io wrote:
> AMD\PlatformPkg is mainly for the modules that are generic to AMD's
> server, client or other platforms, while AMD\BoardPkg that contains
> the modules that support MinPlatformrPkg framework. AMD\BoardPkg may
>
Hi Ray
Some members of the coreboot community want to centre the logo (as it is
currently) and some want to use the Microsoft recommended position. All we
want to do is have the option to build edk2 with one or the other.
Thanks
Sean
On Mon, 20 Mar 2023 at 09:56, Ni, Ray wrote:
> Sheng Lean
It's good to me.
Reviewed-by: Min Xu
Thanks
> -Original Message-
> From: Gerd Hoffmann
> Sent: Monday, March 20, 2023 6:02 PM
> To: devel@edk2.groups.io
> Cc: Pawel Polawski ; Wang, Jian J
> ; Oliver Steffen ; Xu, Min M
> ; Marvin Häuser ; Yao, Jiewen
> ; jma...@redhat.com
> Subject:
On Mon, Mar 20, 2023 at 01:33:18PM +0800, Dun Tan wrote:
> For different usage, check if the combination for Mask and
> Attr is valid when creating or updating page table.
>
> 1.For non-present range
> 1.1Mask.Present is 0 but some other attributes is provided.
> This case is invalid.
>
On Mon, Mar 20, 2023 at 01:33:11PM +0800, duntan wrote:
> In the V3 patch set:
> 1.Modify the V2 patch set based on Ray's comments
> 2.Remove the patch to enable PAE paging. Will do this in future patches
> 3.Add patches to combine code branch for non-present and leaf ParentEntry
Patch series
On Thu, Mar 02, 2023 at 09:15:30AM +, Dov Murik wrote:
> AMD SEV and SEV-ES support measured direct boot with
> kernel/initrd/cmdline hashes injected by QEMU and verified by OVMF
> during boot.
>
> To enable the same approach for AMD SEV-SNP, we declare the kernel
> hashes page in the SNP
On Fri, Mar 03, 2023 at 07:51:10AM +0100, Gerd Hoffmann wrote:
Ping. Any comments on this?
The interesting update actually adding the macros is in patch #3.
thanks & take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online
Reviewed-by: Ray Ni
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 10, 2023 8:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Oliver Steffen ; Gerd
> Hoffmann ; Kumar, Rahul R
> ; Pawel Polawski ;
> Dong, Eric
> Subject: [PATCH 2/2] UefiCpuPkg/PiSmmCpuDxeSmm: fix
Reviewed-by: Ray Ni
> -Original Message-
> From: Gerd Hoffmann
> Sent: Friday, March 10, 2023 8:49 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Oliver Steffen ; Gerd
> Hoffmann ; Kumar, Rahul R
> ; Pawel Polawski ;
> Dong, Eric
> Subject: [PATCH 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: drop
On Fri, Mar 03, 2023 at 11:35:53AM +0100, Gerd Hoffmann wrote:
> Call gRT->GetVariable() directly to read the SecureBoot variable. It is
> one byte in size so we can easily place it on the stack instead of
> having GetEfiGlobalVariable2() allocate it for us, which avoids a few
> possible error
On Tue, Mar 07, 2023 at 07:54:51AM +0100, Gerd Hoffmann wrote:
> v2:
> - rebase to latest master.
>
> Gerd Hoffmann (3):
> OvmfPkg/PlatformInitLib: update address space layout comment
> OvmfPkg/PlatformInitLib: move mmconfig to 0xe000
> OvmfPkg/PlatformInitLib: simplify mtrr setup
On Tue, Mar 07, 2023 at 01:20:37PM +0100, Gerd Hoffmann wrote:
> In case the number of CPUs can in increase beyond 255
> due to CPU hotplug choose x2apic mode.
>
> Signed-off-by: Gerd Hoffmann
Ping. Any comments on this patch?
thanks,
Gerd
> ---
> UefiCpuPkg/Library/MpInitLib/MpLib.c | 8
Sheng Lean Tan,
In short, I am looking forward to be convinced by you and Sean, but so far I
haven’t been.
1. In the beginning, I left comments to suggest you use the logic below to
meet your requirement.
Status = gBS->HandleProtocol (gST->ConsoleOutHandle,
, (VOID **) );
if
On Thu, Mar 09, 2023 at 12:09:23PM +0100, Gerd Hoffmann wrote:
> v3 changes:
> - rebase to latest master.
> - enable crypto driver only for SMM + DXE.
> - CI passes now \o/
Ping. Any comments on this series?
take care,
Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all
On Wed, Mar 15, 2023 at 04:57:47PM -0500, Michael Roth wrote:
> Currently OVMF tries to rely on the base size advertised via the CPUID
> table entries corresponding to leaf 0xD, sub-leafs 0x0/0x1. This will
> generally work for KVM guests, but might not for other SEV-SNP
> hypervisor
On Wed, Mar 15, 2023 at 04:57:46PM -0500, Michael Roth wrote:
> CPUID leaf 0xD sub-leafs 0x0 and 0x1 contain cumulative sizes for the
> enabled XSave areas. Those sizes are calculated by tallying up all the
> other sub-leafs that contain per-area size information for XSave areas
> that are
On Wed, Mar 15, 2023 at 04:57:45PM -0500, Roth, Michael via groups.io wrote:
> The Confidential Computing blob defined here is intended to match the
> definition defined by linux guest kernel. Previously, both definitions
> relied on natural alignment, but that relies on both OVMF and kernel
>
On Wed, Mar 15, 2023 at 04:57:44PM -0500, Michael Roth wrote:
> The SEV-SNP Confidential Computing blob contains metadata that should
> remain accessible for the life of the guest. Allocate it as
> EfiACPIReclaimMemory to ensure the memory isn't overwritten by the guest
> operating system later.
>
On Fri, Mar 17, 2023 at 04:43:24AM -0600, Rebecca Cran wrote:
> On 3/15/23 4:07 AM, Gerd Hoffmann wrote:
> > > Rework the BaseTools Makefiles removing the 'BUILD_' prefix (BUILD_CC
> > > and BUILD_CXX) and using the standard name 'LDFLAGS' instead of
> > > 'LFLAGS'. This allows clang to be used by
- Use OS specific path seperator instead of hardcoding ';'
- Fix case of build artifact FV/PLATFORMPAYLOAD.Fv
Test:
python Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
works on Linux.
Signed-off-by: Patrick Rudolph
Ref:
Add package that are required to build PlatformPayloadFeaturePkg.
Test:
Running python
Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.py
generates a FV.
Signed-off-by: Patrick Rudolph
Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=4359
---
Thanks for addressing my comments.
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Monday, March 20, 2023 4:14 PM
To: devel@edk2.groups.io
Cc: Nickle Wang ; Igor Kulchytskyy
Subject: [PATCH v2 1/3] RedfishPkg/Library: Redfish BMC USBNIC
The BIOS Firmware Version in the SMBIOS Type 0 can be fetched from
the fixed PcdFirmwareVersionString or platform specific OemMiscLib.
In fact, the support from OemMiscLib comes into play when the firmware
version may be modified at boot time for extended information.
Therefore, the priority of
Please find my comment inline below.
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Nickle Wang
; Igor Kulchytskyy ; Abdul Lateef Attar
Subject:
[AMD Official Use Only - General]
Hi Nickle,
Thanks for those good comments. V2 patch was just sent!
Abner
> -Original Message-
> From: Nickle Wang
> Sent: Monday, March 20, 2023 11:13 AM
> To: Chang, Abner ; devel@edk2.groups.io
> Cc: Igor Kulchytskyy
> Subject: RE: [PATCH 1/3]
From: Abner Chang
BMC exposed USB NIC platform Redfish Host Interface
library implementation.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishPkg/RedfishPkg.dec | 10 +
.../PlatformHostInterfaceBmcUsbNicLib.inf | 48 +
From: Abner Chang
Update Redfish DSC for
PlatformHostInterfaceBmcUsbNicLib.
Signed-off-by: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Reviewed-by: Nickle Wang
---
RedfishPkg/RedfishPkg.dsc | 7 +++
1 file changed, 7 insertions(+)
diff --git a/RedfishPkg/RedfishPkg.dsc
From: Abner Chang
In V2: Address review comments.
BZ #: 4282
Implement the platform Redfish host interface library that
uses IPMI commands to get the network information of
BMC-exposed USB NIC for building up the SMBIOS type 42
record.
The prerequisites: BZ #4213, 4214 and 4231
Check
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Nickle Wang
; Igor Kulchytskyy ; Abdul Lateef Attar
Subject: [edk2-platforms][PATCH
Hi Ray,Any feedback per Mic feedback?On 15. Mar 2023, at 16:35, Michael D Kinney wrote:
HI Ray,
I think it is a reasonable request to have the EDK II logo driver support multiple standards for the logo location.
Especially if they are documented in public specifications.
The
Hi Xuerui,
I and Xianglai have reviewed this change a few days ago, you can create
a PR in the edk2-platforms repo.
Thanks,
Chao
在 2023/3/8 11:17, xianglai 写道:
Reviewed-by: Xianglai Li
On 2023/3/5 下午12:40, WANG Xuerui wrote:
Some toolchains have stack protection enabled by default, so
Thanks for offline discussion with me, Abner.
Reviewed-by: Nickle Wang
Regards,
Nickle
-Original Message-
From: abner.ch...@amd.com
Sent: Wednesday, March 8, 2023 10:17 PM
To: devel@edk2.groups.io
Cc: Liming Gao ; Isaac Oram ;
Nate DeSimone ; Abdul Lateef Attar
; Nickle Wang ; Igor
On Mon, Mar 20, 2023 at 6:03 AM Ni, Ray wrote:
>
> > ASM_PFX(FspInfoHeaderRelativeOff):
> >
> > DD0x12345678 ; This value must be patched by the
> > build script
> >
> > - and rax, 0x
> >
> > + mov eax, eax ; equal to and rax, 0x
>
>
> ASM_PFX(FspInfoHeaderRelativeOff):
>
> DD0x12345678 ; This value must be patched by the build
> script
>
> - and rax, 0x
>
> + mov eax, eax ; equal to and rax, 0x
Based on the discussion, we know "mov eax, eax" clears upper
75 matches
Mail list logo
